[ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-12 Thread Bart Van Assche
Avoid that scsi_remove_host() is invoked from the context of a work queue thread on which work has been queued that scsi_remove_host() might be waiting for. That avoids that module removal of ib_srp triggers a deadlock on a pre-2.6.36 kernel. This patch has been tested on RHEL 6.1, RHEL 6.2, RHEL 6

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-15 Thread Vladimir Sokolovsky
On 10/12/2012 02:03 PM, Bart Van Assche wrote: Avoid that scsi_remove_host() is invoked from the context of a work queue thread on which work has been queued that scsi_remove_host() might be waiting for. That avoids that module removal of ib_srp triggers a deadlock on a pre-2.6.36 kernel. This pa

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-15 Thread Rupert Dance
Vlad, Thanks for getting this done. Is this in today's daily build or if not when will I have access? Thanks Rupert -Original Message- From: Vladimir Sokolovsky [mailto:v...@dev.mellanox.co.il] Sent: Monday, October 15, 2012 9:28 AM To: Bart Van Assche Cc: Rupert Dance; ewg; Tziporet K

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-16 Thread Vladimir Sokolovsky
On 10/15/2012 04:46 PM, Rupert Dance wrote: Vlad, Thanks for getting this done. Is this in today's daily build or if not when will I have access? Thanks Rupert Hi Rupert, Yes, today's daily build includes this fix. Regards, Vladimir -Original Message- From: Vladimir Sokolovsky [m

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-16 Thread Tziporet Koren
Rupert I must get your input for SRP stability to know when we can build a new RC Thanks Tziporet -Original Message- From: Vladimir Sokolovsky [mailto:v...@dev.mellanox.co.il] Sent: Tuesday, October 16, 2012 12:34 PM To: Rupert Dance Cc: 'Bart Van Assche'; 'ewg'; Tziporet Koren Subject:

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-16 Thread Rupert Dance
Tziporet, UNH-IOL completed the testing of the new daily build and here is what we found. +++ SL 6.3 2.6.32-279.el6.x86_64 OFED-3.5-20121016-0341.tgz 16-Oct-2012 03:42 18M The new build now allows you to load and unload successfully with no system crashes. We

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-17 Thread Bart Van Assche
On 10/17/12 05:12, Rupert Dance wrote: However the Module took a long time (~1-2 minutes) to unload 2. Message saying something to the effect of 'stale connection...retrying' was observed That behavior is consistent with the behavior of the ib_srp driver in the latest upstream kernel (3.7-rc1)

Re: [ewg] [PATCH] ib_srp: Avoid that module removal can trigger a deadlock

2012-10-17 Thread Tziporet Koren
Vu Do you know? Tziporet -Original Message- From: Bart Van Assche [mailto:bvanass...@acm.org] Sent: Wednesday, October 17, 2012 9:09 AM To: Rupert Dance Cc: Tziporet Koren; Vladimir Sokolovsky; 'ewg' Subject: Re: [PATCH] ib_srp: Avoid that module removal can trigger a deadlock On 10/17