Re: [ewg] Re: [PATCH v1] mlx4_ib: Optimize hugetlab pages support

2009-01-25 Thread Eli Cohen
On Thu, Jan 22, 2009 at 09:07:41PM -0800, Roland Dreier wrote: > > seems this might underestimate by 1 if the region doesn't start/end on a > huge-page aligned boundary (but we would still want to use big pages to > register it). > Looks like we must pass the virtual address through struct ib_um

[ewg] Re: [PATCH v1] mlx4_ib: Optimize hugetlab pages support

2009-01-22 Thread Roland Dreier
OK, looks better. However the patch had a bunch of whitespace problems (run checkpatch.pl to see them). Also: > +static int handle_hugetlb_user_mr(struct ib_pd *pd, struct mlx4_ib_mr *mr, > + u64 virt_addr, int access_flags) > +{ > +#ifdef CONFIG_HUGETLB_PAGE >