[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-19 Thread Eli Cohen
On Mon, Apr 13, 2009 at 10:19:08PM +0300, Yossi Etigin wrote: I see. That surprises me... could you also print vma-vm_start and vma-vm_end? I would have expected the vma to be streched to fill a full huge page and return the number of regular pages fitting in it. Eli Cohen wrote: On Mon, Apr

[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-13 Thread Yossi Etigin
Eli Cohen wrote: On Mon, Apr 06, 2009 at 08:49:43PM +0300, Yossi Etigin wrote: I don't understand - if all area is huge pages, it does not mean that it fills full huge pages - I can have just 4096 bytes in huge page memory and umem-hugetlb will remain 1, right? You may call ib_umem_get()

[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-07 Thread Eli Cohen
On Mon, Apr 06, 2009 at 08:49:43PM +0300, Yossi Etigin wrote: I don't understand - if all area is huge pages, it does not mean that it fills full huge pages - I can have just 4096 bytes in huge page memory and umem-hugetlb will remain 1, right? You may call ib_umem_get() with a fraction of

[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-05 Thread Eli Cohen
On Thu, Apr 02, 2009 at 11:31:42PM +0300, Yossi Etigin wrote: Hi Eli, I've placed a printk in the new hugetlb function to print n and j. While running the mckey test (attached in bugzilla), I got j=0, n=1. Why do you say that the number of pages must cover HUGE_PAGES? In ib_umem_get,

Re: [ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-02 Thread Or Gerlitz
Eli Cohen wrote: You mention in Bugzilla an mckey test but I don't know this test. Can you send how to obatain the test and instructions how to build it and run it? Eli, mckey is installed with librdmac-utils, has man page, etc. Its source is under the examples directory of the librdmacm

Re: [ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-02 Thread Eli Cohen
On Thu, Apr 02, 2009 at 11:47:26AM +0300, Or Gerlitz wrote: mckey is installed with librdmac-utils, has man page, etc. Its source is under the examples directory of the librdmacm src tree, you can clone Sean's librdmacm git from ofa to get it - OK? Thanks Or. I will check this.

[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-04-02 Thread Yossi Etigin
Hi Eli, I've placed a printk in the new hugetlb function to print n and j. While running the mckey test (attached in bugzilla), I got j=0, n=1. Why do you say that the number of pages must cover HUGE_PAGES? In ib_umem_get, hugetlb is set to 0 only if any of the pages is not-hugetlb - otherwise

Fwd: [ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-03-31 Thread Olga Shern (Voltaire)
Vlad, Can you please replase mlx4_1070-optimize-huge_tlb.patch with Yossi's patch. It fixes Eli's patch. Thanks Olga -- Forwarded message -- From: Yossi Etigin yos...@voltaire.com Date: Mon, Mar 30, 2009 at 6:49 PM Subject: [ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages

Re: Fwd: [ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-03-31 Thread Vladimir Sokolovsky
Olga Shern (Voltaire) wrote: Vlad, Can you please replase mlx4_1070-optimize-huge_tlb.patch with Yossi's patch. It fixes Eli's patch. Thanks Olga Done, Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org

[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

2009-03-30 Thread Yossi Etigin
Eli Cohen wrote: Since Linux may not merge adjacent pages into a single scatter entry through calls to dma_map_sg(), we check the special case of hugetlb pages which are likely to be mapped to coniguous dma addresses and if they are, take advantage of this. This will result in a significantly