Hmm... I located the trouble but it seems my email hasn't hit.
On Jun 9, 2009, at 7:40 PM, Alex Chapman wrote:
> : rotate-circular ( circular -- )
> 1 swap circular-wrap (>>start) ;
This was the change I thought made sense, but I'm curious whether it's
optimal.
> By the way, your testing
Looks like you beat me to it Slava :)
Was your fix the one I suggested?
2009/6/10 Slava Pestov
> Hi Charles,
>
> Looks like rotate-circular is broken. Unfortunately it didn't have
> unit tests and wasn't used anywhere else in the library, so nobody
> noticed until now. I pushed a patch fixing th
Hi Charles,
It looks like you've found a bug. From basis/circular/circular.factor:
: circular-wrap ( n circular -- n circular )
[ start>> + ] keep
[ seq>> length rem ] keep ; inline
: rotate-circular ( circular -- )
[ start>> 1 + ] keep circular-wrap (>>start) ;
Looks like this secon
Hi Charles,
Looks like rotate-circular is broken. Unfortunately it didn't have
unit tests and wasn't used anywhere else in the library, so nobody
noticed until now. I pushed a patch fixing the issue.
Slava
On Tue, Jun 9, 2009 at 3:19 PM, Charles Turner wrote:
> Hey all:
>
> What don't I understa
Hey all:
What don't I understand about circular sequences, or sequences in
general? This using a recent (> 2 weeks old) Factor OSX x86_32 and _64
binaries, 10.5.7:
( scratchpad ) Command: restart
1: Note:
Added "circular" vocabulary to search path
{ 1 2 3 }
--- Data stack:
T{ circular f ~
