Hi Julius,
On 03/02, Julius Smith wrote:
>
> Hi Oleg,
>
> Thanks for the "noise-coefficients test" - I am convinced by that, of
> course, and vote in favor of version 2.
OK, thanks. I have updated
https://github.com/grame-cncm/faustlibraries/pull/218
Just in case, this is the test-case (included in the changelog of 2/2)
import("stdfaust.lib");
// Old implementations before this patch
o_fb_comb(maxdel,N,b0,aN) = (+ <: de.delay(maxdel,N-1),_) ~ *(-aN) :
!,*(b0) : mem;
o_fb_fcomb(maxdel,N,b0,aN) = (+ <: de.fdelay(maxdel,float(N)-1.0),_) ~
*(-aN) : !,*(b0) : mem;
maxdel = 10; N = 7.5;
maxerr = abs : max ~ _;
test(inp,b0,aN) = inp <:
fi.fb_comb(maxdel,N,b0,aN)
-o_fb_comb(maxdel,N,b0,aN),
fi.fb_fcomb(maxdel,N,b0,aN)
-o_fb_fcomb(maxdel,N,b0,aN)
: par(i,2,maxerr);
process = no.multinoise(3) : test;
> I don't recall if I've said all this before, but my vote is always to
> (1) maintain exact backward compatibility of existing function names,
> (2) address any deviations from references in the doc comments, and
> (3) come up with new function names for new improvements, whatever their
> nature.
Sure, agreed.
Thank you!
Oleg.
_______________________________________________
Faudiostream-devel mailing list
Faudiostream-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/faudiostream-devel
