Re: [Faudiostream-devel] cmake issues

2018-03-26 Thread Romain Michon
> > But you've done a marvelous job, apart from the minor issues I > reported (which should hopefully be easy to fix) everything works > without any hitches on Linux, Mac and Windows /msys2! > +1. Now that things are stabilizing, it's proving really useful. Thanks, Dom! ---

Re: [Faudiostream-devel] cmake issues

2018-03-26 Thread Albert Graef
BTW, about that version script. Isn't that a bit old-fashioned way of doing things? Shouldn't cmake be able to scrape the current version number from the toplevel Makefile or some other convenient location and then update the other files as needed? Dominique? On Mon, Mar 26, 2018 at 9:34 AM, Alber

Re: [Faudiostream-devel] cmake issues

2018-03-26 Thread Albert Graef
On Mon, Mar 26, 2018 at 9:36 AM, Dominique Fober wrote: > Thanks for the feedback.I was waiting for this, especially for the install > process. Yeah, build system changes are always disruptive, so I figured it would be better to wait a bit until the initial commit flurry has petered out. :) But

Re: [Faudiostream-devel] cmake issues

2018-03-26 Thread Dominique Fober
Hi Albert, Thanks for the feedback.I was waiting for this, especially for the install process. Answers are inline. > Le 26 mars 2018 à 09:21, Albert Graef a écrit : > > Hi Dominique, > > first, congrats for adding cmake support! That should hopefully > improve cross-platform support. > > Th

Re: [Faudiostream-devel] cmake issues

2018-03-26 Thread Albert Graef
One more thing I just noticed: Stéphane, could you please make sure that the new version script in the toplevel directory also edits the version number in the toplevel Makefile? That's still needed to generate the correct version number for the Debian package. Thanks, Albert On Mon, Mar 26, 2018

[Faudiostream-devel] cmake issues

2018-03-26 Thread Albert Graef
Hi Dominique, first, congrats for adding cmake support! That should hopefully improve cross-platform support. That said, in build/README.md it says that "you must have LLVM version 3.8 or greater installed to compile the llvm backend." Is that a typo? Because it still builds fine with LLVM 3.5 f