Changes have been pushed for the repository "fawkesrobotics/fawkes".

Clone:  https://github.com/fawkesrobotics/fawkes.git
Gitweb: https://github.com/fawkesrobotics/fawkes

The branch, thofmann/catch2 has been updated
        to  7b0603f106039466aebdc409e64b46e24888227c (commit)
       via  d1e7d105525b280215fd05539acbdc5327508b7f (commit)
       via  9042c8acf5e5c3fc772ff56580f10e411045b296 (commit)
       via  0f12cb12961b305cb2868e3efa22fb14c13d3dc1 (commit)
       via  ae2d1d9aa1317ab84657903807eadc9755292175 (commit)
       via  f048d523900d589b1680385b5243c163ee310505 (commit)
      from  1bbc458ad5dd3fbe11ea175c3cea0048190ca525 (commit)

https://github.com/fawkesrobotics/fawkes/tree/thofmann/catch2

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- *Log* ---------------------------------------------------------------
commit f048d523900d589b1680385b5243c163ee310505
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:24:43 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:24:43 2020 +0100

    buildsys: always set BINS_test to union of all gtests and catch2 tests
    
    This reduces the boilerplate code in test Makefiles, as this would need
    to be repeated in every Makefile that builds tests.

https://github.com/fawkesrobotics/fawkes/commit/f048d5239

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit ae2d1d9aa1317ab84657903807eadc9755292175
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:25:46 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:25:46 2020 +0100

    core: remove unnecessary boilerplate for BINS_test

https://github.com/fawkesrobotics/fawkes/commit/ae2d1d9aa

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 0f12cb12961b305cb2868e3efa22fb14c13d3dc1
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:26:06 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:26:06 2020 +0100

    kdl_parser: remove unnecessary boilerplate for BINS_test

https://github.com/fawkesrobotics/fawkes/commit/0f12cb129

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 9042c8acf5e5c3fc772ff56580f10e411045b296
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:26:15 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:26:15 2020 +0100

    syncpoint: remove unnecessary boilerplate for BINS_test

https://github.com/fawkesrobotics/fawkes/commit/9042c8acf

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit d1e7d105525b280215fd05539acbdc5327508b7f
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:26:35 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:26:35 2020 +0100

    tools: remove unnecessary boilerplate for BINS_test

https://github.com/fawkesrobotics/fawkes/commit/d1e7d1055

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 7b0603f106039466aebdc409e64b46e24888227c
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Thu Feb 27 14:31:31 2020 +0100
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Thu Feb 27 14:31:31 2020 +0100

    buildsys: get rid of unused exec_gdb_test
    
    The target is rarely used and is not very useful as part of the build
    system anyway. If you want to run a test with gdb, just call gdb with
    the test binary.

https://github.com/fawkesrobotics/fawkes/commit/7b0603f10

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -


- *Summary* -----------------------------------------------------------
 etc/buildsys/rules.mk              | 12 +++++-------
 src/libs/core/tests/Makefile       |  3 ---
 src/libs/kdl_parser/tests/Makefile |  3 ---
 src/libs/syncpoint/tests/Makefile  |  3 ---
 src/tools/gtest/Makefile           |  2 --
 5 files changed, 5 insertions(+), 18 deletions(-)


- *Diffs* -------------------------------------------------------------

- *commit* f048d523900d589b1680385b5243c163ee310505 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:24:43 2020 +0100
Subject: buildsys: always set BINS_test to union of all gtests and catch2 tests

 etc/buildsys/rules.mk | 2 ++
 1 file changed, 2 insertions(+)

_Diff for modified files_:
diff --git a/etc/buildsys/rules.mk b/etc/buildsys/rules.mk
index 4ebe391ab..eda7d8e28 100644
--- a/etc/buildsys/rules.mk
+++ b/etc/buildsys/rules.mk
@@ -99,6 +99,8 @@ UNLISTED_libs = $(strip $(filter-out 
$(LIBS_all:%.so=%.$(SOEXT)),$(LIBS_build:%.
 UNLISTED_plugins = $(strip $(filter-out 
$(PLUGINS_all:%.so=%.$(SOEXT)),$(PLUGINS_build:%.so=%.$(SOEXT))))
 UNLISTED_all = $(strip $(UNLISTED_bins) $(UNLISTED_libs) $(UNLISTED_plugins))
 
+BINS_test = $(BINS_gtest) $(BINS_catch2test)
+
 all: $(if $(UNLISTED_all),error_unlisted,presubdirs 
$(PLUGINS_build:%.so=%.$(SOEXT)) $(LIBS_build:%.so=%.$(SOEXT)) $(BINS_build) 
$(MANPAGES_all) $(TARGETS_all) $(EXTRA_ALL) stats subdirs | 
silent-nothing-to-do-all)
 gui: $(if $(UNLISTED_all),error_unlisted,presubdirs 
$(LIBS_gui:%.so=%.$(SOEXT)) $(PLUGINS_gui:%.so=%.$(SOEXT)) $(BINS_gui) 
$(MANPAGES_gui) $(TARGETS_gui) stats-gui subdirs | silent-nothing-to-do-gui)
 test: $(if $(UNLISTED_all),error_unlisted,presubdirs 
$(LIBS_test:%.so=%.$(SOEXT)) $(PLUGINS_test:%.so=%.$(SOEXT)) $(BINS_test) 
$(TARGETS_test) exec_test stats-test subdirs | silent-nothing-to-do-test)

- *commit* ae2d1d9aa1317ab84657903807eadc9755292175 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:25:46 2020 +0100
Subject: core: remove unnecessary boilerplate for BINS_test

 src/libs/core/tests/Makefile | 3 ---
 1 file changed, 3 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/core/tests/Makefile b/src/libs/core/tests/Makefile
index fa1a5feda..116df72a0 100644
--- a/src/libs/core/tests/Makefile
+++ b/src/libs/core/tests/Makefile
@@ -47,9 +47,6 @@ else
   WARN_TARGETS += warning_gtest
 endif
 
-BINS_test = $(BINS_gtest) $(BINS_catch2test)
-BINS_all = $(BINS_test)
-
 ifeq ($(OBJSSUBMAKE),1)
 test: $(WARN_TARGETS)
 

- *commit* 0f12cb12961b305cb2868e3efa22fb14c13d3dc1 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:26:06 2020 +0100
Subject: kdl_parser: remove unnecessary boilerplate for BINS_test

 src/libs/kdl_parser/tests/Makefile | 3 ---
 1 file changed, 3 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/kdl_parser/tests/Makefile 
b/src/libs/kdl_parser/tests/Makefile
index 3dba4979b..0baa75e30 100644
--- a/src/libs/kdl_parser/tests/Makefile
+++ b/src/libs/kdl_parser/tests/Makefile
@@ -28,7 +28,4 @@ ifeq ($(HAVE_GTEST)$(HAVE_KDLPARSER),11)
   BINS_gtest = $(BINDIR)/test_kdlparser
 endif
 
-BINS_test = $(BINS_gtest)
-BINS_all = $(BINDIR)/test_kdlparser
-
 include $(BUILDSYSDIR)/base.mk

- *commit* 9042c8acf5e5c3fc772ff56580f10e411045b296 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:26:15 2020 +0100
Subject: syncpoint: remove unnecessary boilerplate for BINS_test

 src/libs/syncpoint/tests/Makefile | 3 ---
 1 file changed, 3 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/syncpoint/tests/Makefile 
b/src/libs/syncpoint/tests/Makefile
index 132e8ee66..1045c2de1 100644
--- a/src/libs/syncpoint/tests/Makefile
+++ b/src/libs/syncpoint/tests/Makefile
@@ -41,9 +41,6 @@ else
   endif
 endif
 
-BINS_test = $(BINS_gtest)
-BINS_all = $(BINS_test)
-
 ifeq ($(OBJSSUBMAKE),1)
 test: $(WARN_TARGETS)
 .PHONY: $(WARN_TARGETS)

- *commit* d1e7d105525b280215fd05539acbdc5327508b7f - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:26:35 2020 +0100
Subject: tools: remove unnecessary boilerplate for BINS_test

 src/tools/gtest/Makefile | 2 --
 1 file changed, 2 deletions(-)

_Diff for modified files_:
diff --git a/src/tools/gtest/Makefile b/src/tools/gtest/Makefile
index 34bde3963..984515fe6 100644
--- a/src/tools/gtest/Makefile
+++ b/src/tools/gtest/Makefile
@@ -39,8 +39,6 @@ else
   WARN_TARGETS += warning_gtest
 endif
 
-BINS_all = $(BINS_test)
-
 ifeq ($(OBJSSUBMAKE),1)
 test: $(WARN_TARGETS)
 

- *commit* 7b0603f106039466aebdc409e64b46e24888227c - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Thu Feb 27 14:31:31 2020 +0100
Subject: buildsys: get rid of unused exec_gdb_test

 etc/buildsys/rules.mk | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

_Diff for modified files_:
diff --git a/etc/buildsys/rules.mk b/etc/buildsys/rules.mk
index eda7d8e28..68da515f0 100644
--- a/etc/buildsys/rules.mk
+++ b/etc/buildsys/rules.mk
@@ -276,27 +276,23 @@ $(foreach 
MS,$(MANPAGE_SECTIONS),$(MANDIR)/man$(MS)/%.$(MS)): %.txt
                echo -e "$(INDENT_PRINT)=== $(TYELLOW)Cannot generate man page 
for $* (asciidoc not installed)$(TNORMAL)"; \
        fi
 
-# execute every test in $(BINS_test)
+# execute every test
 exec_test: $(patsubst $(BINDIR)/%,exec_gtest_%,$(BINS_gtest)) $(patsubst 
$(BINDIR)/%,exec_catch2test_%,$(BINS_catch2test))
 
-# execution of a single test.
+# execute a single gtest
 exec_gtest_%: $(BINDIR)/%
        $(eval BUILT_PARTS += $@)
        $(SILENT)echo -e "$(INDENT_PRINT)[TEST] Running gtest $(BINDIR)/$*"
        $(SILENT)exec $(BINDIR)/$* --gtest_color=$(if $(COLORED),yes,no) | sed 
's/^/$(INDENT_PRINT)[TEST] /'; \
                test $${PIPESTATUS[0]} -eq 0
 
+# execute a single catch2test
 exec_catch2test_%: $(BINDIR)/%
        $(eval BUILT_PARTS += $@)
        $(SILENT)echo -e "$(INDENT_PRINT)[TEST] Running catch2 test 
$(BINDIR)/$*"
        $(SILENT)exec $(BINDIR)/$* --use-colour $(if $(COLORED),yes,no) | sed 
's/^/$(INDENT_PRINT)[TEST] /'; \
                test $${PIPESTATUS[0]} -eq 0
 
-exec_gdb_gtest_%: $(BINDIR)/gtest_%
-       $(eval BUILT_PARTS += $@)
-       $(SILENT)echo -e "$(INDENT_PRINT)[TEST-GDB] $(BINDIR)/gtest_$*"
-       $(SILENT)exec gdb $(BINDIR)/gtest_$*
-
 .SECONDEXPANSION:
 $(BINDIR)/%: $$(OBJS_$$(call nametr,$$*))
        $(eval BUILT_PARTS += $@)



_______________________________________________
fawkes-commits mailing list
fawkes-commits@lists.kbsg.rwth-aachen.de
https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits

Reply via email to