Changes have been pushed for the repository "fawkesrobotics/fawkes".
Clone: https://github.com/fawkesrobotics/fawkes.git Gitweb: https://github.com/fawkesrobotics/fawkes The branch, thofmann/gcc9 has been created at c29ad858ad2e82d66ffaf72237c1f3c45d3a1f4e (commit) https://github.com/fawkesrobotics/fawkes/tree/thofmann/gcc9 - *Log* --------------------------------------------------------------- commit c29ad858ad2e82d66ffaf72237c1f3c45d3a1f4e Author: Till Hofmann <hofm...@kbsg.rwth-aachen.de> AuthorDate: Thu Jul 25 16:56:21 2019 +0200 Commit: Till Hofmann <hofm...@kbsg.rwth-aachen.de> CommitDate: Thu Jul 25 16:57:39 2019 +0200 interfaces: do not pack interface structs Packing interface structs is a bad idea if we access the pointer of a member of that struct, as the pointer may now be unaligned. We have never observed memory issues with blackboard interfaces, so packing seems to be unnecessary anyway. This effectively reverts 46f1e250c8f6b5938a05a1ad4a347f13285519cb, except that it removes every packing. This fixes an address-of-packed member warning that has been added in GCC9. https://github.com/fawkesrobotics/fawkes/commit/c29ad858a - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - *Summary* ----------------------------------------------------------- - *Diffs* ------------------------------------------------------------- - *commit* c29ad858ad2e82d66ffaf72237c1f3c45d3a1f4e - - - - - - - - - - Author: Till Hofmann <hofm...@kbsg.rwth-aachen.de> Date: Thu Jul 25 16:56:21 2019 +0200 Subject: interfaces: do not pack interface structs src/libs/interfaces/generator/cpp_generator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) _Diff for modified files_: diff --git a/src/libs/interfaces/generator/cpp_generator.cpp b/src/libs/interfaces/generator/cpp_generator.cpp index 0b380c718..ad14e2d8d 100644 --- a/src/libs/interfaces/generator/cpp_generator.cpp +++ b/src/libs/interfaces/generator/cpp_generator.cpp @@ -132,7 +132,7 @@ CppInterfaceGenerator::write_struct(FILE * f, fprintf(f, "%s/** Internal data storage, do NOT modify! */\n" - "%stypedef struct __attribute__((packed)) {\n" + "%stypedef struct {\n" "%s int64_t timestamp_sec; /**< Interface Unix timestamp, seconds */\n" "%s int64_t timestamp_usec; /**< Interface Unix timestamp, micro-seconds */\n", is.c_str(), _______________________________________________ fawkes-commits mailing list fawkes-commits@lists.kbsg.rwth-aachen.de https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits
