Re: [fcrepo-dev] fcrepo-1058

2012-08-27 Thread frank
I don't really mind using a diff. impl for the underlying data structure currently it's using ConcurrentHashMap from java.util.concurrent which i have used for many cache implementations. the cache class itself i think was not reinventing the wheel. it's a standard lru implememtation for DoReade

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Benjamin Armintor
Ok, this should be done. I did have to rebase the branch, so the old fcrepo-1023 issue branch is obsolete. On Mon, Aug 27, 2012 at 5:25 PM, Benjamin Armintor wrote: > The trippi merge/tag is done; I'll work on the release tonight. I'm > probably going to have to solicit some key signing, since

Re: [fcrepo-dev] fcrepo-1058

2012-08-27 Thread Edwin Shin
Looking at this again over my morning coffee, I think we ought to seriously consider re-implementing the caching using a synchronized LinkedHashMap or opt for Google's ConcurrentLinkedHashMap (http://code.google.com/p/concurrentlinkedhashmap/). I like the latter: well-documented, tested and now

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Benjamin Armintor
The trippi merge/tag is done; I'll work on the release tonight. I'm probably going to have to solicit some key signing, since I have no idea what's become of the keys I created (2? 3?) years ago for the project. - Ben On Mon, Aug 27, 2012 at 2:12 PM, Edwin Shin wrote: > ok, i've requested acces

Re: [fcrepo-dev] fcrepo-1058

2012-08-27 Thread frank
> i did a really cursory review--sorry, I'm about to crash for the night. Looks > generally ok to me, but I didn't thoroughly review the expiry of cache items, > so someone with fresher eyes might want to have a look. No worries, i wouldn't mind if this doesn't get into 3.6.1, but i rewrote the

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Edwin Shin
ok, i've requested access for you (see https://issues.sonatype.org/browse/OSSRH-2943 for when it's approved) i'm really turning in now :P On Aug 28, 2012, at 1:58 AM, Benjamin Armintor wrote: > I'm pretty sure mine's barmintor. > > On Mon, Aug 27, 2012 at 1:41 PM, frank wrote: >> Ben, can yo

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Benjamin Armintor
I'm pretty sure mine's barmintor. On Mon, Aug 27, 2012 at 1:41 PM, frank wrote: > Ben, can you do this? it's 20.00h here and i'd like to call it a night > too.. ;) > > On 08/27/2012 07:39 PM, Edwin Shin wrote: >> I'm turning in for the night (it's 1:30am), so I'm not going to be able to >> do a

Re: [fcrepo-dev] fcrepo-1058

2012-08-27 Thread Edwin Shin
Not sure if Chris is back from holiday. i did a really cursory review--sorry, I'm about to crash for the night. Looks generally ok to me, but I didn't thoroughly review the expiry of cache items, so someone with fresher eyes might want to have a look. On Aug 27, 2012, at 2:33 PM, "Asseg, Fran

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread frank
Ben, can you do this? it's 20.00h here and i'd like to call it a night too.. ;) On 08/27/2012 07:39 PM, Edwin Shin wrote: > I'm turning in for the night (it's 1:30am), so I'm not going to be able to do > a Trippi release. > > Can Ben/Frank (and whoever else) who might ever want to do a Trippi re

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Edwin Shin
I'm turning in for the night (it's 1:30am), so I'm not going to be able to do a Trippi release. Can Ben/Frank (and whoever else) who might ever want to do a Trippi release send me your Sonatype JIRA username (or sign up for an account at https://issues.sonatype.org) so I can add you to the list

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread frank
On 08/27/12 18:41, Edwin Shin wrote: > I think 1 & 2 will probably eat up 30mins-1 hour, not including Maven central > sync time, > so your call if you think you can get #3 done for today's code freeze =) I'm happy to do it, i got 6-7 more hours until im off to bed ;) But as Ben said, it's just an

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread frank
Hola, >> It looks like the actual code for the fix is all in Trippi? I'm >> happy to make sure Frank's tests and the version bump get into master >> (if Frank can't) if you can cut a Trippi release. yes thats correct, the whole code is in Trippi, just the integration tests are in frcrepo and it w

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Benjamin Armintor
Eddie, It looks like the actual code for the fix is all in Trippi? I'm happy to make sure Frank's tests and the version bump get into master (if Frank can't) if you can cut a Trippi release. - Ben On Mon, Aug 27, 2012 at 12:41 PM, Edwin Shin wrote: > Frank, > > So, if I understand correctly, i

Re: [fcrepo-dev] fcrepo-1023

2012-08-27 Thread Edwin Shin
Frank, So, if I understand correctly, in order to close FCREPO-1023, 1) trippi/fcrepo-1023 needs to be applied to trippi/master, 2) a new release of Trippi needs to cut (including publishing to Maven central) 3) fcrepo/fcrepo-1023 needs to be applied fcrepo/master (including updating pom to ref