Action requested: check dist tags and conditionals

2009-06-04 Thread Bill Nottingham
(If you've never used a construct like "%if 0%{?fedora}" in your spec file, you can disregard this message.) Many packages in Fedora use release-based conditionals such as: ... %if 0%{?rhel} %endif %if 0%{?fedora} < 10 %endif %{?fedora:%global _with_xfce --with-xfce} ... I'd just like to remin

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Julian Sikorski
Bill Nottingham pisze: > (If you've never used a construct like "%if 0%{?fedora}" in your spec > file, you can disregard this message.) > > Many packages in Fedora use release-based conditionals such as: > > ... > %if 0%{?rhel} > %endif > > %if 0%{?fedora} < 10 > %endif > > %{?fedora:%global _w

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Kevin Kofler
Bill Nottingham wrote: > %if 0%{?fedora} < 10 > %endif While we are at it: Please make sure you always use 0%{?fedora}, not "%{?fedora}". The latter will do string comparisons and do the wrong thing when comparing "9" with "10" or "11". We already had a broken dependency in F9 updates because of t

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Jeremy Sanders
Bill Nottingham wrote: > - If you're using open ended conditionals such as: > %if 0%{?fedora} > 9 > make sure you keep in mind what will happen if %{fedora} isn't defined, > such as in the case of a derivative distribution. > > - If you're building for EPEL from a unified Fedora spec file, an

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Peter Robinson
>> - If you're using open ended conditionals such as: >> %if 0%{?fedora} > 9 >>   make sure you keep in mind what will happen if %{fedora} isn't defined, >>   such as in the case of a derivative distribution. >> >> - If you're building for EPEL from a unified Fedora spec file, and have >>   separat

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Bill Nottingham
Jeremy Sanders (jer...@jeremysanders.net) said: > Can someone suggest how I should do this? I'm not sure who put this in my > spec file! > > # for eggs > %if 0%{?fedora} >= 8 > BuildRequires: python-setuptools-devel > %else > BuildRequires: python-setuptools > %endif > > Is it safe to drop th

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Peter Robinson
>> Can someone suggest how I should do this? I'm not sure who put this in my >> spec file! >> >> # for eggs >> %if 0%{?fedora} >= 8 >> BuildRequires:  python-setuptools-devel >> %else >> BuildRequires:  python-setuptools >> %endif >> >> Is it safe to drop the conditional now and always expect pytho

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Kevin Kofler
Jeremy Sanders wrote: > %if 0%{?fedora} >= 8 That should be: %if 0%{?fedora} >= 8 || 0%{?rhel} >= 6 Kevin Kofler -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Dennis Gilmore
On Thursday 04 June 2009 05:01:49 pm Peter Robinson wrote: > >> Can someone suggest how I should do this? I'm not sure who put this in > >> my spec file! > >> > >> # for eggs > >> %if 0%{?fedora} >= 8 > >> BuildRequires: python-setuptools-devel > >> %else > >> BuildRequires: python-setuptools > >

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Bill Nottingham
Peter Robinson (pbrobin...@gmail.com) said: > >> Is it safe to drop the conditional now and always expect python-setup-devel > >> to be there? > > > > If you're not building for EPEL 4/5, yes. > > Do EPEL pick up the fedora >= 8 conditional? Not as far as I know - that would make the earlier men

Re: Action requested: check dist tags and conditionals

2009-06-04 Thread Toshio Kuratomi
On 06/04/2009 01:11 PM, Julian Sikorski wrote: > Bill Nottingham pisze: >> (If you've never used a construct like "%if 0%{?fedora}" in your spec >> file, you can disregard this message.) >> >> Many packages in Fedora use release-based conditionals such as: >> >> ... >> %if 0%{?rhel} >> %endif >> >>

Re: Action requested: check dist tags and conditionals

2009-06-05 Thread Bill Nottingham
Toshio Kuratomi (a.bad...@gmail.com) said: > Does this look like the right generic structure for doing this: > > %if 0%{?fedora} >= X || 0%{?rhel} >= Y > # Do things from X until Current Fedora, Y until Current RHEL > # Y should be the latest released version if we don't know that > # it's

Re: Action requested: check dist tags and conditionals

2009-06-07 Thread Björn Persson
Dennis Gilmore wrote: > %if 0%{?fedora} <= 8 || 0%{?rhel} <= 5 Won't that expression always be true, except if both %{fedora} and %{rhel} are defined? I can only guess on how this works but it seems to me that, in Fedora 10 for example, it will be expanded to "%if 010 <= 8 || 0 <= 5", which wil

Re: Action requested: check dist tags and conditionals

2009-06-07 Thread Kevin Kofler
Björn Persson wrote: > Dennis Gilmore wrote: >> %if 0%{?fedora} <= 8 || 0%{?rhel} <= 5 > > Won't that expression always be true, except if both %{fedora} and %{rhel} > are defined? I can only guess on how this works but it seems to me that, > in Fedora 10 for example, it will be expanded to "%if