Re: Heads-up: %define vs %global in specs

2010-01-08 Thread Toshio Kuratomi
On Thu, Jan 07, 2010 at 11:54:14AM +0200, Panu Matilainen wrote: > On Tue, 5 Jan 2010, Panu Matilainen wrote: > > > > >For the impatient: > > > >Starting with today's rawhide, the these kind of constructs in > >specs no longer "work": > > %{?!foo: %define foo bar} > >For the generally desired

Re: Heads-up: %define vs %global in specs

2010-01-07 Thread Panu Matilainen
On Tue, 5 Jan 2010, Panu Matilainen wrote: For the impatient: Starting with today's rawhide, the these kind of constructs in specs no longer "work": %{?!foo: %define foo bar} For the generally desired effect, the above simply becomes: %{?!foo: %global foo bar} This is alread

Re: Heads-up: %define vs %global in specs

2010-01-05 Thread Ville Skyttä
On Tuesday 05 January 2010, Tom "spot" Callaway wrote: > On 01/05/2010 11:50 AM, Daniel P. Berrange wrote: > > What exactly do you mean 'no longer work' ? Can we expect to get a formal > > RPM build error for this bogus construct, or will it silently build and > > do the wrong thing ? From your lon

Re: Heads-up: %define vs %global in specs

2010-01-05 Thread Panu Matilainen
On Tue, 5 Jan 2010, Daniel P. Berrange wrote: On Tue, Jan 05, 2010 at 06:34:12PM +0200, Panu Matilainen wrote: For the impatient: Starting with today's rawhide, the these kind of constructs in specs no longer "work": %{?!foo: %define foo bar} For the generally desired effect, the abov

Re: Heads-up: %define vs %global in specs

2010-01-05 Thread Tom "spot" Callaway
On 01/05/2010 11:50 AM, Daniel P. Berrange wrote: > What exactly do you mean 'no longer work' ? Can we expect to get a formal > RPM build error for this bogus construct, or will it silently build and > do the wrong thing ? From your long description, it sounds like the latter, > which means maintai

Re: Heads-up: %define vs %global in specs

2010-01-05 Thread Daniel P. Berrange
On Tue, Jan 05, 2010 at 06:34:12PM +0200, Panu Matilainen wrote: > > For the impatient: > > Starting with today's rawhide, the these kind of constructs in specs > no longer "work": > %{?!foo: %define foo bar} > For the generally desired effect, the above simply becomes: > %{?!foo: %g

Heads-up: %define vs %global in specs

2010-01-05 Thread Panu Matilainen
For the impatient: Starting with today's rawhide, the these kind of constructs in specs no longer "work": %{?!foo: %define foo bar} For the generally desired effect, the above simply becomes: %{?!foo: %global foo bar} This is already recommended by the Fedora guidelines, but p