Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread Darren VanBuren
Why is maxconn an array? Seems like a waste to me. Darren VanBuren - Sent from my iPod Try Fedora 10 today. Fire it up. http://fedoraproject.org/ On Sep 22, 2009, at 7:38, Mike McGrath wrote: commit 5b943443066594955fb0194d65524dff4e5ad468 Author: Mike McGrath Dat

Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread Mike McGrath
On Tue, 22 Sep 2009, Darren VanBuren wrote: > Why is maxconn an array? Seems like a waste to me. > It's not, maxconn is a string, but in the syntax we're using: $maxconn = $memcached_maxconn ? { "" => "1024", default => $memcached_maxconn } We have it set to a defa

Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread Darren VanBuren
I only saw the "$maxconn = $memcached_maxconn ? { "" => "1024",• Still, that's some funky syntax. Darren VanBuren - Sent from my iPod Try Fedora 10 today. Fire it up. http://fedoraproject.org/ On Sep 22, 2009, at 8:47, Mike McGrath wrote: On Tue, 22 Sep

Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread brett lentz
Why not just do this: if $memcached_maxconn { $maxconn = $memcached_maxconn } else { $maxconn = 1024 } That's much more clear about what conditions set the default value. ---Brett. On Tue, Sep 22, 2009 at 9:55 AM, Darren VanBuren wrote: > I only saw the "$maxconn = $memcached_maxconn ? {    

Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread Todd Zullinger
brett lentz wrote: > Why not just do this: > > if $memcached_maxconn { $maxconn = $memcached_maxconn } else { > $maxconn = 1024 } > > That's much more clear about what conditions set the default value. Is the puppet selector method that ugly/unfamiliar though? It's used many places in puppet mani

Re: [puppet: 1/2] Adding memcached selinux policy"

2009-09-22 Thread brett lentz
On Tue, Sep 22, 2009 at 11:19 AM, Todd Zullinger wrote: > brett lentz wrote: >> Why not just do this: >> >> if $memcached_maxconn { $maxconn = $memcached_maxconn } else { >> $maxconn = 1024 } >> >> That's much more clear about what conditions set the default value. > > Is the puppet selector metho