Re: Change Request -- high risk, high reward

2009-03-14 Thread Toshio Kuratomi
mmcgr...@redhat.com wrote: > > On Mar 14, 2009, at 8:27 PM, Nigel Jones wrote: > >> >> - "Toshio Kuratomi" wrote: >> >>> ricky and I have identified a piece of code in fas2's new >>> safasprovider >>> that's querying the database a lot. It's causing anything that >>> checks >>> identity to

Re: Change Request -- high risk, high reward

2009-03-14 Thread mmcgrath
On Mar 14, 2009, at 8:27 PM, Nigel Jones wrote: - "Toshio Kuratomi" wrote: ricky and I have identified a piece of code in fas2's new safasprovider that's querying the database a lot. It's causing anything that checks identity to issue a query to the database to lookup the visit cookie

Re: Change Request -- high risk, high reward

2009-03-14 Thread Nigel Jones
- "Toshio Kuratomi" wrote: > ricky and I have identified a piece of code in fas2's new > safasprovider > that's querying the database a lot. It's causing anything that > checks > identity to issue a query to the database to lookup the visit cookie. > This is causing things that lookup infor

Re: Change Request -- high risk, high reward

2009-03-14 Thread Jon Stanley
I'm out, sorry for the top post. But zodbot FAS routines are not functional due to this, so I'd be +1 here if I had a vote :) On 3/14/09, Ricky Zhou wrote: > On 2009-03-14 05:36:27 PM, Toshio Kuratomi wrote: >> Ricky and I have both looked at the code in >> fas/safasprovider.py::SaFasIdentity and

Re: Change Request -- high risk, high reward

2009-03-14 Thread Ricky Zhou
On 2009-03-14 05:36:27 PM, Toshio Kuratomi wrote: > Ricky and I have both looked at the code in > fas/safasprovider.py::SaFasIdentity and think that it's safe to cache > this. The TG-1.0.8 saprovider on which safasprovider is based does not > cache this but I've looked at the code and it seems lik

Change Request -- high risk, high reward

2009-03-14 Thread Toshio Kuratomi
ricky and I have identified a piece of code in fas2's new safasprovider that's querying the database a lot. It's causing anything that checks identity to issue a query to the database to lookup the visit cookie. This is causing things that lookup information on the identity multiple times to take