Re: [PATCH] modprobe: Read module options from kernel command line

2008-09-04 Thread Pete Zaitcev
On Thu, 04 Sep 2008 13:54:18 -0700, Dan Nicholson [EMAIL PROTECTED] wrote: @@ -1586,6 +1626,7 @@ int main(int argc, char *argv[]) read_toplevel_config(config, , 1, 0, modoptions, commands, aliases, blacklist); + read_kcmdline(1,

Re: [PATCH] modprobe: Read module options from kernel command line

2008-09-04 Thread Pete Zaitcev
On Thu, 4 Sep 2008 14:22:46 -0700, Dan Nicholson [EMAIL PROTECTED] wrote: I see two of them. You didn't add it into insmod by any chance? If so, there has to be a way to override this. I didn't add it into insmod. The first call to read_kcmdline() is during the dump_only (-c) fast path.

Re: [PATCH] modprobe: Read module options from kernel command line

2008-09-04 Thread Jeremy Katz
On Thu, 2008-09-04 at 13:54 -0700, Dan Nicholson wrote: It is often advantageous to pass parameters to built-in kernel modules at boot time using the convention module.option. However, this does not work with loadable modules where modprobe reads its options from the config files. This patch

Re: [PATCH] modprobe: Read module options from kernel command line

2008-09-04 Thread Dan Nicholson
On Thu, Sep 4, 2008 at 3:30 PM, Jeremy Katz [EMAIL PROTECTED] wrote: On Thu, 2008-09-04 at 13:54 -0700, Dan Nicholson wrote: It is often advantageous to pass parameters to built-in kernel modules at boot time using the convention module.option. However, this does not work with loadable modules

Re: [PATCH] modprobe: Read module options from kernel command line

2008-09-04 Thread Jon Masters
On Thu, 2008-09-04 at 18:30 -0400, Jeremy Katz wrote: On Thu, 2008-09-04 at 13:54 -0700, Dan Nicholson wrote: It is often advantageous to pass parameters to built-in kernel modules at boot time using the convention module.option. However, this does not work with loadable modules where

Re: [Fwd: [PATCH] modprobe: Read module options from kernel command line]

2008-09-03 Thread Jon Masters
On Wed, 2008-09-03 at 11:34 -0400, Jon Masters wrote: Oh, did the attachment die, is that what you're saying? Hmmm...I'll look at what's going on with evolution today (unless it's mailman). Hmmm...when I sent that email there was an attachment attached to it. However, this is not the only

[Fwd: [PATCH] modprobe: Read module options from kernel command line]

2008-09-02 Thread Jon Masters
Hi folks, This patch randomly turned up in my inbox this evening and does what was discussed on IRC the other day, so I'll be adding this feature to module-init-tools...I think it's the least worst option right now. Jon. ___ Fedora-kernel-list mailing