[FFmpeg-cvslog] AAC encoder: fix valgrind errors

2016-04-05 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Apr 5 23:13:44 2016 -0300| [8005b6de4f88c9e3739a3a4ceda4288804788df9] | committer: Claudio Freire AAC encoder: fix valgrind errors Move wi.clipping computation outside of psy_lame_window, LFE channels don't even call that, and make the LFE

[FFmpeg-cvslog] AAC encoder: fix filling of wi.clipping array

2016-04-05 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Apr 5 04:03:05 2016 -0300| [7d49abdf4750d63cd9bf71235d6f064152310fff] | committer: Claudio Freire AAC encoder: fix filling of wi.clipping array Fill all windows in all window groups instead of only the first window of each group. Also avoid

[FFmpeg-cvslog] AAC encoder: new regression test

2016-04-03 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Apr 3 15:28:17 2016 -0300| [52562503d5249e4b0fc10ee3a53cf289b24cb6a3] | committer: Claudio Freire AAC encoder: new regression test Test to catch the recently fixed minsf bug Signed-off-by: Michael Niedermayer > http://git.videolan.

[FFmpeg-cvslog] AAC encoder: fix initialization of minsf

2016-04-03 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Apr 3 15:03:53 2016 -0300| [bad41d3724228cf9b03973a68cf3082adffb48f8] | committer: Claudio Freire AAC encoder: fix initialization of minsf In some situations (exactly zeroed DC coeffs) minsf would be initialized with garbage > h

[FFmpeg-cvslog] AAC encoder: fix undefined behavior

2016-03-30 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Wed Mar 30 18:34:08 2016 -0300| [be746ae4706302a100cc9e53f93fa6167215a674] | committer: Claudio Freire AAC encoder: fix undefined behavior Fix uninitialized access of minsf in short windows Fix potential invocation of coef2minsf(0) > h

[FFmpeg-cvslog] AAC encoder: fix signed integer overflow

2016-03-30 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Wed Mar 30 10:05:03 2016 -0300| [c883da6bf4610ee37848687346f543dfb73de011] | committer: Claudio Freire AAC encoder: fix signed integer overflow Clamp scalefactors by coef2minsf to avoid undefined behavior caused by signed integer overflow. It also

[FFmpeg-cvslog] AAC encoder: check for NaNs/inf in TNS gain

2016-01-20 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Jan 21 03:32:49 2016 -0300| [adc7d2a4ce8ff09431d22441b1a41f1cc9dff0e4] | committer: Claudio Freire AAC encoder: check for NaNs/inf in TNS gain Can happen in cases where's there's zero autocorrelation (pulses), and it also implies NaN/

[FFmpeg-cvslog] libavcodec/aacenc_tnc.c: remove unused variable w2

2016-01-17 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Jan 17 13:14:24 2016 -0300| [69697be92200fff8c59158f35b1771f0c002] | committer: Claudio Freire libavcodec/aacenc_tnc.c: remove unused variable w2 No longer needed since previous commit > http://git.videolan.org/gitweb.cgi/ffmpeg.git

[FFmpeg-cvslog] AAC encoder: use signed coeffs when measuring IS energy

2016-01-17 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sat Jan 16 20:47:00 2016 -0300| [df3fa48288d6e79ac4a193406d514c1dace22397] | committer: Claudio Freire AAC encoder: use signed coeffs when measuring IS energy I/S energy, especially when it comes to phase cancellations, needs to use signed

[FFmpeg-cvslog] AAC encoder: enforce SF delta in PNS and IS SFs

2016-01-17 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sat Jan 16 20:44:36 2016 -0300| [60a76f8be8f4795e63fd7b43514b8588a691aa4d] | committer: Claudio Freire AAC encoder: enforce SF delta in PNS and IS SFs Make sure to properly enforce maximum scalefactor delta in PNS and I/S, not as an absolute range

[FFmpeg-cvslog] AAC encoder: TNS fixes on short windows

2016-01-17 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sat Jan 16 23:02:41 2016 -0300| [3d0849cc90a7098e9992317248a53ef5f29ceffc] | committer: Claudio Freire AAC encoder: TNS fixes on short windows TNS was computing filter coefficients incorrectly for short windows due to a few coefficient addressing

[FFmpeg-cvslog] avcodec/aacenc_is: replace pow(x, 0.75) by x/sqrtf(sqrtf(x))

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Jan 14 00:38:22 2016 -0300| [62dfe1d40d87f8f67cd77d4b769b7c6163083c5e] | committer: Claudio Freire avcodec/aacenc_is: replace pow(x, 0.75) by x/sqrtf(sqrtf(x)) This is quite an accurate approximation; testing shows ~ 2ulp error in the floating

[FFmpeg-cvslog] AAC encoder: fix I/S relative error evaluation

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Jan 8 06:18:24 2016 -0300| [aa64a483575be65eedb336ab949e865e441d1f85] | committer: Claudio Freire AAC encoder: fix I/S relative error evaluation The relative error between two encoding strategies is the simple difference of rate-distortion

[FFmpeg-cvslog] AAC encoder: don't apply MS on special bands

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Jan 8 05:04:37 2016 -0300| [509f168017462cf301d16e3c406337072c81c783] | committer: Claudio Freire AAC encoder: don't apply MS on special bands Change the condition for application of the M/S transform to match that of the decoder. Namely,

[FFmpeg-cvslog] AAC encoder: in IS, fix index of sf_idx, band_type

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Jan 8 05:16:18 2016 -0300| [4dcb69cc12d00d46f93a07178e2087a8d27c8f64] | committer: Claudio Freire AAC encoder: in IS, fix index of sf_idx, band_type Correct addressing of sf_idx and band_type arrays in I/S code. Both arrays don't guar

[FFmpeg-cvslog] AAC encoder: avoid assertion failure on PNS

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Jan 8 04:39:02 2016 -0300| [00d481b2c37552634490443b3af6dc04e6b42239] | committer: Claudio Freire AAC encoder: avoid assertion failure on PNS In rare corner cases it could still fail an assert on sf_diff due to failure to update prev_sf in some

[FFmpeg-cvslog] AAC encoder: encode out-of-phase I/S efficiently

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Jan 10 03:04:21 2016 -0300| [699c2ee560532a5111a944d2653e9a3e484efc34] | committer: Claudio Freire AAC encoder: encode out-of-phase I/S efficiently Use the ability to invert phase with ms_mask instead of changing the codebook when possible, to

[FFmpeg-cvslog] AAC encoder: various fixes in M/S coding

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Jan 8 05:31:32 2016 -0300| [6711aa21e263a270ecd2d6a6ee1b673e665ce98a] | committer: Claudio Freire AAC encoder: various fixes in M/S coding 1. Fix sf_idx and band_type addressing to address only the first subwindow in the group (others could hold

[FFmpeg-cvslog] AAC encoder: fix assertion error with prediction

2016-01-13 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Dec 29 05:18:40 2015 -0300| [2a31b076b444d0c096efd4ab0eb4e19cf0ffd2ac] | committer: Claudio Freire AAC encoder: fix assertion error with prediction Fixes an assertion error reported in #2686 that happens when using prediction (either explicitly

[FFmpeg-cvslog] AAC encoder: fix possible assertion failure in PNS

2015-12-22 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Dec 22 05:26:12 2015 -0300| [4720a562c8d45b15c49ea3535a8e74933b1ac260] | committer: Claudio Freire AAC encoder: fix possible assertion failure in PNS Fix possible SF delta violation that would cause an eventual assertion failure in some corner

[FFmpeg-cvslog] AAC encoder: fix OOB access in search_for_pns

2015-12-09 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Wed Dec 9 17:36:32 2015 -0300| [124c3759386a98e9f47b3305cb18cee5e1707d73] | committer: Andreas Cadhalpun AAC encoder: fix OOB access in search_for_pns Fix OOB access in search_for_pns which was using w2 outside the window group loop, and fix a typo

[FFmpeg-cvslog] AAC encoder: ANMR, avoid empty search ranges

2015-12-04 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Dec 4 22:56:34 2015 -0300| [293c170f59414647b9bba9cb4602eb92989fd4ba] | committer: Claudio Freire AAC encoder: ANMR, avoid empty search ranges Avoid generating broken paths when some bands have an empty search space. > http://git.videolan.

[FFmpeg-cvslog] AAC encoder: improve SF range utilization

2015-12-02 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Dec 1 03:28:36 2015 -0300| [ca203e9985cd2dcf42a0c0853940850d3a8edf3a] | committer: Claudio Freire AAC encoder: improve SF range utilization This patch does 4 things, all of which interact and thus it woudln't be possible to commit

[FFmpeg-cvslog] AAC encoder: make pe.min a local minimum

2015-11-29 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Nov 29 15:03:45 2015 -0300| [88e498a87eb255eca48c40fd5570a42372491f2f] | committer: Claudio Freire AAC encoder: make pe.min a local minimum As noted in a comment, pe.min in the reference encoder is centered around current pe. The bit reservoir

[FFmpeg-cvslog] AAC encoder: fix wrong gain sacalefactor being set

2015-11-25 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Nov 26 03:37:29 2015 -0300| [3b1cab9351f384f3a8d03dec58262d5b66920e30] | committer: Claudio Freire AAC encoder: fix wrong gain sacalefactor being set In some conditions, where the first band was being zeroed mainly, the wrong global gain

[FFmpeg-cvslog] AAC encoder: Fix application of M/S with PNS

2015-11-25 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Nov 26 03:27:06 2015 -0300| [fc36d852ee3413f7cd00ce531ba985925fa7a749] | committer: Claudio Freire AAC encoder: Fix application of M/S with PNS When both M/S coding and PNS are enabled, scalefactors and coding books would be mistakenly clobbered

[FFmpeg-cvslog] AAC encoder: memoize quantize_band_cost

2015-10-11 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Mon Oct 12 03:56:22 2015 -0300| [b629c67ddfceb7026e407685f04d1bb09cb08d31] | committer: Claudio Freire AAC encoder: memoize quantize_band_cost The bulk of calls to quantize_band_cost are replaced by a call to a version that memoizes, greatly

[FFmpeg-cvslog] AAC encoder: fix assertion error re SF differences

2015-10-11 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Oct 11 23:00:46 2015 -0300| [07b3b779a9f75c73f8e9e638d67bff1e8d244392] | committer: Claudio Freire AAC encoder: fix assertion error re SF differences Intermediate results can indeed violate SF delta. Instead of asserting there, just make the code

[FFmpeg-cvslog] AAC encoder tests: increase fuzz for pred test

2015-10-11 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Oct 11 18:45:27 2015 -0300| [79f2014f1264aeb9dae3134d3649aba6ca0d4d13] | committer: Claudio Freire AAC encoder tests: increase fuzz for pred test MIPS needs more fuzz > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commi

[FFmpeg-cvslog] AAC encoder: cosmetics from last commit

2015-10-11 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Oct 11 18:06:02 2015 -0300| [323d37521d66233c8d9405dba902100ef146b5ec] | committer: Claudio Freire AAC encoder: cosmetics from last commit Reindent > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commi

[FFmpeg-cvslog] AAC encoder: fix OOB access in search_for_pns

2015-09-26 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sat Sep 26 04:49:16 2015 -0300| [0f98fd30e2d3c7254a1c56ce42a9a8bf0f6dc0eb] | committer: Claudio Freire AAC encoder: fix OOB access in search_for_pns Fix out of bounds access caused by wrongful usage of swb_offset constants when computing scalefactor

[FFmpeg-cvslog] AAC encoder: tweak PNS usage to be more aggressive

2015-09-25 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Sep 25 03:56:32 2015 -0300| [9458a62decfcaa1313b1ba69276466de536d0768] | committer: Claudio Freire AAC encoder: tweak PNS usage to be more aggressive This patch tweaks search_for_pns to be both more aggressive and more careful when applying PNS

[FFmpeg-cvslog] AAC encoder: tweak rate-distortion logic

2015-09-22 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Wed Sep 23 02:13:56 2015 -0300| [7ec74ae4aaf50507c5da3dfbb7336e15f848b99b] | committer: Claudio Freire AAC encoder: tweak rate-distortion logic This patch modifies the encode frame function to retry encoding the frame when the resulting bit count is

[FFmpeg-cvslog] AAC encoder: simplify and speed up find_min_book

2015-09-22 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Mon Sep 21 03:41:26 2015 -0300| [b01f3ddad31aba45254dfd553447c7952f86fd31] | committer: Claudio Freire AAC encoder: simplify and speed up find_min_book Trivial change to simplify the small but hot find_min_book function. The new form is easier to

[FFmpeg-cvslog] AAC encoder: fix make checkheaders

2015-09-18 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Sep 18 18:38:54 2015 -0300| [3693efb3158d8e6aaeb9d504177fb6f96fc8f4e3] | committer: Claudio Freire AAC encoder: fix make checkheaders With the move of some functions into templates in aaccoder_twoloop.h and aaccoder_trellis.h, make checkheaders

[FFmpeg-cvslog] AAC encoder: refactor to resynchronize MIPS port

2015-09-16 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Sep 15 03:59:45 2015 -0300| [8df9bf8e39b5f38c75d63c0ef17965382e634b1c] | committer: Claudio Freire AAC encoder: refactor to resynchronize MIPS port This patch refactors the AAC coders to reuse code between the MIPS port and the regular, portable

[FFmpeg-cvslog] AAC: MIPS: Add missing codebooks in quantize funcs

2015-09-03 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Sep 3 10:49:17 2015 -0300| [5131ba565792828a44ff275ea4dd53300cc6f119] | committer: Claudio Freire AAC: MIPS: Add missing codebooks in quantize funcs Add entries on the quantize function tables for the missing codebooks (which all behave like

[FFmpeg-cvslog] AAC: Increase fuzziness of fate-aac tests

2015-09-03 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Thu Sep 3 10:16:33 2015 -0300| [bcb3332b1bc155c0bd05c9a40436b301fede7787] | committer: Claudio Freire AAC: Increase fuzziness of fate-aac tests Needed to make them pass in mips > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commi

[FFmpeg-cvslog] AAC Encoder: clipping avoidance

2015-07-27 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Mon Jul 20 22:53:24 2015 -0300| [59216e0525a58714be4207be6ae8744750e62867] | committer: Michael Niedermayer AAC Encoder: clipping avoidance Avoid clipping due to quantization noise to produce audible artifacts, by detecting near-clipping signals and

[FFmpeg-cvslog] tests/fate-run: Print more details on failure of stddev / filesize compares

2015-03-09 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Mar 8 03:53:22 2015 -0300| [374ec68139d1676fd7fe8b090dca9e0adf03678e] | committer: Michael Niedermayer tests/fate-run: Print more details on failure of stddev / filesize compares Signed-off-by: Michael Niedermayer > http://git.videolan.

[FFmpeg-cvslog] AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate.

2015-03-06 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Fri Mar 6 04:05:32 2015 -0300| [6dbbb981b5730be5ee618688d848df5face31e84] | committer: Michael Niedermayer AAC: Add support for 7350Hz sampling rates, no error on too hight bitrate. Instead, warn that bitrate will be clamped down to the maximum

[FFmpeg-cvslog] AAC: Fix M/S stereo encoding

2015-03-03 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Tue Mar 3 03:43:06 2015 -0300| [6394acaf36da3106f4793bda32730f8ff6b0ddb1] | committer: Michael Niedermayer AAC: Fix M/S stereo encoding This patch fixes a pointer arithmetic bug in adjust_frame_information that resulted in heavily corrupted audio

[FFmpeg-cvslog] avcodec/aacpsy: Fix AAC Psy PE reduction calculation when multiple iterations are required

2015-03-02 Thread Claudio Freire
ffmpeg | branch: master | Claudio Freire | Sun Mar 1 20:11:12 2015 -0300| [84f4be424d52b05fabe0fe8cfb569c77fc0c1f7b] | committer: Michael Niedermayer avcodec/aacpsy: Fix AAC Psy PE reduction calculation when multiple iterations are required This is a small change, but it does have a big