Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

2014-07-18 Thread Nicolas George
Le decadi 30 messidor, an CCXXII, Clément Bœsch a écrit : > It's not present in 2.3 release? No, it was applied a little bit later. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

2014-07-18 Thread Paul B Mahol
On Fri, Jul 18, 2014 at 4:25 AM, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > libavcodec/smacker.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c > index 644beb3..518bdad 100644 > --- a/libavcodec/smacker.c > +++ b/libavcodec/smack

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
Hi, Any chance someone could take a look to these patches ? -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Stefano Sabatini
On date Friday 2014-07-18 10:07:21 +0200, Nicolas Martyanoff encoded: > Hi, > > Any chance someone could take a look to these patches ? Could you send them to this mailing-list? This way we will be able to make a proper inline review, thanks. -- FFmpeg = Fundamentalist & Freak Mysterious Power

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
The FFmpeg developer info page said it was fine to use github instead of mailing patches, but if you prefer, I can mail them. -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

[FFmpeg-devel] [PATCH] ffmpeg_filter: refuse to configure input without a decoder.

2014-07-18 Thread Nicolas George
The decoder is necessary in order to filter frames. This makes the error message clearer in this case: currently, it will usually fail because the pixel or sample format is not defined and is converted into "(null)" (non-portable). Signed-off-by: Nicolas George --- ffmpeg_filter.c | 6 ++ 1

[FFmpeg-devel] [PATCH 1/7] avformat/hlsenc: correctly compute target duration

2014-07-18 Thread Nicolas Martyanoff
With HLS, the duration of all segments must be lower or equal to the target duration. Therefore floor(duration + 0.5) yields incorrect results. For example, for duration = 1.35, floor(duration + 0.5) yields 1.0, but the correct result is 2.0. --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 ins

[FFmpeg-devel] [PATCH 3/7] avformat/hlsenc: fix segmentation issues

2014-07-18 Thread Nicolas Martyanoff
- Select a reference stream (the first video stream, or the first audio stream if there is no video stream) instead of using the PTS of any video stream. - Control the segment length using the time since the last segment. --- libavformat/hlsenc.c | 165 +++-

[FFmpeg-devel] [PATCH 2/7] avformat/hlsenc: make the code easier to read

2014-07-18 Thread Nicolas Martyanoff
Before adding new features, I read the code and cleaned it. The main issue was abstruse identifier names. The behaviour of the muxer is *not* modified, by this patch, this is only cosmetic. If this is not the case, it is a mistake. --- libavformat/hlsenc.c | 360 ++

[FFmpeg-devel] [PATCH 4/7] avformat/hlsenc: do not regenerate the playlist for each segment

2014-07-18 Thread Nicolas Martyanoff
Since we need all segments to find out the target duration, we can only generate the playlist after writing all segments. There is no need to rewrite the segment list every time we create a new segment file. --- libavformat/hlsenc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-

[FFmpeg-devel] [PATCH 6/7] avformat/hlsenc: add a flag disabling the filename in segment names

2014-07-18 Thread Nicolas Martyanoff
The default way to name segment is to use the name of the media file, with an optional prefix (-hls_base_url). However in applications where the URL used to fetch segments does not contain the name of the file, it is useful to have the ability not to include the filename in segment names. Of cour

[FFmpeg-devel] [PATCH 7/7] avformat/hlsenc: add an option to set the media filename

2014-07-18 Thread Nicolas Martyanoff
Works with or without the 'single_file' HLS flag. --- doc/muxers.texi | 11 +++ libavformat/hlsenc.c | 31 ++- 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b97775b..63a0fdf 100644 --- a/doc/muxers.

[FFmpeg-devel] [PATCH 5/7] avformat/hlsenc: add single file mode

2014-07-18 Thread Nicolas Martyanoff
HLS version 4 offers the possibility to keep the media file whole instead of splitting it. In that case, segments are specified with byte ranges. We introduce a new '-hls_flags' option for the hlsenc muxer, with a single flag for the time being, 'single_file'. --- doc/muxers.texi | 23 ++

[FFmpeg-devel] [PATCH] libavu: add pkt_timebase to AVFrame.

2014-07-18 Thread Benoit Fouet
In order to easily correlate pkt_duration to its real duration, add the packet time base information to the frame structure. Fixes issue #3052 --- libavcodec/utils.c | 6 ++ libavutil/frame.c | 3 +++ libavutil/frame.h | 11 +++ 3 files changed, 20 insertions(+) diff --git a/liba

Re: [FFmpeg-devel] [PATCH] libavu: add pkt_timebase to AVFrame.

2014-07-18 Thread Nicolas George
Le decadi 30 messidor, an CCXXII, Benoit Fouet a écrit : > +if (frame && av_frame_get_pkt_timebase(frame).num) > +avpkt->duration = av_rescale_q(av_frame_get_pkt_duration(frame), > + av_frame_get_pkt_timebase(frame), > +

Re: [FFmpeg-devel] A few filter questions

2014-07-18 Thread Gerion Entrup
Am Donnerstag 17 Juli 2014, 17:24:35 schrieb Clément Bœsch: > On Thu, Jul 17, 2014 at 04:56:08PM +0200, Gerion Entrup wrote: > [...] > > > > Also, you still have the string metadata possibility (git grep SET_META > > > libavfilter). > > > > Hmm, thank you, I will take a look at it. If I see it ri

Re: [FFmpeg-devel] [PATCH] libavu: add pkt_timebase to AVFrame.

2014-07-18 Thread Hendrik Leppkes
Am 18.07.2014 12:04 schrieb "Benoit Fouet" : > > In order to easily correlate pkt_duration to its real duration, add the > packet time base information to the frame structure. > > Fixes issue #3052 The code in avcodec doesn't know the timebase, unless the user tells it. And if the user wants to t

[FFmpeg-devel] Filters

2014-07-18 Thread JULIAN GARDNER
How do I fix a filter so that it takes in 1 input but has no output, this is part of a project and this part is a detection filter, it does nothing else. The problem at the moment is that with the current filter, based on drawbox, is that it produces an output which i need to the use overlay to

Re: [FFmpeg-devel] [PATCH] libavu: add pkt_timebase to AVFrame.

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 12:47:06PM +0200, Hendrik Leppkes wrote: > Am 18.07.2014 12:04 schrieb "Benoit Fouet" : > > > > In order to easily correlate pkt_duration to its real duration, add the > > packet time base information to the frame structure. > > > > Fixes issue #3052 > > The code in avcodec

Re: [FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:04:05AM +0200, Paul B Mahol wrote: > On Fri, Jul 18, 2014 at 4:25 AM, Timothy Gu wrote: > > > Signed-off-by: Timothy Gu > > --- > > libavcodec/smacker.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c > > ind

Re: [FFmpeg-devel] Filters

2014-07-18 Thread Clément Bœsch
On Fri, Jul 18, 2014 at 12:08:41PM +0100, JULIAN GARDNER wrote: > How do I fix a filter so that it takes in 1 input but has no output, this is > part of a project and this part is a detection filter, it does nothing else. > > The problem at the moment is that with the current filter, based on dra

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: refuse to configure input without a decoder.

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:43:22AM +0200, Nicolas George wrote: > The decoder is necessary in order to filter frames. > This makes the error message clearer in this case: > currently, it will usually fail because the pixel or sample > format is not defined and is converted into "(null)" > (non-port

Re: [FFmpeg-devel] Filters

2014-07-18 Thread JULIAN GARDNER
> > From: Clément Bœsch >To: FFmpeg development discussions and patches >Sent: Friday, 18 July 2014, 13:38 >Subject: Re: [FFmpeg-devel] Filters > > >On Fri, Jul 18, 2014 at 12:08:41PM +0100, JULIAN GARDNER wrote: >> How do I fix a filter so that it takes in 1 inp

Re: [FFmpeg-devel] Filters

2014-07-18 Thread Clément Bœsch
On Fri, Jul 18, 2014 at 12:56:17PM +0100, JULIAN GARDNER wrote: > > > > From: Clément Bœsch > >To: FFmpeg development discussions and patches > >Sent: Friday, 18 July 2014, 13:38 > >Subject: Re: [FFmpeg-devel] Filters > > > > > >On Fri, Jul 18, 2014 at 12:08:41PM

Re: [FFmpeg-devel] Filters

2014-07-18 Thread JULIAN GARDNER
- Original Message - > From: Clément Bœsch > To: FFmpeg development discussions and patches > Cc: > Sent: Friday, 18 July 2014, 14:01 > Subject: Re: [FFmpeg-devel] Filters > > On Fri, Jul 18, 2014 at 12:56:17PM +0100, JULIAN GARDNER wrote: >> > >> >

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: add alias "expr_int_format" to expansion function "eif"

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 07:53:48AM +0200, Stefano Sabatini wrote: > On date Friday 2014-07-18 01:00:40 +0300, Andrey Utkin encoded: > > --- > > doc/filters.texi | 2 +- > > libavfilter/vf_drawtext.c | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/doc/fi

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:40:03AM +0200, Nicolas Martyanoff wrote: > The FFmpeg developer info page said it was fine to use github instead of > mailing patches, but if you prefer, I can mail them. pull requests are more intended for code after it has been reviewed by someone who knows the code we

Re: [FFmpeg-devel] Filters

2014-07-18 Thread Clément Bœsch
On Fri, Jul 18, 2014 at 01:14:25PM +0100, JULIAN GARDNER wrote: [...] > > You do exactly that and that's all. Then ffmpeg -i foo -vf bar -f null - > > > > There are a lot of detection only filters. volumedetect, signalstats, > > blackdetect, ... just copy their behaviour > > > > Yes but this is

Re: [FFmpeg-devel] [PATCH] Introduce avio_dump_contents() and use it in lavd/lavfi.c

2014-07-18 Thread Michael Niedermayer
On Thu, Jul 17, 2014 at 11:37:03PM +0300, Andrey Utkin wrote: > This is a replacement for previously proposed API > av_bprint_fd_contents(). > Side-effect: lavfi input device now accepts any URL as "graph_file" > option value. > --- > libavdevice/lavfi.c | 30 +++--- > li

Re: [FFmpeg-devel] [PATCH 1/7] avformat/hlsenc: correctly compute target duration

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:57:41AM +0200, Nicolas Martyanoff wrote: > With HLS, the duration of all segments must be lower or equal to the target > duration. Therefore floor(duration + 0.5) yields incorrect results. > > For example, for duration = 1.35, floor(duration + 0.5) yields 1.0, but the >

Re: [FFmpeg-devel] [PATCH] lavf/segment: do not allow to create segments with no key-frames

2014-07-18 Thread Michael Niedermayer
On Thu, Jul 17, 2014 at 08:39:16PM +0200, Stefano Sabatini wrote: > Fix trac ticket #3749. > --- > libavformat/segment.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) probably ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those w

Re: [FFmpeg-devel] [PATCH] oss_audio: check all ioctl() return codes

2014-07-18 Thread Michael Niedermayer
On Thu, Jul 17, 2014 at 05:59:43PM -0700, Timothy Gu wrote: > Also uses a macro to simplify. > > Signed-off-by: Timothy Gu > --- > > Found with clang's static analyzer. > > --- > libavdevice/oss_audio.c | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff

[FFmpeg-devel] [PATCH] [RFC] hevc: report more precise progress

2014-07-18 Thread Christophe Gisquet
Hi, HEAD currently does note pass "make fate-hevc THREADS=6" because of a missing output frame in POC_A. Except for this sequence, the patch passes for THREADS={2,3,4,6,7} on a 6-cores system. This is more of an RFC because the value used in reporting surprises me and my understanding leads to th

[FFmpeg-devel] [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl, chunk).

2014-07-18 Thread Peter B.
Hello. Georg Lippitsch and I created 2 FATE tests for the EBU Peak Envelope Chunk: Test 1: Normal WAV file with levl-chunk and audio data. Test 2: "Peakfile" WAV with levl-chunk, without audio data. I tried to follow the style of existing lavf-regression tests in FATE as good as possible. Regard

[FFmpeg-devel] [PATCH]Parse dri in rtp jpeg

2014-07-18 Thread Carl Eugen Hoyos
Hi! Attached completely untested patch is based on the file attached to ticket #3780. Please review, Carl Eugen diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index 80fe295..ccd80ad 100644 --- a/libavformat/rtpdec_jpeg.c +++ b/libavformat/rtpdec_jpeg.c @@ -106,7 +106,8 @@ sta

Re: [FFmpeg-devel] [PATCH] Introduce avio_dump_contents() and use it in lavd/lavfi.c

2014-07-18 Thread Andrey Utkin
Thanks for comments, going to resubmit on Monday. -- Andrey Utkin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl, chunk).

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 06:10:42PM +0200, Peter B. wrote: > Hello. > > Georg Lippitsch and I created 2 FATE tests for the EBU Peak Envelope Chunk: > Test 1: Normal WAV file with levl-chunk and audio data. > Test 2: "Peakfile" WAV with levl-chunk, without audio data. > > I tried to follow the styl

Re: [FFmpeg-devel] [PATCH]Parse dri in rtp jpeg

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 06:46:07PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached completely untested patch is based on the file attached to ticket > #3780. > > Please review, Carl Eugen i suspect this is correct, but have no idea on how to test if no way to test is found, then iam in favor

[FFmpeg-devel] dmMediaConverter

2014-07-18 Thread Dalacu Marius
Hi, i am the developer of dmMediaConverter, a simple FFmpeg frontend. I am writing here in hope that my program will appear on FFmpeg-Based Projects (https://www.ffmpeg.org/projects.html). In case you like the app and i am not infringe any rules, thank you, Best regards, Marius Dalacu.    http://d

Re: [FFmpeg-devel] [PATCH] [RFC] hevc: report more precise progress

2014-07-18 Thread Christophe Gisquet
014-07-18 17:41 GMT+02:00 Christophe Gisquet : > This is more of an RFC Only a part can apply, Michaël should have a patch with the correct part. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] Filters

2014-07-18 Thread JULIAN GARDNER
> > From: Clément Bœsch >To: FFmpeg development discussions and patches >Sent: Friday, 18 July 2014, 14:55 >Subject: Re: [FFmpeg-devel] Filters > > >On Fri, Jul 18, 2014 at 01:14:25PM +0100, JULIAN GARDNER wrote: >[...] >> > You do exactly that and that's

Re: [FFmpeg-devel] [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl, chunk).

2014-07-18 Thread Peter B.
On 07/18/2014 07:40 PM, Michael Niedermayer wrote: > applied Thanks! Pb ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] oss_audio: use a macro to simplify ioctl() error checking

2014-07-18 Thread Timothy Gu
Also add a note about SNDCTL_DSP_GETFMTS which may fail even if OSS is available. Signed-off-by: Timothy Gu --- libavdevice/oss_audio.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavdevice/oss_audio.c b/libavdevice/oss_audio.c index 9a3cdc

Re: [FFmpeg-devel] [PATCH] oss_audio: use a macro to simplify ioctl() error checking

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 02:56:16PM -0700, Timothy Gu wrote: > Also add a note about SNDCTL_DSP_GETFMTS which may fail even if OSS is > available. > > Signed-off-by: Timothy Gu > --- > libavdevice/oss_audio.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) a