Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On 30.08.2014, at 15:38, wm4 wrote: > +// The packet-size is stored as part of the packet. > +if ((ret = avio_read(s->pb, tmp, 3)) < 0) > +return ret; > + > +len = AV_RB16(tmp + 1); > + > +if ((ret = av_new_packet(pkt, len + 3)) < 0) > +return ret; > + > +memcpy

Re: [FFmpeg-devel] [PATCH]Clean up if filter initialisation failed

2014-08-31 Thread Carl Eugen Hoyos
Nicolas George nsup.org> writes: > Please mention in the commit short message that it > is about the command-line tools and not the library; > maybe "ffmpeg: clean up if...". Merged by Michael with that change. Thank you, Carl Eugen ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Hendrik Leppkes
On Sun, Aug 31, 2014 at 9:41 AM, Reimar Döffinger wrote: > On 30.08.2014, at 15:38, wm4 wrote: >> +// The packet-size is stored as part of the packet. >> +if ((ret = avio_read(s->pb, tmp, 3)) < 0) >> +return ret; >> + >> +len = AV_RB16(tmp + 1); >> + >> +if ((ret = av_new_

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 10:15:56AM +0200, Hendrik Leppkes wrote: > On Sun, Aug 31, 2014 at 9:41 AM, Reimar Döffinger > wrote: > > On 30.08.2014, at 15:38, wm4 wrote: > >> +// The packet-size is stored as part of the packet. > >> +if ((ret = avio_read(s->pb, tmp, 3)) < 0) > >> +ret

Re: [FFmpeg-devel] [PATCH 1/6] fft: add ff_ prefix to some global arrays.

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 04:43:39PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger Patchset pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 06:18:41PM +0200, Reimar Döffinger wrote: > Moves it from .data to .bss, slightly reducing binary size. Any other comments? Should I write more in the commit message? It's obviously not a big deal, I just thought the code to be overall better this way. _

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 11:23:52PM +0200, Reimar Döffinger wrote: > On 30.08.2014, at 21:50, Clément Bœsch wrote: > > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > >> On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > >>> On Fri, Aug 29, 2014 at 06:34:52PM +0200

Re: [FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 06:15:46PM +0200, Michael Niedermayer wrote: > On Sat, Aug 30, 2014 at 06:00:43PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/aac_tablegen.h | 2 +- > > libavcodec/aacps_tablegen.h| 4 ++-- > > libavcodec/aacsb

Re: [FFmpeg-devel] [PATCH] WMA: add "const" to avoid warnings with hardcoded tables.

2014-08-31 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 06:14:59PM +0200, Michael Niedermayer wrote: > On Sat, Aug 30, 2014 at 06:00:20PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/wma.h | 2 +- > > libavcodec/wmaprodec.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 dele

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-31 Thread Clément Bœsch
On Sun, Aug 31, 2014 at 10:46:29AM +0200, Reimar Döffinger wrote: > On Sat, Aug 30, 2014 at 11:23:52PM +0200, Reimar Döffinger wrote: > > On 30.08.2014, at 21:50, Clément Bœsch wrote: > > > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > > >> On Fri, Aug 29, 2014 at 09:29:46PM

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
On Sun, 31 Aug 2014 10:24:13 +0200 Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 10:15:56AM +0200, Hendrik Leppkes wrote: > > On Sun, Aug 31, 2014 at 9:41 AM, Reimar Döffinger > > wrote: > > > On 30.08.2014, at 15:38, wm4 wrote: > > >> +// The packet-size is stored as part of the packet

[FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
--- I got the semantics of avio_read wrong: short reads on EOF are in fact allowed and don't return an error. Hopefully this is correct now... --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 92 3 fil

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 09:41:49AM +0200, Reimar Döffinger wrote: > On 30.08.2014, at 15:38, wm4 wrote: > > +// The packet-size is stored as part of the packet. > > +if ((ret = avio_read(s->pb, tmp, 3)) < 0) > > +return ret; > > + > > +len = AV_RB16(tmp + 1); > > + > > +if

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 11:39:16AM +0200, wm4 wrote: > I got the semantics of avio_read wrong: short reads on EOF are in > fact allowed and don't return an error. Hopefully this is correct now... What I _really_ dislike about these approaches is that we hard-code EOF behaviour in every single demu

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
On Sun, 31 Aug 2014 11:50:36 +0200 Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 11:39:16AM +0200, wm4 wrote: > > I got the semantics of avio_read wrong: short reads on EOF are in > > fact allowed and don't return an error. Hopefully this is correct now... > > What I _really_ dislike about t

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 12:00:13PM +0200, wm4 wrote: > On Sun, 31 Aug 2014 11:50:36 +0200 > Reimar Döffinger wrote: > > > On Sun, Aug 31, 2014 at 11:39:16AM +0200, wm4 wrote: > > > I got the semantics of avio_read wrong: short reads on EOF are in > > > fact allowed and don't return an error. Hope

[FFmpeg-devel] [PATCH] intmath.h: Remove duplicated ARM include.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavutil/intmath.h | 4 1 file changed, 4 deletions(-) diff --git a/libavutil/intmath.h b/libavutil/intmath.h index e140d82..8f7a69e 100644 --- a/libavutil/intmath.h +++ b/libavutil/intmath.h @@ -35,10 +35,6 @@ * @{ */ -#if ARCH_ARM -# include

[FFmpeg-devel] [PATCH] aacps_tablegen: replace TABLE_CONST by const.

2014-08-31 Thread Reimar Döffinger
Doesn't change generated code, just is more consistent and a bit less error-prone. Signed-off-by: Reimar Döffinger --- libavcodec/aacps_tablegen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacps_tablegen.c b/libavcodec/aacps_tablegen.c index 47d4205..f56930b

[FFmpeg-devel] [PATCH] cabac: Allow hardcoding CABAC table.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/Makefile | 4 +- libavcodec/cabac.c | 74 + libavcodec/cabac.h | 7 ++- libavcodec/cabac_functions.h | 8 ++-- libavcodec/cabac_tablegen.c | 41 libavcodec/cabac_table

[FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
--- Following the advice to use av_get_packet() etc. Tese functions still return partial packets, but mark them as corrupted - so returning them should be fine. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 85

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread compn
On Sun, 31 Aug 2014 00:33:58 +0200 wm4 wrote: > On Sat, 30 Aug 2014 18:16:27 -0400 > Marcus Johnson wrote: > > > Here's a PGS subtitle sample from Eac3to: > > https://dl.dropboxusercontent.com/u/52358991/English.zip you saw the few samples we have in the repo, right? http://samples.ffmpeg.org/

[FFmpeg-devel] [PATCH 2/2] rl.h: Use deprecated attribute for deprecated field.

2014-08-31 Thread Reimar Döffinger
--- libavcodec/rl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rl.h b/libavcodec/rl.h index c80283d..5a90167 100644 --- a/libavcodec/rl.h +++ b/libavcodec/rl.h @@ -44,7 +44,7 @@ typedef struct RLTable { uint8_t *index_run[2]; ///< encoding only

[FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
This has a few TODOs like adjusting the run tables instead of having a -1 in the decode loop. But please review the general idea. Signed-off-by: Reimar Döffinger --- libavcodec/flv.h| 1 - libavcodec/flvdec.c | 12 --- libavcodec/h261dec.c| 27 +++- l

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 01:04:29PM +0200, wm4 wrote: > +static int sup_probe(AVProbeData *p) > +{ > +if (p->buf_size < 2 || memcmp(p->buf, "PG", 2)) > +return 0; > +return AVPROBE_SCORE_EXTENSION; I understand if you consider it not worth the effort, but ideally this would scan ahe

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 02:21:46PM +0200, Reimar Döffinger wrote: > This has a few TODOs like adjusting the run tables instead > of having a -1 in the decode loop. > But please review the general idea. I forgot to say: this is the first time I use this API, and I was quite confused. And in particu

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-08-31 Thread Dmitry Volyntsev
>why is this condition true ? I tried several configuration and problem occurred only under certain circumstances: 1. webcam type: Logitech C310 (tried also: C350) 2. capturing settings: 640*480, 422p 3. simultaneous capturing from two webcams 4. relatively old laptop (Lenovo Z470, Z570, L420)

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Ronald S. Bultje
Hi, On Sun, Aug 31, 2014 at 8:27 AM, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 02:21:46PM +0200, Reimar Döffinger wrote: > > This has a few TODOs like adjusting the run tables instead > > of having a -1 in the decode loop. > > But please review the general idea. > > I forgot to say: this

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 08:37:56AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 31, 2014 at 8:27 AM, Reimar Döffinger > wrote: > > > On Sun, Aug 31, 2014 at 02:21:46PM +0200, Reimar Döffinger wrote: > > > This has a few TODOs like adjusting the run tables instead > > > of having a -1 in

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
On Sun, 31 Aug 2014 14:25:21 +0200 Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 01:04:29PM +0200, wm4 wrote: > > +static int sup_probe(AVProbeData *p) > > +{ > > +if (p->buf_size < 2 || memcmp(p->buf, "PG", 2)) > > +return 0; > > +return AVPROBE_SCORE_EXTENSION; > > I unders

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 02:57:54PM +0200, wm4 wrote: > On Sun, 31 Aug 2014 14:25:21 +0200 > Reimar Döffinger wrote: > > > On Sun, Aug 31, 2014 at 01:04:29PM +0200, wm4 wrote: > > > +static int sup_probe(AVProbeData *p) > > > +{ > > > +if (p->buf_size < 2 || memcmp(p->buf, "PG", 2)) > > > +

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Ronald S. Bultje
Hi, On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 08:37:56AM -0400, Ronald S. Bultje wrote: > > On Sun, Aug 31, 2014 at 8:27 AM, Reimar Döffinger < > reimar.doeffin...@gmx.de> > > wrote: > > > On Sun, Aug 31, 2014 at 02:21:46PM +0200, Reimar Döffinger wrote:

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger > wrote: > > > On Sun, Aug 31, 2014 at 08:37:56AM -0400, Ronald S. Bultje wrote: > > > On Sun, Aug 31, 2014 at 8:27 AM, Reimar Döffinger < > > reimar.doeffin...@gmx.de> >

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
On Sun, 31 Aug 2014 15:16:49 +0200 Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 02:57:54PM +0200, wm4 wrote: > > On Sun, 31 Aug 2014 14:25:21 +0200 > > Reimar Döffinger wrote: > > > > > On Sun, Aug 31, 2014 at 01:04:29PM +0200, wm4 wrote: > > > > +static int sup_probe(AVProbeData *p) > > >

[FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/ituh263dec.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c index 26f0ec5..083f5ae 100644 --- a/libavcodec/ituh263dec.c +++ b/libavcodec/

[FFmpeg-devel] [PATCH 2/4] h261dec: Optimize new RL_VLC decoding.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index 5f0eb59..f286d23 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -318,27 +318,25 @@ static int h26

[FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
Some additional optimizations in following patch. Signed-off-by: Reimar Döffinger --- libavcodec/flv.h| 1 - libavcodec/flvdec.c | 12 -- libavcodec/h261dec.c| 27 ++- libavcodec/ituh263dec.c | 58 - 4 f

[FFmpeg-devel] [PATCH 4/4] rl.h: remove deprecated and now unused vlc member.

2014-08-31 Thread Reimar Döffinger
--- libavcodec/mpeg12.c| 13 +++-- libavcodec/mpegvideo.c | 8 libavcodec/rl.h| 8 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index 27d680f..cb00baf 100644 --- a/libavcodec/mpeg12.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Ronald S. Bultje
Hi, On Sun, Aug 31, 2014 at 9:38 AM, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: > > On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger < > reimar.doeffin...@gmx.de> > > wrote: > > > On Sun, Aug 31, 2014 at 08:37:56AM -0400, Ronald S. Bultje wrote:

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 03:38:21PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: > > On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger > > wrote: > > > > > I forgot to say: this is the first time I use this API, > > > > > and I was quite confuse

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 04:15:51PM +0200, wm4 wrote: > Well yes, it would be possible to loop over the entire probe buffer, > until it ends on a packet boundary, or there's a partial cut-off > packet. How exactly would you suggest the probe score? > > Personally, I'd probably do the following: if

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > > +return AVPROBE_SCORE_EXTENSION; > > > > I understand if you consider it not worth the effort, > > but ideally this would scan ahead several packets, > > and if it all matches up return a higher score. > > The MP3 probe function is possibly a good reference

Re: [FFmpeg-devel] *** GMX Spamverdacht *** [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-08-31 Thread Reimar Döffinger
On Wed, Aug 13, 2014 at 07:04:01PM +0400, Dmitry Volyntsev wrote: > From: Dmitry Volyntsev > > s->buffers_queued constantly decremented and not incremented > in case of (s->frame_size > 0 && buf.bytesused != s->frame_size) > condition (caught on long run capture of Logitech C310) > --- > libavde

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
On Sun, 31 Aug 2014 15:06:08 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > > +return AVPROBE_SCORE_EXTENSION; > > > > > > I understand if you consider it not worth the effort, > > > but ideally this would scan ahead several packets, > > > and if it all matches u

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 03:06:08PM +, Carl Eugen Hoyos wrote: > > Other formats are also relatively lazy > > Please point me to such a format, I would like to > fix it. > EXTENSION is ok for 32 bit, MAX is ok for 64bit. Sorry, I missed that EXTENSION is actually MAX/2 nowadays! That's quite

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > Some additional optimizations in following patch. what effect on speed do these patches have ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number t

[FFmpeg-devel] [PATCH] avutil/pixelutils: add small buffers tests

2014-08-31 Thread Clément Bœsch
--- libavutil/pixelutils.c| 98 +-- tests/ref/fate/pixelutils | 12 ++ 2 files changed, 89 insertions(+), 21 deletions(-) diff --git a/libavutil/pixelutils.c b/libavutil/pixelutils.c index 10ff7e8..07672c3 100644 --- a/libavutil/pixelutils.c +++

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > Some additional optimizations in following patch. > > what effect on speed do these patches have ? No idea at this point. If someone else feels like benchma

Re: [FFmpeg-devel] [PATCH] intmath.h: Remove duplicated ARM include.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 12:29:04PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavutil/intmath.h | 4 > 1 file changed, 4 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who

Re: [FFmpeg-devel] [PATCH] aacps_tablegen: replace TABLE_CONST by const.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 12:42:15PM +0200, Reimar Döffinger wrote: > Doesn't change generated code, just is more consistent > and a bit less error-prone. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/aacps_tablegen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should be ok

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > Some additional optimizations in following patch. > > what effect on speed do these patches have ? With high error bars, with vsynth1 file, median of 3 runs

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:28:24PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > > Some additional optimizations in following patch. > > > > what effect on speed do the

Re: [FFmpeg-devel] [PATCH] intmath.h: Remove duplicated ARM include.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:18:14PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 12:29:04PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavutil/intmath.h | 4 > > 1 file changed, 4 deletions(-) > > LGTM Pushed.

Re: [FFmpeg-devel] [PATCH] aacps_tablegen: replace TABLE_CONST by const.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 06:19:37PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 12:42:15PM +0200, Reimar Döffinger wrote: > > Doesn't change generated code, just is more consistent > > and a bit less error-prone. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/aacps

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 06:31:30PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 06:28:24PM +0200, Reimar Döffinger wrote: > > On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > > > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > > > Some additio

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/ituh263dec.c | 39 ++- > 1 file changed, 18 insertions(+), 21 deletions(-) > > diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c

Re: [FFmpeg-devel] [PATCH] avutil/pixelutils: add small buffers tests

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 06:04:21PM +0200, Clément Bœsch wrote: > --- > libavutil/pixelutils.c| 98 > +-- > tests/ref/fate/pixelutils | 12 ++ > 2 files changed, 89 insertions(+), 21 deletions(-) tested on mips & arm qemu & x86, all passed [..

Re: [FFmpeg-devel] [PATCH 2/4] h261dec: Optimize new RL_VLC decoding.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 04:48:42PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/h261dec.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) LGTM (same comment as for h263 would apply but i dont think h261 is important enough to spend any tim

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Carl Eugen Hoyos
compn mi.rr.com> writes: > will try to dig some more. sup samples are attached to ticket #2208, the original file is in http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2208/ Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

Re: [FFmpeg-devel] [PATCH] add silenceremove filter

2014-08-31 Thread Clément Bœsch
On Fri, Aug 29, 2014 at 06:22:36PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 62 ++ > libavfilter/Makefile | 1 + > libavfilter/af_silenceremove.c | 478 > + > libavfilter/allfilters.

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: > > @@ -549,11 +549,8 @@ retry: > > av_log(s->avctx, AV_LOG_ERROR, "run overflow at %dx%d i:%d\n", > > s->mb_x, s->mb_y, s->mb_intra); > >

Re: [FFmpeg-devel] [PATCH] avutil/pixelutils: add small buffers tests

2014-08-31 Thread Clément Bœsch
On Sun, Aug 31, 2014 at 07:45:24PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 06:04:21PM +0200, Clément Bœsch wrote: > > --- > > libavutil/pixelutils.c| 98 > > +-- > > tests/ref/fate/pixelutils | 12 ++ > > 2 files changed, 89

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 08:06:54PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: > > > @@ -549,11 +549,8 @@ retry: > > > av_log(s->avctx, AV_LOG_ERROR, "run ove

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 08:14:04PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 08:06:54PM +0200, Reimar Döffinger wrote: > > On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: > > > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: > > > > @@ -549,1

[FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/mpeg12.c| 23 --- libavcodec/mpegvideo.c | 14 ++ libavcodec/rl.h| 8 ++-- 3 files changed, 24 insertions(+), 21 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index cb00baf..769b

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger This was intended to come out under "rl.h: remove deprecated and now unused vlc member.", as that one needs to be applied first. I can merge them though if desired. I by accident typed -1 when I h

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

2014-08-31 Thread Reimar Döffinger
3646 -> 3597 decicycles in inner loop when decoding vsynth1-flv. Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 7 --- libavcodec/ituh263dec.c | 9 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index f286d2

Re: [FFmpeg-devel] [PATCH] add silenceremove filter

2014-08-31 Thread Timothy Gu
On Aug 29, 2014 11:23 AM, "Paul B Mahol" wrote: > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 62 ++ > libavfilter/Makefile | 1 + > libavfilter/af_silenceremove.c | 478 + > libavfilter/allfilters.c | 1

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

2014-08-31 Thread Timothy Gu
On Aug 31, 2014 11:36 AM, "Reimar Döffinger" wrote: > > 3646 -> 3597 decicycles in inner loop when decoding > vsynth1-flv. Wow. [...] Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 12:23:48PM -0700, Timothy Gu wrote: > On Aug 31, 2014 11:36 AM, "Reimar Döffinger" > wrote: > > > > 3646 -> 3597 decicycles in inner loop when decoding > > vsynth1-flv. > > Wow. Note sure what way you meant it, but unfortunately it's not much really. On the other hand it'

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > Some additional optimizations in following patch. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/flv.h| 1 - > libavcodec/flvdec.c | 12 -- > libavcodec/h261dec.c| 27 ++- > l

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 2 ++ libavcodec/ituh263dec.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index c9470b1..9b95775 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 09:40:05PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/h261dec.c| 2 ++ > libavcodec/ituh263dec.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) LGTM though in theory its probably also ok not to write back on error

[FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

2014-08-31 Thread Reimar Döffinger
ff_mpa_table_4_3_value alone saves over 128kB. Signed-off-by: Reimar Döffinger --- libavcodec/Makefile| 24 +++--- libavcodec/mpegaudio_tablegen.c| 13 +-- libavcodec/mpegaudio_tablegen.h| 26 +++--- libavcodec/mpegaudiodec_common.c | 135

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 09:56:03PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 09:40:05PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/h261dec.c| 2 ++ > > libavcodec/ituh263dec.c | 4 ++-- > > 2 files changed, 4 insertions(+), 2 de

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 09:32:45PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > -code = get_vlc2(&s->gb, rl->vlc.table, TCOEFF_VLC_BITS, 2); > > -if (code < 0) { > > +UPDATE_CACHE(re, &s->gb); > > +GET_RL_V

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Move condition.

2014-08-31 Thread Reimar Döffinger
Stops compiler from doing incredibly stupid things. With vsynth1-flv inner loop goes from 3501 to 3275 decicycles. Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 12 ++-- libavcodec/ituh263dec.c | 10 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 10:51:40PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:32:45PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > > -code = get_vlc2(&s->gb, rl->vlc.table, TCOEFF_VLC_BITS, 2); > > > -if

[FFmpeg-devel] [PATCH] ac3dec: avoid duplicating symbols between fixed and float decoder.

2014-08-31 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/ac3.h | 4 +- libavcodec/ac3dec.c | 188 +++ libavcodec/ac3dec_data.c | 138 ++ libavcodec/ac3dec_data.h | 15 4 files changed, 182 insertions(+), 163 de

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

2014-08-31 Thread Reimar Döffinger
On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > Some additional optimizations in following patch. All pushed except for the last one (4/4). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

[FFmpeg-devel] [PATCH v4] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
--- Integrating Reimar's suggestions. No changes outside of the probe function. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 107 +++ 3 files changed, 109 insertions(+) create mode 100644 libavformat

Re: [FFmpeg-devel] [PATCH v4] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Reimar Döffinger
On Mon, Sep 01, 2014 at 12:05:23AM +0200, wm4 wrote: > +for (nb_packets = 0; nb_packets < 10; nb_packets++) { > +size_t full_packet_size; > +if (buf_size < 10 + 3) > +break; > +if (memcmp(buf, "PG", 2)) > +return 0; AV_RB16(buf) != SUP_PGS_MAGIC

Re: [FFmpeg-devel] [PATCHv2] doc/demuxers: document gif demuxer

2014-08-31 Thread Lou Logan
From ecad89e3edb64da662ae06a9d37c1fa84b02fadb Mon Sep 17 00:00:00 2001 From: Lou Logan Date: Thu, 28 Aug 2014 16:26:11 -0800 Subject: [PATCH] doc/demuxers: document gif demuxer Signed-off-by: Lou Logan --- New patch addressing comments from Timothy and Clément. doc/demuxers.texi | 40 +

[FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
--- Use AV_RB16 instead of memcpy. Don't use AVPROBE_SCORE_EXTENSION. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 107 +++ 3 files changed, 109 insertions(+) create mode 100644 libavformat/supdec.c

Re: [FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 10:47:09PM +0200, Reimar Döffinger wrote: > ff_mpa_table_4_3_value alone saves over 128kB. i wonder if that table shouldnt be something different in the float implementation. Also i think anyone caring about file size would likely not build the float and fixed point mp3 dec

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Move condition.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 11:02:34PM +0200, Reimar Döffinger wrote: > Stops compiler from doing incredibly stupid things. > With vsynth1-flv inner loop goes from 3501 to 3275 > decicycles. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/h261dec.c| 12 ++-- > libavcodec/ituh263de

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

2014-08-31 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/mpeg12.c| 23 --- > libavcodec/mpegvideo.c | 14 ++ > libavcodec/rl.h| 8 ++-- > 3 files changed, 24 insertions(+), 21 deletions(

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Enable compute_edt only when the subtitles are used for a output stream instead of a filter

2014-08-31 Thread Michael Niedermayer
Fixes/works around Ticket3768 Signed-off-by: Michael Niedermayer --- ffmpeg.c|5 +++-- ffmpeg.h|5 - ffmpeg_filter.c |2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 8bca9e7..d5b53e7 100644 --- a/ffmpeg.c +++ b/ffmpeg

[FFmpeg-devel] [PATCH 1/2] avcodec/dvbsubdec: make compute_edt user settable

2014-08-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffmpeg.c |2 +- libavcodec/dvbsubdec.c |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index ff7961f..8bca9e7 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2298,7 +2298,7 @@ static int init_input_st

Re: [FFmpeg-devel] [PATCH] Use makeinfo to generate html doc for the new website

2014-08-31 Thread Timothy Gu
On Sat, Aug 23, 2014 at 4:16 PM, Michael Niedermayer wrote: > On Sun, Jul 20, 2014 at 02:23:07PM -0700, Timothy Gu wrote: >> texi2html is deprecated by upstream in favor of makeinfo/texi2any. See: >> >> - >> https://www.gnu.org/software/texinfo/manual/texinfo/html_node/texi2html.html >> - https:/

[FFmpeg-devel] [PATCH] Use makeinfo to generate html doc for the new website

2014-08-31 Thread Timothy Gu
This is a new iteration of the patch that has been stalled for more than a month. Finally got time to work on it. Change since last patch: - Fix compilation on machines with makeinfo < 5 that don't support HTML output. ---8<--- texi2html is deprecated by upstream in favor of makeinfo/texi2any.

[FFmpeg-devel] [PATCH] general: Fix usage of @float

2014-08-31 Thread Timothy Gu
makeinfo chokes on that. Signed-off-by: Timothy Gu --- doc/general.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/general.texi b/doc/general.texi index 9ce0b31..8d7555d 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -130,7 +130,7 @@ Go to @url{http://x265.o

[FFmpeg-devel] [PATCH] x86/hevc_res_add: add ff_hevc_transform_add32_8_avx2

2014-08-31 Thread James Almer
~20% faster than AVX. Signed-off-by: James Almer --- libavcodec/x86/hevc_res_add.asm | 31 +++ libavcodec/x86/hevcdsp.h| 2 ++ libavcodec/x86/hevcdsp_init.c | 2 ++ 3 files changed, 31 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/hevc_res_add

[FFmpeg-devel] [PATCH 2/2] [WEB] Add generate-doc.sh to generate makeinfo-based ffmpeg docs

2014-08-31 Thread Timothy Gu
Signed-off-by: Timothy Gu --- Changes: - src/template_doctitle is not deleted in this commit per Michael's request. Michael, now this patch should be able to be applied before the server patch I will send to you in a moment. README | 12 +--- generate-doc.sh | 41 +++

[FFmpeg-devel] [PATCH 1/2] [WEB] style: add "warning" style similar to .info but has a red border

2014-08-31 Thread Timothy Gu
Signed-off-by: Timothy Gu --- No changes. src/less/style.less | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/less/style.less b/src/less/style.less index 6a26684..0c9ea03 100644 --- a/src/less/style.less +++ b/src/less/style.less @@ -15,6 +15,7 @@ @Csecond

Re: [FFmpeg-devel] [PATCH] delete the old segment file from hls list

2014-08-31 Thread Steven Liu
CC Anshul The Follow is the result of the parameter with -hls_wrap 7,It in the older mail of this mail list. When use the option -hls_wrap 7 ./ffmpeg -i shaolinzuqiu.rm -vcodec libx264 -preset ultrafast -an -f hls -hls_wrap 7 a.m3u8 it dose not remove the nouse file: [root@localhost ffmpeg]# ls