Re: [FFmpeg-devel] [PATCH] avutil/lzo: fix resource leak

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 11:50:20AM +0800, Ruoyu wrote: Signed-off-by: Ruoyu lian...@ucweb.com --- libavutil/lzo.c | 1 + 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 07:25:52AM +0300, Mika Raento wrote: If present, an MFRA box and its TFRAs are read for fragment start times. Without this change, timestamps for discontinuous fragmented mp4 are wrong, and cause audio/video desync and are not usable for generating HLS. ---

[FFmpeg-devel] [PATCH] fate: make subtitles tests output to stdout instead of md5

2014-10-11 Thread Clément Bœsch
This makes tracking subtitles changes simpler. --- tests/fate-run.sh | 6 ++ tests/fate/subtitles.mak | 38 tests/ref/fate/sub-aqtitle| 45 +- tests/ref/fate/sub-charenc| 62 - tests/ref/fate/sub-jacosub| 23 -

[FFmpeg-devel] [PATCH] proresenc_ks: use chroma sampling in autoselection

2014-10-11 Thread Christophe Gisquet
Hi, according to: https://documentation.apple.com/en/finalcutpro/professionalformatsandworkflows/index.html#chapter=10%26section=2%26tasks=true the ProRes is the only profile to handle 4:4:4(:4) sources. The patch therefore checks the chroma sampling when trying to determine automatically

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Mika Raento
Interesting. The input.mov created with ./ffmpeg -i matrixbench_mpeg2.mpg -t 1 -frag_duration 200k input.mov does not have tfra entries for all the moofs for the audio track. The single tfra it has is not for the first moof, but the last one. I'll improve the matching of the moofs and tfra

Re: [FFmpeg-devel] [PATCH] fate: make subtitles tests output to stdout instead of md5

2014-10-11 Thread wm4
On Sat, 11 Oct 2014 13:56:16 +0200 Clément Bœsch u...@pkh.me wrote: This makes tracking subtitles changes simpler. --- ... Seems like a good idea. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: make subtitles tests output to stdout instead of md5

2014-10-11 Thread Clément Bœsch
On Sat, Oct 11, 2014 at 02:53:24PM +0200, wm4 wrote: On Sat, 11 Oct 2014 13:56:16 +0200 Clément Bœsch u...@pkh.me wrote: This makes tracking subtitles changes simpler. --- ... Seems like a good idea. I'm unfortunately kind of uncomfortable with this: [~]☭ printf x\r\n /tmp/a [~]☭

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Mika Raento
Hm. After fixing the obvious problems with matching moofs with tfra entries I noticed that the timestamps aren't right even after that. AFAICT, ffmpeg's fragmentation code puts dts in the tfra time. In movenc.c: mov-tracks[i].frag_start += mov-tracks[i].start_dts +

[FFmpeg-devel] [PATCH] mov.c: read fragment start pts from fragmented mp4

2014-10-11 Thread Mika Raento
If present, an MFRA box and its TFRAs are read for fragment start times. Without this change, timestamps for discontinuous fragmented mp4 are wrong, and cause audio/video desync and are not usable for generating HLS. --- libavformat/isom.h | 16 ++ libavformat/mov.c | 158

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Carl Eugen Hoyos
Mika Raento mikie at iki.fi writes: +if (ret 0) +av_log(c-fc, AV_LOG_ERROR, + failed to seek back after looking for mfra\n); +else +ret = 0; If you resubmit please consider making this: if (ret 0) { avl_log(); } else { ret = 0; } This makes

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Mika Raento
On 11 October 2014 16:41, Carl Eugen Hoyos ceho...@ag.or.at wrote: Mika Raento mikie at iki.fi writes: +if (ret 0) +av_log(c-fc, AV_LOG_ERROR, + failed to seek back after looking for mfra\n); +else +ret = 0; If you resubmit please consider making

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Carl Eugen Hoyos
Mika Raento mikie at iki.fi writes: Somehow I'd gotten the impression that the opposite was preferred, and indeed mov.c tends not to have those braces. Has the convention changed? I don't think so, tools/patcheck should tell you more. Carl Eugen

[FFmpeg-devel] [PATCH] lavf/mov.c: Allocate buffer in case of long metadata entries.

2014-10-11 Thread Thilo Borgmann
Hi, trying to fix ticket #4018. Metadata in mov is silently truncated to 1023 bytes. This patch allocated a buffer in case of entries found that exceed 1023 bytes. Fixes ticket #4018 for me. Maybe check str_size against an upper limit? -Thilo From 365bec36b3b7f1925cfa2310d979a63ef8e3a7e8 Mon

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Allocate buffer in case of long metadata entries.

2014-10-11 Thread Nicolas George
Le decadi 20 vendémiaire, an CCXXIII, Thilo Borgmann a écrit : Hi, trying to fix ticket #4018. Metadata in mov is silently truncated to 1023 bytes. This patch allocated a buffer in case of entries found that exceed 1023 bytes. Fixes ticket #4018 for me. Maybe check str_size against an

[FFmpeg-devel] [PATCH] mov.c: allow reading fragment start dts/pts from fragmented mp4

2014-10-11 Thread Mika Raento
This introduces a new option to the mov demuxer: -use_mfra_for (pts|dts). When it's given and moofs and a MFRA are present, the MFRA's TFRAs are read for fragment start times. Unfortunately some programs that produce fragmented mp4s use the TFRA time field for dts and some for pts. There is no

Re: [FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

2014-10-11 Thread Mika Raento
Resubmission follows Carl's advice on braces. On 11 October 2014 16:49, Carl Eugen Hoyos ceho...@ag.or.at wrote: Mika Raento mikie at iki.fi writes: Somehow I'd gotten the impression that the opposite was preferred, and indeed mov.c tends not to have those braces. Has the convention changed?

Re: [FFmpeg-devel] [PATCH] proresenc_ks: use chroma sampling in autoselection

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 02:24:19PM +0200, Christophe Gisquet wrote: Hi, according to: https://documentation.apple.com/en/finalcutpro/professionalformatsandworkflows/index.html#chapter=10%26section=2%26tasks=true the ProRes is the only profile to handle 4:4:4(:4) sources. The patch

Re: [FFmpeg-devel] [PATCH] mov.c: allow reading fragment start dts/pts from fragmented mp4

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 06:43:48PM +0300, Mika Raento wrote: This introduces a new option to the mov demuxer: -use_mfra_for (pts|dts). When it's given and moofs and a MFRA are present, the MFRA's TFRAs are read for fragment start times. Unfortunately some programs that produce fragmented

Re: [FFmpeg-devel] [PATCH] mov.c: allow reading fragment start dts/pts from fragmented mp4

2014-10-11 Thread Mika Raento
On 11 October 2014 20:20, Michael Niedermayer michae...@gmx.at wrote: On Sat, Oct 11, 2014 at 06:43:48PM +0300, Mika Raento wrote: This introduces a new option to the mov demuxer: -use_mfra_for (pts|dts). When it's given and moofs and a MFRA are present, the MFRA's TFRAs are read for fragment

[FFmpeg-devel] [PATCH 1/7] fate: add rawdiff and use it for subtitles

2014-10-11 Thread Clément Bœsch
We want subtitles tests to match exactly line endings and trailing characters. --- tests/fate-run.sh| 1 + tests/fate/subtitles.mak | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 224da8b..2f18fa3 100755 --- a/tests/fate-run.sh +++

[FFmpeg-devel] [PATCH 3/7] avformat/assenc: support remuxing old V4 ASS form (SSA)

2014-10-11 Thread Clément Bœsch
--- libavformat/assenc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index d495ce3..8225967 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -35,6 +35,7 @@ typedef struct ASSContext{ DialogueLine

[FFmpeg-devel] [PATCH 2/7] fate: fix some subtitles tests dependencies

2014-10-11 Thread Clément Bœsch
--- tests/fate/subtitles.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak index 2c6edc6..9243178 100644 --- a/tests/fate/subtitles.mak +++ b/tests/fate/subtitles.mak @@ -37,7 +37,7 @@ fate-sub-sami: CMD = fmtstdout ass

[FFmpeg-devel] [PATCH 5/7] avcodec/ass_split: extend recognized fields in ASS splitter

2014-10-11 Thread Clément Bœsch
This simplifies the logic for the fix in the next commit. --- libavcodec/ass_split.c | 31 ++- libavcodec/ass_split.h | 20 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index

[FFmpeg-devel] [PATCH 6/7] avcodec/ass_split: assume default order when Format: line is not found

2014-10-11 Thread Clément Bœsch
Fixes the decoding of the ASS stream in a mkv from a fansub release from Coalgirls. --- libavcodec/ass_split.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index fea38e7..bd7db93 100644 ---

[FFmpeg-devel] [PATCH 4/7] avcodec/ass: output missing fields in AVSubtitles and output files

2014-10-11 Thread Clément Bœsch
Fixes Ticket #3207 --- libavcodec/ass.c| 29 +-- libavcodec/version.h| 2 +- tests/ref/fate/sub-aqtitle | 72 +-- tests/ref/fate/sub-charenc | 106 tests/ref/fate/sub-jacosub |

[FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

2014-10-11 Thread Clément Bœsch
--- libavcodec/ass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index ac1bfae..62981b6 100644 --- a/libavcodec/ass.c +++ b/libavcodec/ass.c @@ -34,6 +34,7 @@ int ff_ass_subtitle_header(AVCodecContext *avctx, { avctx-subtitle_header =

Re: [FFmpeg-devel] [PATCH 1/7] fate: add rawdiff and use it for subtitles

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 07:59:06PM +0200, Clément Bœsch wrote: We want subtitles tests to match exactly line endings and trailing characters. --- tests/fate-run.sh| 1 + tests/fate/subtitles.mak | 1 + 2 files changed, 2 insertions(+) LGTM [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] fate: make subtitles tests output to stdout instead of md5

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 01:56:16PM +0200, Clément Bœsch wrote: This makes tracking subtitles changes simpler. --- tests/fate-run.sh | 6 ++ tests/fate/subtitles.mak | 38 tests/ref/fate/sub-aqtitle| 45 +- tests/ref/fate/sub-charenc

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: add -seek_error option

2014-10-11 Thread Michael Niedermayer
On Fri, Oct 10, 2014 at 11:19:21PM +0200, Simon Thelen wrote: On 10/10/14 at 00:45, Michael Niedermayer wrote: On Thu, Oct 09, 2014 at 11:22:07PM +0200, Simon Thelen wrote: On 09/10/14 at 23:05, Michael Niedermayer wrote: On Wed, Oct 08, 2014 at 07:13:33PM +0200, Simon Thelen wrote:

[FFmpeg-devel] [PATCH] vf_drawtext: add missing clear of pointers after av_expr_free()

2014-10-11 Thread Karl Kiniger
Fixes segfault when using sendcmd with drawtext. Since LIBAVFILTER_VERSION_MAJOR 5 FF_API_DRAWTEXT_OLD_TIMELINE evaluates to 0. Signed-off-by: Karl Kiniger karl.kini...@med.ge.com --- libavfilter/vf_drawtext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_drawtext.c

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/ass_split: assume default order when Format: line is not found

2014-10-11 Thread wm4
On Sat, 11 Oct 2014 19:59:11 +0200 Clément Bœsch u...@pkh.me wrote: Fixes the decoding of the ASS stream in a mkv from a fansub release from Coalgirls. --- libavcodec/ass_split.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] gnome-opw 2015

2014-10-11 Thread Nikita Mantri
Hi, I am a 4th year B.Tech. student. As a part of gnome-opw 2015 programme, I would like to contribute to one of the development projects that is listed on the website. I have decided to contribute to the symmetric-key block ciphers project as i have an intermediate knowledge of cryptography. I

Re: [FFmpeg-devel] [PATCH] vf_drawtext: add missing clear of pointers after av_expr_free()

2014-10-11 Thread Michael Niedermayer
On Sat, Oct 11, 2014 at 10:34:11PM +0200, Karl Kiniger wrote: Fixes segfault when using sendcmd with drawtext. Since LIBAVFILTER_VERSION_MAJOR 5 FF_API_DRAWTEXT_OLD_TIMELINE evaluates to 0. Signed-off-by: Karl Kiniger karl.kini...@med.ge.com --- libavfilter/vf_drawtext.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/ass_split: assume default order when Format: line is not found

2014-10-11 Thread Clément Bœsch
On Sat, Oct 11, 2014 at 10:53:28PM +0200, wm4 wrote: On Sat, 11 Oct 2014 19:59:11 +0200 Clément Bœsch u...@pkh.me wrote: Fixes the decoding of the ASS stream in a mkv from a fansub release from Coalgirls. --- libavcodec/ass_split.c | 26 +- 1 file changed, 25

Re: [FFmpeg-devel] gnome-opw 2015

2014-10-11 Thread Michael Niedermayer
Hi On Sun, Oct 12, 2014 at 02:51:36AM +0530, Nikita Mantri wrote: Hi, I am a 4th year B.Tech. student. As a part of gnome-opw 2015 programme, I would like to contribute to one of the development projects that is listed on the website. I have decided to contribute to the symmetric-key block

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

2014-10-11 Thread James Almer
On 11/10/14 2:59 PM, Clément Bœsch wrote: --- libavcodec/ass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index ac1bfae..62981b6 100644 --- a/libavcodec/ass.c +++ b/libavcodec/ass.c @@ -34,6 +34,7 @@ int ff_ass_subtitle_header(AVCodecContext

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

2014-10-11 Thread Timothy Gu
On Saturday, October 11, 2014, James Almer jamr...@gmail.com wrote: On 11/10/14 2:59 PM, Clément Bœsch wrote: --- libavcodec/ass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index ac1bfae..62981b6 100644 --- a/libavcodec/ass.c +++

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

2014-10-11 Thread James Almer
On 11/10/14 10:58 PM, Timothy Gu wrote: On Saturday, October 11, 2014, James Almer jamr...@gmail.com wrote: On 11/10/14 2:59 PM, Clément Bœsch wrote: --- libavcodec/ass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index ac1bfae..62981b6

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

2014-10-11 Thread Timothy Gu
On Sat, Oct 11, 2014 at 7:05 PM, James Almer jamr...@gmail.com wrote: On 11/10/14 10:58 PM, Timothy Gu wrote: I think you misread it: the colon is after the AV_STRINGIFY(LIBAVCODEC_VERSION). (avctx-flags CODEC_FLAG_BITEXACT) ? ; Script generated by FFmpeg/Lavc