Re: [FFmpeg-devel] [PATCH]Read aspect ratio from mxf

2014-11-18 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: I suggest you add a documented as private/internal display_aspect_ratio to AVStream instead of metadata also av_reduce can be replaced by av_mul_q which is probably simpler New patch attached. The patch was merged. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH] web/style.less: Separate out .table-bordered from .table

2014-11-18 Thread Michael Niedermayer
On Sat, Nov 15, 2014 at 09:23:39PM -0800, Timothy Gu wrote: The only instance of .table in the web source is the download page for the Git repos. I did not change that page because an unbordered table there is prettier IMO. I retained the .table-bordered style in case anyone want to use it

Re: [FFmpeg-devel] [PATCH] lavf/ffmenc: fix memleak in ffm_write_header

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 03:16:19AM -0300, James Almer wrote: Regression since 745730c9c208c40f800d5d71ffa39aceab6ce044. The dynamic buffer was not being used or freed. Signed-off-by: James Almer jamr...@gmail.com LGTM thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] lavf/concatdec: add timestamp log

2014-11-18 Thread Stefano Sabatini
Help debugging timestamp conversion issues. --- libavformat/concatdec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 2089883..f275bac 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -23,6 +23,7 @@

[FFmpeg-devel] [PATCH] lavf/concatdec: fix timestamp conversion

2014-11-18 Thread Stefano Sabatini
Use the correct output time base when converting. --- libavformat/concatdec.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index f275bac..2574e0b 100644 --- a/libavformat/concatdec.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nellymoser: Use avpriv_float_dsp_alloc()

2014-11-18 Thread Michael Niedermayer
On Fri, Nov 14, 2014 at 08:45:43PM +0100, Reimar Döffinger wrote: On Fri, Nov 14, 2014 at 08:38:39PM +0100, Michael Niedermayer wrote: On Fri, Nov 14, 2014 at 07:59:17PM +0100, Reimar Döffinger wrote: On Fri, Nov 14, 2014 at 02:39:46PM +0100, Michael Niedermayer wrote: Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] avutil/float_dsp: add avpriv_float_dsp_alloc()

2014-11-18 Thread Michael Niedermayer
On Fri, Nov 14, 2014 at 02:39:45PM +0100, Michael Niedermayer wrote: TODO: update APIChanges version Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavutil/float_dsp.c | 11 ++- libavutil/float_dsp.h |7 +++ 2 files changed, 17 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: TODO: bump minor, update doc/APIchanges also please make sure the version you add to doc/APIchanges matches what you set in version.h [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and

[FFmpeg-devel] [PATCH] doc/filters: use '|' instead of ':' in the documentation.

2014-11-18 Thread Simon Thelen
Using colons to separate the outdefs is deprecated. Switch to using '|' to separate the list items. Signed-off-by: Simon Thelen ffmpeg-...@c-14.de --- doc/filters.texi | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [FFmpeg-devel] [PATCH] doc/filters: use '|' instead of ':' in the documentation.

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 01:29:27PM +0100, Simon Thelen wrote: Using colons to separate the outdefs is deprecated. Switch to using '|' to separate the list items. Signed-off-by: Simon Thelen ffmpeg-...@c-14.de --- doc/filters.texi | 16 1 file changed, 8 insertions(+), 8

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-18 Thread Stefano Sabatini
On date Wednesday 2014-11-12 22:32:04 +0100, Lukasz Marek encoded: On 12.11.2014 17:45, Stefano Sabatini wrote: On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: On 11.11.2014 17:19, Stefano Sabatini wrote: We have already av_get_opt() which serializes the value. Also we should

Re: [FFmpeg-devel] [PATCH] lavf/ffmenc: fix memleak in ffm_write_header

2014-11-18 Thread James Almer
On 18/11/14 7:26 AM, Michael Niedermayer wrote: On Tue, Nov 18, 2014 at 03:16:19AM -0300, James Almer wrote: Regression since 745730c9c208c40f800d5d71ffa39aceab6ce044. The dynamic buffer was not being used or freed. Signed-off-by: James Almer jamr...@gmail.com LGTM thanks Pushed.

Re: [FFmpeg-devel] [PATCH] web/style.less: Separate out .table-bordered from .table

2014-11-18 Thread Timothy Gu
On Tue, Nov 18, 2014 at 2:20 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov 15, 2014 at 09:23:39PM -0800, Timothy Gu wrote: The only instance of .table in the web source is the download page for the Git repos. I did not change that page because an unbordered table there is

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 18 November 2014 03:31, Michael Niedermayer michae...@gmx.at wrote: It should be also possible to serialize an empty dictionary the serialization string should also contain a serialization format identifer/version otherwise future maintaince could become hard this identifer should

[FFmpeg-devel] [PATCH] dashenc: degrade gracefully if a stream's bitrate is unavailable

2014-11-18 Thread Rodger Combs
From e6793b554bb3979cfb5c1feec2ba73bbf8a31d8a Mon Sep 17 00:00:00 2001 From: Rodger Combs rodger.co...@gmail.com Date: Tue, 18 Nov 2014 12:59:59 -0600 Subject: [PATCH] dashenc: degrade gracefully if a stream's bitrate is unavailable If a stream's bitrate is not set, this attempts to use its

Re: [FFmpeg-devel] [PATCH] web/style.less: Separate out .table-bordered from .table

2014-11-18 Thread Timothy Gu
On Tue, Nov 18, 2014 at 10:51 AM, Timothy Gu timothyg...@gmail.com wrote: On Tue, Nov 18, 2014 at 2:20 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov 15, 2014 at 09:23:39PM -0800, Timothy Gu wrote: The only instance of .table in the web source is the download page for the Git

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: add timestamp log

2014-11-18 Thread Nicolas George
L'octidi 28 brumaire, an CCXXIII, Stefano Sabatini a écrit : Help debugging timestamp conversion issues. --- libavformat/concatdec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 2089883..f275bac 100644 ---

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: fix timestamp conversion

2014-11-18 Thread Nicolas George
L'octidi 28 brumaire, an CCXXIII, Stefano Sabatini a écrit : Use the correct output time base when converting. --- libavformat/concatdec.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 08:00:51PM +0100, Lukasz Marek wrote: On 18 November 2014 03:31, Michael Niedermayer michae...@gmx.at wrote: It should be also possible to serialize an empty dictionary the serialization string should also contain a serialization format identifer/version

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/16/2014 10:46 PM, Lukasz Marek wrote: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com [..] @@ -965,43 +881,38 @@ static int ffserver_parse_config_stream(FFServerConfig *config, const char *cmd, ret = av_parse_video_size(w, h, arg); if (ret 0)

Re: [FFmpeg-devel] [PATCH 04/11] ffserver_config: remove ffserver_apply_stream_config function

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz On 11/16/2014 10:46 PM, Lukasz Marek wrote: [..] @@ -174,13 +174,20 @@ void ffserver_parse_acl_row(FFServerStream *stream, FFServerStream* feed, } /* add a codec and set the default parameters */ -static void add_codec(FFServerStream *stream, AVCodecContext *av) +static

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/16/2014 10:46 PM, Lukasz Marek wrote: [..] diff --git a/doc/ffserver.texi b/doc/ffserver.texi index b7c5b6a..d3ff13e 100644 --- a/doc/ffserver.texi +++ b/doc/ffserver.texi @@ -408,6 +408,11 @@ ignored, and the log is written to standard output. Set no-daemon mode. This option is

Re: [FFmpeg-devel] [PATCH] dashenc: degrade gracefully if a stream's bitrate is unavailable

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 01:02:58PM -0600, Rodger Combs wrote: From e6793b554bb3979cfb5c1feec2ba73bbf8a31d8a Mon Sep 17 00:00:00 2001 From: Rodger Combs rodger.co...@gmail.com Date: Tue, 18 Nov 2014 12:59:59 -0600 Subject: [PATCH] dashenc: degrade gracefully if a stream's bitrate is

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi. Overall this looks good, thanks. I would move the test to tests/ though and integrate it with the build/test system as, say, the way tiny_ssim is: grep -R tiny_ssim * Makefile:TESTTOOLS = audiogen videogen rotozoom tiny_psnr tiny_ssim base64 tests/Makefile:FATE_UTILS = base64 tiny_psnr

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
On 11/16/2014 11:00 PM, Lukasz Marek wrote: [..] Second thing, I don't know how to integrate this test into build system. I put it into tool, but it requires ffserver_config.o and cmdutils.o For now it have to be build with make make tools/ffserver_config_test as these two *.o are not

Re: [FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/16/2014 10:46 PM, Lukasz Marek wrote: [..] @@ -3355,6 +3354,9 @@ static int add_av_stream(FFServerStream *feed, AVStream *st) fst = add_av_stream1(feed, av, 0); if (!fst) return -1; +if (av_stream_get_recommended_encoder_configuration(st)) +

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-18 Thread Nicolas George
L'octidi 28 brumaire, an CCXXIII, Reynaldo H. Verdejo Pinochet a écrit : I think I commented about this before but having yesvar novar options seems redundant. Having var = yes or no if absent (or the other way around depending on the intended default) seems less cumbersome and should

Re: [FFmpeg-devel] Patch mpegts_start_pid to allow ATSC PID ranges

2014-11-18 Thread Zach Swena
Sorry, I am new to using Git. I have a .patch file, but I am not sure what the proper way to send it is. I am using GitHub for windows. Anyway, the .patch file is attached. Zach On Tue, Nov 18, 2014 at 10:33 AM, Timothy Gu timothyg...@gmail.com wrote: Hi, On Tue, Nov 18, 2014 at 9:02

Re: [FFmpeg-devel] [PATCH] web/style.less: Separate out .table-bordered from .table

2014-11-18 Thread Clément Bœsch
On Tue, Nov 18, 2014 at 11:08:01AM -0800, Timothy Gu wrote: On Tue, Nov 18, 2014 at 10:51 AM, Timothy Gu timothyg...@gmail.com wrote: On Tue, Nov 18, 2014 at 2:20 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov 15, 2014 at 09:23:39PM -0800, Timothy Gu wrote: The only instance

Re: [FFmpeg-devel] [PATCH] web/style.less: Separate out .table-bordered from .table

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 11:16:52PM +0100, Clément Bœsch wrote: On Tue, Nov 18, 2014 at 11:08:01AM -0800, Timothy Gu wrote: On Tue, Nov 18, 2014 at 10:51 AM, Timothy Gu timothyg...@gmail.com wrote: On Tue, Nov 18, 2014 at 2:20 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/18/2014 06:54 PM, Nicolas George wrote: L'octidi 28 brumaire, an CCXXIII, Reynaldo H. Verdejo Pinochet a écrit : I think I commented about this before but having yesvar novar options seems redundant. Having var = yes or no if absent (or the other way around depending on the

Re: [FFmpeg-devel] [PATCH 1/3] web: Remove all comments in the cleaned CSS

2014-11-18 Thread Michael Niedermayer
On Sun, Nov 16, 2014 at 08:12:55PM +0100, Michael Niedermayer wrote: On Sat, Nov 15, 2014 at 09:26:08PM -0800, Timothy Gu wrote: http://ffmpeg.org/css/style.min.css and the copy in ffmpeg/doc are both generated using this option. Signed-off-by: Timothy Gu timothyg...@gmail.com ---

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-18 Thread Lukasz Marek
On 18.11.2014 22:20, Reynaldo H. Verdejo Pinochet wrote: Hi. Overall this looks good, thanks. I would move the test to tests/ though and integrate it with the build/test system as, say, the way tiny_ssim is: grep -R tiny_ssim * Makefile:TESTTOOLS = audiogen videogen rotozoom tiny_psnr

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format? also a serialization stream thats self containd seems much nicer to handle as theres no need to keep track of the exact version (if we end up having more than 1) the used

Re: [FFmpeg-devel] Patch mpegts_start_pid to allow ATSC PID ranges

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 01:56:21PM -0800, Zach Swena wrote: Sorry, I am new to using Git. I have a .patch file, but I am not sure what the proper way to send it is. I am using GitHub for windows. Anyway, the .patch file is attached. Zach On Tue, Nov 18, 2014 at 10:33 AM, Timothy Gu

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format? also a serialization stream thats self containd seems much nicer to handle as theres no need to keep track of

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-18 Thread Mark Reid
--- libavformat/mxfdec.c | 74 +++- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fa0a2f4..8c13c24 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -668,22 +668,6 @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-18 Thread Mark Reid
hi, This patch exports mxf source package uids and names as metadata. AAF files and some editing applications can link to mxf files and their streams by package uids. They can be used to resolve a media file instead of just a url. Here are the metadata keys I added: material_package_uid

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 19.11.2014 01:13, Michael Niedermayer wrote: On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format? also a serialization stream thats self containd seems much nicer

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: On 19.11.2014 01:13, Michael Niedermayer wrote: On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format?