Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-13 Thread Clément Bœsch
On Sat, Dec 13, 2014 at 01:50:03AM +0100, Carl Eugen Hoyos wrote: > On Saturday 13 December 2014 01:12:02 am Ivan Kalvachev wrote: > > On 12/12/14, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #4183. > > > > > > Please review, Carl Eugen > > > > You should also update

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc_mc: fix sse register counts

2014-12-13 Thread Christophe Gisquet
Hi, 2014-12-10 8:11 GMT+01:00 Michael Niedermayer : > These fix failures of --enable-xmm-clobber-test Some old patches around the ml were I think trying to fix some of the macros, from where the superfluous regs are coming from. I guess being thorough with the ABI is better, though that particul

Re: [FFmpeg-devel] [PATCH]Set the default for --shlibdir to --libdir

2014-12-13 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > > > > Attached patch fixes ticket #4183. > >--libdir=DIR install libs in DIR [PREFIX/lib] > > - --shlibdir=DIR install shared libs in DIR [PREFIX/lib] > > + --shlibdir=DIR install shared libs in DIR [LIBDIR] > What if LIBDIR

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Nicolas George
Le duodi 22 frimaire, an CCXXIII, Rodger Combs a écrit : > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Carl Eugen Hoyos
Rodger Combs gmail.com> writes: > + --disable-libguess disable libguess [autodetect] > + --disable-uchardet disable universalchardet [autodetect] I cannot comment on your actual patch, but both libraries should not be auto-detected imo. Imo, if your distribution contains the libr

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc_mc: fix sse register counts

2014-12-13 Thread Michael Niedermayer
On Sat, Dec 13, 2014 at 11:45:27AM +0100, Christophe Gisquet wrote: > Hi, > > 2014-12-10 8:11 GMT+01:00 Michael Niedermayer : > > These fix failures of --enable-xmm-clobber-test > > Some old patches around the ml were I think trying to fix some of the > macros, from where the superfluous regs are

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-13 Thread Carl Eugen Hoyos
On Friday 12 December 2014 01:43:19 pm Tomas Härdin wrote: > On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #4173 for me. > > To be split in two parts. > > > > Please comment, Carl Eugen > > Looks alright. Maybe you want to pass it a MXFMetada

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc_mc: fix sse register counts

2014-12-13 Thread Christophe Gisquet
Hi, 2014-12-13 13:17 GMT+01:00 Michael Niedermayer : > i remember such patches faintly too, was there one that wasnt > applied ? Not your fault, mine actually, as I lost interest in that code. I think there were compilations issues iirc. That and multiple things (like gpr usage) needed to be fixe

Re: [FFmpeg-devel] [PATCH 3/5] lavu/dict: remove weird intptr_t cast

2014-12-13 Thread Michael Niedermayer
On Fri, Dec 12, 2014 at 06:15:41PM +0100, wm4 wrote: > I can't come up with a reason why this would be needed. > --- > libavutil/dict.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) if people prefer this, i can apply it, it might cause an additional warning with some compilers thoug

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Rodger Combs
> On Dec 13, 2014, at 05:34, Nicolas George wrote: > > So, now that I have a decent connection and time, here are some comments: > > First, your patch seems to happen after the text demuxers have parsed the > text files. Therefore, this can not work for non-ASCII-compatible encodings, > such as

Re: [FFmpeg-devel] [PATCH 3/5] lavu/dict: remove weird intptr_t cast

2014-12-13 Thread Nicolas George
> > I can't come up with a reason why this would be needed. Reading the commit message where this was introduced would be a good start: # commit 8aed90958d8bbf4a0652fdc56b9655ad9962fa50 # Author: Michael Niedermayer # Date: 2011-10-17 22:56:13 +0200 # # dict: fix assignment discards quali

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Fri, 12 Dec 2014 00:05:27 -0600 Rodger Combs wrote: > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Sat, 13 Dec 2014 12:34:28 +0100 Nicolas George wrote: > First, your patch seems to happen after the text demuxers have parsed the > text files. Therefore, this can not work for non-ASCII-compatible encodings, > such as UTF-16. You might say that UTF-16 already works, but its > implementation i

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, wm4 a écrit : > What about it is bogus? Read the documentation. >In fact, the UTF-16 change made > UTF-16 just work with any API user. And inconsistent values in the context. > Recoding in the demuxer is unacceptable, because

Re: [FFmpeg-devel] [PATCH 3/5] lavu/dict: remove weird intptr_t cast

2014-12-13 Thread wm4
On Sat, 13 Dec 2014 13:55:44 +0100 Nicolas George wrote: > > > I can't come up with a reason why this would be needed. > > Reading the commit message where this was introduced would be a good start: > > # commit 8aed90958d8bbf4a0652fdc56b9655ad9962fa50 > # Author: Michael Niedermayer > # Date:

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Sat, 13 Dec 2014 16:17:48 +0100 Nicolas George wrote: > Le tridi 23 frimaire, an CCXXIII, wm4 a écrit : > > What about it is bogus? > > Read the documentation. Broken library design. > > In fact, the UTF-16 change made > > UTF-16 just work with any API user.

[FFmpeg-devel] [PATCH] lavd/alsa-audio-common: mark default device in device list

2014-12-13 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavdevice/alsa-audio-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/alsa-audio-common.c b/libavdevice/alsa-audio-common.c index 749897f..b7f5313 100644 --- a/libavdevice/alsa-audio-common.c +++ b/libavdevice/alsa-audio-common.c @@ -379

[FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-13 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- cmdutils.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index b68dae9..4e0a406 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1213,12 +1213,7 @@ static int is_device(const AVClass *avclass) { if (!avclass)

Re: [FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-13 Thread Michael Niedermayer
On Sat, Dec 13, 2014 at 07:54:57PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > cmdutils.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use goto

[FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table

2014-12-13 Thread Lukasz Marek
This symbol is required for query capabilities callbacks. This symbol is only required by libavdevice and should not be exported. Signed-off-by: Lukasz Marek --- libavdevice/avdevice.c | 2 +- libavdevice/avdevice.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevi

[FFmpeg-devel] [PATCH 2/2] lavd/avdevice: use better option types for caps options

2014-12-13 Thread Lukasz Marek
Using dedicated types allows to use format/layout names, not just raw int values. Signed-off-by: Lukasz Marek --- libavdevice/avdevice.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavdevice/avdevice.c b/libavdevice/avdevice.c index 86deb82..e5ab0b7 100644 --

Re: [FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table

2014-12-13 Thread James Almer
On 13/12/14 4:27 PM, Lukasz Marek wrote: > This symbol is required for query capabilities callbacks. > This symbol is only required by libavdevice and should not be exported. This need a deprecation and an FF_API scheduled removal. We can't remove the symbol without a major bump. Also, an inter

Re: [FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table

2014-12-13 Thread Reimar Döffinger
On 13.12.2014, at 20:42, James Almer wrote: > On 13/12/14 4:27 PM, Lukasz Marek wrote: >> This symbol is required for query capabilities callbacks. >> This symbol is only required by libavdevice and should not be exported. > > This need a deprecation and an FF_API scheduled removal. We can't remo

Re: [FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table

2014-12-13 Thread Lukasz Marek
On 13.12.2014 20:48, Reimar Döffinger wrote: On 13.12.2014, at 20:42, James Almer wrote: On 13/12/14 4:27 PM, Lukasz Marek wrote: This symbol is required for query capabilities callbacks. This symbol is only required by libavdevice and should not be exported. This need a deprecation and an F

Re: [FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table

2014-12-13 Thread Lukasz Marek
On 13.12.2014 20:54, Lukasz Marek wrote: On 13.12.2014 20:48, Reimar Döffinger wrote: On 13.12.2014, at 20:42, James Almer wrote: On 13/12/14 4:27 PM, Lukasz Marek wrote: This symbol is required for query capabilities callbacks. This symbol is only required by libavdevice and should not be ex

Re: [FFmpeg-devel] [PATCH] lavfi: add colorlevels filter

2014-12-13 Thread Lou Logan
On Thu, 11 Dec 2014 10:20:11 +, Paul B Mahol wrote: > I added 3 examples from you. You can truncate my examples to three decimal places. I was being lazy and copy and pasted my calculated values. Looking at it again I couldn't tell a difference between the truncated ones and the long ones, bu

Re: [FFmpeg-devel] [PATCH 2/2] lavd/avdevice: use better option types for caps options

2014-12-13 Thread Michael Niedermayer
On Sat, Dec 13, 2014 at 08:27:08PM +0100, Lukasz Marek wrote: > Using dedicated types allows to use format/layout names, > not just raw int values. > > Signed-off-by: Lukasz Marek LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever kn

[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-13 Thread arwa arif
I have tried to port fspp. Not sure, if it is correct or not. From da23a3d94181a5d53454d3904d79a422ea1272ac Mon Sep 17 00:00:00 2001 From: Arwa Arif Date: Sun, 14 Dec 2014 12:03:31 +0530 Subject: [PATCH] Port fspp to FFmpeg --- doc/filters.texi | 24 + libavfilter/Makefile |1