Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-24 Thread James Almer
On 02/01/15 6:34 PM, Michael Niedermayer wrote: > On Fri, Jan 02, 2015 at 05:13:33PM +0100, Giorgio Vazzana wrote: >> Hello, >> >> 2015-01-02 15:17 GMT+01:00 Michael Niedermayer : >>> i assume giorgio is ok with the patch as he previously said "rest LGTM" >>> so applied >> >> thank you Supraja for

Re: [FFmpeg-devel] [PATCH] Move stream_options to avformat

2015-01-24 Thread Michael Niedermayer
On Sun, Jan 25, 2015 at 02:31:33AM +0100, wm4 wrote: > On Sun, 25 Jan 2015 02:28:01 +0100 > Michael Niedermayer wrote: > > > On Sun, Jan 25, 2015 at 02:16:58AM +0100, wm4 wrote: > > > On Sun, 25 Jan 2015 01:56:30 +0100 > > > Michael Niedermayer wrote: > > > > > > > TODO: APIChanges/version bump

Re: [FFmpeg-devel] [PATCH] Move stream_options to avformat

2015-01-24 Thread wm4
On Sun, 25 Jan 2015 02:28:01 +0100 Michael Niedermayer wrote: > On Sun, Jan 25, 2015 at 02:16:58AM +0100, wm4 wrote: > > On Sun, 25 Jan 2015 01:56:30 +0100 > > Michael Niedermayer wrote: > > > > > TODO: APIChanges/version bump > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > ff

Re: [FFmpeg-devel] [PATCH] Move stream_options to avformat

2015-01-24 Thread Michael Niedermayer
On Sun, Jan 25, 2015 at 02:16:58AM +0100, wm4 wrote: > On Sun, 25 Jan 2015 01:56:30 +0100 > Michael Niedermayer wrote: > > > TODO: APIChanges/version bump > > > > Signed-off-by: Michael Niedermayer > > --- > > ffmpeg.c | 30 -- > > libavformat/avform

Re: [FFmpeg-devel] [PATCH] Move stream_options to avformat

2015-01-24 Thread wm4
On Sun, 25 Jan 2015 01:56:30 +0100 Michael Niedermayer wrote: > TODO: APIChanges/version bump > > Signed-off-by: Michael Niedermayer > --- > ffmpeg.c | 30 -- > libavformat/avformat.h |6 ++ > libavformat/options.c | 30 +++

[FFmpeg-devel] [PATCH] x86/sbrdsp: add ff_sbr_autocorrelate_{sse, sse3}

2015-01-24 Thread James Almer
2 to 2.5 times faster. Signed-off-by: James Almer --- libavcodec/x86/sbrdsp.asm| 114 +++ libavcodec/x86/sbrdsp_init.c | 8 +++ 2 files changed, 122 insertions(+) diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm index 6f2e4f4..c9f2

Re: [FFmpeg-devel] [PATCH] ffmpeg: allow overriding and amending AVStream->disposition

2015-01-24 Thread Michael Niedermayer
On Thu, Jan 08, 2015 at 11:23:57PM +0100, Michael Niedermayer wrote: > On Thu, Jan 08, 2015 at 11:09:14PM +0100, Nicolas George wrote: > > Le nonidi 19 nivôse, an CCXXIII, Michael Niedermayer a écrit : > > > + { "default" , ... { .i64 = AV_DISPOSITION_DEFAULT }, ... > > > + { "dub" , ... {

[FFmpeg-devel] [PATCH] Move stream_options to avformat

2015-01-24 Thread Michael Niedermayer
TODO: APIChanges/version bump Signed-off-by: Michael Niedermayer --- ffmpeg.c | 30 -- libavformat/avformat.h |6 ++ libavformat/options.c | 30 ++ 3 files changed, 40 insertions(+), 26 deletions(-) diff --git a/

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 12:26:49PM -0800, jon morley wrote: > Hi Clément, > > I am sorry I was rude. That was not my intention. I was attempting > to follow these directions from the ffmpeg.org page: > > "You can use the FFmpeg libraries in your commercial program, but > you are encouraged to pub

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 12:52:58PM -0800, Philip Langdale wrote: > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when th

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-24 Thread Paul B Mahol
On 1/24/15, Paul B Mahol wrote: > From: Arwa Arif > > Code adapted from James Darnley's port > > Signed-off-by: Paul B Mahol > --- > configure| 1 + > doc/filters.texi | 43 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter

[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-24 Thread Paul B Mahol
From: Arwa Arif Code adapted from James Darnley's port Signed-off-by: Paul B Mahol --- configure| 1 + doc/filters.texi | 43 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 4 +- libavfilter/vf_eq.c | 27

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 20:28:30 +0100 Michael Niedermayer wrote: > On Sat, Jan 24, 2015 at 10:11:21AM -0800, Philip Langdale wrote: > > On Sat, 24 Jan 2015 13:02:01 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > > > Yeah, I've g

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
--- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 7d82d58..16ef93f 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -590,6 +590,11 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) memcpy(&ctx-

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-24 Thread Giorgio Vazzana
Hello, thanks for the new patch. As I said the code looks quite good, here's what I spotted in my review: > From b46d6a457aeee319fc6e56217a265c9881a34c2c Mon Sep 17 00:00:00 2001 > From: Supraja Meedinti > Date: Thu, 15 Jan 2015 21:35:16 +0530 > Subject: [PATCH] libavutil: Added Twofish block ci

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread Clément Bœsch
On Sat, Jan 24, 2015 at 09:09:05PM +0100, wm4 wrote: > On Sat, 24 Jan 2015 18:37:01 + > Derek Buitenhuis wrote: > > > On 1/24/2015 4:33 PM, wm4 wrote: > > > Which ones? We even expect C99 support from the compiler. > > > > Doesn't matter. It's the project's policy to have decls at > > block

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread jon morley
Hi Clément, I am sorry I was rude. That was not my intention. I was attempting to follow these directions from the ffmpeg.org page: "You can use the FFmpeg libraries in your commercial program, but you are encouraged to publish any patch you make. In this case the best way to proceed is to s

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread wm4
On Sat, 24 Jan 2015 18:37:01 + Derek Buitenhuis wrote: > On 1/24/2015 4:33 PM, wm4 wrote: > > Which ones? We even expect C99 support from the compiler. > > Doesn't matter. It's the project's policy to have decls at > block beginnings. Yes some of us think it's better. > > We know you don't.

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-24 Thread Paul B Mahol
On 1/23/15, Stefano Sabatini wrote: > On date Friday 2015-01-23 20:44:01 +0530, Arwa Arif encoded: > [...] >> > Looks good otherwise, assuming it is bitexact with the mp=eq2. >> > >> >> The default is bit-exact with mp=eq2, I can't check it with other values, >> because the range of values in mp i

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 10:11:21AM -0800, Philip Langdale wrote: > On Sat, 24 Jan 2015 13:02:01 +0100 > Michael Niedermayer wrote: > > > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > > Signed-off-by: Philip Langdale > > > --- > > > libavcodec/nvenc.c | 5 + > > > 1 fi

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread Derek Buitenhuis
On 1/24/2015 4:33 PM, wm4 wrote: > Which ones? We even expect C99 support from the compiler. Doesn't matter. It's the project's policy to have decls at block beginnings. Yes some of us think it's better. We know you don't. Don't start an ideological troll war. - Derek ___

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 13:02:01 +0100 Michael Niedermayer wrote: > On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > > Signed-off-by: Philip Langdale > > --- > > libavcodec/nvenc.c | 5 + > > 1 file changed, 5 insertions(+) > > Applying: nvenc: Propagate desired number of ref

Re: [FFmpeg-devel] [PATCH 1/7] hevc: pass the full HEVCNAL struct to decode_nal_unit

2015-01-24 Thread Michael Niedermayer
On Sat, Jan 24, 2015 at 03:26:15PM +0100, Hendrik Leppkes wrote: > This enables decode_nal_unit to access additional fields added in > subsequent commits. > --- > libavcodec/hevc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/hevc.c b/libavcodec/hevc

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread wm4
On Sat, 24 Jan 2015 17:21:40 +0100 Clément Bœsch wrote: > On Sat, Jan 24, 2015 at 07:40:38AM -0800, jon morley wrote: > > Hi Clément, > > > > Hi, > > > That is a good point! I am attaching an additional patch to remove those > > cases even before entering the mod test loop. > > > > Now the lo

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread Clément Bœsch
On Sat, Jan 24, 2015 at 07:40:38AM -0800, jon morley wrote: > Hi Clément, > Hi, > That is a good point! I am attaching an additional patch to remove those > cases even before entering the mod test loop. > > Now the logic should look like this: > > static int check_fps(int fps) > { > if (f

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread jon morley
Hi Clément, That is a good point! I am attaching an additional patch to remove those cases even before entering the mod test loop. Now the logic should look like this: static int check_fps(int fps) { if (fps <= 0) return -1; int i; static const int supported_fps_bases[] = {24, 25

[FFmpeg-devel] [PATCH 7/7] ffmpeg_dxva2: add hevc support

2015-01-24 Thread Hendrik Leppkes
--- ffmpeg_dxva2.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ffmpeg_dxva2.c b/ffmpeg_dxva2.c index 3c91d26..741c55b 100644 --- a/ffmpeg_dxva2.c +++ b/ffmpeg_dxva2.c @@ -52,6 +52,7 @@ DEFINE_GUID(DXVA2_ModeH264_F, 0x1b81be69, 0xa0c7,0x11d3,0xb9,0x84,0x00

[FFmpeg-devel] [PATCH 6/7] Add DXVA2 HEVC HWAccel

2015-01-24 Thread Hendrik Leppkes
--- configure | 5 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/dxva2_hevc.c | 375 libavcodec/hevc.c | 8 +- 5 files changed, 389 insertions(+), 1 deletion(-) create mode 100644 libavcodec/

[FFmpeg-devel] [PATCH 5/7] hevc: reindent after previous commit

2015-01-24 Thread Hendrik Leppkes
--- libavcodec/hevc.c | 38 +++--- libavcodec/hevc_refs.c | 24 2 files changed, 31 insertions(+), 31 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 8e686c6..8bf9562 100644 --- a/libavcodec/hevc.c +++ b/libavcode

[FFmpeg-devel] [PATCH 4/7] hevc: add hwaccel hooks

2015-01-24 Thread Hendrik Leppkes
--- libavcodec/hevc.c | 35 +-- libavcodec/hevc.h | 3 +++ libavcodec/hevc_refs.c | 17 + 3 files changed, 53 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 36c7b47..8e686c6 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 1/7] hevc: pass the full HEVCNAL struct to decode_nal_unit

2015-01-24 Thread Hendrik Leppkes
This enables decode_nal_unit to access additional fields added in subsequent commits. --- libavcodec/hevc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 2bd89ec..8f60b3d 100644 --- a/libavcodec/hevc.c +++ b/libavcodec/hevc.

[FFmpeg-devel] [PATCH 3/7] hevc: store the short term rps flag and size in the context

2015-01-24 Thread Hendrik Leppkes
For future use by hardware accelerators. --- libavcodec/hevc.c | 8 +--- libavcodec/hevc.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 778f39b..36c7b47 100644 --- a/libavcodec/hevc.c +++ b/libavcodec/hevc.c @@ -474,7 +474,7

[FFmpeg-devel] [PATCH 2/7] hevc: store the escaped/raw bitstream in HEVCNAL

2015-01-24 Thread Hendrik Leppkes
Hardware Accelerators require access to the escaped bitstream. --- libavcodec/hevc.c | 6 -- libavcodec/hevc.h | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 8f60b3d..778f39b 100644 --- a/libavcodec/hevc.c +++ b/libavcodec/he

Re: [FFmpeg-devel] [PATCH] avutil/pixdesc: rewrite AV_PIX_FMT_FLAG_PSEUDOPAL documentation

2015-01-24 Thread Michael Niedermayer
On Thu, Jan 15, 2015 at 08:57:47PM +0100, Michael Niedermayer wrote: > It seems many people do not understand its current documentation > > Signed-off-by: Michael Niedermayer > --- > libavutil/pixdesc.h | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) applied [...] -- Mich

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: expand format for strftime

2015-01-24 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 08:10:40PM +0100, Christophe Gisquet wrote: > Hi, > > another warning under MinGW fixed, because the format specifiers are > not supported, cf. for instance: > https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx > > -- > Christophe > ffmpeg_opt.c |2 +- > 1 file

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: > Signed-off-by: Philip Langdale > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) Applying: nvenc: Propagate desired number of reference frames. fatal: sha1 information is lacking or useless (libavcodec/nvenc

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Timo Rothenpieler
> Signed-off-by: Philip Langdale > --- > libavcodec/nvenc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index c52beb7..e68bbe9 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -614,6 +614,11 @@ static av_cold int nvenc_

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-24 Thread Clément Bœsch
On Fri, Jan 23, 2015 at 06:44:56AM -0800, jon wrote: > Hi Michael, > > That is great! > > I see what you are referring to in mov_read_timecode_track(). However the > text of that comment seems contradictory to me based on what I have read in > the QuickTime reference I sited about the tmcd counte

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread Clément Bœsch
On Fri, Jan 23, 2015 at 08:48:37AM -0800, jon morley wrote: > Patch attached for consideration. > > On 1/23/15 8:03 AM, jon morley wrote: > >Currently check_fps has the following logic: > > > >static int check_fps(int fps) > >{ > > int i; > > static const int supported_fps[] = {24, 25, 30,