Re: [FFmpeg-devel] 0001-avcodec-ppc-idctdsp.c-POWER-LE-support-idct_add_alti

2015-02-02 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 12:33:08PM +0800, rongyan wrote: > Hi, > > We present a patch to fix MPEG2 decoding bugs for POWER8 little endian. The > function idct_add_altivec() in file /libavcodec/ppc/idctdsp.c is fixed. > The fate test result can be found on website by searching "ibmcrl", also >

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 04:13:49 GMT, Michael Niedermayer wrote: > isnt the id3 + vorbis tag issue the same as if the user would seek > back to the begin and read metadata afterwards ? Metadata isn't in-stream for flac (AFAICT, it is only read with the header; I certainly can't get the code to re-

[FFmpeg-devel] 0001-avcodec-ppc-idctdsp.c-POWER-LE-support-idct_add_alti

2015-02-02 Thread rongyan
Hi, We present a patch to fix MPEG2 decoding bugs for POWER8 little endian. The function idct_add_altivec() in file /libavcodec/ppc/idctdsp.c is fixed. The fate test result can be found on website by searching "ibmcrl", also attached in the below to facilitate the review. Thanks. Rong

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 01:36:13AM +, Ben Boeckel wrote: > On Tue, 03 Feb, 2015 at 00:40:46 GMT, Reimar Döffinger wrote: > > Yes, and? > > Point one: ID3 won, it is generally supported. Insisting on something > > else IMHO is just being a pain on the user for little reason and > > nothing we sh

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 01:37:05 GMT, James Almer wrote: > On 02/02/15 10:02 PM, Lou Logan wrote: >> I wonder what the percentage is of flacs with only ID3 or whatever, only >> Vorbis comment, or a mix. I have no idea. Seeing as EAC adds IDv3 to the files it creates, I'd not be surprised if it isn

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 00:40:46 GMT, Reimar Döffinger wrote: > Yes, and? > Point one: ID3 won, it is generally supported. Insisting on something > else IMHO is just being a pain on the user for little reason and > nothing we should strive to emulate. > Point two: If despite that warning a ID3 tag

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread James Almer
On 02/02/15 10:02 PM, Lou Logan wrote: > On Mon, Feb 2, 2015, at 03:40 PM, Reimar Döffinger wrote: >> Yes, and? >> Point one: ID3 won, it is generally supported. Insisting on something >> else IMHO is just being a pain on the user for little reason and nothing >> we should strive to emulate. > > I

[FFmpeg-devel] [PATCHv3] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 20 1 f

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
On Tue, 03 Feb, 2015 at 00:23:55 GMT, Michael Niedermayer wrote: > this doesnt build > libavformat/flacdec.c: In function =E2=80=98flac_read_header=E2=80=99: > libavformat/flacdec.c:59:14: error: =E2=80=98AVFormatContext=E2=80=99 has n= > o member named =E2=80=98err_recognition=E2=80=99 > make: ***

Re: [FFmpeg-devel] [PATCH] avformat/network: Check for av_malloc* failures in ff_tls_init()

2015-02-02 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 04:48:57PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/network.c |6 +- > libavformat/network.h |2 +- > libavformat/tls.c |3 ++- > libavformat/utils.c |3 ++- > 4 files changed, 10 insertions(+), 4

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Lou Logan
On Mon, Feb 2, 2015, at 03:40 PM, Reimar Döffinger wrote: > Yes, and? > Point one: ID3 won, it is generally supported. Insisting on something > else IMHO is just being a pain on the user for little reason and nothing > we should strive to emulate. I simply don't want to see ffmpeg output files tha

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Reimar Döffinger
On 03.02.2015, at 01:26, Lou Logan wrote: > On Mon, Feb 2, 2015, at 03:10 PM, Reimar Döffinger wrote: >> I'm not really convinced this makes sense. >> There are thousands of programs that can edit IDv3 tags, but >> comparatively few that can handle vorbis tags. >> If both exist, why should the Vor

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Lou Logan
On Mon, Feb 2, 2015, at 03:10 PM, Reimar Döffinger wrote: > I'm not really convinced this makes sense. > There are thousands of programs that can edit IDv3 tags, but > comparatively few that can handle vorbis tags. > If both exist, why should the Vorbis tags be more likely to > be correct? > The wa

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 06:49:11PM -0500, Ben Boeckel wrote: > FLAC doesn't really support IDv3 tags, so warn if they are found at all. > If vorbis tags are found, toss out the IDv3 tags. They are kept if > vorbis tags aren't found to at least have something there. > > Fixes #3799. > > Signed-off

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Reimar Döffinger
On Mon, Feb 02, 2015 at 06:49:11PM -0500, Ben Boeckel wrote: > FLAC doesn't really support IDv3 tags, so warn if they are found at all. > If vorbis tags are found, toss out the IDv3 tags. They are kept if > vorbis tags aren't found to at least have something there. I'm not really convinced this ma

[FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-02 Thread Ben Boeckel
FLAC doesn't really support IDv3 tags, so warn if they are found at all. If vorbis tags are found, toss out the IDv3 tags. They are kept if vorbis tags aren't found to at least have something there. Fixes #3799. Signed-off-by: Ben Boeckel --- libavformat/flacdec.c | 20 1 f

[FFmpeg-devel] [PATCH 4/7] avfilter/avf_avectorscope: Change enums to int, which are accessed via AVOption as int

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/avf_avectorscope.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_avectorscope.c b/libavfilter/avf_avectorscope.c index 1b5365a..3027de3 100644 --- a/libavfilter/avf_avectorscope.c +++ b/libavfilter/avf_ave

[FFmpeg-devel] [PATCH 6/7] avfilter/af_biquads: Change width_type to int as its accessed as int via AVOptions

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/af_biquads.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 10de28d..91662c4 100644 --- a/libavfilter/af_biquads.c +++ b/libavfilter/af_biquads.c @@ -98,7 +98,7 @@

[FFmpeg-devel] [PATCH 7/7] avfilter/af_aphaser: Change type to int as its accessed as int via AVOptions

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/af_aphaser.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_aphaser.c b/libavfilter/af_aphaser.c index 9d8f696..708b568 100644 --- a/libavfilter/af_aphaser.c +++ b/libavfilter/af_aphaser.c @@ -37,7 +37,7 @@

[FFmpeg-devel] [PATCH 5/7] avfilter/af_volume: Change enums to int, which are accessed via AVOption as int

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/af_volume.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_volume.h b/libavfilter/af_volume.h index 53a328e..aff7526 100644 --- a/libavfilter/af_volume.h +++ b/libavfilter/af_volume.h @@ -68,13 +68,13

[FFmpeg-devel] [PATCH 3/7] avfilter/avf_showspectrum: Change enums to int, which are accessed via AVOption as int

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/avf_showspectrum.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 24116da..49491b6 100644 --- a/libavfilter/avf_showspectrum.c +++ b/libavfilter

[FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffprobe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index d352bb6b..30f9cba 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -338,7 +338,7 @@ struct WriterContext { unsigned int nb_section_frame; ///< number

[FFmpeg-devel] [PATCH 2/7] avcodec/libfdk-aacdec: Change conceal_method to int, its accessed via AVOption as int

2015-02-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/libfdk-aacdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c index a8ed104..f7fc811 100644 --- a/libavcodec/libfdk-aacdec.c +++ b/libavcodec/libfdk-aacdec.c @@ -44,7

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 11:56:52AM +0200, dhead666 wrote: > This adds an option to set the service type in mpegts as defined in ETSI 300 > 468. > > I added what I believe are the most useful service types as pre defined > values, > the others can be sent by using their hexdecimal form directly (

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread James Almer
On 02/02/15 2:11 PM, Christophe Gisquet wrote: > Hi, > > 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : >> https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a > > No longer apply cleanly, as multiple fixes and improvements have been > committed since then. > > The atta

Re: [FFmpeg-devel] support for monochrome sequences in hevc decoder

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 05:04:04PM +0100, Mickaël Raulet wrote: > I did it first :) ahh, ok applied thanks alot [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Mickaël Raulet
PL Lepere is the original author and I did some improvements on top of it. Mickael 2015-02-02 18:11 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : > > > https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a > > No longer apply c

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Christophe Gisquet
Hi, 2015-02-02 17:16 GMT+01:00 Mickaël Raulet : > https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a No longer apply cleanly, as multiple fixes and improvements have been committed since then. The attached patch fixes that, and passes on a non-avx2 machine. I can't

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libopenjpegenc: add layerrates parameter to allow different compression rates per layer

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 05:31:07PM +0100, Jean First wrote: > On Mon Feb 02 2015 17:20:44 GMT+0100 (CET), Michael Niedermayer wrote: > > On Mon, Feb 02, 2015 at 01:18:35PM +0100, Jean First wrote: > >> libopenjpegenc.c | 42 -- > >> 1 file changed, 20 inse

Re: [FFmpeg-devel] libopenjpegenc improvements

2015-02-02 Thread Michael Niedermayer
On Wed, Jan 28, 2015 at 04:41:23PM +0100, Jean First wrote: > This patchset sould alow ffmpeg to create jpeg2000 files conforming to the > dci specification. > > Most of the code originates form the image_to_j2k file provided by openjpeg. > > Can someone shed some light, if the following paramet

Re: [FFmpeg-devel] [PATCH 1/3] lavc/libopenjpegenc: factorize cinema parameters to it's own function

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 05:21:06PM +0100, Michael Niedermayer wrote: > On Wed, Jan 28, 2015 at 04:41:24PM +0100, Jean First wrote: > > Signed-off-by: Jean First > > --- > > > > also reordered them slightly to match the code in image_to_j2k.c provided > > by openjpeg > > > > libavcodec/libope

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libopenjpegenc: add layerrates parameter to allow different compression rates per layer

2015-02-02 Thread Jean First
On Mon Feb 02 2015 17:20:44 GMT+0100 (CET), Michael Niedermayer wrote: > On Mon, Feb 02, 2015 at 01:18:35PM +0100, Jean First wrote: >> libopenjpegenc.c | 42 -- >> 1 file changed, 20 insertions(+), 22 deletions(-) >> 6bed682adf441fa060b9fef84df173cd758320

Re: [FFmpeg-devel] [PATCH 1/3] lavc/libopenjpegenc: factorize cinema parameters to it's own function

2015-02-02 Thread Michael Niedermayer
On Wed, Jan 28, 2015 at 04:41:24PM +0100, Jean First wrote: > Signed-off-by: Jean First > --- > > also reordered them slightly to match the code in image_to_j2k.c provided by > openjpeg > > libavcodec/libopenjpegenc.c | 62 > ++--- > 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libopenjpegenc: add layerrates parameter to allow different compression rates per layer

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 01:18:35PM +0100, Jean First wrote: > libopenjpegenc.c | 42 -- > 1 file changed, 20 insertions(+), 22 deletions(-) > 6bed682adf441fa060b9fef84df173cd758320ed > 0001-lavc-libopenjpegenc-move-opj_create_compress-opj_cio.patch > Fro

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Mickaël Raulet
Hi christophe, I was willing to send avx2 mc patch, but I need to test it on top of ffmpeg head. Last time I tried I had to revert 940300945995c20f7583394ebe6907e72829b4a. https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a . Here is the avx2 implementation if someo

Re: [FFmpeg-devel] support for monochrome sequences in hevc decoder

2015-02-02 Thread Mickaël Raulet
I did it first :) 2015-02-02 16:47 GMT+01:00 Michael Niedermayer : > On Mon, Feb 02, 2015 at 04:11:33PM +0100, Mickaël Raulet wrote: > > Hi here is a commit that support monochrome sequences! > > > > > https://github.com/OpenHEVC/FFmpeg/commit/8e50557707d2ec11ccad657470b2e140f314348e > > > > Comm

Re: [FFmpeg-devel] support for monochrome sequences in hevc decoder

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 04:11:33PM +0100, Mickaël Raulet wrote: > Hi here is a commit that support monochrome sequences! > > https://github.com/OpenHEVC/FFmpeg/commit/8e50557707d2ec11ccad657470b2e140f314348e > > Commit hash: 8e50557707d2ec11ccad657470b2e140f314348e is this an independant impleme

[FFmpeg-devel] support for monochrome sequences in hevc decoder

2015-02-02 Thread Mickaël Raulet
Hi here is a commit that support monochrome sequences! https://github.com/OpenHEVC/FFmpeg/commit/8e50557707d2ec11ccad657470b2e140f314348e Commit hash: 8e50557707d2ec11ccad657470b2e140f314348e Mickael ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 03:31:54PM +0100, Michael Niedermayer wrote: > On Mon, Feb 02, 2015 at 02:22:36PM +0100, Christophe Gisquet wrote: > > Hi, > > > > 2015-02-02 13:32 GMT+01:00 Michael Niedermayer : > > > On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote: > > > hmm, is there

Re: [FFmpeg-devel] PATCH dshow show devices options

2015-02-02 Thread Roger Pack
On 1/31/15, Roger Pack wrote: > On 1/30/15, Michael Niedermayer wrote: >> On Fri, Jan 30, 2015 at 08:55:45AM -0700, Roger Pack wrote: >>> On 1/30/15, Don Moir wrote: >>> > >>> > - Original Message - >>> > From: "Roger Pack" >>> > To: "FFmpeg development discussions and patches" >>> > >

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 02:22:36PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-02 13:32 GMT+01:00 Michael Niedermayer : > > On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote: > > hmm, is there a reason not to take the original commit unchanged ? > > I was hoping to reduce t

Re: [FFmpeg-devel] [PATCH] avcodec/wavpackenc: remove unneeded L suffixes

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 08:57:04AM +, Paul B Mahol wrote: > On 2/1/15, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/wavpackenc.c |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/wavpackenc.c b/lib

[FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-02 Thread Christophe Gisquet
This is not a clean equivalent of the openhevc patch, as we don't have the same history on hevc_mc. -- Christophe From 0eedfb7d5902cc388d018111c670cc31ad22db60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micka=C3=ABl=20Raulet?= Date: Thu, 31 Jul 2014 19:26:57 +0200 Subject: [PATCH] x86: hevc_mc: re

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-02 Thread Christophe Gisquet
Hi, 2015-02-02 13:32 GMT+01:00 Michael Niedermayer : > On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote: > hmm, is there a reason not to take the original commit unchanged ? > I was hoping to reduce the difference to openhevc so that we also > are able to merge future changes fro

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-02 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote: > Hi, > > the attached patch is somewhat of a hack job, as the commit I used may > already have been edited from its original version, and I have added > some stuff on top of it (eg the commit message). hmm, is there a reason not

Re: [FFmpeg-devel] [PATCH 2/3] lavc/libopenjpegenc: add layerrates parameter to allow different compression rates per layer

2015-02-02 Thread Jean First
>From fe0afff9c7b8c6f78dcad0720965c6f6a50e7813 Mon Sep 17 00:00:00 2001 From: Jean First Date: Mon, 2 Feb 2015 12:57:03 +0100 Subject: [PATCH] lavc/libopenjpegenc: move opj_create_compress, opj_cio_open and opj_set_event_mgr to libopenjpeg_encode_frame libopenjpegenc crashes with "pointer being

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: allow to set service_type in sdt

2015-02-02 Thread dhead666
This adds an option to set the service type in mpegts as defined in ETSI 300 468. I added what I believe are the most useful service types as pre defined values, the others can be sent by using their hexdecimal form directly (e.g. -mpegts_service_type digital_radio, -mpegts_service_type 0x07).

Re: [FFmpeg-devel] [PATCH] avcodec/wavpackenc: remove unneeded L suffixes

2015-02-02 Thread Paul B Mahol
On 2/1/15, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpackenc.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c > index 63971c6..c174950 100644 > --- a/libavcodec/wavp