Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On 03.02.2015, at 22:06, wm4 wrote: > On Tue, 3 Feb 2015 22:00:11 +0100 > Reimar Döffinger wrote: > >> On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: >>> On Tue, 3 Feb 2015 21:47:57 +0100 >>> Reimar Döffinger wrote: >>> On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > This

Re: [FFmpeg-devel] [PATCH 4/6] hevcdsp: replace the SAOParams struct parameter from sao_edge_filter

2015-02-03 Thread Mickaël Raulet
lgtm. Mickael 2015-02-04 4:55 GMT+01:00 James Almer : > As with sao_band_filter, pass instead the two variables from the struct > needed in the function. > This simplifies writing asm optimized versions. > > Signed-off-by: James Almer > --- > libavcodec/hevc_filter.c | 4 +++- > libavcode

Re: [FFmpeg-devel] [PATCH 3/6] hevcdsp: further simplify sao_edge_filter

2015-02-03 Thread Mickaël Raulet
ok. 2015-02-04 8:07 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-04 4:55 GMT+01:00 James Almer : > [...] > > Ok, no need to resend a refreshed patch if patch 2/6 changes. > > -- > Christophe > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 2/6] hevcdsp: simplified sao_edge_filter

2015-02-03 Thread Mickaël Raulet
OK too. 2015-02-04 8:04 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-04 4:55 GMT+01:00 James Almer : > > +int a_stride, b_stride; > > +int src_offset = 0; > > +int dst_offset = 0; > > Could maybe use ptrdiff_t type, like the other strides? > > With or without, ok. > > -- > Christo

Re: [FFmpeg-devel] [PATCH 1/6] hevcdsp: separated sao edge filter and pixel restore funcs

2015-02-03 Thread Mickaël Raulet
Ok too. 2015-02-04 8:09 GMT+01:00 Christophe Gisquet : > Hi, > > 2015-02-04 6:13 GMT+01:00 Michael Niedermayer : > > On Wed, Feb 04, 2015 at 12:55:48AM -0300, James Almer wrote: > >> From: Seppo Tomperi > >> > >> --- > >> libavcodec/hevc_filter.c | 3 ++- > >> libavcodec/hevcdsp.c

Re: [FFmpeg-devel] [PATCH 1/6] hevcdsp: separated sao edge filter and pixel restore funcs

2015-02-03 Thread Christophe Gisquet
Hi, 2015-02-04 6:13 GMT+01:00 Michael Niedermayer : > On Wed, Feb 04, 2015 at 12:55:48AM -0300, James Almer wrote: >> From: Seppo Tomperi >> >> --- >> libavcodec/hevc_filter.c | 3 ++- >> libavcodec/hevcdsp.c | 5 +++-- >> libavcodec/hevcdsp.h | 11 +++ >> libavc

Re: [FFmpeg-devel] [PATCH 3/6] hevcdsp: further simplify sao_edge_filter

2015-02-03 Thread Christophe Gisquet
Hi, 2015-02-04 4:55 GMT+01:00 James Almer : [...] Ok, no need to resend a refreshed patch if patch 2/6 changes. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/6] hevcdsp: simplified sao_edge_filter

2015-02-03 Thread Christophe Gisquet
Hi, 2015-02-04 4:55 GMT+01:00 James Almer : > +int a_stride, b_stride; > +int src_offset = 0; > +int dst_offset = 0; Could maybe use ptrdiff_t type, like the other strides? With or without, ok. -- Christophe ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/6] hevcdsp: separated sao edge filter and pixel restore funcs

2015-02-03 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:55:48AM -0300, James Almer wrote: > From: Seppo Tomperi > > --- > libavcodec/hevc_filter.c | 3 ++- > libavcodec/hevcdsp.c | 5 +++-- > libavcodec/hevcdsp.h | 11 +++ > libavcodec/hevcdsp_template.c | 15 +-- > 4 files chang

[FFmpeg-devel] [PATCH] avformat/tta: only check for header and seek table crc if requested

2015-02-03 Thread James Almer
Signed-off-by: James Almer --- I made it abort only if AV_EF_EXPLODE is also set like we do when decoding audio frames, but maybe aborting if the header or seek table are damaged should be the default behaviour. Chances are a file with a broken header is unplayable after all. Thoughts? libav

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-03 Thread Philip Langdale
Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out of step with all the other encoders in ffmpeg. Thanks, --phil On Wed, 28 Jan 2015 09:05:53

Re: [FFmpeg-devel] [PATCH] ffmpeg: Make CFR frame drop threshold user adjustable

2015-02-03 Thread Michael Niedermayer
On Sat, Jan 17, 2015 at 05:39:18AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffmpeg.c |4 +++- > ffmpeg.h |1 + > ffmpeg_opt.c |3 +++ > 3 files changed, 7 insertions(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2

[FFmpeg-devel] [PATCH 4/6] hevcdsp: replace the SAOParams struct parameter from sao_edge_filter

2015-02-03 Thread James Almer
As with sao_band_filter, pass instead the two variables from the struct needed in the function. This simplifies writing asm optimized versions. Signed-off-by: James Almer --- libavcodec/hevc_filter.c | 4 +++- libavcodec/hevcdsp.h | 4 ++-- libavcodec/hevcdsp_template.c | 7 ++

[FFmpeg-devel] [PATCH 6/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_{10, 12}_{sse2, avx2}

2015-02-03 Thread James Almer
Original x86 intrinsics code by Pierre-Edouard Lepere. Yasm port by James Almer. Benchmarks of BQTerrace_1920x1080_60_qp22.bin with an Intel Core i5-4200U Width 32 342694 decicycles in sao_edge_filter_10, 16384 runs, 0 skips 29476 decicycles in ff_hevc_sao_edge_filter_32_10_ssse3, 16384 runs, 0 s

[FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-03 Thread James Almer
Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere. Refactoring and optimizations by James Almer. Benchmarks of BQTerrace_1920x1080_60_qp22.bin with an Intel Core i5-4200U Width 32 158583 decicycles in edge, sao_edge_filter_8 runs, 0 skips 5205 decicycles in ff_hevc_sao_e

[FFmpeg-devel] [PATCH 3/6] hevcdsp: further simplify sao_edge_filter

2015-02-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevcdsp_template.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/hevcdsp_template.c b/libavcodec/hevcdsp_template.c index d372c9a..4479435 100644 --- a/libavcodec/hevcdsp_template.c +++ b/libavcodec/hevcdsp_te

[FFmpeg-devel] [PATCH 2/6] hevcdsp: simplified sao_edge_filter

2015-02-03 Thread James Almer
From: Seppo Tomperi --- libavcodec/hevc_filter.c | 2 +- libavcodec/hevcdsp.h | 2 +- libavcodec/hevcdsp_template.c | 36 3 files changed, 18 insertions(+), 22 deletions(-) diff --git a/libavcodec/hevc_filter.c b/libavcodec/hevc_filter.c inde

[FFmpeg-devel] [PATCH 1/6] hevcdsp: separated sao edge filter and pixel restore funcs

2015-02-03 Thread James Almer
From: Seppo Tomperi --- libavcodec/hevc_filter.c | 3 ++- libavcodec/hevcdsp.c | 5 +++-- libavcodec/hevcdsp.h | 11 +++ libavcodec/hevcdsp_template.c | 15 +-- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/hevc_filter.c

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-03 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 04:02:41PM +0100, Michael Niedermayer wrote: > On Mon, Feb 02, 2015 at 03:31:54PM +0100, Michael Niedermayer wrote: > > On Mon, Feb 02, 2015 at 02:22:36PM +0100, Christophe Gisquet wrote: > > > Hi, > > > > > > 2015-02-02 13:32 GMT+01:00 Michael Niedermayer : > > > > On Mon,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpc8: fix broken pointer math

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 09:44:13PM +0100, Reimar Döffinger wrote: > On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote: > > This could overflow and crash at least on 32 bit systems. > > --- > > libavformat/mpc8.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 10:06:28PM +0100, wm4 wrote: > On Tue, 3 Feb 2015 22:00:11 +0100 > Reimar Döffinger wrote: > > > On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > > > On Tue, 3 Feb 2015 21:47:57 +0100 > > > Reimar Döffinger wrote: > > > > > > > On Tue, Feb 03, 2015 at 07:04:12PM +0

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/tak_parser: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:29:47PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/tak_parser.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe yo

Re: [FFmpeg-devel] [PATCH] avcodec/wnv1: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:50:01PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/wnv1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lo

Re: [FFmpeg-devel] [PATCH] x86: lavu/x264asm: fix ymm register instanciation

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:12:27PM +0100, Christophe Gisquet wrote: > The attached patch fixes the generated AVX2 assembly from thread > "[PATCH] x86: hevc_mc: remove non necessary moves". With it, it is > identical to what is generated without ec21721. > > This should also be submitted to the x26

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Mickaël Raulet
it works now for me. Thanks, Mickaël Le 3 févr. 2015 à 15:28, Mickaël Raulet a écrit : > I will check it this evening. > > Mickaël > > 2015-02-03 15:15 GMT+01:00 Christophe Gisquet : > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet : > > Actually, 940300945 does need to be reverted for the pa

[FFmpeg-devel] [PATCH] dxva2_hevc: properly fill the scaling list structure

2015-02-03 Thread Hendrik Leppkes
The scaling list can be specified in either the SPS or PPS. Additionally, compensate for the diagonal scan permutation applied in the decoder. --- libavcodec/dxva2_hevc.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/libavcodec/dxva2_hevc.c b/libavcod

Re: [FFmpeg-devel] [PATCH] dxva2_hevc: properly fill the scaling list structure

2015-02-03 Thread Hendrik Leppkes
On Tue, Feb 3, 2015 at 10:23 PM, Hendrik Leppkes wrote: > The HEVC decoder has the scaling lists in the SPS structs, and not the PPS. > Additionally, it needs to compensate for the diagonal scan permutation > applied in the decoder. > --- > libavcodec/dxva2_hevc.c | 19 +++ > 1 f

[FFmpeg-devel] [PATCH] dxva2_hevc: properly fill the scaling list structure

2015-02-03 Thread Hendrik Leppkes
The HEVC decoder has the scaling lists in the SPS structs, and not the PPS. Additionally, it needs to compensate for the diagonal scan permutation applied in the decoder. --- libavcodec/dxva2_hevc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
On Tue, 3 Feb 2015 22:00:11 +0100 Reimar Döffinger wrote: > On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > > On Tue, 3 Feb 2015 21:47:57 +0100 > > Reimar Döffinger wrote: > > > > > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > > > This can lead to an endless loop by seeking b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 09:54:51PM +0100, wm4 wrote: > On Tue, 3 Feb 2015 21:47:57 +0100 > Reimar Döffinger wrote: > > > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > > This can lead to an endless loop by seeking back a few bytes after each > > > attempted chunk read. Assuming negative

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
On Tue, 3 Feb 2015 21:47:57 +0100 Reimar Döffinger wrote: > On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > > This can lead to an endless loop by seeking back a few bytes after each > > attempted chunk read. Assuming negative sizes are always invalid, this > > is easy to fix. Other code in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 07:04:12PM +0100, wm4 wrote: > This can lead to an endless loop by seeking back a few bytes after each > attempted chunk read. Assuming negative sizes are always invalid, this > is easy to fix. Other code in this demuxer treats negative sizes as > invalid as well. > > Fixes

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpc8: fix broken pointer math

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote: > This could overflow and crash at least on 32 bit systems. > --- > libavformat/mpc8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mpc8.c b/libavformat/mpc8.c > index a15dc25..d6ca338 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-03 Thread Reimar Döffinger
On Tue, Feb 03, 2015 at 02:57:56PM +0100, wm4 wrote: > On Tue, 3 Feb 2015 01:10:11 +0100 > Reimar Döffinger wrote: > > > On Mon, Feb 02, 2015 at 06:49:11PM -0500, Ben Boeckel wrote: > > > FLAC doesn't really support IDv3 tags, so warn if they are found at all. > > > If vorbis tags are found, toss

[FFmpeg-devel] Adding Force Style option in Subtitles Filter

2015-02-03 Thread Eejya Singh
Hi, I've implemented a force_style option in the subtitles filter. Kindly find the patch attached. -- Eejya Singh, 3rd year undergraduate, Computer Science, BITS Pilani Goa Campus From 88014fde69b249d3b1cb8e6bd2f654156ba2b4e7 Mon Sep 17 00:00:00 2001 From: Eejya Singh Date: Wed, 28 Jan 2015 17:4

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 03/02/15 4:04 PM, Christophe Gisquet wrote: > ​​Hi, > > Le 3 févr. 2015 18:47, "James Almer" a écrit : >> >> On 02/02/15 2:11 PM, Christophe Gisquet wrote: >>> @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 >>> %elif %1 <= 8 >>> movdqa%3, > [%2]

[FFmpeg-devel] [PATCH 3/3] update docs: remove the non-negative number requirement for start_number

2015-02-03 Thread Liviu Oniciuc
--- doc/muxers.texi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b0bed7e..a8225fc 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -381,8 +381,7 @@ ffmpeg -f v4l2 -r 1 -i /dev/video0 -f image2 -strftime 1 "%Y-%m-%d_%H-%M-%S.jpg

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
​​Hi, Le 3 févr. 2015 18:47, "James Almer" a écrit : > > On 02/02/15 2:11 PM, Christophe Gisquet wrote: > > @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 > > %elif %1 <= 8 > > movdqa%3, [%2] ; load data from source2 > > %elif %1 <= 1

[FFmpeg-devel] [PATCH 2/2] avformat/mpc8: fix hang with fuzzed file

2015-02-03 Thread wm4
This can lead to an endless loop by seeking back a few bytes after each attempted chunk read. Assuming negative sizes are always invalid, this is easy to fix. Other code in this demuxer treats negative sizes as invalid as well. Fixes ticket #4262. --- libavformat/mpc8.c | 4 1 file changed,

[FFmpeg-devel] [PATCH 1/2] avformat/mpc8: fix broken pointer math

2015-02-03 Thread wm4
This could overflow and crash at least on 32 bit systems. --- libavformat/mpc8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpc8.c b/libavformat/mpc8.c index a15dc25..d6ca338 100644 --- a/libavformat/mpc8.c +++ b/libavformat/mpc8.c @@ -91,7 +91,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] remove the non-negative number requirement for start_number option

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 09:01:29AM -0800, Liviu Oniciuc wrote: > industrial cameras usually mark the trigger frame as frame number 0 > all frames saved before trigger frame receive a negative sequence number > --- > libavformat/img2dec.c | 2 +- > libavformat/utils.c | 2 ++ > 2 files changed, 3

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 02/02/15 2:11 PM, Christophe Gisquet wrote: > @@ -87,11 +95,22 @@ QPEL_TABLE 12, 4, w, sse4 > %elif %1 <= 8 > movdqa%3, [%2] > ; load data from source2 > %elif %1 <= 12 > +%if avx_enabled If this is meant for avx2, then the correc

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-03 Thread Lou Logan
On Mon, Feb 2, 2015, at 04:37 PM, James Almer wrote: > This is about the demuxer, not muxer. We're not creating files that > violate the spec if > that's what you worry about. I don't know why I was thinking about the muxer...kind of ironic since I'm the one who submitted the bug report mentioned

[FFmpeg-devel] [PATCH 2/2] new option for drawtext (boxborderw = set box border width)

2015-02-03 Thread Liviu Oniciuc
at this time the drawtext box extends only for the width and height of the text. for a better visual appearance a new option was added (boxboderw) to set how much the box should extend outside of the text area Signed-off-by: Liviu Oniciuc --- libavfilter/vf_drawtext.c | 6 +- 1 file changed,

[FFmpeg-devel] [PATCH 1/2] remove the non-negative number requirement for start_number option

2015-02-03 Thread Liviu Oniciuc
industrial cameras usually mark the trigger frame as frame number 0 all frames saved before trigger frame receive a negative sequence number --- libavformat/img2dec.c | 2 +- libavformat/utils.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) mode change 100644 => 100755 libavformat/img

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/webp: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:29:44PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc D

Re: [FFmpeg-devel] [PATCH] avcodec/on2avc: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:33:18PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/on2avc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists t

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/qcelpdec: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:29:45PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/qcelpdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ac3dec: use init_get_bits8()

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 03:29:46PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/ac3dec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a pro

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread James Almer
On 03/02/15 11:15 AM, Christophe Gisquet wrote: > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet : >> Actually, 940300945 does need to be reverted for the patch to work, as >> Mickael stated. It miscompiles hevc_mc.asm, more particularly the >> [eq]pel_hv functions. No idea why. > > The patch in "[

[FFmpeg-devel] [PATCH] avcodec/cllc: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cllc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cllc.c b/libavcodec/cllc.c index 9c710bb..829cb52 100644 --- a/libavcodec/cllc.c +++ b/libavcodec/cllc.c @@ -394,7 +394,8 @@ static int cllc_decode_frame(AVCodecConte

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: added HLS encryption

2015-02-03 Thread Christian Suloway
Updated patch is attached. On 1/10/15, 3:06 PM, "Michael Niedermayer" wrote: > >i got it working after a few tries but >please provide an example that works and documentation that describes >the feature in a way sufficient to use it without reading the code >ideally add a example to the documenta

[FFmpeg-devel] [PATCH] avcodec/wnv1: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/wnv1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/wnv1.c b/libavcodec/wnv1.c index 99aee3c..fb9e9cf 100644 --- a/libavcodec/wnv1.c +++ b/libavcodec/wnv1.c @@ -88,7 +88,9 @@ static int decode_frame(AVCodecContext *av

[FFmpeg-devel] [PATCH] avcodec/on2avc: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/on2avc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c index 9bf5e87..4ad6eca 100644 --- a/libavcodec/on2avc.c +++ b/libavcodec/on2avc.c @@ -795,7 +795,9 @@ static int on2avc_decode_subfr

[FFmpeg-devel] [PATCH 4/4] avcodec/tak_parser: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/tak_parser.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/tak_parser.c b/libavcodec/tak_parser.c index 5d8460c..4f2149a 100644 --- a/libavcodec/tak_parser.c +++ b/libavcodec/tak_parser.c @@ -43,10 +43,12 @@ stat

[FFmpeg-devel] [PATCH 3/4] avcodec/ac3dec: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/ac3dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index d3e8713..20c2889 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -1429,7 +1429,8 @@ static int ac3_decode_frame(A

[FFmpeg-devel] [PATCH 2/4] avcodec/qcelpdec: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/qcelpdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/qcelpdec.c b/libavcodec/qcelpdec.c index 6f08607..03364f6 100644 --- a/libavcodec/qcelpdec.c +++ b/libavcodec/qcelpdec.c @@ -719,7 +719,8 @@ static int qcelp_deco

[FFmpeg-devel] [PATCH 1/4] avcodec/webp: use init_get_bits8()

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/webp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 4b1c8e7..e0f7239 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1106,7 +1106,7 @@ static int vp8_lossless_decode_frame(AVCo

Re: [FFmpeg-devel] [PATCH] avformat/tta: fix crash with corrupted files

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 02:40:58PM +, Paul B Mahol wrote: > On 2/3/15, wm4 wrote: > > av_add_index_entry() can fail, for example because the parameters are > > invalid, or because memory allocation fails. Check this; it can actually > > happen with corrupted files. > > > > The second hunk is j

Re: [FFmpeg-devel] [PATCH] avformat/tta: fix crash with corrupted files

2015-02-03 Thread Paul B Mahol
On 2/3/15, wm4 wrote: > av_add_index_entry() can fail, for example because the parameters are > invalid, or because memory allocation fails. Check this; it can actually > happen with corrupted files. > > The second hunk is just for robustness. Just in case functions like > ff_reduce_index() remove

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix build with msvc

2015-02-03 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:49:39AM +1100, Matt Oliver wrote: > A recent commit has broken msvc compilation. > http://fate.ffmpeg.org/report.cgi?time=20150203090035&slot=x86_32-msvc12-windows-native > > Attached is the corresponding fix. > mpegtsenc.c | 20 ++-- > 1 file changed

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Mickaël Raulet
I will check it this evening. Mickaël 2015-02-03 15:15 GMT+01:00 Christophe Gisquet : > 2015-02-03 12:57 GMT+01:00 Christophe Gisquet < > christophe.gisq...@gmail.com>: > > Actually, 940300945 does need to be reverted for the patch to work, as > > Mickael stated. It miscompiles hevc_mc.asm, mor

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
2015-02-03 12:57 GMT+01:00 Christophe Gisquet : > Actually, 940300945 does need to be reverted for the patch to work, as > Mickael stated. It miscompiles hevc_mc.asm, more particularly the > [eq]pel_hv functions. No idea why. The patch in "[PATCH] x86: lavu/x264asm: fix ymm register instanciation"

Re: [FFmpeg-devel] [PATCH] avutil/mem: replace remaining void **/*** casts by memcpy()

2015-02-03 Thread Michael Niedermayer
On Sun, Feb 01, 2015 at 03:27:34PM +0100, Michael Niedermayer wrote: > This is similar to 60392480181f24ebf3ab48d8ac3614705de90152 > > Signed-off-by: Michael Niedermayer applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to te

[FFmpeg-devel] [PATCH] x86: lavu/x264asm: fix ymm register instanciation

2015-02-03 Thread Christophe Gisquet
The attached patch fixes the generated AVX2 assembly from thread "[PATCH] x86: hevc_mc: remove non necessary moves". With it, it is identical to what is generated without ec21721. This should also be submitted to the x264 project, so that they can also choose a better description/title for the pat

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-03 Thread wm4
On Tue, 3 Feb 2015 01:10:11 +0100 Reimar Döffinger wrote: > On Mon, Feb 02, 2015 at 06:49:11PM -0500, Ben Boeckel wrote: > > FLAC doesn't really support IDv3 tags, so warn if they are found at all. > > If vorbis tags are found, toss out the IDv3 tags. They are kept if > > vorbis tags aren't found

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix build with msvc

2015-02-03 Thread Matt Oliver
A recent commit has broken msvc compilation. http://fate.ffmpeg.org/report.cgi?time=20150203090035&slot=x86_32-msvc12-windows-native Attached is the corresponding fix. avformat-mpegtsenc-Fix-build-with-msvc.patch Description: Binary data ___ ffmpeg-dev

[FFmpeg-devel] [PATCH] avformat/tta: fix crash with corrupted files

2015-02-03 Thread wm4
av_add_index_entry() can fail, for example because the parameters are invalid, or because memory allocation fails. Check this; it can actually happen with corrupted files. The second hunk is just for robustness. Just in case functions like ff_reduce_index() remove entries. (Not sure if this can ac

Re: [FFmpeg-devel] [PATCH] avformat/mov: simplify pasp value before setting SAR

2015-02-03 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 03:07:10AM +0100, Michael Niedermayer wrote: > This avoids a 65536:65536 SAR > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF673

Re: [FFmpeg-devel] [PATCHv2] flac: ignore IDv3 tags if vorbis tags exist

2015-02-03 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 04:47:19AM +, Ben Boeckel wrote: > On Tue, 03 Feb, 2015 at 04:13:49 GMT, Michael Niedermayer wrote: > > isnt the id3 + vorbis tag issue the same as if the user would seek > > back to the begin and read metadata afterwards ? > > Metadata isn't in-stream for flac (AFAICT,

Re: [FFmpeg-devel] [PATCH] x86: hevc_mc: remove non necessary moves

2015-02-03 Thread Christophe Gisquet
Hi, 2015-02-02 18:23 GMT+01:00 James Almer : >>> https://github.com/OpenHEVC/FFmpeg/commit/940300945995c20f7583394ebe6907e72829b4a [...] > Tested it. Doesn't pass with avx2. Actually, 940300945 does need to be reverted for the patch to work, as Mickael stated. It miscompiles hevc_mc.asm, more par

[FFmpeg-devel] [PATCH] avfilter: add HRTF filter

2015-02-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 24 ++ libavfilter/Makefile | 1 + libavfilter/af_hrtf.c| 554 +++ libavfilter/af_hrtf.h| 550 ++ libavfilter/allfilters.c | 1 + 5 f