[FFmpeg-devel] [PATCH 3/3] avcodec/tak: clarify the size of residues buffer

2015-02-20 Thread James Almer
Signed-off-by: James Almer --- At least this is what i interpreted 544 meant. This patch can be discarded otherwise. libavcodec/takdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 77170b5..059fdaa 100644 --- a/libavcodec/t

[FFmpeg-devel] [PATCH 2/3] avcodec/tak: remove unnecessary calls to emms_c()

2015-02-20 Thread James Almer
It's already called by scalarproduct_int16 if required. Signed-off-by: James Almer --- libavcodec/takdec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 0f808e0..77170b5 100644 --- a/libavcodec/takdec.c +++ b/libavcodec/takdec.c @@ -480,8 +

[FFmpeg-devel] [PATCH] avcodec/tak: reset filter buffers

2015-02-20 Thread James Almer
Zeroing them allows us to use scalarproduct_int16 even if the length of vectors is not multiple of 16. Signed-off-by: James Almer --- libavcodec/takdec.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c i

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-20 Thread Dave Rice
Hi Robert, Kevin, > On Feb 20, 2015, at 9:56 AM, Robert Krüger wrote: > > Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > >> On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger > > wrote: >>> if I read the code correctly, the colr atom is only written in the mov >>> muxer if the flag write_c

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 12:10:09AM +0100, Lukasz Marek wrote: > On 20.02.2015 14:30, Michael Niedermayer wrote: > >On Fri, Feb 20, 2015 at 02:15:30PM +0100, Hendrik Leppkes wrote: > >>On Fri, Feb 20, 2015 at 1:38 PM, Michael Niedermayer > >>wrote: > >>>On Fri, Feb 20, 2015 at 12:55:14PM +0100, He

Re: [FFmpeg-devel] [PATCH] lavf/ffmenc: do not fail on missing codec

2015-02-20 Thread Lukasz Marek
On 20.02.2015 01:53, Michael Niedermayer wrote: On Thu, Feb 19, 2015 at 11:52:50PM +0100, Lukasz Marek wrote: ffm encoder fails when codec is not found. It may happen when stream is being copied. This commit allows to store such stream and provides backward compatibility with version prior 2.5 r

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Lukasz Marek
On 20.02.2015 14:30, Michael Niedermayer wrote: On Fri, Feb 20, 2015 at 02:15:30PM +0100, Hendrik Leppkes wrote: On Fri, Feb 20, 2015 at 1:38 PM, Michael Niedermayer wrote: On Fri, Feb 20, 2015 at 12:55:14PM +0100, Hendrik Leppkes wrote: What else could it be? http, ftp, who knows also ff_r

Re: [FFmpeg-devel] [PATCH] lavfi: add showvolume filter

2015-02-20 Thread Clément Bœsch
On Fri, Feb 20, 2015 at 02:28:21PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showvolume.c | 197 > +++ > 3 files changed, 199 insertions(

Re: [FFmpeg-devel] [PATCH] lavfi: add showvolume filter

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 02:28:21PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showvolume.c | 197 > +++ > 3 files changed, 199 insertions(

Re: [FFmpeg-devel] [PATCH] avformat: Outputting DNxHD into .mov containers 'corrupts' following atoms until end of stsd

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 04:04:52PM +, Kevin Wheatley wrote: > On Fri, Feb 20, 2015 at 11:36 AM, Michael Niedermayer > wrote: > > applied the case for DNxHD, for the more general case, please > > explain which case(s) and software need them, and how to reproduce > > that > > My experience and

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 02:48:31PM +, Kevin Wheatley wrote: > On Fri, Feb 20, 2015 at 2:14 PM, Michael Niedermayer wrote: > > On Fri, Feb 20, 2015 at 01:48:55PM +, Kevin Wheatley wrote: > >> Here is the kind of thing that this looks like... This is definitely > >> NOT a patch :-) > > > > i

Re: [FFmpeg-devel] [PATCH] wtvdec: fix integer overflow resulting in errors with large files

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 09:30:04AM -0600, Rodger Combs wrote: > This fixes a regression in 9fbc613f0df1628e7e78bca791fa8833846f8210 > --- > libavformat/wtvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

Re: [FFmpeg-devel] [PATCH] avformat: Outputting DNxHD into .mov containers 'corrupts' following atoms until end of stsd

2015-02-20 Thread Kevin Wheatley
On Fri, Feb 20, 2015 at 11:36 AM, Michael Niedermayer wrote: > applied the case for DNxHD, for the more general case, please > explain which case(s) and software need them, and how to reproduce > that My experience and by the looks of things other people using libquicktime have seen issues with F

[FFmpeg-devel] [PATCH] wtvdec: fix integer overflow resulting in errors with large files

2015-02-20 Thread Rodger Combs
This fixes a regression in 9fbc613f0df1628e7e78bca791fa8833846f8210 --- libavformat/wtvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c index a752ee2..95b2312 100644 --- a/libavformat/wtvdec.c +++ b/libavformat/wtvdec.c @@ -965,7

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-20 Thread Robert Krüger
Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger > wrote: > > if I read the code correctly, the colr atom is only written in the mov > > muxer if the flag write_colr is specified. Was that behaviour chosen to > > have better backward compatibi

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Kevin Wheatley
On Fri, Feb 20, 2015 at 2:14 PM, Michael Niedermayer wrote: > On Fri, Feb 20, 2015 at 01:48:55PM +, Kevin Wheatley wrote: >> Here is the kind of thing that this looks like... This is definitely >> NOT a patch :-) > > i dont understand this patch there are at least two of us. > please explain

[FFmpeg-devel] [PATCH] lavfi: add showvolume filter

2015-02-20 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_showvolume.c | 197 +++ 3 files changed, 199 insertions(+) create mode 100644 libavfilter/avf_showvolume.c diff --git a/libavfilter

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-20 Thread Kevin Wheatley
On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger wrote: > if I read the code correctly, the colr atom is only written in the mov > muxer if the flag write_colr is specified. Was that behaviour chosen to > have better backward compatibility or is there another reason not to write > this standard atom

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 01:48:55PM +, Kevin Wheatley wrote: > Here is the kind of thing that this looks like... This is definitely > NOT a patch :-) i dont understand this patch please explain why you use vos_data it can be the first packet and you seem to implement that case but it is not al

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Kevin Wheatley
Here is the kind of thing that this looks like... This is definitely NOT a patch :-) On Fri, Feb 20, 2015 at 1:22 PM, Michael Niedermayer wrote: > On Fri, Feb 20, 2015 at 12:35:59PM +, Kevin Wheatley wrote: >> Please excuse my newbie knowledge of the code base BTW... >> >> I've just done a si

[FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-20 Thread Robert Krüger
Hi, if I read the code correctly, the colr atom is only written in the mov muxer if the flag write_colr is specified. Was that behaviour chosen to have better backward compatibility or is there another reason not to write this standard atom by default? Thanks and best regards, Robert ___

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 02:15:30PM +0100, Hendrik Leppkes wrote: > On Fri, Feb 20, 2015 at 1:38 PM, Michael Niedermayer wrote: > > On Fri, Feb 20, 2015 at 12:55:14PM +0100, Hendrik Leppkes wrote: > >> --- > >> libavformat/hlsenc.c | 6 +- > >> 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 12:35:59PM +, Kevin Wheatley wrote: > Please excuse my newbie knowledge of the code base BTW... > > I've just done a simple test > > ffmpeg -color_range mpeg -i test_charts/test_encoding.tif -c dnxhd -vb > 115M /quicktimes/ffmpeg_test.mov > > During this the vos_data

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Hendrik Leppkes
On Fri, Feb 20, 2015 at 1:38 PM, Michael Niedermayer wrote: > On Fri, Feb 20, 2015 at 12:55:14PM +0100, Hendrik Leppkes wrote: >> --- >> libavformat/hlsenc.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index 1831c

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 12:55:14PM +0100, Hendrik Leppkes wrote: > --- > libavformat/hlsenc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 1831c17..0f14e90 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Kevin Wheatley
Please excuse my newbie knowledge of the code base BTW... I've just done a simple test ffmpeg -color_range mpeg -i test_charts/test_encoding.tif -c dnxhd -vb 115M /quicktimes/ffmpeg_test.mov During this the vos_data contains... 00 00 02 80 01 01 80 A0 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Re: [FFmpeg-devel] [PATCH 1/2] hlsenc: remove the AVIOContext for the playlist from the muxer context

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 12:55:13PM +0100, Hendrik Leppkes wrote: > Its only used in one function, having it in the context serves no purpose. > --- > libavformat/hlsenc.c | 28 +--- > 1 file changed, 13 insertions(+), 15 deletions(-) applied thanks [...] -- Michael

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Ronald S. Bultje
Hi, On Fri, Feb 20, 2015 at 6:56 AM, Kevin Wheatley wrote: > On Fri, Feb 20, 2015 at 11:44 AM, Michael Niedermayer > wrote: > > If you start with a existing movie and copy the packets one by one > > there is no decoder and no encoder, so no dnxencoder structure > > > > if you want to put some v

[FFmpeg-devel] [PATCH 1/2] hlsenc: remove the AVIOContext for the playlist from the muxer context

2015-02-20 Thread Hendrik Leppkes
Its only used in one function, having it in the context serves no purpose. --- libavformat/hlsenc.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 29bf30e..1831c17 100644 --- a/libavformat/hlsenc.

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Kevin Wheatley
On Fri, Feb 20, 2015 at 11:44 AM, Michael Niedermayer wrote: > If you start with a existing movie and copy the packets one by one > there is no decoder and no encoder, so no dnxencoder structure > > if you want to put some value in the avid atom which are stored in the > bitstream/packets of dnxhd

[FFmpeg-devel] [PATCH 2/2] hlsenc: write playlist into a temp file and replace the original atomically

2015-02-20 Thread Hendrik Leppkes
--- libavformat/hlsenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1831c17..0f14e90 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -242,10 +242,12 @@ static int hls_window(AVFormatContext *s, int last

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-20 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 07:57:05AM +, Kevin Wheatley wrote: > > > Sent on the go... > > > On 19 Feb 2015, at 18:35, Michael Niedermayer wrote: > > > > theres no encoder, the data could instead come from another mov > > file or a binary encoder used by some user application with > > libavfo

Re: [FFmpeg-devel] [PATCH] avformat: Outputting DNxHD into .mov containers 'corrupts' following atoms until end of stsd

2015-02-20 Thread Michael Niedermayer
On Mon, Feb 16, 2015 at 10:49:52AM +, Kevin Wheatley wrote: > ffmpeg and qtdump could not decode pasp/colr atoms in the files made by > ffmpeg, > when outputting DNxHD due to the incorrect padding placement. Now we add the > padding in the correct place, we also always add padding for Final Cu