Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix frame mem leak

2015-04-14 Thread Ivan Efimov
2015-04-10 17:28 GMT+03:00 Ivan Efimov ioefi...@gmail.com: Signed-off-by: Ivan Efimov ioefi...@gmail.com --- This fixes memory leak in drawtext in case of textfile load error libavfilter/vf_drawtext.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] NVENC HEVC Profile Settings Errors

2015-04-14 Thread Timo Rothenpieler
When setting level of HEVC in NVENC, FFmpeg gives error: root@encoder:~# /opt/ffmpeghw/bin/ffmpeg -i /root/bunny.mp4 -aspect 16:9 -s 3840x2160 -vcodec nvenc_h265 -preset hp -fflags +genpts -vb 25000k - minrate 25000k -maxrate 25000k -bufsize 75000k -muxrate 25000k -r 50 -an -flush_packets 0

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: use av_malloc(z)_array()

2015-04-14 Thread Thilo Borgmann
Am 13.04.15 um 21:44 schrieb Michael Niedermayer: On Mon, Apr 13, 2015 at 06:49:04PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/alsdec.c | 61 ++--- 1 file changed, 30 insertions(+), 31 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] webdashenc: Add failure check for av_malloc.

2015-04-14 Thread wm4
On Mon, 13 Apr 2015 12:16:31 -0700 Vignesh Venkatasubramanian vigne...@google.com wrote: Add a missing failure check for av_malloc call. Signed-off-by: Vignesh Venkatasubramanian vigne...@google.com --- libavformat/webmdashenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the second revision of this patch, made after some

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
The images will be retained for 356 days according to the formula left on the website. As long as it's guaranteed its better than anything else I've used, and it doesn't touch the images so you can replicate the results. Nevertheless, here's a backup of them just in case: Original:

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix frame mem leak

2015-04-14 Thread Michael Niedermayer
On Fri, Apr 10, 2015 at 05:28:45PM +0300, Ivan Efimov wrote: Signed-off-by: Ivan Efimov ioefi...@gmail.com --- This fixes memory leak in drawtext in case of textfile load error libavfilter/vf_drawtext.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) applied thanks [...]

Re: [FFmpeg-devel] [PATCH] Check for not synchronized packets (very small feed file, very slow client connection)

2015-04-14 Thread Milan Matejec
Hi, sorry but that doesn't make sense. FFM is internal exchange format and temporary feed file in this format is created every time ffserver is started so why keep backward compatibility? Also adding checks for it would create needless amount of code in it. Thanks. M. 2015-04-14 1:10 GMT+02:00

Re: [FFmpeg-devel] [PATCH] Check for not synchronized packets (very small feed file, very slow client connection)

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:36:37PM +0200, Milan Matejec wrote: Hi, sorry but that doesn't make sense. FFM is internal exchange format and temporary feed file in this format is created every time ffserver is started so why keep backward compatibility? Also adding checks for it would create

Re: [FFmpeg-devel] [PATCH 2/2] webmdashenc: Fix potential leak in realloc

2015-04-14 Thread Michael Niedermayer
On Mon, Apr 13, 2015 at 01:58:30PM -0700, Vignesh Venkatasubramanian wrote: On Mon, Apr 13, 2015 at 12:48 PM, Michael Niedermayer michae...@gmx.at wrote: On Mon, Apr 13, 2015 at 12:16:44PM -0700, Vignesh Venkatasubramanian wrote: Fix potential leak in av_realloc call where the output was

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: use av_malloc(z)_array()

2015-04-14 Thread Paul B Mahol
On 4/14/15, Thilo Borgmann thilo.borgm...@mail.de wrote: Am 13.04.15 um 21:44 schrieb Michael Niedermayer: On Mon, Apr 13, 2015 at 06:49:04PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/alsdec.c | 61

Re: [FFmpeg-devel] NVENC HEVC Profile Settings Errors

2015-04-14 Thread Scott Leno
On Tue, Apr 14, 2015 at 8:49 AM, Ali KIZIL aliki...@gmail.com wrote: Timo Rothenpieler timo at rothenpieler.org writes: When setting level of HEVC in NVENC, FFmpeg gives error: root at encoder:~# /opt/ffmpeghw/bin/ffmpeg -i /root/bunny.mp4 - aspect 16:9 -s 3840x2160 -vcodec

Re: [FFmpeg-devel] NVENC HEVC Profile Settings Errors

2015-04-14 Thread Timo Rothenpieler
Yes, agree. Maybe a fix to give info massage that NVENC does not support levels 1, 2, 2.1, 3, 3.1, 4, 4.1, 5, 5.1, 5.2, 6 in HEVC ? There is no documented information about what levels it supports, it also likely depends on other settings. So ffmpeg just offers all of them. I think this

Re: [FFmpeg-devel] [PATCH 1/2] webdashenc: Add failure check for av_malloc.

2015-04-14 Thread wm4
On Tue, 14 Apr 2015 10:29:33 -0700 Vignesh Venkatasubramanian vigne...@google.com wrote: Add a missing failure check for av_malloc call. Signed-off-by: Vignesh Venkatasubramanian vigne...@google.com --- libavformat/webmdashenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:42:21PM -0300, Claudio Freire wrote: On Tue, Apr 14, 2015 at 6:10 AM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: This commit implements the perceptual noise substitution AAC extension. This is

Re: [FFmpeg-devel] [PATCH v2 3/3] [GSoC] [AAC] aacdec: Use macros for constants

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:36:48PM -0300, Claudio Freire wrote: LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 03:01:00PM +0200, Wiebe Cazemier wrote: - Original Message - From: Wiebe Cazemier wi...@halfgaar.net To: Michael Niedermayer michae...@gmx.at Cc: FFmpeg development discussions and patches ffmpeg-devel@ffmpeg.org, madshi mad...@gmail.com Sent: Monday, 6

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Mon, Apr 13, 2015 at 8:33 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the second revision of this patch, made after

Re: [FFmpeg-devel] [PATCH v2 3/3] [GSoC] [AAC] aacdec: Use macros for constants

2015-04-14 Thread Claudio Freire
LGTM On Mon, Apr 13, 2015 at 8:33 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit replaces the previous hardcoded constants with both new and previously defined macros from aac.h. This change makes it easy for anyone reading the code to know how encoding and decoding

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Tue, Apr 14, 2015 at 6:10 AM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-04-14 Thread Kieran Kunhya
On 14 April 2015 at 14:01, Wiebe Cazemier wi...@halfgaar.net wrote: - Original Message - From: Wiebe Cazemier wi...@halfgaar.net To: Michael Niedermayer michae...@gmx.at Cc: FFmpeg development discussions and patches ffmpeg-devel@ffmpeg.org, madshi mad...@gmail.com Sent: Monday, 6

[FFmpeg-devel] [PATCH v3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution for AAC

2015-04-14 Thread Rostislav Pehlivanov
This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the third revision of this patch, made after some problems were noted out. Any changes made since the previous revisions have been

[FFmpeg-devel] Question regarding inter-filter communication

2015-04-14 Thread Bahram Dahi
This is my first email to the list and I apologize in advance if I'm breaking some sort of rule by doing a mass email. I am developing a couple of specialized filters for ffmpeg, where the first filter would find some regions of interest (ROIs) on some frames and the second filter (if present in

Re: [FFmpeg-devel] ffmpeg latest git - rewrapping (codec copy) breaks container fps/tbr values

2015-04-14 Thread David Favor
Michael Niedermayer wrote: On Mon, Apr 13, 2015 at 04:36:18PM -0500, David Favor wrote: David Favor wrote: David Favor wrote: The following command: ffmpeg -i clip.mts -c:v copy -c:a copy clip.mp4 (or clip.mov) seems to incorrectly write container values for fps + tbr which causes

Re: [FFmpeg-devel] [PATCH 1/2] webdashenc: replace unchecked av_malloc with stack allocation

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 10:54:23AM -0700, Vignesh Venkatasubramanian wrote: Replace an unchecked av_malloc call with stack allocation as the size is always a constant. Signed-off-by: Vignesh Venkatasubramanian vigne...@google.com --- libavformat/webmdashenc.c | 3 +-- 1 file changed, 1

[FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-14 Thread wm4
For consistency. This masked another bug before. --- libavformat/mp3dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index c48f1f1..e157a1a 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -432,7

[FFmpeg-devel] [PATCH 4/5] avformat/mp3dec: offset seek index to end of vbr headers

2015-04-14 Thread wm4
--- libavformat/mp3dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index d2498a0..c48f1f1 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -334,6 +334,7 @@ static int mp3_read_header(AVFormatContext *s) AVStream *st;

[FFmpeg-devel] [PATCH 2/5] lavc: use correct type for printf() argument

2015-04-14 Thread wm4
This was passing uint32_t for %d. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index d2b8631..fe435fd 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2600,7 +2600,7 @@ int attribute_align_arg

[FFmpeg-devel] [PATCH 3/5] Revert avformat/mp3dec: offset seek index to end of id3v2 tag

2015-04-14 Thread wm4
This reverts commit 8b76c0eb561b0313e2a27950fe9d2bc5e4780dd8. It was slightly incorrect; the next commit fixes it. --- libavformat/mp3dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 161f27d..d2498a0 100644 ---

[FFmpeg-devel] [PATCH 1/5] avformat, avcodec: log discard padding

2015-04-14 Thread wm4
Useful for debugging. --- libavcodec/utils.c | 4 ++-- libavformat/utils.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 99f254b..d2b8631 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2549,9 +2549,9 @@ int

[FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-14 Thread wm4
Seeking was slightly broken. The 4th patch seems to fix this (everything else is noise). Note that ffmpeg can't correctly implement mp3 gapless audio if seeking is used. The xing toc is not precise enough. The only way to fix it is to do a full scan on the mp3 to index each frame (which in turn

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 04:03:40AM +0300, Ludmila Glinskih wrote: This is a simple test for the FLAC codec. It generates an increasing tone, encodes it, decodes it back and compares with the original one byte-by-byte. --- configure| 2 + doc/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH 1/5] avformat, avcodec: log discard padding

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 09:24:33PM +0200, wm4 wrote: Useful for debugging. --- libavcodec/utils.c | 4 ++-- libavformat/utils.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 2/5] lavc: use correct type for printf() argument

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 09:24:34PM +0200, wm4 wrote: This was passing uint32_t for %d. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
Uhh, can't replicate bug here (freshly built ffmpeg, just applied this patch only), (md5 for file = 473edd68b91123c3a9c1825271012357). tried other files and they encode and play fine. Spectrum also looks fine. I also tested other random files out of the samples and they all seem file. Know of any

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread wm4
On Tue, 14 Apr 2015 04:03:40 +0300 Ludmila Glinskih lglins...@gmail.com wrote: This is a simple test for the FLAC codec. It generates an increasing tone, encodes it, decodes it back and compares with the original one byte-by-byte. --- configure| 2 + doc/Makefile

Re: [FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 09:24:32PM +0200, wm4 wrote: Seeking was slightly broken. The 4th patch seems to fix this (everything else is noise). Note that ffmpeg can't correctly implement mp3 gapless audio if seeking is used. The xing toc is not precise enough. The only way to fix it is to do

[FFmpeg-devel] [PATCH] avformat/utils: Preserve packet duration when parsing is done only for headers

2015-04-14 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/utils.c |2 +- tests/ref/fate/mkv | 144 ++-- tests/ref/fate/vp8-alpha | 240 +++--- 3 files changed, 193 insertions(+), 193 deletions(-) diff

Re: [FFmpeg-devel] NVENC HEVC Profile Settings Errors

2015-04-14 Thread Ali KIZIL
Timo Rothenpieler timo at rothenpieler.org writes: When setting level of HEVC in NVENC, FFmpeg gives error: root at encoder:~# /opt/ffmpeghw/bin/ffmpeg -i /root/bunny.mp4 - aspect 16:9 -s 3840x2160 -vcodec nvenc_h265 -preset hp -fflags +genpts -vb 25000k - minrate 25000k -maxrate

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Paul B Mahol
On 4/14/15, Rostislav Pehlivanov atomnu...@gmail.com wrote: The images will be retained for 356 days according to the formula left on the website. As long as it's guaranteed its better than anything else I've used, and it doesn't touch the images so you can replicate the results.

Re: [FFmpeg-devel] NVENC HEVC Profile Settings Errors

2015-04-14 Thread Ali KIZIL
Timo Rothenpieler timo at rothenpieler.org writes: When setting level of HEVC in NVENC, FFmpeg gives error: root at encoder:~# /opt/ffmpeghw/bin/ffmpeg -i /root/bunny.mp4 - aspect 16:9 -s 3840x2160 -vcodec nvenc_h265 -preset hp -fflags +genpts -vb 25000k - minrate 25000k -maxrate

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-04-14 Thread Wiebe Cazemier
- Original Message - From: Wiebe Cazemier wi...@halfgaar.net To: Michael Niedermayer michae...@gmx.at Cc: FFmpeg development discussions and patches ffmpeg-devel@ffmpeg.org, madshi mad...@gmail.com Sent: Monday, 6 April, 2015 7:25:16 AM Subject: Re: [FFmpeg-devel] [PATCH] Dolby

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Tue, Apr 14, 2015 at 4:52 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: Uhh, can't replicate bug here (freshly built ffmpeg, just applied this patch only), (md5 for file = 473edd68b91123c3a9c1825271012357). tried other files and they encode and play fine. Spectrum also looks fine. I

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 09:24:37PM +0200, wm4 wrote: For consistency. This masked another bug before. --- libavformat/mp3dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) this breaks seeking in CBR files with a xing toc see: https://trac.ffmpeg.org/ticket/2590 for

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
You're right. Unfortunately letting the sf_idx be clipped to the minscale (+SCALE_MAX_DIFF) causes clipped noise values to be reported by the decoder. Seems like that magic number 4 you suggested might need to be adjusted after all. I also tried testing to see if advancing the minscaler based off

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread Ludmila Glinskih
Hi, Thanks for you comments! +static int generate_raw_frame(uint16_t *frame_data, int i, int sample_rate, + int channels, int frame_size) +{ +double t, tincr, tincr2; +int j, k; + +t = 0.0; +tincr = 2 * M_PI * 440.0 / sample_rate; +

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
Nevermind, I failed to read your suggestion to just use a separate minscaler for noise sf_idx. On 15 April 2015 at 00:05, Rostislav Pehlivanov atomnu...@gmail.com wrote: You're right. Unfortunately letting the sf_idx be clipped to the minscale (+SCALE_MAX_DIFF) causes clipped noise values to