Re: [FFmpeg-devel] [libav-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

On Sat, Apr 18, 2015 at 01:59:53PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 04:40, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 12:55:08AM +0200, Andreas Cadhalpun wrote: The problem is that minath is not the minimum, only close: minath = ath(3410, ATH_ADD) = -5.24237967

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

On 18.04.2015 03:54, Luca Barbato wrote: if thr is really tiny norm_fac would be huge, not tiny. (or tiny and not huge depending if you look it before or after norm_fac = 1/norm_fac) That depends. If band-thr is 0 this more or less means band-energy is 0 (band-thr is set to 'band-energy *

[FFmpeg-devel] [PATCH] avutil/mips/generic_macros_msa: volatile doesnt need __

Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavutil/mips/generic_macros_msa.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/mips/generic_macros_msa.h b/libavutil/mips/generic_macros_msa.h index d2fd87c..374382f 100644 ---

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

On 18.04.2015 04:40, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 12:55:08AM +0200, Andreas Cadhalpun wrote: The problem is that minath is not the minimum, only close: minath = ath(3410, ATH_ADD) = -5.24237967 ath(3407, ATH_ADD) = -5.24241638 the exact location of the

Re: [FFmpeg-devel] [PATCH 1/3] aaccoder: use put_sbits()

On 18/04/15 7:06 AM, Michael Niedermayer wrote: On Fri, Apr 17, 2015 at 11:29:42PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/aaccoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks Pushed the three oked so far.

[FFmpeg-devel] [PATCH] alsdec: limit avctx-bits_per_raw_sample to 32

avctx-bits_per_raw_sample is used in get_sbits_long, which only supports up to 32 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/alsdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index

[FFmpeg-devel] [PATCH] alsdec: ensure channel reordering is reversible

If the same idx is used for more than one i, at least one entry in sconf-chan_pos remains uninitialized. This can cause segmentation faults. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/alsdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] Usecases of the AVIODir* API

On Sat, Apr 18, 2015 at 04:44:35AM +0200, Mariusz Szczepańczyk wrote: On Wed, Apr 8, 2015 at 8:15 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 08, 2015 at 07:58:19PM +0200, Mariusz Szczepańczyk wrote: On Wed, Apr 8, 2015 at 6:33 PM, Michael Niedermayer michae...@gmx.at

[FFmpeg-devel] [PATCH] alsdec: validate time diff index

If begin is smaller than t, the subtraction 'begin -= t' wraps around, because begin is unsigned. The same applies for end t. This causes segmentation faults. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/alsdec.c | 8 1 file changed, 8 insertions(+)

Re: [FFmpeg-devel] [PATCH] alsdec: ensure channel reordering is reversible

On Sat, Apr 18, 2015 at 06:31:36PM +0200, Andreas Cadhalpun wrote: If the same idx is used for more than one i, at least one entry in sconf-chan_pos remains uninitialized. This can cause segmentation faults. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com applied thanks

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On 18.04.2015 20:05, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 06:58:30PM +0200, Andreas Cadhalpun wrote: If begin is smaller than t, the subtraction 'begin -= t' wraps around, because begin is unsigned. The same applies for end t. This causes segmentation faults. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:05, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 06:58:30PM +0200, Andreas Cadhalpun wrote: If begin is smaller than t, the subtraction 'begin -= t' wraps around, because begin is unsigned. The same

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 08:47:08PM +0200, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:42:58PM +0200, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:05, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 06:58:30PM

[FFmpeg-devel] Help in understanding seeking behaviour of FFmpeg API on MP4 video with hint tracks

Hi I need help understanding the internals of FFmpeg API seek call with certain files. Im using the ffmpeg libav* API in an appliaction that reduces the bitrate of MP4 files. The output MP4 file has 1 H264 video and 1 AAC audio track. The application supports seeking on the input file to a

Re: [FFmpeg-devel] [PATCH 3/3] wavpackenc: use put_sbits()

On Fri, Apr 17, 2015 at 11:29:44PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/wavpackenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] alsdec: limit avctx-bits_per_raw_sample to 32

On Sat, Apr 18, 2015 at 08:29:13PM +0200, Andreas Cadhalpun wrote: avctx-bits_per_raw_sample is used in get_sbits_long, which only supports up to 32 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/alsdec.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On 18.04.2015 20:42, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: @@ -1290,8 +1290,16 @@ static int revert_channel_correlation(ALSDecContext *ctx, ALSBlockData *bd, if (ch[dep].time_diff_sign) { t = -t; +

Re: [FFmpeg-devel] [PATCH 1/2] dca_xll: use av_clip_intp2()

On 18/04/15 7:14 AM, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 03:44:10AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/dca_xll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thanks Patchset pushed.

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 06:58:30PM +0200, Andreas Cadhalpun wrote: If begin is smaller than t, the subtraction 'begin -= t' wraps around, because begin is unsigned. The same applies for end t. This causes segmentation faults. Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 08:42:58PM +0200, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:05, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 06:58:30PM +0200, Andreas Cadhalpun wrote: If begin is smaller than t, the

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 09:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:42, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: @@ -1290,8 +1290,16 @@ static int revert_channel_correlation(ALSDecContext *ctx, ALSBlockData *bd,

[FFmpeg-devel] LFEScaleIndex larger than 127 is not implemented

Hello Ffmpeg-devel, Just uploaded LFEScaleIndex-larger-than-127-is-not-implemented-example.dts то ftp://upload.ffmpeg.org/incoming/ Got this log during DTS decoding: [dca @ 003b89c0] LFEScaleIndex larger than 127 is not implemented. Update your FFmpeg version to the newest one from

[FFmpeg-devel] [PATCH] avfilter/vf_colorkey: Add colorkey video filter

--- Changelog | 1 + MAINTAINERS | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorkey.c | 226 ++ 5 files changed, 230 insertions(+) create mode 100644

Re: [FFmpeg-devel] [libav-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

On 18.04.2015 21:46, Luca Barbato wrote: On 18/04/15 13:50, Andreas Cadhalpun wrote: Here you can still have 0/0. I know, once you get a 0 you get completely out of the previous loop and you do not even enter in the other. To sum up the problem, a way to tackle it is to calculate the

Re: [FFmpeg-devel] [libav-devel] [PATCH] alsdec: validate time diff index

On 18.04.2015 21:55, Luca Barbato wrote: On 18/04/15 18:58, Andreas Cadhalpun wrote: If begin is smaller than t, the subtraction 'begin -= t' wraps around, because begin is unsigned. The same applies for end t. Why that variable is unsigned? Probably because it should never be negative.

Re: [FFmpeg-devel] LFEScaleIndex larger than 127 is not implemented

On Sat, Apr 18, 2015 at 09:35:09AM +0300, Eugene Myronchuk wrote: Hello Ffmpeg-devel, Just uploaded LFEScaleIndex-larger-than-127-is-not-implemented-example.dts то ftp://upload.ffmpeg.org/incoming/ Got this log during DTS decoding: [dca @ 003b89c0] LFEScaleIndex larger than

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On 18.04.2015 23:34, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 10:28:53PM +0200, Andreas Cadhalpun wrote: I don't think an assert would be good here. If you want to protect against future code changes, I would rather leave the error return. But I'd also be fine with dropping this

Re: [FFmpeg-devel] [PATCH] alsdec: limit avctx-bits_per_raw_sample to 32

Am 18.04.15 um 21:11 schrieb Michael Niedermayer: On Sat, Apr 18, 2015 at 08:29:13PM +0200, Andreas Cadhalpun wrote: avctx-bits_per_raw_sample is used in get_sbits_long, which only supports up to 32 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com ---

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sat, Apr 18, 2015 at 10:28:53PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 21:46, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 09:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:42, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorkey: Add colorkey video filter

On Sat, Apr 18, 2015 at 1:30 PM Timo Rothenpieler t...@rothenpieler.org wrote: --- Changelog | 1 + MAINTAINERS | 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorkey.c | 226

Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorkey: Add colorkey video filter

What does this do? (Don't answer me in email, but write in in doc/filters.texi.) Just noticed that git entirely removed my comments. This is not (yet) for merging, but primarily a request for comments on the implementation. I'm sure this can be easily optimized quite a bit and also cleaned up

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On Sun, Apr 19, 2015 at 12:20:01AM +0200, Andreas Cadhalpun wrote: On 18.04.2015 23:34, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 10:28:53PM +0200, Andreas Cadhalpun wrote: I don't think an assert would be good here. If you want to protect against future code changes, I would

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

On Thu, Apr 16, 2015 at 6:19 PM, Debargha Mukherjee debar...@google.com wrote: Resolutions inline... From d84e140ed83bdc3889720e4a6af330198176b839 Mon Sep 17 00:00:00 2001 From: Deb Mukherjee debar...@google.com Date: Wed, 25 Mar 2015 17:10:16 -0700 Subject: [PATCH] Support for VP9

Re: [FFmpeg-devel] [PATCH] alsdec: ensure channel reordering is reversible

Am 18.04.15 um 19:12 schrieb Michael Niedermayer: On Sat, Apr 18, 2015 at 06:31:36PM +0200, Andreas Cadhalpun wrote: If the same idx is used for more than one i, at least one entry in sconf-chan_pos remains uninitialized. This can cause segmentation faults. Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] alsdec: validate time diff index

On 18.04.2015 21:46, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 09:13:30PM +0200, Andreas Cadhalpun wrote: On 18.04.2015 20:42, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:13:30PM +0200, Andreas Cadhalpun wrote: @@ -1290,8 +1290,16 @@ static int

Re: [FFmpeg-devel] LFEScaleIndex larger than 127 is not implemented

On Saturday 18 April 2015 08:35:09 am Eugene Myronchuk wrote: Just uploaded LFEScaleIndex-larger-than-127-is-not-implemented-example.dts I created ticket #4492, thank you for the sample! Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] cmdutils: indent protocols listing

For readability. Signed-off-by: Lou Logan l...@lrcd.com --- cmdutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index e4e3bac..7126ce8 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1535,10 +1535,10 @@ int show_protocols(void *optctx, const

[FFmpeg-devel] [PATCH] avutil: remove pointless bmi1 define

Signed-off-by: James Almer jamr...@gmail.com --- libavutil/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 1617464..765577d 100644 --- a/libavutil/cpu.c +++ b/libavutil/cpu.c @@ -115,8 +115,7 @@ int av_parse_cpu_flags(const

Re: [FFmpeg-devel] [PATCH] cmdutils: indent protocols listing

On Sat, Apr 18, 2015 at 02:31:23PM -0800, Lou Logan wrote: For readability. Signed-off-by: Lou Logan l...@lrcd.com --- cmdutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] avutil: remove pointless bmi1 define

On 18/04/15 9:35 PM, Michael Niedermayer wrote: On Sat, Apr 18, 2015 at 08:14:12PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavutil/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) LGTM thanks Pushed.

Re: [FFmpeg-devel] [PATCH] avutil: remove pointless bmi1 define

On Sat, Apr 18, 2015 at 08:14:12PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavutil/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting

[FFmpeg-devel] [PATCH] proresenc_anatoliy: use put_sbits()

Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/proresenc_anatoliy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index bf6e671..cc98c66 100644 --- a/libavcodec/proresenc_anatoliy.c +++

[FFmpeg-devel] [PATCH 1/2] dca_xll: use av_clip_intp2()

Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/dca_xll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c index 9e1085c..98fd4c8 100644 --- a/libavcodec/dca_xll.c +++ b/libavcodec/dca_xll.c @@ -393,7 +393,7 @@ static

[FFmpeg-devel] [PATCH 2/2] adpcm: use av_clip_intp2()

Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/adpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 1c3fdc4..56d1660 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1498,7 +1498,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/3] aaccoder: use put_sbits()

On Fri, Apr 17, 2015 at 11:29:42PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/aaccoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 2/3] dcaenc: use put_sbits()

On Fri, Apr 17, 2015 at 11:29:43PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/dcaenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The

Re: [FFmpeg-devel] [PATCH 1/2] dca_xll: use av_clip_intp2()

On Sat, Apr 18, 2015 at 03:44:10AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/dca_xll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many

Re: [FFmpeg-devel] [PATCH 2/2] adpcm: use av_clip_intp2()

On Sat, Apr 18, 2015 at 03:44:11AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/adpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real

Re: [FFmpeg-devel] [PATCH] proresenc_anatoliy: use put_sbits()

On Sat, Apr 18, 2015 at 04:33:56AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/proresenc_anatoliy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: