Re: [FFmpeg-devel] [libav-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Andreas Cadhalpun
On 28.06.2015 13:13, Ronald S. Bultje wrote: On Sun, Jun 28, 2015 at 5:28 AM, Andreas Cadhalpun Treating one like an error, but not the other seems strange as well. One could add an explode mode for both. Would that be better? In the first case, it's an error. If the frame size is 2 bits,

Re: [FFmpeg-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Andreas Cadhalpun
On 27.06.2015 23:01, Michael Niedermayer wrote: On Sat, Jun 27, 2015 at 08:36:15PM +0200, Andreas Cadhalpun wrote: Claiming to have decoded more bytes than the packet size is wrong. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wmavoice.c | 4 ++-- 1 file

Re: [FFmpeg-devel] [PATCH] wavpack: use get_bits_long to read up to 32 bits

2015-06-28 Thread Andreas Cadhalpun
On 27.06.2015 23:27, Paul B Mahol wrote: On 6/27/15, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: get_bits should not be used for more than 25 bits. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/wavpack.c | 4 ++-- 1 file changed, 2

Re: [FFmpeg-devel] [libav-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Ronald S. Bultje
Hi, On Sun, Jun 28, 2015 at 5:28 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 27.06.2015 23:01, Michael Niedermayer wrote: On Sat, Jun 27, 2015 at 08:36:15PM +0200, Andreas Cadhalpun wrote: Claiming to have decoded more bytes than the packet size is wrong.

Re: [FFmpeg-devel] [PATCH] huffyuvdec: validate image size

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 11:23:12AM +0200, Andreas Cadhalpun wrote: On 27.06.2015 22:40, Michael Niedermayer wrote: On Sat, Jun 27, 2015 at 07:42:48PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/huffyuvdec.c | 6 ++

Re: [FFmpeg-devel] [PATCH] api-h264-test: build with another api test

2015-06-28 Thread Ronald S. Bultje
On Sat, Jun 27, 2015 at 6:50 PM, Ludmila Glinskih lglins...@gmail.com wrote: Location of api-h264-test changed to special directory for api tests. --- libavformat/Makefile| 1 - libavformat/api-h264-test.c | 183 tests/api/Makefile

Re: [FFmpeg-devel] [PATCH 06/11] aacpsy: Add energy spread for each band

2015-06-28 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 10:12:18PM -0300, Claudio Freire wrote: LGTM applied thanks On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: -float distortion; -float perceptual_weight; Those are in fact in disuse. Thought I'd clarify.

Re: [FFmpeg-devel] [PATCH] huffyuvdec: validate image size

2015-06-28 Thread Andreas Cadhalpun
On 28.06.2015 14:17, Michael Niedermayer wrote: On Sun, Jun 28, 2015 at 11:23:12AM +0200, Andreas Cadhalpun wrote: huffyuvdec.c |5 + 1 file changed, 5 insertions(+) bc13fbe9569565b84fde3c4757c64f3f391a4f9b 0001-huffyuvdec-validate-image-size.patch From

Re: [FFmpeg-devel] [libav-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 01:39:41PM +0200, Andreas Cadhalpun wrote: On 28.06.2015 13:13, Ronald S. Bultje wrote: On Sun, Jun 28, 2015 at 5:28 AM, Andreas Cadhalpun Treating one like an error, but not the other seems strange as well. One could add an explode mode for both. Would that be

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr vf_ssim: abort filtering when shortest video ends

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Paul B Mahol a écrit : Can Nicolas comment too? I'm not really sure why just 'shortest' is not needed. I suspect it might be a bug in the options mapping between dualinput and framesync. if (s-shortest) in[0].after = in[1].after = EXT_STOP; if

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 04:32:58 pm wm4 wrote: Surely you know, as it has been severe enough that you got MiNi to block the new demuxer and not only keep the old demuxer, but to leave it as default. I don't understand this sentence. (Except for the insult.) But please allow me to repeat my

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : But please allow me to repeat my question: Why do think the new demuxer should be used? What sample does it fix? Why do you think it should NOT be used? Regards, -- Nicolas George signature.asc Description: Digital

Re: [FFmpeg-devel] [PATCH] lavc/adpcm: THP: set approx_nb_samples correctly

2015-06-28 Thread Michael Niedermayer
On Wed, Jun 24, 2015 at 07:58:15AM -0500, Rodger Combs wrote: --- libavcodec/adpcm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 Used only once

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr vf_ssim: abort filtering when shortest video ends

2015-06-28 Thread Michael Niedermayer
On Fri, Jun 26, 2015 at 08:23:36AM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/vf_psnr.c | 2 ++ libavfilter/vf_ssim.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr vf_ssim: abort filtering when shortest video ends

2015-06-28 Thread Paul B Mahol
On 6/28/15, Michael Niedermayer michae...@gmx.at wrote: On Fri, Jun 26, 2015 at 08:23:36AM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/vf_psnr.c | 2 ++ libavfilter/vf_ssim.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) LGTM thx

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 04:10:48 pm Paul B Mahol wrote: Hi, As you may already know new asf demuxer hit the tree but did not replace the old one. Do you know of a sample that gets fixed by the new demuxer? I was unable to find one;-( Here I ask for samples which show that one is better than

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread wm4
On Sun, 28 Jun 2015 16:46:12 +0200 Carl Eugen Hoyos ceho...@ag.or.at wrote: On Sunday 28 June 2015 04:42:30 pm Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : But please allow me to repeat my question: Why do think the new demuxer should be used? What

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 04:51:53 pm wm4 wrote: On Sun, 28 Jun 2015 16:46:12 +0200 Carl Eugen Hoyos ceho...@ag.or.at wrote: On Sunday 28 June 2015 04:42:30 pm Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : But please allow me to repeat my question:

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : This argument surprises me (very much)! Over the last four years, I had a completely different impression. Shall I understand that, from you point of view, code merged from the libav side is always bad? Regards, -- Nicolas

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 05:14:38 pm Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : On Sunday 28 June 2015 04:54:02 pm Nicolas George wrote: Second, someone actually took efforts to do so, I take it as a sign that it was considered useful by someone

Re: [FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 05:47:51PM +0200, Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : This avoids the need to print such warning in all callers I believe this is a bad idea: the warning will be duplicated when callers already include them. we have

Re: [FFmpeg-devel] [PATCH] api-h264-test: build with another api test

2015-06-28 Thread Kieran Kunhya
So I have a more conceptual question, maybe Kieran can help answer this also. Why are these tests called api-$codec tests? I don't see anything flac/h264 specific in these tests so far, and they could basically be reused for any video (h264) or audio (flac) test (for audio: as long as there's

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread wm4
On Sun, 28 Jun 2015 16:30:43 +0200 Carl Eugen Hoyos ceho...@ag.or.at wrote: On Sunday 28 June 2015 04:10:48 pm Paul B Mahol wrote: Hi, As you may already know new asf demuxer hit the tree but did not replace the old one. Do you know of a sample that gets fixed by the new demuxer? I

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-28 Thread Paul B Mahol
On 6/28/15, Dave Rice d...@dericed.com wrote: Hi, On Jun 27, 2015, at 4:52 PM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 76 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 +

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 04:54:02 pm Nicolas George wrote: Second, someone actually took efforts to do so, I take it as a sign that it was considered useful by someone knowing the issue better than me. This argument surprises me (very much)! Over the last four years, I had a completely

Re: [FFmpeg-devel] [libav-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Andreas Cadhalpun
On 28.06.2015 16:26, Michael Niedermayer wrote: On Sun, Jun 28, 2015 at 01:39:41PM +0200, Andreas Cadhalpun wrote: On 28.06.2015 13:13, Ronald S. Bultje wrote: On Sun, Jun 28, 2015 at 5:28 AM, Andreas Cadhalpun Treating one like an error, but not the other seems strange as well. One could add

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-28 Thread Dave Rice
Hi, On Jun 27, 2015, at 4:52 PM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 76 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_drawgraph.c | 297

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Carl Eugen Hoyos
On Sunday 28 June 2015 04:42:30 pm Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : But please allow me to repeat my question: Why do think the new demuxer should be used? What sample does it fix? Why do you think it should NOT be used? The main reason

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : From a very quick look, the new code seems mostly unreviewed What makes you say that? Where did you give your very quick look exactly? Do you disagree? I do disagree, on several counts. First, the old muxer was based on

Re: [FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : This avoids the need to print such warning in all callers I believe this is a bad idea: the warning will be duplicated when callers already include them. There are low-level APIs that return an error and high-level APIs that print

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 04:54:02PM +0200, Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : From a very quick look, the new code seems mostly unreviewed What makes you say that? Where did you give your very quick look exactly? Do you disagree? I

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread James Almer
On 28/06/15 1:21 PM, Michael Niedermayer wrote: On Sun, Jun 28, 2015 at 04:54:02PM +0200, Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Carl Eugen Hoyos a écrit : From a very quick look, the new code seems mostly unreviewed What makes you say that? Where did you give your very

Re: [FFmpeg-devel] [libav-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Andreas Cadhalpun
On 28.06.2015 11:40, Luca Barbato wrote: On 28/06/15 11:28, Andreas Cadhalpun wrote: am i assuming correct that gb was read beyond its end ? That only happens in the second case, not in the first. if so this maybe should be treated as an error instead of cliping Treating one like an error,

Re: [FFmpeg-devel] GSoC update

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Stephan Holljes a écrit : Hi, attached patches are the current state of work. It's probably still a bit rough around the edges, but I think I made some progress. The sample code in doc/examples does not write any data as of yet, but the HTTP handshake

Re: [FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

2015-06-28 Thread wm4
On Sun, 28 Jun 2015 17:47:51 +0200 Nicolas George geo...@nsup.org wrote: Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : This avoids the need to print such warning in all callers I believe this is a bad idea: the warning will be duplicated when callers already include

Re: [FFmpeg-devel] [PATCH] api-h264-test: build with another api test

2015-06-28 Thread wm4
On Sun, 28 Jun 2015 17:46:48 +0100 Kieran Kunhya kier...@obe.tv wrote: So I have a more conceptual question, maybe Kieran can help answer this also. Why are these tests called api-$codec tests? I don't see anything flac/h264 specific in these tests so far, and they could basically be

[FFmpeg-devel] Regarding removal of encryption and crypto support from ffmpeg binary

2015-06-28 Thread Sanjay Jadhav
Hi Team, I am using ffmpeg.exe to convert video files from one format to another format. But due to the encryption algorithms present in ffmpeg.exe this exe cannot be used in some of the countries. Hence to remove the crypto and encryption support I am using below command to configure ffmpeg

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 03:07:00PM +, Paul B Mahol wrote: On 6/28/15, Dave Rice d...@dericed.com wrote: Hi, On Jun 27, 2015, at 4:52 PM, Paul B Mahol one...@gmail.com wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 76

[FFmpeg-devel] [PATCH] avfilter/dualinput: do not overwrite shortest setting from above lines

2015-06-28 Thread Paul B Mahol
From: Nicolas George geo...@nsup.org Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/dualinput.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/dualinput.c b/libavfilter/dualinput.c index 45f6810..37535d1 100644 --- a/libavfilter/dualinput.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/dualinput: do not overwrite shortest setting from above lines

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Paul B Mahol a écrit : From: Nicolas George geo...@nsup.org Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/dualinput.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) LGTM if tested, of course. I had no time to test (with the

Re: [FFmpeg-devel] [PATCH 04/11] aaccoder: add intensity stereo support to encode_window_bands_info quantizer

2015-06-28 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit adds support for both PNS and IS (intensity stereo) codebooks to the encode_window_bands_info() quantizer, used by the faast, faac and anmr non-default, native coders. This does not mean that both

Re: [FFmpeg-devel] [PATCH 04/11] aaccoder: add intensity stereo support to encode_window_bands_info quantizer

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 03:17:46PM -0300, Claudio Freire wrote: On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit adds support for both PNS and IS (intensity stereo) codebooks to the encode_window_bands_info() quantizer, used by the faast, faac and

Re: [FFmpeg-devel] [PATCH 03/11] aaccoder: add intensity stereo coding support for the trellis quantizer

2015-06-28 Thread Michael Niedermayer
On Sat, Jun 27, 2015 at 10:36:11PM -0300, Claudio Freire wrote: On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: +/* Energy spread threshold value below which no PNS is used, this corresponds to + * typically around 17Khz, after which PNS usage decays

Re: [FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

2015-06-28 Thread Nicolas George
Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : i understand that but taking the burden off the caller to print an error for memory allocation failures seemed overall to be the correct thing to do in this case if thats not wanted iam happy to drop this patch, it was just a

Re: [FFmpeg-devel] [PATCH 11/11] aaccoder: zero ms_mask bands on execution

2015-06-28 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: +memset(cpe-ms_mask, 0, sizeof(uint8_t)*128); sizeof(cpe-ms_mask) would be safer ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avutil/dict: Print warning in case av_dict_set() fails to allocate memory

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 06:54:50PM +0200, Nicolas George wrote: Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : i understand that but taking the burden off the caller to print an error for memory allocation failures seemed overall to be the correct thing to do in this case

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-28 Thread Dave Rice
On Jun 28, 2015, at 1:54 PM, Paul B Mahol one...@gmail.com wrote: On 6/28/15, Dave Rice d...@dericed.com wrote: On Jun 28, 2015, at 11:07 AM, Paul B Mahol one...@gmail.com wrote: On 6/28/15, Dave Rice d...@dericed.com wrote: Hi, On Jun 27, 2015, at 4:52 PM, Paul B Mahol

Re: [FFmpeg-devel] [PATCH] lavfi: add drawgraph filter

2015-06-28 Thread Paul B Mahol
On 6/28/15, Dave Rice d...@dericed.com wrote: On Jun 28, 2015, at 1:54 PM, Paul B Mahol one...@gmail.com wrote: On 6/28/15, Dave Rice d...@dericed.com wrote: On Jun 28, 2015, at 11:07 AM, Paul B Mahol one...@gmail.com wrote: On 6/28/15, Dave Rice d...@dericed.com wrote: Hi, On Jun 27,

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread Andreas Cadhalpun
Hi, On 28.06.2015 16:10, Paul B Mahol wrote: As you may already know new asf demuxer hit the tree but did not replace the old one. Here I ask for samples which show that one is better than another, whichever that one is. For starters, the new asf demuxer crashes, where the old one didn't:

Re: [FFmpeg-devel] [PATCH] api-h264-test: build with another api test

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 01:50:25AM +0300, Ludmila Glinskih wrote: Location of api-h264-test changed to special directory for api tests. --- libavformat/Makefile| 1 - libavformat/api-h264-test.c | 183 tests/api/Makefile | 1

Re: [FFmpeg-devel] [PATCH] fate/api-tests: Added dependency on $(FF_DEP_LIBS)

2015-06-28 Thread Michael Niedermayer
On Sun, Jun 28, 2015 at 11:47:19PM +0100, George Boyle wrote: This ensures they are built before the tests are run. --- tests/api/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

[FFmpeg-devel] [PATCH] fate/api-tests: Added dependency on $(FF_DEP_LIBS)

2015-06-28 Thread George Boyle
This ensures they are built before the tests are run. --- tests/api/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/api/Makefile b/tests/api/Makefile index 86c0cf2..9f82be2 100644 --- a/tests/api/Makefile +++ b/tests/api/Makefile @@ -9,7 +9,7 @@ $(APITESTOBJS):

Re: [FFmpeg-devel] New asf demuxer

2015-06-28 Thread compn
On Sun, 28 Jun 2015 16:51:53 +0200 wm4 nfx...@googlemail.com wrote: The new demuxer was written based on the official ASF spec, and was tested against a number of real world samples. i really dont care about the pissing contest in this thread. if someone wants to bench-test the new demuxer,

Re: [FFmpeg-devel] [PATCH 05/11] aacenc: add support for coding of intensity stereo scalefactor indices

2015-06-28 Thread Claudio Freire
Seems straightforward enough. LGTM. On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov atomnu...@gmail.com wrote: This commit adds support for the coding of intensity stereo scalefactor indices. It does not do any marking of such bands and as such does no functional changes to the