Re: [FFmpeg-devel] [PATCH] vp9: add fullpel (avg) SIMD for 10/12bpp.

2015-09-15 Thread James Almer
On 9/15/2015 9:24 PM, Ronald S. Bultje wrote: > --- > libavcodec/x86/vp9dsp_init_16bpp.c | 42 > ++ Why not just add all this to vp9dsp_init.c and selectively initialize everything by checking the existing bpp argument in ff_vp9dsp_init_x86()? If you think you

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: change fft left-right separation

2015-09-15 Thread Muhammad Faiz
On Mon, Sep 14, 2015 at 4:48 AM, Michael Niedermayer wrote: > also if you want to have git write access, send me your public > SSH key > no, i think it is not necessary for now thanks ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] configure: Print large lists in more columns if the screen size allows

2015-09-15 Thread Timothy Gu
On Mon, Sep 14, 2015 at 5:09 PM Ganesh Ajjanagadde wrote: > Shouldn't this function be renamed, since it no longer necessarily > prints in 3 columns? > Applied with that change. Timothy ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Voting committee

2015-09-15 Thread Yayoi Ukai
On Mon, Sep 14, 2015 at 10:20 AM, Nicolas George wrote: > L'octidi 28 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> Looks mostly good to me. One thing I think that should be clarified is >> the meaning of "linear combination" - I assume you meant a non-trivial >>

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-15 Thread James Almer
On 9/15/2015 1:29 PM, Carl Eugen Hoyos wrote: > James Almer gmail.com> writes: > >> On 9/12/2015 3:42 PM, Michael Niedermayer wrote: >>> I think theres consense about "abi compatibility" so i >>> would tend to suggest to move forward with that in mind. >> >> In that case we should go ahead and

[FFmpeg-devel] [PATCH] lavc/lavf: remove incompatible abi checks for the new 64bit fields

2015-09-15 Thread James Almer
Signed-off-by: James Almer --- All the casts to int64_t for these fields in assorted files can be removed in a separate patch. I left those out so this patch was clean and easier to read. libavcodec/avcodec.h| 12 libavcodec/options_table.h | 11

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ronald S. Bultje
Hi, On Tue, Sep 15, 2015 at 6:05 PM, Michael Niedermayer wrote: > On Tue, Sep 15, 2015 at 05:35:53PM -0400, Ganesh Ajjanagadde wrote: > > On Tue, Sep 15, 2015 at 3:03 PM, Michael Niedermayer > wrote: > > > On Tue, Sep 15, 2015 at 02:00:27PM -0400, Ganesh

[FFmpeg-devel] [PATCH] vp9: add fullpel (avg) SIMD for 10/12bpp.

2015-09-15 Thread Ronald S. Bultje
--- libavcodec/x86/vp9dsp_init_16bpp.c | 42 ++ libavcodec/x86/vp9mc.asm | 24 ++ 2 files changed, 58 insertions(+), 8 deletions(-) diff --git a/libavcodec/x86/vp9dsp_init_16bpp.c b/libavcodec/x86/vp9dsp_init_16bpp.c index

[FFmpeg-devel] [PATCH] vp9: add fullpel (put) MC SIMD for 10/12bpp.

2015-09-15 Thread Ronald S. Bultje
--- libavcodec/x86/Makefile| 3 +- libavcodec/x86/vp9dsp_init.c | 6 ++- libavcodec/x86/vp9dsp_init.h | 28 + libavcodec/x86/vp9dsp_init_16bpp.c | 85 ++ libavcodec/x86/vp9mc.asm | 18 +++- 5 files changed,

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 6:36 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Sep 15, 2015 at 6:05 PM, Michael Niedermayer > wrote: > >> On Tue, Sep 15, 2015 at 05:35:53PM -0400, Ganesh Ajjanagadde wrote: >> > On Tue, Sep 15, 2015 at 3:03 PM, Michael

Re: [FFmpeg-devel] [PATCH] configure: make assignment of variable to '=' explicit

2015-09-15 Thread Timothy Gu
On Sat, Sep 12, 2015 at 11:28 PM Ganesh Ajjanagadde wrote: > op== is confusing, as it may easily be mistook for an equality check, > while in reality it is doing an assigment to '='. > This patch has the additional benefit of cleaning up 2 warnings from > shellcheck.net.

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 05:35:53PM -0400, Ganesh Ajjanagadde wrote: > On Tue, Sep 15, 2015 at 3:03 PM, Michael Niedermayer wrote: > > On Tue, Sep 15, 2015 at 02:00:27PM -0400, Ganesh Ajjanagadde wrote: > >> On Tue, Sep 15, 2015 at 1:47 PM, Michael Niedermayer

Re: [FFmpeg-devel] IRC meeting summary for Outeachy Fundraising (Item No.5)

2015-09-15 Thread Yayoi Ukai
Hi Ngassa, On Sun, Sep 13, 2015 at 10:33 PM, Ngassa Finjap wrote: > Hi Yayoi, > > Thank you for writing a summary of the IRC Meeting which took place > yesterday regarding the upcoming Outreachy program. Yaaay! ^_^ [ Sadness > levels drop. ] I am glad to hear that. > >

[FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-15 Thread Claudio Freire
This patch refactors the AAC coders to reuse code between the MIPS port and the regular, portable C code. There were two main functions that had to use hand-optimized versions of quantization code: - search_for_quantizers_twoloop - codebook_trellis_rate Those two were split into their own

Re: [FFmpeg-devel] [PATCH]lavc/utils: Correctly show bit_rate>INT_MAX

2015-09-15 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > utils.c |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > 1208f300967a41eff112ec4caa35400b2f5e0149 patchbitrate.diff > > LGTM Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 02:00:27PM -0400, Ganesh Ajjanagadde wrote: > On Tue, Sep 15, 2015 at 1:47 PM, Michael Niedermayer wrote: > > On Tue, Sep 15, 2015 at 12:47:35PM -0400, Ganesh Ajjanagadde wrote: > >> On Tue, Sep 15, 2015 at 10:54 AM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avfilter/f_sendcmd: use the name 's' for the pointer to the private context

2015-09-15 Thread Ganesh Ajjanagadde
On Wed, Sep 9, 2015 at 2:30 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/f_sendcmd.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] checkasm: add vp9mc tests.

2015-09-15 Thread Ronald S. Bultje
--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/vp9mc.c| 105 ++ 4 files changed, 110 insertions(+) create mode 100644 tests/checkasm/vp9mc.c diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/f_sendcmd: use the name 's' for the pointer to the private context

2015-09-15 Thread Ronald S. Bultje
Hi, On Tue, Sep 15, 2015 at 12:59 PM, Ganesh Ajjanagadde wrote: > On Wed, Sep 9, 2015 at 2:30 PM, Ganesh Ajjanagadde > wrote: > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavfilter/f_sendcmd.c | 36

[FFmpeg-devel] [PATCH] checkasm: add vp9 MC tests.

2015-09-15 Thread Ronald S. Bultje
--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/vp9.c | 110 ++ 4 files changed, 115 insertions(+) create mode 100644 tests/checkasm/vp9.c diff --git

Re: [FFmpeg-devel] [PATCH] checkasm: add vp9 MC tests.

2015-09-15 Thread Henrik Gramner
On Tue, Sep 15, 2015 at 8:48 PM, Ronald S. Bultje wrote: \ > +if (op == 1) {\ > +for (k = 0; k < DST_BUF_SIZE; k += 4) { \ > +uint32_t r = rnd() & mask;

[FFmpeg-devel] [PATCH] checkasm: add vp9 intra pred tests.

2015-09-15 Thread Ronald S. Bultje
--- tests/checkasm/vp9.c | 73 +++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/vp9.c b/tests/checkasm/vp9.c index 51c4a65..a44b23c 100644 --- a/tests/checkasm/vp9.c +++ b/tests/checkasm/vp9.c @@ -26,8 +26,78 @@

Re: [FFmpeg-devel] -noautorotate option not shown in help

2015-09-15 Thread Paul B Mahol
On 9/15/15, Ryan Williams wrote: > ffmpeg -h full contains the following line: > > -autorotate automatically insert correct rotate filters Whats wrong with -autorotate=no > > > > I would like to see an additional line included in the output for the >

Re: [FFmpeg-devel] [PATCH] configure: Print large lists in more columns if the screen size allows

2015-09-15 Thread Michael Niedermayer
On Mon, Sep 14, 2015 at 04:46:14PM -0700, Timothy Gu wrote: > --- > configure | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) I have no oppinion on the function name (could be changed, could be a seperate patch) rest LGTM thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avfilter: add stereowiden filter

2015-09-15 Thread Michael Niedermayer
On Sat, Sep 12, 2015 at 04:16:27AM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/af_stereowiden.c | 167 > +++ > libavfilter/allfilters.c | 1 + > 3 files

[FFmpeg-devel] [PATCH]lavc/utils: Correctly show bit_rate >INT_MAX

2015-09-15 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the remaining issue in ticket #2089. Please comment, Carl Eugen diff --git a/libavcodec/utils.c b/libavcodec/utils.c index ababdf3..19548e2 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1118,9 +1118,9 @@ static void get_subtitle_defaults(AVSubtitle *sub)

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-15 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > On 9/14/2015 7:49 PM, Carl Eugen Hoyos wrote: > > But nobody wants to send a patch with an updated > > commit message afaict. > > How is that important? Afaiu, it is the only objection that was raised. (But I am not a native speaker and may of course have

[FFmpeg-devel] [PATCH]lavf/img2dec: Return a small score for possibly invalid jpeg files

2015-09-15 Thread Carl Eugen Hoyos
Hi! I believe that the jpeg probe function should always return a small score for files starting with 0xffd8. Please comment, Carl Eugen diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index 70f0b09..5e3c60b 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -683,17

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a small score for possibly invalid jpeg files

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 05:24:52PM +0200, Carl Eugen Hoyos wrote: > Hi! > > I believe that the jpeg probe function should always return > a small score for files starting with 0xffd8. > > Please comment, Carl Eugen do you have a sample file that benefits from this ? [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: use the name 's' for the pointer to the private context

2015-09-15 Thread Ronald S. Bultje
Hi, On Mon, Sep 14, 2015 at 9:34 PM, Ganesh Ajjanagadde wrote: > On Mon, Sep 7, 2015 at 10:10 AM, Ganesh Ajjanagadde > wrote: > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavfilter/vf_vidstabdetect.c | 60 >

Re: [FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

2015-09-15 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > > that said, the patches are fine, the bugs are just in cases that > > > the there exist unanimous consent that they should be dropped > > > > Second patch attached that fixes ticket #2089 for me. Only the container bitrate is fixed now, patch for codec

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a small score for possibly invalid jpeg files

2015-09-15 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > I believe that the jpeg probe function should always return > > a small score for files starting with 0xffd8. > do you have a sample file that benefits from this ? No, the more specific test for ticket #4841 was applied, I just believe that "0" is not

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 10:54 AM, Michael Niedermayer wrote: > On Tue, Sep 15, 2015 at 08:48:33AM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Sep 15, 2015 at 6:54 AM, Ronald S. Bultje wrote: >> > Hi Ganesh, >> > >> > On Mon, Sep 14, 2015 at 10:27 PM, Ganesh

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 04:24:02AM -0300, Claudio Freire wrote: > This patch refactors the AAC coders to reuse code > between the MIPS port and the regular, portable C code. > There were two main functions that had to use > hand-optimized versions of quantization code: > -

Re: [FFmpeg-devel] [PATCH 1/2] rtpdec: add a trace when jitter buffer is full

2015-09-15 Thread Michael Niedermayer
On Mon, Sep 14, 2015 at 02:02:16PM -0400, Eloi BAIL wrote: > This commit adds an error trace when jitter buffer > is full. It helps to understand leading decoding issues. > > Signed-off-by: Eloi BAIL > --- > libavformat/rtpdec.c | 3 +++ > 1 file changed, 3

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Clément Bœsch
On Mon, Sep 14, 2015 at 10:27:30PM -0400, Ganesh Ajjanagadde wrote: > Hi all, > > What is ffmpeg's policy on "necro-bumping" old patches? Or more > precisely, what is the policy of requesting a patch to be merged where > all objections raised have been addressed via discussion/updated > patches,

Re: [FFmpeg-devel] [PATCH]lavc/utils: Correctly show bit_rate >INT_MAX

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 06:19:52PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the remaining issue in ticket #2089. > > Please comment, Carl Eugen > utils.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > 1208f300967a41eff112ec4caa35400b2f5e0149

[FFmpeg-devel] [PATCH] avfilter: add stereo tools filter

2015-09-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 84 + libavfilter/Makefile | 1 + libavfilter/af_stereotools.c | 290 +++ libavfilter/allfilters.c | 1 + 4 files changed, 376 insertions(+)

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 12:47:35PM -0400, Ganesh Ajjanagadde wrote: > On Tue, Sep 15, 2015 at 10:54 AM, Michael Niedermayer > wrote: > > On Tue, Sep 15, 2015 at 08:48:33AM -0400, Ganesh Ajjanagadde wrote: > >> On Tue, Sep 15, 2015 at 6:54 AM, Ronald S. Bultje

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 1:47 PM, Michael Niedermayer wrote: > On Tue, Sep 15, 2015 at 12:47:35PM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Sep 15, 2015 at 10:54 AM, Michael Niedermayer >> wrote: >> > On Tue, Sep 15, 2015 at 08:48:33AM -0400, Ganesh

Re: [FFmpeg-devel] [PATCH] avfilter/f_sendcmd: use the name 's' for the pointer to the private context

2015-09-15 Thread Stefano Sabatini
On date Tuesday 2015-09-15 12:59:54 -0400, Ganesh Ajjanagadde encoded: > On Wed, Sep 9, 2015 at 2:30 PM, Ganesh Ajjanagadde > wrote: > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavfilter/f_sendcmd.c | 36

Re: [FFmpeg-devel] [PATCH] avfilter/f_sendcmd: use the name 's' for the pointer to the private context

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 1:22 PM, Stefano Sabatini wrote: > On date Tuesday 2015-09-15 12:59:54 -0400, Ganesh Ajjanagadde encoded: >> On Wed, Sep 9, 2015 at 2:30 PM, Ganesh Ajjanagadde >> wrote: >> > Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

2015-09-15 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > On 9/12/2015 3:42 PM, Michael Niedermayer wrote: > > I think theres consense about "abi compatibility" so i > > would tend to suggest to move forward with that in mind. > > In that case we should go ahead and don't bother with the >

Re: [FFmpeg-devel] [PATCH] avfilter: add stereo tools filter

2015-09-15 Thread Lou Logan
Just some annoying simple stuff. On Tue, 15 Sep 2015 17:26:00 +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 84 + > libavfilter/Makefile | 1 + > libavfilter/af_stereotools.c | 290 >

Re: [FFmpeg-devel] [PATCH] libavformat/riff.c: Add support for RV40 codec in AVI

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 02:11:38PM -0700, Thierry Foucu wrote: > --- > libavformat/riff.c | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out

[FFmpeg-devel] [PATCH] libavformat/riff.c: Add support for RV40 codec in AVI

2015-09-15 Thread Thierry Foucu
--- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 768b406..be76b0a 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -373,6 +373,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_HQX,

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 3:03 PM, Michael Niedermayer wrote: > On Tue, Sep 15, 2015 at 02:00:27PM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Sep 15, 2015 at 1:47 PM, Michael Niedermayer >> wrote: >> > On Tue, Sep 15, 2015 at 12:47:35PM -0400, Ganesh

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ronald S. Bultje
Hi Ganesh, On Mon, Sep 14, 2015 at 10:27 PM, Ganesh Ajjanagadde wrote: > Hi all, > > What is ffmpeg's policy on "necro-bumping" old patches? Or more > precisely, what is the policy of requesting a patch to be merged where > all objections raised have been addressed via

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 6:54 AM, Ronald S. Bultje wrote: > Hi Ganesh, > > On Mon, Sep 14, 2015 at 10:27 PM, Ganesh Ajjanagadde > wrote: > >> Hi all, >> >> What is ffmpeg's policy on "necro-bumping" old patches? Or more >> precisely, what is the policy of

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Ganesh Ajjanagadde
On Tue, Sep 15, 2015 at 8:18 AM, Clément Bœsch wrote: > On Mon, Sep 14, 2015 at 10:27:30PM -0400, Ganesh Ajjanagadde wrote: >> Hi all, >> >> What is ffmpeg's policy on "necro-bumping" old patches? Or more >> precisely, what is the policy of requesting a patch to be merged where >>

Re: [FFmpeg-devel] policy on "necro-bumping" patches

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 08:48:33AM -0400, Ganesh Ajjanagadde wrote: > On Tue, Sep 15, 2015 at 6:54 AM, Ronald S. Bultje wrote: > > Hi Ganesh, > > > > On Mon, Sep 14, 2015 at 10:27 PM, Ganesh Ajjanagadde > > wrote: > > > >> Hi all, > >> > >> What is ffmpeg's