Re: [FFmpeg-devel] [PATCH] ffmpeg/web/index: add news describing GSoC 2015 program outcome

2015-09-28 Thread Lou Logan
On Sun, Sep 27, 2015, at 08:55 AM, Stefano Sabatini wrote: > > + 0001-ffmpeg-web-index-add-news-describing-GSoC-2015-progr.patch > 10k (text/x-diff) LGTM. Thanks for writing this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

[FFmpeg-devel] Adding Closed Caption support to Decklink output

2015-09-28 Thread Deron
As the title says, I'm adding closed caption support to the Decklink driver. For this to work, I have to output 10 bit YUV ‘v210’ 4:2:2 representation (twelve 10-bit unsigned components packed into four 32-bit little-endian words). AV_PIX_FMT_NV20LE sounds like it would be the correct format,

Re: [FFmpeg-devel] [PATCHv2] avcodec/videotoolbox: fix -Wunused-but-set-variable

2015-09-28 Thread Michael Niedermayer
On Mon, Sep 28, 2015 at 10:15:01AM -0400, Ganesh Ajjanagadde wrote: > On Sat, Sep 26, 2015 at 12:09 PM, wm4 wrote: > > On Sat, 26 Sep 2015 10:55:29 -0400 > > Ganesh Ajjanagadde wrote: > > > >> On Sat, Sep 19, 2015 at 5:41 PM, Ganesh Ajjanagadde > >> wrote: > >> > pix_fmt was declared presumably

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec.c: free always the packet after a resync.

2015-09-28 Thread Michael Niedermayer
On Mon, Sep 28, 2015 at 02:34:45PM -0700, Thierry Foucu wrote: > In case of resync, always free the packet, but retry only if the resync > did not get to the end of the file. Otherwise, there is a memory leak when the > last packet in the file is corrupted. > --- > libavformat/flvdec.c | 2 +- > 1

[FFmpeg-devel] Proposed vf_decimate enhancement

2015-09-28 Thread Ray Cole
I hope this is the appropriate place to propose an enhancement. This is the first time I've offered up code to any open source project...so be gentle :-) First, I love ffmpeg. Wonderful software and thank you for your efforts. I have been pulling down a number of movies back to 24 FPS (24000/10

Re: [FFmpeg-devel] [PATCH]lavc/pngdec: Reset has_trns on init

2015-09-28 Thread Gonzalo
El 28/09/15 a las 16:29, Carl Eugen Hoyos escribió: Carl Eugen Hoyos ag.or.at> writes: Attached patch fixes ticket #4887 for me. Thanks for the quick turnaround to you and Paul B. Mahol. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:/

[FFmpeg-devel] [PATCH] libavformat/flvdec.c: free always the packet after a resync.

2015-09-28 Thread Thierry Foucu
In case of resync, always free the packet, but retry only if the resync did not get to the end of the file. Otherwise, there is a memory leak when the last packet in the file is corrupted. --- libavformat/flvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flvd

[FFmpeg-devel] [PATCH] videotoolbox: require hardware acceleration

2015-09-28 Thread wm4
From: Stefano Pigozzi VideoToolbox also implements a software decoder for h264, and will fallback to using it if the file cannot be doceded on the CPU. In these cases though we want the hwaccel to fail so that we can use the libavcodec software decoder instead. --- libavcodec/videotoolbox.c | 6

Re: [FFmpeg-devel] [PATCH]lavc/pngdec: Reset has_trns on init

2015-09-28 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch fixes ticket #4887 for me. Please ignore;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]lavc/pngdec: Reset has_trns on init

2015-09-28 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4887 for me. Please comment, Carl Eugen diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index ee11f12..c794b47 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1077,6 +1077,7 @@ static int decode_frame_common(AVCodecContext *avctx, PNGDecCont

Re: [FFmpeg-devel] [PATCH] hevc - fix split function of parser

2015-09-28 Thread Ståle Kristoffersen
On 2015-09-25 at 17:13, Hendrik Leppkes wrote: > It seems unlikely that this patch is the cause of that, but regardless > - please open an issue on Trac, preferably with a small sample and > command line to test the difference. I got permission to share the sample, so I have filed bug #4888 https:

Re: [FFmpeg-devel] [PATCH] checkasm/vp9dsp: Fix iszero() to read the correct data

2015-09-28 Thread Ronald S. Bultje
Hi, On Mon, Sep 28, 2015 at 12:54 PM, Henrik Gramner wrote: > --- > tests/checkasm/vp9dsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c > index 5ec4038..37a3ca6 100644 > --- a/tests/checkasm/vp9dsp.c > +++ b/tests/ch

Re: [FFmpeg-devel] pngdec failing with an assertion

2015-09-28 Thread Gonzalo
Please file a ticket at trac.ffmpeg.org with the source PNGs attached to it. Timothy I have done so. The ticket #4887: defect: PNG sequences crashffplaywith an assertion (new) A set of 10 png files as a zip file has been uploaded to: ​http://www.dat

[FFmpeg-devel] [PATCH] checkasm/vp9dsp: Fix iszero() to read the correct data

2015-09-28 Thread Henrik Gramner
--- tests/checkasm/vp9dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c index 5ec4038..37a3ca6 100644 --- a/tests/checkasm/vp9dsp.c +++ b/tests/checkasm/vp9dsp.c @@ -297,7 +297,7 @@ static int iszero(const int16_t *c, int sz

[FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-09-28 Thread Christophe Gisquet
This parameter is intended for pixel data, while the functions are actually only called for dct blocks. I admit I haven't run this over all of fate, so it would be nice to validate nothing actually uses it for pixels (I have see nothing of the sort). -- Christophe From d89cdcaf4f71bcb910e57184c2

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-28 Thread Kyle Swanson
> questions: > > - what happens if you resample the input (by prefixing ebur128 with > aformat=channel_layout=stereo)? > - if I'm reading the blog correctly ("Note that In my discussions with > leading experts in the space, it has come to my attention that this > approach may not be sustainab

Re: [FFmpeg-devel] [PATCH v2] checkasm: Fix the function name sorting algorithm

2015-09-28 Thread Henrik Gramner
On Mon, Sep 28, 2015 at 3:48 AM, Michael Niedermayer wrote: > LGTM Thanks, applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv2] avcodec/videotoolbox: fix -Wunused-but-set-variable

2015-09-28 Thread Ganesh Ajjanagadde
On Sat, Sep 26, 2015 at 12:09 PM, wm4 wrote: > On Sat, 26 Sep 2015 10:55:29 -0400 > Ganesh Ajjanagadde wrote: > >> On Sat, Sep 19, 2015 at 5:41 PM, Ganesh Ajjanagadde >> wrote: >> > pix_fmt was declared presumably to shorten the argument passed to the >> > function. >> > However, it is currentl

Re: [FFmpeg-devel] [PATCH 1/7] libkvazaar: Update to work with the latest version

2015-09-28 Thread Arttu Ylä-Outinen
On 2015-09-28 15:09, Carl Eugen Hoyos wrote: I believe the patch is missing a change to configure: Please make sure that configure --enable-libkvazaar fails if compilation would fail later because a too old version of libkvazaar is installed. Okay, I'll add a version check. - Arttu ___

Re: [FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

2015-09-28 Thread Arttu Ylä-Outinen
On 2015-09-28 15:12, Carl Eugen Hoyos wrote: Arttu Ylä-Outinen tut.fi> writes: Removes the -threads option from libkvazaar documentation since it does not work with libkvazaar. Why? (Is this something that has to be fixed in FFmpeg?) The -threads option is ignored and the thread_count field

[FFmpeg-devel] doc/examples/transcoding: Using AVStream.codec.time_base as a timebase hint to the muxer is deprecated. Set AVStream.time_base instead.

2015-09-28 Thread Przemysław Sobala
Hello I'm trying to get rid of deprecated code/runtime warnings. How would you change doc/examples/transcoding.c to remove [mp4 @ 0x2002e00] Using AVStream.codec.time_base as a timebase hint to the muxer is deprecated. Set AVStream.time_base instead. [mp4 @ 0x2002e00] Using AVStream.codec.time_ba

Re: [FFmpeg-devel] [PATCH 6/7] libkvazaar: Fix setting target bitrate

2015-09-28 Thread Arttu Ylä-Outinen
On 2015-09-28 15:11, Carl Eugen Hoyos wrote: Arttu Ylä-Outinen tut.fi> writes: The divisor and dividend in the equation had been swapped, making the result the inverse of the actual bitrate. cfg->framerate = - (double)(avctx->time_base.num * avctx->ticks_per_frame) / avctx->time_bas

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-09-28 Thread Tobias Rapp
On 19.09.2015 22:49, Tomas Härdin wrote: On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: Hi, attached patch fixes ticket #4759 but I guess it is a bit too hasty to always abort transcoding if a single frame cannot be written. I guess it would be better to check for some "exit_on_error" li

Re: [FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

2015-09-28 Thread Carl Eugen Hoyos
Arttu Ylä-Outinen tut.fi> writes: > Removes the -threads option from libkvazaar documentation > since it does not work with libkvazaar. Why? (Is this something that has to be fixed in FFmpeg?) > -cfg->threads = avctx->thread_count; Please clarify in the description that the patch is not

Re: [FFmpeg-devel] [PATCH 6/7] libkvazaar: Fix setting target bitrate

2015-09-28 Thread Carl Eugen Hoyos
Arttu Ylä-Outinen tut.fi> writes: > The divisor and dividend in the equation had been swapped, > making the result the inverse of the actual bitrate. > cfg->framerate = > - (double)(avctx->time_base.num * avctx->ticks_per_frame) / > avctx->time_base.den; > + avctx->time_base.den

Re: [FFmpeg-devel] [PATCH 1/7] libkvazaar: Update to work with the latest version

2015-09-28 Thread Carl Eugen Hoyos
Arttu Ylä-Outinen tut.fi> writes: > Function encoder_encode in Kvazaar API was changed I believe the patch is missing a change to configure: Please make sure that configure --enable-libkvazaar fails if compilation would fail later because a too old version of libkvazaar is installed. Carl Eug

Re: [FFmpeg-devel] [PATCH] avfilter/delogo: Fix show option when band is small

2015-09-28 Thread Michael Niedermayer
On Mon, Sep 28, 2015 at 10:18:06AM +0200, Jean Delvare wrote: > The code assumed that the outermost interpolated pixels were always in > the fuzzy area defined by the band option. However if the band value > is small, there may be no fuzzy area on a given plane. In that case, > option show did not

Re: [FFmpeg-devel] [PATCH 7/7] dnxhddec: add my contributions

2015-09-28 Thread Michael Niedermayer
On Sun, Sep 27, 2015 at 10:09:08AM +0200, Christophe Gisquet wrote: > --- > libavcodec/dnxhddec.c | 2 ++ > 1 file changed, 2 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not

Re: [FFmpeg-devel] [PATCH 5/7] dnxhddec: reindent/cosmetics

2015-09-28 Thread Michael Niedermayer
On Sun, Sep 27, 2015 at 10:09:06AM +0200, Christophe Gisquet wrote: > --- > libavcodec/dnxhddec.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great ge

[FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

2015-09-28 Thread Arttu Ylä-Outinen
Removes the -threads option from libkvazaar documentation since it does not work with libkvazaar. Signed-off-by: Arttu Ylä-Outinen --- doc/encoders.texi |3 --- libavcodec/libkvazaar.c |1 - 2 files changed, 4 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 3

[FFmpeg-devel] [PATCH 6/7] libkvazaar: Fix setting target bitrate

2015-09-28 Thread Arttu Ylä-Outinen
The divisor and dividend in the equation had been swapped, making the result the inverse of the actual bitrate. Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c in

[FFmpeg-devel] [PATCH 5/7] libkvazaar: Use av_image_copy for copying pixels

2015-09-28 Thread Arttu Ylä-Outinen
Replaces a for loop for copying pixels by a call to av_image_copy. Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 9c59cad..087984

[FFmpeg-devel] [PATCH 4/7] libkvazaar: Set pts and dts

2015-09-28 Thread Arttu Ylä-Outinen
Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index a15700a..9c59cad 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/libkvazaar.c @@ -141,6 +141,7

[FFmpeg-devel] [PATCH 3/7] libkvazaar: Replace asserts with proper errors

2015-09-28 Thread Arttu Ylä-Outinen
Changes function libkvazaar_encode to return proper error codes instead of crashing when the video dimensions or pixel format change in the middle of encoding. Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c | 24 +--- 1 file changed, 21 insertions(+), 3 deleti

[FFmpeg-devel] [PATCH 2/7] libkvazaar: Remove unnecessary NULL checks

2015-09-28 Thread Arttu Ylä-Outinen
Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index 7430e0a..aaaf1f7 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/libkvazaar.c @@ -106,8 +106,8

[FFmpeg-devel] [PATCH 1/7] libkvazaar: Update to work with the latest version

2015-09-28 Thread Arttu Ylä-Outinen
Function encoder_encode in Kvazaar API was changed to have new output parameters: source picture and frame info. Frame info is used to set the keyframe flag and source picture is ignored. Signed-off-by: Arttu Ylä-Outinen --- libavcodec/libkvazaar.c | 16 +++- 1 file changed, 15 ins

[FFmpeg-devel] [PATCH 0/7] libkvazaar improvements

2015-09-28 Thread Arttu Ylä-Outinen
These patches fix some problems in libkvazaar encoder and update it to work with the latest git version of Kvazaar. Most notable changes are setting pts, dts and keyframe flag on the output packets and fixing the calculation of the target bitrate. Arttu Ylä-Outinen (7): libkvazaar: Update to wor

Re: [FFmpeg-devel] [PATCH 6/7] dnxhddata: deduplicate table

2015-09-28 Thread Christophe Gisquet
Hi, 2015-09-27 10:09 GMT+02:00 Christophe Gisquet : > CID 1256 chroma table is the same as luma table for CID 1235 and 1256, > which is consistent with the content being (normally) RGB. Please ignore for now. -- Christophe ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH]libx264: Disable global header for AVC-Intra encoding

2015-09-28 Thread Thomas Mundt
>AVCodecContext.flags is set by the user application not by the codec >see libavcodec/avcodec.h Okay, maybe a patch for x264 is even better. Regards, Thomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

[FFmpeg-devel] [PATCH] avfilter/delogo: Fix show option when band is small

2015-09-28 Thread Jean Delvare
The code assumed that the outermost interpolated pixels were always in the fuzzy area defined by the band option. However if the band value is small, there may be no fuzzy area on a given plane. In that case, option show did not work, no rectangle was drawn (or only on the luma plane, depending on