[FFmpeg-devel] [PATCH] avfilter: add vibrato filter

2015-10-23 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- Changelog| 2 +- doc/filters.texi | 16 libavfilter/Makefile | 1 + libavfilter/af_vibrato.c | 210 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 6 files ch

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Michael Niedermayer
On Thu, Oct 22, 2015 at 09:48:30PM -0700, Dale Curtis wrote: > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > wrote: > > > On Tue, Oct 20, 2015 at 11:50 PM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > >> > >> the last element to be written should be checked, so that if > >> initial

Re: [FFmpeg-devel] [PATCH] vp9: uses ff_set_dimensions (which sets coded_width/height).

2015-10-23 Thread Ronald S. Bultje
Hi, On Fri, Oct 23, 2015 at 9:40 PM, Ronald S. Bultje wrote: > Fixes ticket 4935. > --- > libavcodec/vp9.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) I can give a slightly longer explanation here, I think it's worth it. Without the above change, coded_width/height are not initi

[FFmpeg-devel] [PATCH] vp9: uses ff_set_dimensions (which sets coded_width/height).

2015-10-23 Thread Ronald S. Bultje
Fixes ticket 4935. --- libavcodec/vp9.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 3753e89..cee17d9 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -222,8 +222,7 @@ static int update_size(AVCodecContext *ctx, int w, int h

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Dale Curtis
http://ffmpeg.org/pipermail/ffmpeg-devel/2015-October/181938.html makes the changes to use ff_thread_once; this review may be abandoned. On Fri, Oct 23, 2015 at 5:15 AM, Derek Buitenhuis wrote: > On 10/23/2015 12:35 PM, wm4 wrote: >> There are 2 possibilities: >> 1. Using ff_thread_once() >> 2. N

[FFmpeg-devel] [PATCHv2 1/2] ffplay: use a separate struct for the rescaled YUVA AVSubtitle rectangles

2015-10-23 Thread Marton Balint
Current code segfaults since the deprecation of AVSubtitleRect.pict because it freed/realloced AVSubtitleRect.pict.data by itself. The new code stores the generated YUVA AVSubtitle rectangles in their own struct and keeps the original AVSubtitle structure untouched, because overwriting it is consi

[FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-23 Thread Dale Curtis
Changes from partial initialization which happens for every initialize call to a full initialization once per process. Changes as discussed on list by wm4 and rbultje. Passes fft-test and fate suite. Signed-off-by: Dale Curtis --- libavcodec/fft_template.c | 33 -

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 21:33:49 +0200 Hendrik Leppkes wrote: > On Fri, Oct 23, 2015 at 8:44 PM, Marton Balint wrote: > > Current code segfaults since the deprecation of AVSubtitleRect.pict because > > it > > frees/reallocs AVSubtitleRect.pict.data by itself. > > > > Patch looks fine, however I'

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

2015-10-23 Thread Lucas Andrade
Can this patch be added to 2.9-dev? I think it should be released on 2.8.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread Hendrik Leppkes
On Fri, Oct 23, 2015 at 8:44 PM, Marton Balint wrote: > Current code segfaults since the deprecation of AVSubtitleRect.pict because it > frees/reallocs AVSubtitleRect.pict.data by itself. > Patch looks fine, however I'm curious about this - does ffplay free data that was allocated by avcodec, and

[FFmpeg-devel] [PATCH 2/2] libzvbi-teletextdec: fix AVSubtitleRect pict compatiblity code

2015-10-23 Thread Marton Balint
Only set pict if we got a valid rect. Signed-off-by: Marton Balint --- libavcodec/libzvbi-teletextdec.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index c63b1ec..22acd39 100644 --- a/liba

[FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

2015-10-23 Thread Marton Balint
Current code segfaults since the deprecation of AVSubtitleRect.pict because it frees/reallocs AVSubtitleRect.pict.data by itself. Signed-off-by: Marton Balint --- ffplay.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/ffplay.c b/ffplay.c ind

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-23 Thread Tinglin Liu
On Thu, Oct 22, 2015 at 4:57 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/23/2015 12:19 AM, wm4 wrote: > > Wrong, snprintf() always returns the number of characters the string > > would have been, even if the buffer size is smaller. > > That'll teach me to reply past midnight.

[FFmpeg-devel] [PATCH] avfilter/avf_showcqt: rewrite showcqt and add features

2015-10-23 Thread Muhammad Faiz
add yuv444p, yuv422p, and yuv420p output format (lower cpu usage on ffplay playback because it does not do format conversion) custom size with size/s option (fullhd option is deprecated) custom layout with bar_h, axis_h, and sono_h option support rational frame rate (within fps/r/rate option) relax

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 18:08:00 +0200 Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libswresample/aarch64/audio_convert_init.c |8 - > libswresample/arm/audio_convert_init.c |8 - > libswresample/audioconvert.c

Re: [FFmpeg-devel] [PATCH] Add myself as maintainer for Hap

2015-10-23 Thread Michael Niedermayer
On Fri, Oct 23, 2015 at 12:04:56PM +0100, Tom Butterworth wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study you

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-23 Thread Ronald S. Bultje
Hi, On Fri, Oct 23, 2015 at 12:08 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libswresample/aarch64/audio_convert_init.c |8 - > libswresample/arm/audio_convert_init.c |8 - > libswresample/audioconvert.c

[FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-23 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libswresample/aarch64/audio_convert_init.c |8 - libswresample/arm/audio_convert_init.c |8 - libswresample/audioconvert.c | 44 ++-- libswresample/options.c

[FFmpeg-devel] Use of SDL mutex

2015-10-23 Thread canaar
Hey all, I started reading ffplay.c today. I came a function/macro SDL_LockMutex(q->mutex) inside a packet enqueue function. Is this done to prevent other threads from accessing the queue, when one thread is processing on it? Also, where can I get to read the algorithms used in

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 16:12:07 +0200 Gwenole Beauchesne wrote: > Hi, > > 2015-10-23 15:41 GMT+02:00 wm4 : > > On Fri, 23 Oct 2015 14:54:56 +0200 > > Gwenole Beauchesne wrote: > > > >> Hi, > >> > >> 2015-10-07 18:40 GMT+02:00 wm4 : > >> > On Wed, 7 Oct 2015 19:20:56 +0300 > >> > Ivan Uskov wr

[FFmpeg-devel] Incorrect PTS/DTS timestamp?

2015-10-23 Thread Dethof, Alexander Martin
Dear ffmpeg developers, I reference to the question I previously posted in the user mailing list (q.v. http://ffmpeg.org/pipermail/ffmpeg-user/2015-October/028879.html). The main problem is that when I try to stream a HEVC video bitstream with FFMPEG in the rtp_mpegts format it is always encap

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread Gwenole Beauchesne
Hi, 2015-10-23 15:41 GMT+02:00 wm4 : > On Fri, 23 Oct 2015 14:54:56 +0200 > Gwenole Beauchesne wrote: > >> Hi, >> >> 2015-10-07 18:40 GMT+02:00 wm4 : >> > On Wed, 7 Oct 2015 19:20:56 +0300 >> > Ivan Uskov wrote: >> > >> >> Hello Hendrik, >> >> >> >> Wednesday, October 7, 2015, 5:58:25 PM, you wr

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 14:54:56 +0200 Gwenole Beauchesne wrote: > Hi, > > 2015-10-07 18:40 GMT+02:00 wm4 : > > On Wed, 7 Oct 2015 19:20:56 +0300 > > Ivan Uskov wrote: > > > >> Hello Hendrik, > >> > >> Wednesday, October 7, 2015, 5:58:25 PM, you wrote: > >> > >> HL> On Wed, Oct 7, 2015 at 4:41

Re: [FFmpeg-devel] [PATCH] configure: add -Wstrict-prototypes when available

2015-10-23 Thread Ganesh Ajjanagadde
On Fri, Oct 23, 2015 at 8:49 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 22, 2015 at 2:50 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 22, 2015 at 2:45 PM, Hendrik Leppkes wrote: >>> On Thu, Oct 22, 2015 at 8:40 PM, Ganesh Ajjanagadde >>> wrote: GCC (and Clang) have this useful warning tha

Re: [FFmpeg-devel] [PATCH] avcodec: disallow hwaccel with frame threads

2015-10-23 Thread James Darnley
On 2015-10-23 13:54, Hendrik Leppkes wrote: > The only reason the combination of frame threads and HWAccel was > considered useful is to allow a seamless fallback to multi-threaded > software decoding if the HWAccel is not available, however the issues > outlined above far outweight this.

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread Gwenole Beauchesne
Hi, 2015-10-07 18:40 GMT+02:00 wm4 : > On Wed, 7 Oct 2015 19:20:56 +0300 > Ivan Uskov wrote: > >> Hello Hendrik, >> >> Wednesday, October 7, 2015, 5:58:25 PM, you wrote: >> >> HL> On Wed, Oct 7, 2015 at 4:41 PM, Ivan Uskov wrote: >> >> HL> Global static variables are not acceptable, sorry. >> HL

Re: [FFmpeg-devel] [PATCH] configure: add -Wstrict-prototypes when available

2015-10-23 Thread Ganesh Ajjanagadde
On Thu, Oct 22, 2015 at 2:50 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 22, 2015 at 2:45 PM, Hendrik Leppkes wrote: >> On Thu, Oct 22, 2015 at 8:40 PM, Ganesh Ajjanagadde >> wrote: >>> GCC (and Clang) have this useful warning that is not enabled by -Wall or >>> -Wextra. This will ensure that is

Re: [FFmpeg-devel] [PATCH] avutil/qsort: use do while form for AV_QSORT

2015-10-23 Thread Ganesh Ajjanagadde
On Fri, Oct 23, 2015 at 1:55 AM, Clément Bœsch wrote: > On Thu, Oct 22, 2015 at 10:53:10PM -0400, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/qsort.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavutil/qsort.h b/libavut

[FFmpeg-devel] [PATCH] avformat: add xvag demuxer

2015-10-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/xvag.c | 104 +++ 3 files changed, 106 insertions(+) create mode 100644 libavformat/xvag.c diff --git a/libavformat/Makefile b/libavf

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Derek Buitenhuis
On 10/23/2015 12:35 PM, wm4 wrote: > There are 2 possibilities: > 1. Using ff_thread_once() > 2. Not using global tables, but moving them to per-instance contexts > > Both should be fine, but I think 2. is preferred. I think 1 makes more sense in this case, since sin and cos are widely used, and

Re: [FFmpeg-devel] [PATCH] avcodec: disallow hwaccel with frame threads

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 13:54:25 +0200 Hendrik Leppkes wrote: > HWAccels with frame threads are fundamentally flawed in avcodecs current > design, and there are several known problems ranging from image corruption > to driver crashes. > > These problems come down to two design problems in the intera

[FFmpeg-devel] [PATCH] avcodec: disallow hwaccel with frame threads

2015-10-23 Thread Hendrik Leppkes
HWAccels with frame threads are fundamentally flawed in avcodecs current design, and there are several known problems ranging from image corruption to driver crashes. These problems come down to two design problems in the interaction of threads and HWAccel decoding: (1) While avcodec prevents par

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 06:40:29 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Fri, Oct 23, 2015 at 12:48 AM, Dale Curtis > wrote: > > > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > > wrote: > > > > > On Tue, Oct 20, 2015 at 11:50 PM, Michael Niedermayer < > > > mich...@niedermayer.cc> wrote

Re: [FFmpeg-devel] [PATCH] avformat: add xvag demuxer

2015-10-23 Thread Nicolas George
Le duodi 2 brumaire, an CCXXIV, Paul B Mahol a écrit : > +if (memcmp(p->buf, "XVAG", 4)) > +return 0; > +return AVPROBE_SCORE_MAX; MAX seems a bit high for just four ASCII characters at the beginning. It would match a text file starting with "XVAG file format specification" for exa

[FFmpeg-devel] [PATCH] avformat: add xvag demuxer

2015-10-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/xvag.c | 92 3 files changed, 94 insertions(+) create mode 100644 libavformat/xvag.c diff --git a/libavformat/Makefile b/libavform

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/png: read and write stereo3d frame side data information

2015-10-23 Thread Kirill Gavrilov
On Fri, Oct 23, 2015 at 12:21 AM, Gonzalo wrote: > Do you have an example of writing a stereo image through the API? > if you are looking for C++ sample, you can have a look onto code escaped by ST_AV_NEWSTEREO macros in sView for writing PNG files: https://github.com/gkv311/sview/blob/master/StS

[FFmpeg-devel] [PATCH] Add myself as maintainer for Hap

2015-10-23 Thread Tom Butterworth
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fd9507c..25cff79 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -185,6 +185,7 @@ Codecs: h261* Michael Niedermayer h263* Michael

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Ronald S. Bultje
Hi, On Fri, Oct 23, 2015 at 12:48 AM, Dale Curtis wrote: > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > wrote: > > > On Tue, Oct 20, 2015 at 11:50 PM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > >> > >> the last element to be written should be checked, so that if > >> initializ

Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Michael Niedermayer
On Thu, Oct 22, 2015 at 11:40:41PM +0100, Tom Butterworth wrote: > fixes issue where alpha is ignored in some players > --- > libavcodec/hapenc.c | 3 +++ > 1 file changed, 3 insertions(+) applied btw, you are quite active on hapenc.c, more than 50% of the commits are from you, maybe you want to

Re: [FFmpeg-devel] [PATCH]lavc/hapdec: Correct colour spaces

2015-10-23 Thread Tom Butterworth
LGTM, thanks On 23 October 2015 at 08:30, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes hap colour spaces as reminded by Tom Butterworth. > > Please comment, Carl Eugen > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffm

Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Tom Butterworth
On 23 October 2015 at 08:32, Carl Eugen Hoyos wrote: > Tom Butterworth gmail.com> writes: > > > fixes issue where alpha is ignored in some players > > Your patch looks ok to me, RGB0 should be added as an > input colour space but this can be an independent patch. > > Could you confirm that only

Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Carl Eugen Hoyos
Tom Butterworth gmail.com> writes: > fixes issue where alpha is ignored in some players Your patch looks ok to me, RGB0 should be added as an input colour space but this can be an independent patch. Could you confirm that only Hap5 is supposed to contain transparency information? I just sent

[FFmpeg-devel] [PATCH]lavc/hapdec: Correct colour spaces

2015-10-23 Thread Carl Eugen Hoyos
Hi! Attached patch fixes hap colour spaces as reminded by Tom Butterworth. Please comment, Carl Eugen diff --git a/libavcodec/hapdec.c b/libavcodec/hapdec.c index 6adac21..5a399dc 100644 --- a/libavcodec/hapdec.c +++ b/libavcodec/hapdec.c @@ -383,9 +383,6 @@ static av_cold int hap_init(AVCodecCon