[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-03 Thread Agatha Hu
--- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) }

Re: [FFmpeg-devel] overlay filter option/alternative

2015-12-03 Thread Ryan Williams
EDIT: Fixed errors in syntax. TLDR, Would you consider an 'underlay' filter or perhaps an option on the 'overlay' filter that reverses the order of the input labels? Consider the following shorthand syntax "[input][a] overlay, [b] overlay, [c] overlay [output]" Which expands to "[input][a]

Re: [FFmpeg-devel] overlay filter option/alternative

2015-12-03 Thread Shyamal Dass
Hi, I need to remove the green screen gradient. When I am using the colorkey option blend and similarity. I found there is spills coming in hair. Please can you suggest me the method to removing that spill from the command line in FFMPEG. My command is as follow : ffmpeg -i background_video.mp4

[FFmpeg-devel] Memory leaks in libavformat/segment.c

2015-12-03 Thread Lvqier
Hi, I am using FFmpeg to generate mpegts segments. FFmpeg has memory leaks, see the valgrind output in the attachment. Command line to reproduce: > valgrind --tool=memcheck --leak-check=full ./ffmpeg_g -f decklink -i 'DeckLink Mini Recorder@14' -map 0 -acodec libvo_aacenc -vcodec libx264

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-03 Thread Agatha Hu
--- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) } }

[FFmpeg-devel] overlay filter option/alternative

2015-12-03 Thread Ryan Williams
TLDR, Would you consider an 'underlay' filter or perhaps an option on the 'overlay' filter that reverses the order of the input labels? Consider the following shorthand syntax "[input][a] overlay [b] overlay [c] overlay [output]" Which expands to "[input][a] overlay [unnamed1]; [b][unnamed1]

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 08:26:21 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > > There was no reason AFAIK for making AV_CRC_24_IEEE 12. > > The reason was to leave room for the fork to add its own new constants > without causing ABI

Re: [FFmpeg-devel] [PATCH] tests/api: Fix API test build on windows with --enable-shared

2015-12-03 Thread Hendrik Leppkes
On Wed, Dec 2, 2015 at 9:09 AM, Hendrik Leppkes wrote: > On Wed, Dec 2, 2015 at 2:29 AM, Michael Niedermayer wrote: >> On Tue, Dec 01, 2015 at 08:04:22PM +0100, Hendrik Leppkes wrote: >>> On Mon, Nov 30, 2015 at 10:50 PM, Hendrik Leppkes

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > Except that nobody actually did that. It was a thing that was tried > once, went bust, but somehow it was kept. Stop making statements about things you do not know. You were not behind all Debian and Gentoo users' back at the time, nor did you have

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > Too small sample size, One is enough to refute "nobody". > I never even doubted that it worked at the beginning Then stop bitching, because it is exactly what this discussion is abut: it DID work, it DID make users' life easier. It no longer

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/aacsbr_tablegen: fix tablegen on windows

2015-12-03 Thread Hendrik Leppkes
On Wed, Dec 2, 2015 at 9:52 AM, Hendrik Leppkes wrote: > Including these headers is not needed and breaks building on Windows as it > tries to activate the full compat tools, which are not needed for host > tools. > --- > libavcodec/aacsbr_fixed_tablegen.c | 3 --- >

Re: [FFmpeg-devel] [PATCH 1/2] vp9: add hwaccel hooks

2015-12-03 Thread Hendrik Leppkes
On Thu, Dec 3, 2015 at 11:13 AM, Hendrik Leppkes wrote: > --- > libavcodec/vp9.c | 128 > +++ > libavcodec/vp9.h | 3 ++ > 2 files changed, 94 insertions(+), 37 deletions(-) > > diff --git a/libavcodec/vp9.c

Re: [FFmpeg-devel] [PATCH 2/5] lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

2015-12-03 Thread Stefano Sabatini
On date Friday 2015-11-27 19:16:07 +0100, Nicolas George encoded: > Fix trac ticket #5041. > > Signed-off-by: Nicolas George > --- > libavformat/flvdec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > > Problem can be observed by transcoding or

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Ganesh Ajjanagadde
On Thu, Dec 3, 2015 at 2:26 AM, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> There was no reason AFAIK for making AV_CRC_24_IEEE 12. > > The reason was to leave room for the fork to add its own new constants > without causing ABI

Re: [FFmpeg-devel] [PATCH 1/5] lavf: add FFERROR_REDO to let demuxer return no packet.

2015-12-03 Thread Stefano Sabatini
On date Friday 2015-11-27 19:16:06 +0100, Nicolas George encoded: > Signed-off-by: Nicolas George > --- > libavformat/internal.h | 6 ++ > libavformat/utils.c| 5 + > 2 files changed, 11 insertions(+) > > > Apparently, the most unhappyness was caused by the error

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Clément Bœsch
On Thu, Dec 03, 2015 at 10:08:50AM +0100, wm4 wrote: > On Thu, 3 Dec 2015 09:17:22 +0100 > Nicolas George wrote: > > > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > > You could just append them to the end, like all new constants. > > > > That does not prevent ABI

[FFmpeg-devel] [PATCH] avcodec/srtdec: Keep exact end times

2015-12-03 Thread Eelco Lempsink
When converting SRT to SRT (to normalize) or WebVTT the end timestamps were modified compared to the original. Fixes trac 4783. NOTE: The FATE test 'sub-srt' fails after this patch, because the end times of the Dialogue lines change from X:XX:XX.50 to X:XX:XX.49. I can argue that this is

[FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-03 Thread Hendrik Leppkes
--- libavcodec/vp9.c | 137 --- libavcodec/vp9.h | 3 ++ 2 files changed, 103 insertions(+), 37 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index dc0..134ee55 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@

[FFmpeg-devel] [PATCH 1/2] vp9: add hwaccel hooks

2015-12-03 Thread Hendrik Leppkes
--- libavcodec/vp9.c | 128 +++ libavcodec/vp9.h | 3 ++ 2 files changed, 94 insertions(+), 37 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index dc0..87e80d8 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -168,6

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > You could just append them to the end, like all new constants. That does not prevent ABI incompatibilities. > But someone preferred to make life harder and worse for everyone by > trying to keep the FFmpeg ABI somewhat compatible to Libav Please

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, Stefano Sabatini a écrit : > I'd like to fix the libavformat API/ffprobe, so I'm in favor of this > patchset. > > Regarding the specific patch, we could keep the REDO error code (and > mark in the comment that's intended for internal use), or add and use > an

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Paul B Mahol
On 12/3/15, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a ecrit : >> Too small sample size, > > One is enough to refute "nobody". > >> I never even doubted that it worked at the beginning > > Then stop bitching, because it is exactly what this discussion is abut:

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 09:17:22 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > You could just append them to the end, like all new constants. > > That does not prevent ABI incompatibilities. It removes the need for such hacks. > > But someone

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-12-03 Thread Stefano Sabatini
On date Friday 2015-11-27 15:27:02 +0100, Clément Bœsch encoded: > On Fri, Nov 27, 2015 at 01:10:29PM +0100, Nicolas George wrote: > > Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > > > But then it's still exposed by the API, and someone looking at handling > > > every error code

[FFmpeg-devel] [PATCH 2/2] avcodec: implement vp9 dxva2 hwaccel

2015-12-03 Thread Hendrik Leppkes
--- configure | 5 + libavcodec/Makefile| 2 + libavcodec/allcodecs.c | 2 + libavcodec/dxva2_vp9.c | 338 + libavcodec/vp9.c | 11 +- 5 files changed, 357 insertions(+), 1 deletion(-) create mode 100644

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 11:02:38 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > Except that nobody actually did that. It was a thing that was tried > > once, went bust, but somehow it was kept. > > Stop making statements about things you do not

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > So the goal is not to make it simple to write application code in a way > that will be ABI compatible with newer FFmpeg minor releases? Stop being a caricature. The goal was to be ABI-compatible with the fork. Considering the hostile stance of the

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 10:19:16 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > So the goal is not to make it simple to write application code in a way > > that will be ABI compatible with newer FFmpeg minor releases? > > Stop being a caricature.

[FFmpeg-devel] [PATCH v3 05/14] mips: add i6400 core optimizations

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 24ea270..62dd3a4 100755 --- a/configure +++

[FFmpeg-devel] [PATCH v3 06/14] mips: i6400 core does have an FPU, so not disable it

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Fix a grammar mistake in the commit log. Change "do has" by "does have". Thanks to Moritz Barsnick:

[FFmpeg-devel] [PATCH v3 04/14] mips: remove --mips64r6 configure option

2015-12-03 Thread Vicente Olivert Riera
Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (i6400). We will add the optimizations just when the i6400 core has been detected, in a later patch. Signed-off-by: Vicente

[FFmpeg-devel] [PATCH v3 03/14] mips: add p5600 core optimizations

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index d0631a0..0397ea1 100755 --- a/configure +++ b/configure

[FFmpeg-devel] [PATCH v3 13/14] mips: add support for R6

2015-12-03 Thread Vicente Olivert Riera
Understanding the mips32r6 and mips64r6 ISAs in the configure script is not enough. In order to have full support for MIPS R6 in FFmpeg we need to be able to build it, and for that we need to make sure we don't use incompatible assembler code which makes the build fail. Ifdefing the offending code

[FFmpeg-devel] [PATCH v3 11/14] mips: do not disable any feature for generic cores

2015-12-03 Thread Vicente Olivert Riera
We don't know which features are available when the user selects a generic core, so let's don't disable anything by default and let the user decide. Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Change the logic of this patch. Instead of removing the

[FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - This patch has been added for v3. Changes v1 -> v2: - This patch didn't exist at that point. configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 7d06494..62a5452

Re: [FFmpeg-devel] [PATCH 2/2] ffmdec: reject zero-sized chunks

2015-12-03 Thread Michael Niedermayer
On Wed, Dec 02, 2015 at 11:13:44PM +0100, Andreas Cadhalpun wrote: > If size is zero, avio_get_str fails, leaving the buffer uninitialized. > This causes invalid reads in av_set_options_string. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/ffmdec.c |

[FFmpeg-devel] [PATCH v3 02/14] mips: remove --mips32r5 configure option

2015-12-03 Thread Vicente Olivert Riera
Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (p5600). We will add the optimizations just when the p5600 core has been detected, in a later patch. Signed-off-by: Vicente

Re: [FFmpeg-devel] [PATCH v3 11/14] mips: do not disable any feature for generic cores

2015-12-03 Thread Vicente Olivert Riera
Hello all, On 03/12/15 13:22, Vicente Olivert Riera wrote: > We don't know which features are available when the user selects a > generic core, so let's don't disable anything by default and let the > user decide. > > Signed-off-by: Vicente Olivert Riera > --- >

Re: [FFmpeg-devel] [PATCH] mjpegdec: consider chroma subsampling in size check

2015-12-03 Thread Michael Niedermayer
On Wed, Dec 02, 2015 at 10:00:13PM +0100, Andreas Cadhalpun wrote: > If the chroma components are subsampled, smaller buffers are allocated > for them. In that case the maximal block_offset for the chroma > components is not as large as for the luma component. > > This fixes out of bounds writes

[FFmpeg-devel] [PATCH v3 01/14] mips: rename mipsdspr1 to mipsdsp

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Document it in the Changelog Changes v1 -> v2: - Remove a block of code for mipsdspr2 which wasn't intended to be in this patch and it was causing a syntax error in the configure script. Highlighted by

[FFmpeg-devel] [PATCH v3 10/14] mips: put "disable mipsfpu" in a better place for loongson

2015-12-03 Thread Vicente Olivert Riera
Let's disable the ISAs first, and then the core capabilities, as we do for the rest of the cores. This way the code is better organized. Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 2 +- 1 file

[FFmpeg-devel] [PATCH v3 12/14] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Add a block of code for mipsdspr2 which was previously placed in the first patch of this series causing a syntax error in the configure script.

[FFmpeg-devel] [PATCH v3 07/14] mips: i6400 core is not mips32r2, so disable mips32r2

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 045f5bf..ca6e0a0 100755 --- a/configure +++ b/configure @@ -4102,6 +4102,7 @@

[FFmpeg-devel] [PATCH v3 09/14] mips: add mips32r6 architecture variant

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index 0254e9a..5cf487a 100755 --- a/configure +++ b/configure @@

[FFmpeg-devel] [PATCH v3 08/14] mips: add mips64r2 architecture variant

2015-12-03 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Nothing. configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index ca6e0a0..0254e9a 100755 --- a/configure +++ b/configure @@

Re: [FFmpeg-devel] [PATCH 1/2] ffmdec: only seek back at EOF if a server is attached

2015-12-03 Thread Michael Niedermayer
On Wed, Dec 02, 2015 at 11:13:14PM +0100, Andreas Cadhalpun wrote: > Otherwise the ffm demuxer can return the same packets endlessly, if > there is no server attached. > --- > > I haven't tested ffserver, but since it sets server_attached, it > should still work as previously. probably ok thx

Re: [FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-03 Thread Ronald S. Bultje
Hi, On Thu, Dec 3, 2015 at 11:29 AM, Hendrik Leppkes wrote: > On Thu, Dec 3, 2015 at 5:21 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Thu, Dec 3, 2015 at 4:55 AM, Hendrik Leppkes > wrote: > > > >> +if (s->pix_fmt ==

Re: [FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-03 Thread Ronald S. Bultje
Hi, On Thu, Dec 3, 2015 at 4:55 AM, Hendrik Leppkes wrote: > +if (s->pix_fmt == AV_PIX_FMT_YUV420P) { > +#if CONFIG_VP9_DXVA2_HWACCEL > +*fmtp++ = AV_PIX_FMT_DXVA2_VLD; > +#endif > +#if CONFIG_VP9_D3D11VA_HWACCEL > +*fmtp++ = AV_PIX_FMT_D3D11VA_VLD; >

Re: [FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-03 Thread Hendrik Leppkes
On Thu, Dec 3, 2015 at 5:21 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 3, 2015 at 4:55 AM, Hendrik Leppkes wrote: > >> +if (s->pix_fmt == AV_PIX_FMT_YUV420P) { >> > +#if CONFIG_VP9_DXVA2_HWACCEL >> +*fmtp++ = AV_PIX_FMT_DXVA2_VLD; >>

Re: [FFmpeg-devel] [PATCH v2] mpegencts: Fix overflow in cbr mode period calculations

2015-12-03 Thread Michael Niedermayer
On Sat, Nov 28, 2015 at 08:27:39AM +0200, Timo Teräs wrote: > ts->mux_rate is int (signed 32-bit) type. The period calculations > will start to overflow when mux_rate > 5mbps. This fixes overflows > by converting first to 64-bit type. > > Fixes #5044. > > Signed-off-by: Timo Teräs

Re: [FFmpeg-devel] [PATCH 1/2] vp9: add hwaccel hooks

2015-12-03 Thread Ronald S. Bultje
Hi, On Thu, Dec 3, 2015 at 6:13 AM, Hendrik Leppkes wrote: > On Thu, Dec 3, 2015 at 11:13 AM, Hendrik Leppkes > wrote: > > --- > > libavcodec/vp9.c | 128 > +++ > > libavcodec/vp9.h | 3 ++ > > 2

Re: [FFmpeg-devel] [PATCH] aacenc: mark coders other than twoloop as experimental

2015-12-03 Thread Claudio Freire
On Thu, Dec 3, 2015 at 3:01 PM, Rostislav Pehlivanov wrote: > Any opposition? Not from me ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-03 Thread Hendrik Leppkes
On Thu, Dec 3, 2015 at 6:17 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 3, 2015 at 11:29 AM, Hendrik Leppkes > wrote: > >> On Thu, Dec 3, 2015 at 5:21 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Thu, Dec 3, 2015 at 4:55

[FFmpeg-devel] [PATCH] avfilter: add panorama filter

2015-12-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_panorama.c | 304 ++ 3 files changed, 306 insertions(+) create mode 100644 libavfilter/vf_panorama.c diff --git

[FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

2015-12-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + configure | 26 doc/filters.texi | 46 ++ libavfilter/Makefile | 1 + libavfilter/af_aemphasis.c | 370 +

Re: [FFmpeg-devel] [PATCH] aacenc_ltp: attempt to appease Coverity

2015-12-03 Thread Hendrik Leppkes
On Thu, Dec 3, 2015 at 11:31 PM, Rostislav Pehlivanov wrote: > Coverity is reporting an out of bounds here even though there shouldn't > be one. Attempt to apply some stylistic dithering to make it stop. > --- > libavcodec/aacenc_ltp.c | 2 +- > 1 file changed, 1

[FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-03 Thread Michael Niedermayer
From: Michael Niedermayer Fixes undefined behavior Fixes: mozilla bug 1229208 Fixes: fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit Found-by: Tyson Smith Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind

[FFmpeg-devel] [PATCH] aacenc_ltp: attempt to appease Coverity

2015-12-03 Thread Rostislav Pehlivanov
Coverity is reporting an out of bounds here even though there shouldn't be one. Attempt to apply some stylistic dithering to make it stop. --- libavcodec/aacenc_ltp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacenc_ltp.c b/libavcodec/aacenc_ltp.c index

Re: [FFmpeg-devel] [PATCH 3/5] lavfi: deprecate avfilter_link_set_closed().

2015-12-03 Thread Nicolas George
Le duodi 12 frimaire, an CCXXIV, Andreas Cadhalpun a écrit : > It would be nice to mention this deprecation in APIchanges. > Other than that, this deprecation should be fine, as there seem to be no users > of this function. Added this: 2015-XX-XX - xxx - lavfi 6.19.101 - avfilter.h

[FFmpeg-devel] [PATCH] mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays

2015-12-03 Thread Sebastian Dröge
From: Sebastian Dröge --- libavformat/mpegtsenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 8591e8c..27cd89f 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@

[FFmpeg-devel] [PATCH] libavformat/mov.c: allow QuickTime metadata to come after traks

2015-12-03 Thread Neil Birkbeck
QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed. Signed-off-by: Neil Birkbeck --- libavformat/isom.h | 1 + libavformat/mov.c | 6 +- 2 files changed, 6

Re: [FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

2015-12-03 Thread Ganesh Ajjanagadde
On Thu, Dec 3, 2015 at 5:52 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Changelog | 1 + > configure | 26 > doc/filters.texi | 46 ++ > libavfilter/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-03 Thread Ganesh Ajjanagadde
On Thu, Dec 3, 2015 at 5:09 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes undefined behavior > Fixes: mozilla bug 1229208 > Fixes: > fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit

Re: [FFmpeg-devel] [PATCH 2/5] lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, Stefano Sabatini a écrit : > LGTM. Thanks everyone, series pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 01/14] mips: rename mipsdspr1 to mipsdsp

2015-12-03 Thread Michael Niedermayer
On Thu, Dec 03, 2015 at 01:22:16PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v2 -> v3: > - Document it in the Changelog > > Changes v1 -> v2: > - Remove a block of code for mipsdspr2 which wasn't intended to be in >

Re: [FFmpeg-devel] [PATCH] avcodec/aacsbr_tablegen: always initialize tables at runtime

2015-12-03 Thread Ganesh Ajjanagadde
On Sun, Nov 29, 2015 at 10:58 PM, Ganesh Ajjanagadde wrote: > This gets rid of virtually useless hardcoded tables hackery. The reason > it is useless is that a 320 element lut is anyway placed regardless of > --enable-hardcoded-tables, from which all necessary tables are

Re: [FFmpeg-devel] [PATCH] mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays

2015-12-03 Thread Michael Niedermayer
On Thu, Dec 03, 2015 at 11:04:09PM +0200, Sebastian Dröge wrote: > From: Sebastian Dröge > > --- > libavformat/mpegtsenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] Incorrect FourCC for HE-AAC in ISMV manifest

2015-12-03 Thread Michael Niedermayer
On Wed, Dec 02, 2015 at 06:31:12PM +0100, Yann Coupin wrote: > Hi, > > According to Microsoft's specs [1] (and after experiencing issues with the > Unified Streaming Platform [2] server), content encoded with HE-AAC audio > should use the AACH FourCC, but the value AACL is hardcoded in the

Re: [FFmpeg-devel] [PATCH] aacenc: mark coders other than twoloop as experimental

2015-12-03 Thread Rostislav Pehlivanov
Any opposition? On 2 December 2015 at 19:47, Rostislav Pehlivanov wrote: > This commit marks any coders beside twoloop as experimental and gives > out a warning that some of they might be silently removed in the future. > > Users are highly encouraged to use the twoloop

Re: [FFmpeg-devel] [PATCH 4/5] lavfi: replace link.closed by link.status.

2015-12-03 Thread Nicolas George
Le decadi 10 frimaire, an CCXXIV, Michael Niedermayer a écrit : > this should mention in which timebase the pts is and possibly > relative to what the timestamp is > its rather obvious to write > AVERROR(ENOMEM) > pts = av_gettime() > based on this documentation Changed to this: /** * Set the