[FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-07 Thread Jean-Yves Avenard
Hi This is a discussion you guys may already have discussed about this, I apologise in advance if that is the case (and thank you for pointing me to it if that's the case). I work for Mozilla, in the media playback team of gecko. In Firefox, we've finally moved to use ffvp9 and ffvp8 in place of

Re: [FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 07:07:40PM -0600, Rodger Combs wrote: > --- > ffprobe.c | 1 + > libavformat/avformat.h | 12 +--- > 2 files changed, 10 insertions(+), 3 deletions(-) breaks fate utvideoenc_yuv422_none TESTffprobe_compact --- ./tests/ref/fate/ffprobe_compact

Re: [FFmpeg-devel] FFMPEG Ubuntu Compilation Wiki

2016-01-07 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 7:27 AM, Olalekan Ogunmolu wrote: > Hi there, > > Thank you for the amazing work that you all do. Glad that you find FFmpeg useful. > > I thought to let you know I made your wiki page into a shell script > available for download via my github page for your users. > >

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 5:20 PM, Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 4:48 PM, Michael Niedermayer > wrote: >> On Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde wrote: >>> This exploits an approach based on the sieve of Eratosthenes, a popular >>> method for generating pri

Re: [FFmpeg-devel] [PATCH] lavf/mov: export chapter streams as private data

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 05:14:26PM -0600, Rodger Combs wrote: > This prevents consumers from showing chapters as if they were regular subtitle > streams. > --- > libavformat/mov.c | 3 +++ > 1 file changed, 3 insertions(+) iam not sure this is optimal in the sense of being a final solution but it

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-07 Thread James Zern
Hi, On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: >> Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION >> to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? > > Yes, bumping any of the defines would

[FFmpeg-devel] FFMPEG Ubuntu Compilation Wiki

2016-01-07 Thread Olalekan Ogunmolu
Hi there, Thank you for the amazing work that you all do. I thought to let you know I made your wiki page into a shell script available for download via my github page for your users. https://github.com/lakehanne/Shells/blob/master/ffmpeg.sh Feel free to use as you wish. Thank you! Sinc

[FFmpeg-devel] [PATCH] -cmdline_from_file new paramter

2016-01-07 Thread Procontrol Robert Kovacs
--- cmdutils.c | 186 +++ doc/fftools-common-opts.texi | 41 ++ 2 files changed, 227 insertions(+) diff --git a/cmdutils.c b/cmdutils.c index e0d2807..5441485 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -732,6 +732,189 @@ void uni

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: remove unnecessary include

2016-01-07 Thread Anshul Maheshwari
On Tue, Jan 5, 2016 at 8:58 AM, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index 9f67caa..4e478e0 100644 > --- a/libavcodec/ccaption_dec.c > +++ b/libavc

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

2016-01-07 Thread Anshul Maheshwari
On Tue, Jan 5, 2016 at 8:58 AM, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 98 > ++- > 1 file changed, 45 insertions(+), 53 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index 4e4

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-07 Thread Aman Gupta
Probably should have written a longer commit message here. The EOC command stands for "end of caption" aka "display buffer". It's used with POPON mode, where characters are written to an off-screen buffer and EOC flips the buffers to display what has been written so far. Thus, it makes sense to rea

Re: [FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: replace pow(x, 0.25) by sqrt(sqrt(x))

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 2:25 PM, Michael Niedermayer wrote: > On Wed, Jan 06, 2016 at 08:26:43PM -0800, Ganesh Ajjanagadde wrote: >> On Mon, Jan 4, 2016 at 6:38 PM, Ganesh Ajjanagadde >> wrote: >> > This is faster; precision assured as result is a float. >> > >> > Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 4:34 PM, Michael Niedermayer wrote: > On Thu, Jan 07, 2016 at 04:01:14PM -0800, Ganesh Ajjanagadde wrote: >> On Thu, Jan 7, 2016 at 3:57 PM, Ganesh Ajjanagadde wrote: >> > On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer >> > wrote: >> >> On Thu, Jan 07, 2016 at 11:16:2

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 4:48 PM, Michael Niedermayer wrote: > On Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde wrote: >> This exploits an approach based on the sieve of Eratosthenes, a popular >> method for generating prime numbers. >> >> Tables are identical to previous ones. >> >> Tes

Re: [FFmpeg-devel] [PATCH] rtp: Fix play multiple multicast streams with the same port

2016-01-07 Thread Zhao Zhili
Sorry, I work hard to cross the Great Fire Wall to send this patch and cannot send it as plaintext. Now send it as attachment. On Fri, Jan 8, 2016 at 1:52 AM, Michael Niedermayer wrote: > On Thu, Jan 07, 2016 at 06:58:49PM +0800, Zhao Zhili wrote: > > I made a mistake that rtp and rtcp cannot be

[FFmpeg-devel] [PATCH 2/3] lavf/mov: improve `tref/chap` chapter handling

2016-01-07 Thread Rodger Combs
3 parts: - Supports multiple chapter streams - Exports regular text chapter streams as opaque data. This prevents consumers from showing chapters as if they were regular subtitle streams. - Exports video chapter streams as thumbnails, and provides the first one as an attached_pic. --- libavfor

[FFmpeg-devel] [PATCH 3/3] lavf/mov: reindent

2016-01-07 Thread Rodger Combs
--- libavformat/mov.c | 156 +++--- 1 file changed, 78 insertions(+), 78 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index cde4140..a3ca394 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4421,94 +4421,94 @@ static voi

[FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-01-07 Thread Rodger Combs
--- ffprobe.c | 1 + libavformat/avformat.h | 12 +--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index c352b44..20af969 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2326,6 +2326,7 @@ static int show_stream(WriterContext *w, AVFormatCo

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-07 Thread Michael Niedermayer
On Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde wrote: > This exploits an approach based on the sieve of Eratosthenes, a popular > method for generating prime numbers. > > Tables are identical to previous ones. > > Tested with FATE with/without --enable-hardcoded-tables. > > Sample

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 04:01:14PM -0800, Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 3:57 PM, Ganesh Ajjanagadde wrote: > > On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer > > wrote: > >> On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael Niedermayer wrote: > >>> On Thu, Jan 07, 2016 a

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 3:57 PM, Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer > wrote: >> On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael Niedermayer wrote: >>> On Thu, Jan 07, 2016 at 10:00:47AM -0800, Ganesh Ajjanagadde wrote: >>> > On Thu, Jan 7, 2016 at 9:2

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer wrote: > On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael Niedermayer wrote: >> On Thu, Jan 07, 2016 at 10:00:47AM -0800, Ganesh Ajjanagadde wrote: >> > On Thu, Jan 7, 2016 at 9:27 AM, Michael Niedermayer >> > wrote: >> > > On Wed, Jan 06, 2016

[FFmpeg-devel] [PATCH] lavf/mov: export chapter streams as private data

2016-01-07 Thread Rodger Combs
This prevents consumers from showing chapters as if they were regular subtitle streams. --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 78081ce..77a4a71 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4418,6 +4418,

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2016-01-07 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 08:31:38PM -0800, Ganesh Ajjanagadde wrote: > On Wed, Jan 6, 2016 at 1:25 PM, Michael Niedermayer > wrote: > > On Tue, Jan 05, 2016 at 09:51:15PM -0800, Ganesh Ajjanagadde wrote: > >> On Tue, Jan 5, 2016 at 4:57 PM, Michael Niedermayer > >> wrote: > >> > On Tue, Jan 05, 20

Re: [FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: replace pow(x, 0.25) by sqrt(sqrt(x))

2016-01-07 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 08:26:43PM -0800, Ganesh Ajjanagadde wrote: > On Mon, Jan 4, 2016 at 6:38 PM, Ganesh Ajjanagadde > wrote: > > This is faster; precision assured as result is a float. > > > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavfilter/avf_showspectrum.c | 2 +- > > 1 file ch

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael Niedermayer wrote: > On Thu, Jan 07, 2016 at 10:00:47AM -0800, Ganesh Ajjanagadde wrote: > > On Thu, Jan 7, 2016 at 9:27 AM, Michael Niedermayer > > wrote: > > > On Wed, Jan 06, 2016 at 09:00:46PM -0800, Ganesh Ajjanagadde wrote: > > >> In the spir

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 10:00:47AM -0800, Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 9:27 AM, Michael Niedermayer > wrote: > > On Wed, Jan 06, 2016 at 09:00:46PM -0800, Ganesh Ajjanagadde wrote: > >> In the spirit of commit a956840cbc. Simple method to reproduce: > >> pass -vstats_file /de

Re: [FFmpeg-devel] [PATCH 2/2] swscale: add P010 input support

2016-01-07 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 12:11:22PM +0100, Hendrik Leppkes wrote: > --- > libswscale/input.c| 53 > +++ > libswscale/swscale_unscaled.c | 4 +++- > libswscale/utils.c| 2 ++ > 3 files changed, 58 insertions(+), 1 deletion(-) LGTM i

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ccaption_dec: use ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 11:11:03PM +0100, Michael Niedermayer wrote: > On Sun, Jan 03, 2016 at 08:21:01PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/ccaption_dec.c | 38 ++ > > 1 file changed, 2 insertions(+), 36 deletions(-) > > should be ok > > thx >

Re: [FFmpeg-devel] [PATCH 3/3] lavc/g729dec: use ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 11:09:01PM +0100, Michael Niedermayer wrote: > On Sun, Jan 03, 2016 at 08:21:02PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/g729dec.c | 10 +- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > LGTM > thx > pushed -- Clément B. signature.asc Desc

Re: [FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 08:25:38PM +0100, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 08:21:00PM +0100, Clément Bœsch wrote: > > --- > > configure | 2 ++ > > libavutil/x86/intmath.h | 9 + > > 2 files changed, 11 insertions(+) > > > > diff --git a/configure b/configure >

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: fix always true condition

2016-01-07 Thread Clément Bœsch
On Wed, Jan 06, 2016 at 01:39:30AM +0100, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 09:54:54PM +0100, Clément Bœsch wrote: > > No idea why this wasn't ever detected by a static analyzer. > > --- > > libavcodec/ccaption_dec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] avfilter: add SOFAlizer audio filter

2016-01-07 Thread Paul B Mahol
On 1/7/16, Paul B Mahol wrote: > On 1/7/16, Paul B Mahol wrote: >> On 1/7/16, Roger Pack wrote: >>> On 12/10/15, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Lite version of one sent to VLC mailing list with only slow but high quality mode present. To use y

Re: [FFmpeg-devel] [PATCH] avfilter: add SOFAlizer audio filter

2016-01-07 Thread Paul B Mahol
On 1/7/16, Paul B Mahol wrote: > On 1/7/16, Roger Pack wrote: >> On 12/10/15, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> Lite version of one sent to VLC mailing list with only slow but high >>> quality >>> mode present. >>> To use you need recent netCDF library, SOFA file(s

Re: [FFmpeg-devel] [PATCH] avfilter: add SOFAlizer audio filter

2016-01-07 Thread Paul B Mahol
On 1/7/16, Roger Pack wrote: > On 12/10/15, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> Lite version of one sent to VLC mailing list with only slow but high >> quality >> mode present. >> To use you need recent netCDF library, SOFA file(s), multichannel audio >> and >> headphone

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-07 Thread Andreas Cadhalpun
On 07.01.2016 20:20, Hendrik Leppkes wrote: > On Thu, Jan 7, 2016 at 8:17 PM, Andreas Cadhalpun > wrote: >> >> I'd be glad to increase fuzz-testing coverage further, but I'm lacking >> input examples. It would be great if you could share some (tiny) samples >> triggering the HEADER_XCH/HEADER_XXCH

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-07 Thread Andreas Cadhalpun
On 06.01.2016 23:17, Andreas Cadhalpun wrote: > On 06.01.2016 18:32, foo86 wrote: >> Otherwise testing coverage will be decreased somewhat. The easiest way to do >> this is to modify ff_dca2_check_crc() to always return 0. > > I tried this (comment out everything in ff_dca2_check_crc except 'retur

Re: [FFmpeg-devel] [PATCH] avfilter: add SOFAlizer audio filter

2016-01-07 Thread Roger Pack
On 12/10/15, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Lite version of one sent to VLC mailing list with only slow but high quality > mode present. > To use you need recent netCDF library, SOFA file(s), multichannel audio and > headphones. Could you post an example or step by ste

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-07 Thread Ganesh Ajjanagadde
On Thu, Jan 7, 2016 at 9:27 AM, Michael Niedermayer wrote: > On Wed, Jan 06, 2016 at 09:00:46PM -0800, Ganesh Ajjanagadde wrote: >> In the spirit of commit a956840cbc. Simple method to reproduce: >> pass -vstats_file /dev/full to ffmpeg. >> >> All raw fclose usages in ffmpeg.c taken care of here.

[FFmpeg-devel] [PATCH] x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

2016-01-07 Thread Hendrik Leppkes
--- libavfilter/x86/vf_w3fdif.asm| 35 +-- libavfilter/x86/vf_w3fdif_init.c | 2 +- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/libavfilter/x86/vf_w3fdif.asm b/libavfilter/x86/vf_w3fdif.asm index c3c73ea..52628c3 100644 --- a/libavfilter/x86

Re: [FFmpeg-devel] [PATCH 2/2] swscale: add P010 input support

2016-01-07 Thread wm4
On Thu, 7 Jan 2016 13:38:13 +0100 Hendrik Leppkes wrote: > On Thu, Jan 7, 2016 at 1:31 PM, Carl Eugen Hoyos wrote: > > Hendrik Leppkes gmail.com> writes: > > > >> Because that doesn't work. bits per raw sample is not > >> taken into account when pixel formats are negotiated > > > > But that

Re: [FFmpeg-devel] [PATCH 1/2] avutil: add P010 pixel format

2016-01-07 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 1:26 PM, wm4 wrote: > On Thu, 7 Jan 2016 12:11:21 +0100 > Hendrik Leppkes wrote: > >> P010 is the 10-bit variant of NV12 (planar luma, packed chroma), using two >> bytes per component to store 10-bit data plus 6-bit zeroes in the LSBs. >> --- >> libavutil/pixdesc.c | 24 +

Re: [FFmpeg-devel] [PATCH 1/2] avutil: add P010 pixel format

2016-01-07 Thread wm4
On Thu, 7 Jan 2016 12:11:21 +0100 Hendrik Leppkes wrote: > P010 is the 10-bit variant of NV12 (planar luma, packed chroma), using two > bytes per component to store 10-bit data plus 6-bit zeroes in the LSBs. > --- > libavutil/pixdesc.c | 24 > libavutil/pixfmt.h | 4 +

Re: [FFmpeg-devel] [PATCH 2/2] swscale: add P010 input support

2016-01-07 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 1:11 PM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> Microsoft specifically described the format to alias >> to P016 with less precision for simplicity, however I >> opted to convert to "true" 10-bit in sws by shifting >> so format selection algorithms

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-07 Thread Christophe Gisquet
Hi, 2016-01-07 12:48 GMT+01:00 foo86 : > bench dca pcm_f32le > bench dca2 pcm_f32le > bench libdcadec pcm_s32le OK, that was mostly out of curiosity, as "dca2" has benefits surpassing such issues anyway. And the improvement is 10% for where it matters (raspberry). > synth_filter inte

Re: [FFmpeg-devel] [PATCH 2/2] swscale: add P010 input support

2016-01-07 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 12:44 PM, Christophe Gisquet wrote: > Hi, > > 2016-01-07 12:11 GMT+01:00 Hendrik Leppkes : >> +static void p010LEToY_c(uint8_t *dst, const uint8_t *src, const uint8_t >> *unused1, >> +const uint8_t *unused2, int width, uint32_t *unused) >> +{ >> +

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-07 Thread foo86
On Wed, Jan 06, 2016 at 02:53:32PM -0300, James Almer wrote: > On 1/6/2016 2:32 PM, foo86 wrote: > > OK, I'll start changing the patch. > > > > Some questions so far: > > > > 1. Should I remove old decoder files in separate commit first or should > > I simply proceed with replacing entire content

Re: [FFmpeg-devel] [PATCH 2/2] swscale: add P010 input support

2016-01-07 Thread Christophe Gisquet
Hi, 2016-01-07 12:11 GMT+01:00 Hendrik Leppkes : > +static void p010LEToY_c(uint8_t *dst, const uint8_t *src, const uint8_t > *unused1, > +const uint8_t *unused2, int width, uint32_t *unused) > +{ > +int i; > +for (i = 0; i < width; i++) { > +AV_WN16(dst +

[FFmpeg-devel] [PATCH 1/2] avutil: add P010 pixel format

2016-01-07 Thread Hendrik Leppkes
P010 is the 10-bit variant of NV12 (planar luma, packed chroma), using two bytes per component to store 10-bit data plus 6-bit zeroes in the LSBs. --- libavutil/pixdesc.c | 24 libavutil/pixfmt.h | 4 2 files changed, 28 insertions(+) diff --git a/libavutil/pixdesc

Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
On 01/07/2016 11:47 AM, Carl Eugen Hoyos wrote: There is a small chance for false positives, but it's probably negligible. Feel free to fix it. The non-FFmpeg sample is: http://samples.ffmpeg.org/Matroska/switzler084d_dl.mkv Carl Eugen Thanks, Carl. Interesting, this file seems to be muxed

Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
On 01/07/2016 11:22 AM, Mats Peterson wrote: So we'd better keep them, I guess. There is a small chance for false positives, but it's probably negligible. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > Are the following kludges for A_QUICKTIME and > V_QUICKTIME ways to accommodate old broken Matroska > files that FFmpeg wrote in the past? It dates back to f009e36f75bc137167a26356305d2c3eb83cac68 It is possible that very old matroska files exist that neede

Re: [FFmpeg-devel] [PATCH] x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

2016-01-07 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 4:18 AM, James Almer wrote: > On 1/6/2016 11:54 PM, Hendrik Leppkes wrote: >> --- >> Based on an idea from Ronald mentioend in an earlier thread about this >> function. >> >> It works and passes FATE, however I'm sure some aspects can be done easier >> or cleaner, so pleas

[FFmpeg-devel] [PATCH] rtp: Fix play multiple multicast streams with the same port

2016-01-07 Thread Zhao Zhili
We cannot play multiple multicast streams with the same port at the same time. This is because both rtp and rtcp ports are opened in read-write mode, so they will not bind to the multicast address. Try to make rtp port as read-only by default to solve this bug. Signed-off-by: Zhao Zhili --- liba

[FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
Are the following kludges for A_QUICKTIME and V_QUICKTIME ways to accommodate old broken Matroska files that FFmpeg wrote in the past? I'm asking because in normal cases, the fourcc in A_QUICKTIME and V_QUICKTIME always starts at offset 4, without exception. A_QUICKTIME: if (ff_codec_get_id(f