Re: [FFmpeg-devel] [PATCH] fix memory leak in url_find_protocol

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 01:21:45PM -0700, Yong Lei wrote: > --- > libavformat/avio.c | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire

Re: [FFmpeg-devel] [PATCH] web/contact: Use https for external links where it works

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 08:19:03AM -0800, Lou Logan wrote: > On Tue, May 17, 2016, at 04:30 AM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > src/contact |6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Also LGTM.

Re: [FFmpeg-devel] [PATCH] web: use https for forgotten trac wiki links

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 08:17:46AM -0800, Lou Logan wrote: > On Tue, May 17, 2016, at 04:36 AM, Michael Niedermayer wrote: > > --- > > src/documentation |2 +- > > src/template_head2 |2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > LGTM applied thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 11:28:32AM -0700, chcunning...@chromium.org wrote: > From: Chris Cunningham > > Fixes: undefined shift. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 07:08:42PM +0200, Michael Niedermayer wrote: > On Tue, May 17, 2016 at 12:26:18PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 17, 2016 at 11:18 AM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > > > > AVCodecContext contains all the fields

Re: [FFmpeg-devel] [PATCH WIP 1/2] ffplay: convert ffplay to use SDL2

2016-05-17 Thread Josh de Kock
On 17/05/2016 21:47, Marton Balint wrote: > > On Tue, 17 May 2016, Josh de Kock wrote: > >> From: Marton Balint >> >> This patch looks mostly fine, there's just one thing though, which is >> the ALSA fix using envvars. There doesn't seem to be a replacement for >> these

Re: [FFmpeg-devel] [PATCH WIP 2/2] avdev: add sdl2 device

2016-05-17 Thread Marton Balint
On Tue, 17 May 2016, Josh de Kock wrote: This "works", as in, it will play video fine (I haven't done too much testing yet). I was using the command, `./ffmpeg_g -f lavfi -i testsrc=size=1280x720:rate=30 -pix_fmt yuv420p -f sdl2 "k"` to test. It will crash on quit, and the Window bar is

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 10:00:38PM +0200, Nicolas George wrote: > Le nonidi 29 floréal, an CCXXIV, Ronald S. Bultje a écrit : > > It's not for us (ffmpeg.c developers), it's for people using the ffmpeg > > libraries on other language platforms (e.g. python). > > I think one of the cruxes of the

Re: [FFmpeg-devel] [PATCH WIP 1/2] ffplay: convert ffplay to use SDL2

2016-05-17 Thread Marton Balint
On Tue, 17 May 2016, Josh de Kock wrote: From: Marton Balint This patch looks mostly fine, there's just one thing though, which is the ALSA fix using envvars. There doesn't seem to be a replacement for these functions in SDL2, so I was wondering how else it could be done.

[FFmpeg-devel] [PATCH] fix memory leak in url_find_protocol

2016-05-17 Thread Yong Lei
--- libavformat/avio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/avio.c b/libavformat/avio.c index 6507593..efde5f3 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -282,6 +282,7 @@ static const struct URLProtocol *url_find_protocol(const char *filename)

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Nicolas George
Le nonidi 29 floréal, an CCXXIV, Ronald S. Bultje a écrit : > It's not for us (ffmpeg.c developers), it's for people using the ffmpeg > libraries on other language platforms (e.g. python). I think one of the cruxes of the issue is that we are (ab)using the AVOption system for two different

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 9:04 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 2:29 PM, Hendrik Leppkes > wrote: > >> On Tue, May 17, 2016 at 7:46 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, May 17, 2016 at

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 2:29 PM, Hendrik Leppkes wrote: > On Tue, May 17, 2016 at 7:46 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, May 17, 2016 at 1:24 PM, Hendrik Leppkes > > wrote: > > > >> On Tue, May 17, 2016 at

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Chris Cunningham
New patch drops the U. Hendrik, you'r right about the negative, but you're also right about the 0. 0 is a case of undefined shift behavior (shift becomes -1). On Tue, May 17, 2016 at 11:28 AM, wrote: > From: Chris Cunningham > > Fixes:

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 7:46 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 1:24 PM, Hendrik Leppkes > wrote: > >> On Tue, May 17, 2016 at 7:22 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, May 17, 2016 at

[FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread chcunningham
From: Chris Cunningham Fixes: undefined shift. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 5f5f03e..d1e4306 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 1:24 PM, Hendrik Leppkes wrote: > On Tue, May 17, 2016 at 7:22 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, May 17, 2016 at 12:34 PM, Hendrik Leppkes > > wrote: > > > >> On Tue, May 17, 2016 at

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 7:22 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 12:34 PM, Hendrik Leppkes > wrote: > >> On Tue, May 17, 2016 at 6:26 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, May 17, 2016 at

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 12:34 PM, Hendrik Leppkes wrote: > On Tue, May 17, 2016 at 6:26 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, May 17, 2016 at 11:18 AM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > > >> AVCodecContext

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 12:26:18PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 11:18 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > AVCodecContext contains all the fields that AVCodecParameters has. > > Examples are width, height, bitrate, profile,

[FFmpeg-devel] [PATCH WIP 2/2] avdev: add sdl2 device

2016-05-17 Thread Josh de Kock
This "works", as in, it will play video fine (I haven't done too much testing yet). I was using the command, `./ffmpeg_g -f lavfi -i testsrc=size=1280x720:rate=30 -pix_fmt yuv420p -f sdl2 "k"` to test. It will crash on quit, and the Window bar is frozen. At first I thought it was because there

[FFmpeg-devel] [PATCH WIP 1/2] ffplay: convert ffplay to use SDL2

2016-05-17 Thread Josh de Kock
From: Marton Balint This patch looks mostly fine, there's just one thing though, which is the ALSA fix using envvars. There doesn't seem to be a replacement for these functions in SDL2, so I was wondering how else it could be done. Maybe through putenv()? --- configure | 27

[FFmpeg-devel] [PATCH WIP 0/2] Update usage of SDL1 library to SDL2

2016-05-17 Thread Josh de Kock
Hi, I'm trying to update the usages of SDL1 to SDL2 so that they can follow the new library, as the last version was released in 2013, and is probably becoming a bit stale. While this should be a fairly simple patch (for others), I'm having a little trouble with it, and it was suggested that I

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 6:26 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 11:18 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> AVCodecContext contains all the fields that AVCodecParameters has. >> Examples are width, height, bitrate, profile,

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 11:18 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > AVCodecContext contains all the fields that AVCodecParameters has. > Examples are width, height, bitrate, profile, sample_rate, channels > > In AVCodecContext these fields are accessible through

Re: [FFmpeg-devel] [PATCH] web/contact: Use https for external links where it works

2016-05-17 Thread Lou Logan
On Tue, May 17, 2016, at 04:30 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > src/contact |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Also LGTM. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] web: use https for forgotten trac wiki links

2016-05-17 Thread Lou Logan
On Tue, May 17, 2016, at 04:36 AM, Michael Niedermayer wrote: > --- > src/documentation |2 +- > src/template_head2 |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 10:21:51AM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 10:04 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Tue, May 17, 2016 at 06:49:44AM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Tue, May 17, 2016 at 6:07 AM,

Re: [FFmpeg-devel] [PATCH 1/2] lavc/mediacodec: factorize static fields initialization

2016-05-17 Thread Matthieu Bouron
On Tue, May 17, 2016 at 03:20:53PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libavcodec/mediacodec_wrapper.c | 167 > ++-- > 1 file changed, 57 insertions(+), 110 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 10:04 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Tue, May 17, 2016 at 06:49:44AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 17, 2016 at 6:07 AM, Michael Niedermayer > > > wrote: > > > > > Most of the major

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 06:49:44AM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, May 17, 2016 at 6:07 AM, Michael Niedermayer > wrote: > > > Most of the major public structures contain an AVClass. > > > What are you hoping to accomplish with this struct that can

[FFmpeg-devel] [PATCH 1/2] lavc/mediacodec: factorize static fields initialization

2016-05-17 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/mediacodec_wrapper.c | 167 ++-- 1 file changed, 57 insertions(+), 110 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 6b3f905..8ce3b32

[FFmpeg-devel] [PATCH 2/2] lavc/mediacodec: add missing MediaCodec.Get{Input, Output}Buffer() checks

2016-05-17 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/mediacodec_wrapper.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 8ce3b32..5c047ea 100644 --- a/libavcodec/mediacodec_wrapper.c +++

[FFmpeg-devel] [PATCH] web: use https for forgotten trac wiki links

2016-05-17 Thread Michael Niedermayer
--- src/documentation |2 +- src/template_head2 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/documentation b/src/documentation index 872206e..e6df56f 100644 --- a/src/documentation +++ b/src/documentation @@ -109,7 +109,7 @@ Community

[FFmpeg-devel] [PATCH] web/contact: Use https for external links where it works

2016-05-17 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- src/contact |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/contact b/src/contact index e84367b..9ee7392 100644 --- a/src/contact +++ b/src/contact @@ -8,7 +8,7 @@ Please

Re: [FFmpeg-devel] [PATCHv3] h2645_parse: support badly muxed mp4 streams

2016-05-17 Thread Hendrik Leppkes
On Thu, May 12, 2016 at 1:53 PM, Michael Niedermayer wrote: > On Thu, May 12, 2016 at 12:07:40PM +0200, Hendrik Leppkes wrote: >> Some streams contain an additional AnnexB NAL inside the mp4/nalff NALU. >> This commonly occurs in interlaced streams where both fields are

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/mips: loongson optimize idctdsp with mmi v2

2016-05-17 Thread 周晓勇
avcodec/mips/idctdsp_mmi: Version 2 of the optimizations for loongson mmi 1. no longer use the register names directly and optimized code format 2. to be compatible with O32, specify type of address variable with mips_reg and handle the address variable with PTR_ operator 在

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/mips: loongson optimize pixblockdsp with mmi v2

2016-05-17 Thread 周晓勇
avcodec/mips/pixblockdsp_mmi: Version 2 of the optimizations for loongson mmi 1. no longer use the register names directly and optimized code format 2. to be compatible with O32, specify type of address variable with mips_reg and handle the address variable with PTR_ operator 在

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/mips: loongson optimize blockdsp with mmi v2

2016-05-17 Thread 周晓勇
avcodec/mips/blockdsp_mmi: Version 2 of the optimizations for loongson mmi 1. no longer use the register names directly and optimized code format 2. to be compatible with O32, specify type of address variable with mips_reg and handle the address variable with PTR_ operator

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/mips: loongson optimize h264pred with mmi v3

2016-05-17 Thread 周晓勇
avcodec/mips: loongson optimize h264pred with mmi v3 1. no longer use the register names directly and optimized code format 2. to be compatible with O32, specify type of address variable with mips_reg and handle the address variable with PTR_ operator 3. ff_pred16x16_plane_

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Ronald S. Bultje
Hi, On Tue, May 17, 2016 at 6:07 AM, Michael Niedermayer wrote: > Most of the major public structures contain an AVClass. What are you hoping to accomplish with this struct that can currently not be done because it doesn't have an AVClass on top? I haven't seen this

[FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
Most of the major public structures contain an AVClass. We can add the AVClass now as there has been no release with AVCodecParameters after the next release this change would require a major version bump TODO: bump minor version TODO: update APIChanges Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] Refund request for CLT 2015 and CLT 2016

2016-05-17 Thread Stefano Sabatini
On date Friday 2016-03-25 02:05:26 +0100, Michael Niedermayer encoded: > On Tue, Mar 22, 2016 at 10:01:54AM +, Carl Eugen Hoyos wrote: > > Hi! > > > > I'd like to request refunds for my expenses going to > > Chemnitzer Linuxtage 2015 and 2016. Both years, we > > had a booth for two days

Re: [FFmpeg-devel] [PATCH] avcodec: Add AVClass to AVCodecParameters

2016-05-17 Thread Michael Niedermayer
On Tue, May 10, 2016 at 10:40:50PM +0200, wm4 wrote: > On Tue, 10 May 2016 22:21:12 +0200 (CEST) > Marton Balint wrote: > > > On Tue, 10 May 2016, Michael Niedermayer wrote: > > > > > On Tue, May 10, 2016 at 03:53:31PM +0200, wm4 wrote: > > >> On Tue, 10 May 2016 14:35:02

Re: [FFmpeg-devel] Refund request for FFmpeg at CLT 2016

2016-05-17 Thread Stefano Sabatini
On date Tuesday 2016-05-10 00:08:14 +0200, Michael Niedermayer encoded: > On Fri, Apr 29, 2016 at 11:30:26AM +0200, Thomas Volkert wrote: [...] > > >>My expenses consist of: > > >>- 1 x hotel: 154 € > > >please provide the approximate duration (number of nights, whatever) > > We booked the suite

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 3:21 AM, Michael Niedermayer wrote: > On Mon, May 16, 2016 at 03:21:43PM -0700, chcunning...@chromium.org wrote: >> From: Chris Cunningham >> >> Fixes: undefined shift. >> --- >> libavformat/utils.c | 2 +- >> 1 file