[FFmpeg-devel] [PATCHv4] af_hdcd: Add analyze mode (v4)

2016-08-07 Thread Burt P
A new mode, selected by filter option, to aid in analysis of HDCD encoded audio. In this mode the audio is replaced by a solid tone and the amplitude is adjusted to signal some specified aspect of the process. The output file can be loaded in an audio editor alongside the original, where the user c

[FFmpeg-devel] [PATCHv5] af_hdcd: Add analyze mode

2016-08-07 Thread Burt P
A new mode, selected by filter option, to aid in analysis of HDCD encoded audio. In this mode the audio is replaced by a solid tone and the amplitude is adjusted to signal some specified aspect of the process. The output file can be loaded in an audio editor alongside the original, where the user c

Re: [FFmpeg-devel] [PATCHv3 2/2] avformat: parse iTunes gapless information

2016-08-07 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 03:54:25PM -0700, kod...@gmail.com wrote: > From: Chris Moeller > > --- > libavformat/mp3dec.c | 64 > +++- > 1 file changed, 63 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > i

Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 00:51:30 +0100, Rostislav Pehlivanov wrote: > This version has had much testing so there's little point in keeping it > maked as experimental. ^ marked Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 01:10:55 -0500, Burt P. wrote: > "The ANMR coder requires -strict -2 and some may be removed in the future" > should have "some" removed. And I would probably quote the command line part of that, and use the symbolic value: "The ANMR coder requires \"-strict experimental\"

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 00:51:29 +0100, Rostislav Pehlivanov wrote: > +//XXX: some heuristic to determine initial quantizers will reduce search > time Is the "XXX" trying to tell someone something? > +for (g = 0; g < sce->ics.num_swb; g++) { I detect a spurious space in there. ;-)

Re: [FFmpeg-devel] [PATCH 5/6] libavformat/mxf: add dnxhr codec ul

2016-08-07 Thread Tomas Härdin
On Mon, 2016-07-04 at 18:07 -0700, Mark Reid wrote: > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 0affca9..8f2f10a 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -1098,6 +1098,10 @@ static int mxf_match_uid(const UID key, const UID uid, > int len) >  sta

Re: [FFmpeg-devel] [PATCH] Fix null dereferences in the qsv decoder

2016-08-07 Thread Ivan Uskov
Hello Yuli, Friday, July 29, 2016, 6:00:44 PM, you wrote: > This patch fixes the h264_qsv decoder issues mentioned > in https://ffmpeg.zeranoe.com/forum/viewtopic.php?t=2962. > The patch may be tested by specifying h264_qsv as the decoder to ffplay > for an h264 encoded file. > ffplay

[FFmpeg-devel] [PATCH] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Burt P
Signed-off-by: Burt P --- libavfilter/af_hdcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index e4e37e2..36da409 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1714,7 +1714,9 @@ static int config_input(

Re: [FFmpeg-devel] [PATCH] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Paul B Mahol
On 8/7/16, Burt P wrote: > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c > index e4e37e2..36da409 100644 > --- a/libavfilter/af_hdcd.c > +++ b/libavfilter/af_hdcd.c > @

Re: [FFmpeg-devel] [PATCH] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread James Almer
On 8/7/2016 12:50 PM, Burt P wrote: > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c > index e4e37e2..36da409 100644 > --- a/libavfilter/af_hdcd.c > +++ b/libavfilter/af

Re: [FFmpeg-devel] [PATCH] Fix null dereferences in the qsv decoder

2016-08-07 Thread Michael Niedermayer
On Sun, Aug 07, 2016 at 06:45:18PM +0300, Ivan Uskov wrote: > > Hello Yuli, > > Friday, July 29, 2016, 6:00:44 PM, you wrote: > > > This patch fixes the h264_qsv decoder issues mentioned > > in https://ffmpeg.zeranoe.com/forum/viewtopic.php?t=2962. > > > The patch may be tested by specifying h2

[FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Burt P
Signed-off-by: Burt P --- libavfilter/af_hdcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index e4e37e2..ebfe0f1 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1714,7 +1714,9 @@ static int config_input(

Re: [FFmpeg-devel] Subject: [PATCH] libavcodec/qsvdec_h2645.c: switch to the new BSF API

2016-08-07 Thread Michael Niedermayer
On Sun, Jul 24, 2016 at 10:05:27PM +0300, Ivan Uskov wrote: > Hello All, > > This patch applies same changes as commit > e3dfef8e3c85a64dbe6388117303f5819fa3c6a2 > of libav: instead obsolete AVBitStreamFilterContext now new AVBSFContext > filter uses to restore annex-B prefixes. > > Please revi

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Burt P a écrit : > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c > index e4e37e2..ebfe0f1 100644 > --- a/libavfilter/af_hdcd.c > +++

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Burt P.
On Sun, Aug 7, 2016 at 12:20 PM, Nicolas George wrote: > Sorry if it has been addressed before, but what are these tests? Why is this > filter invading other filters' privacy? The HDCD codes are stored in the LSB of consecutive samples, and anything that would change a sample could cause problems.

Re: [FFmpeg-devel] [PATCH 5/6] libavformat/mxf: add dnxhr codec ul

2016-08-07 Thread Michael Niedermayer
On Sun, Aug 07, 2016 at 03:49:34PM +0200, Tomas Härdin wrote: > On Mon, 2016-07-04 at 18:07 -0700, Mark Reid wrote: > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index 0affca9..8f2f10a 100644 > > --- a/libavformat/mxfdec.c > > +++ b/libavformat/mxfdec.c > > @@ -1098,6 +1098,10 @@

Re: [FFmpeg-devel] Outreachy 2016 december

2016-08-07 Thread Michael Niedermayer
Hi On Mon, Jul 25, 2016 at 03:31:04PM +0530, Mayank Agarwal wrote: > Hi, > > I want to contribute to Outreachy this time.It can be in any form be it > admin,testing,development,etc > I can easily devote 2,3 hrs per day for this task.It can be more also > depending on some task If you want to hel

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-07 Thread Rostislav Pehlivanov
On 7 August 2016 at 14:38, Moritz Barsnick wrote: > On Sun, Aug 07, 2016 at 00:51:29 +0100, Rostislav Pehlivanov wrote: > > +//XXX: some heuristic to determine initial quantizers will reduce > search time > > Is the "XXX" trying to tell someone something? > > > +for (g = 0; g < sce->

Re: [FFmpeg-devel] [PATCH] tests/fate/dnxhd: add dnxhr mov tests

2016-08-07 Thread Mark Reid
On Aug 3, 2016 6:46 PM, "Michael Niedermayer" wrote: > > On Wed, Aug 03, 2016 at 02:06:21PM -0700, Mark Reid wrote: > > --- > > tests/fate/vcodec.mak| 18 +- > > tests/ref/vsynth/vsynth1-dnxhd-hr-hq-mov | 4 > > tests/ref/vsynth/vsynth1-dnxhd-hr-l

Re: [FFmpeg-devel] [PATCH 5/6] libavformat/mxf: add dnxhr codec ul

2016-08-07 Thread Mark Reid
On Aug 7, 2016 11:14 AM, "Michael Niedermayer" wrote: > > On Sun, Aug 07, 2016 at 03:49:34PM +0200, Tomas Härdin wrote: > > On Mon, 2016-07-04 at 18:07 -0700, Mark Reid wrote: > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > > index 0affca9..8f2f10a 100644 > > > --- a/libavformat

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit : > The HDCD codes are stored in the LSB of consecutive samples, and > anything that would change a sample could cause problems. So it looks > through the AVFilterLink chain and warns if any resampling or > truncation is happening that might destr

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Carl Eugen Hoyos
2016-08-07 19:20 GMT+02:00 Nicolas George : > Sorry if it has been addressed before, but what are these tests? > Why is this filter invading other filters' privacy? i wanted to suggest since some time to remove sample_fmts_in[] (that is responsible for a possibly auto-inserted resampler) and inste

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : > i wanted to suggest since some time to remove sample_fmts_in[] > (that is responsible for a possibly auto-inserted resampler) and > instead error out if the input signal is not S16 (or S16P) 44100. That would not work: the pixel form

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Carl Eugen Hoyos
2016-08-07 23:07 GMT+02:00 Nicolas George : > Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : >> i wanted to suggest since some time to remove sample_fmts_in[] >> (that is responsible for a possibly auto-inserted resampler) and >> instead error out if the input signal is not S16 (or

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : > It would require the user to precisely declare what he wants which > is a good idea in this case because the filter can only work for > stereo s16 44100. No, it would not do that: there may be another filter in the chain that forces

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Carl Eugen Hoyos
2016-08-07 23:30 GMT+02:00 Nicolas George : > Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : >> It would require the user to precisely declare what he wants which >> is a good idea in this case because the filter can only work for >> stereo s16 44100. > > No, it would not do that: t

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : > I considered that acceptable but if better solutions exist (that are > also acceptable), I am happy. As I already pointed twice: /** * Enable or disable automatic format conversion inside the graph. * * Note that format conversio

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Carl Eugen Hoyos
Hi! 2016-08-07 23:50 GMT+02:00 Nicolas George : > Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : >> I considered that acceptable but if better solutions exist (that are >> also acceptable), I am happy. > > As I already pointed twice: > > /** > * Enable or disable automatic format

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit : > Wouldn't that disable any automatic conversion behind (after) the > hdcd filter? If that is correct, I would not consider it a better solution. The filter already checks for conversions after itself too. Conversion can still happen,

[FFmpeg-devel] [PATCH 1/2] libavcodec/dnxhdenc: add edge emulate for dnxhr

2016-08-07 Thread Mark Reid
Hi This patch fixes dnxhr encoders handling for resolutions that are not multiples of 16. --- libavcodec/dnxhdenc.c | 71 +++ libavcodec/dnxhdenc.h | 2 ++ 2 files changed, 56 insertions(+), 17 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/li

[FFmpeg-devel] [PATCH 2/2] tests/fate/vcodec: add dnxhr edge tests

2016-08-07 Thread Mark Reid
--- tests/fate/vcodec.mak | 20 +++- tests/ref/vsynth/vsynth1-dnxhd-edge1-hr | 4 tests/ref/vsynth/vsynth1-dnxhd-edge2-hr | 4 tests/ref/vsynth/vsynth1-dnxhd-edge3-hr | 4 tests/ref/vsynth/vsynth2-dnxhd-edge1-hr | 4 tes

Re: [FFmpeg-devel] [PATCH] libavcodec/dnxhdenc: remove setting the codec_tag

2016-08-07 Thread Mark Reid
On Fri, Aug 5, 2016 at 4:28 AM, Michael Niedermayer wrote: > On Fri, Aug 05, 2016 at 12:58:10PM +0200, Paul B Mahol wrote: >> On 8/5/16, Michael Niedermayer wrote: >> > On Wed, Aug 03, 2016 at 02:31:04PM -0700, Mark Reid wrote: >> >> setting the codec_tag no longer needed by movenc >> >> it uses

Re: [FFmpeg-devel] next Outreachy & GSoC ideas braindump [RFC]

2016-08-07 Thread Ronald S. Bultje
Hi, On Fri, Aug 5, 2016 at 6:20 PM, Michael Niedermayer wrote: > On Wed, Aug 03, 2016 at 07:48:36PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Aug 3, 2016 at 1:57 PM, Michael Niedermayer > > > wrote: > > > > > Hi all > > > > > > Sun, Jul 31, 2016 at 10:01:00PM +0200, Michael Niederm

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

2016-08-07 Thread Burt P.
Are you now talking about plans of the future or this specific case? As it is, automatic conversion is very helpful, for example from WavePack, which uses s16p. This filter is only looking at the AVFilterLinks between filters, not at the filters themselves. This scan and warn behavior was added to

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-08-07 Thread Omid Ghaffarinia
I made it into two patches, the first one only moves udp_set_multicast_ttl and second one does the fix. On Fri, Aug 5, 2016 at 3:19 AM, Michael Niedermayer wrote: > On Fri, Aug 05, 2016 at 01:20:12AM +0430, Omid Ghaffarinia wrote: >> Thanks for your comment, actually 'code move' is necessary to m