[FFmpeg-devel] [PATCH] avformat/mux: remove unnecessary autobsf hack

2016-09-22 Thread James Almer
autobsf has been ported to the new bsf API. Signed-off-by: James Almer --- libavformat/mux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index bbfc0fc..79fbbfc 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -309,12 +309,6 @@ FF_DISABL

[FFmpeg-devel] [PATCH] avformat/concatdec: don't call open_file when seek position within a file

2016-09-22 Thread raymondzheng1...@gmail.com
Thanks for your suggest, I have modified patch. see below. --- libavformat/concatdec.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index b3a430e..5cc239a 100644 --- a/libavformat/concatdec.c +++ b/l

Re: [FFmpeg-devel] [PATCH] avformat/utils: avoid using marked decoders for probing

2016-09-22 Thread Michael Niedermayer
On Thu, Sep 22, 2016 at 06:44:09PM +0200, Timo Rothenpieler wrote: > --- > libavformat/utils.c | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequa

Re: [FFmpeg-devel] [PATCH 1/5] lavd: Add SDL2 output device

2016-09-22 Thread Michael Niedermayer
On Thu, Sep 22, 2016 at 08:28:47PM +0100, Josh de Kock wrote: > Acked-by: Michael Niedermayer > Signed-off-by: Josh de Kock > --- > Changelog| 1 + > configure| 28 +++- > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + > libavdevice/sdl2.c

Re: [FFmpeg-devel] [PATCH] avfilter: add dynoverlay filter.

2016-09-22 Thread Priebe, Jason
Thanks for the detailed review of the code, Paul. You caught some dumb mistakes that I should have picked up on before I sent the submission. > dynoverlay sounds very powerful, but this filter funcionality is very limited. True, it is limited, but it does something that no other filter does (I a

Re: [FFmpeg-devel] [PATCH]lavf/mov: Read aspect ratio from ares atom for dnxhd

2016-09-22 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-19 14:57 GMT+02:00 Paul B Mahol : >> On 9/19/16, Paul B Mahol wrote: > >>> Ignore that one above, patck with corrected text is ok. >> >> title should mentioned what kind of aspect ratio this is about. As I >> thought it is about sar. > > Log message c

Re: [FFmpeg-devel] [PATCH] avfilter: add dynoverlay filter.

2016-09-22 Thread Paul B Mahol
On 9/22/16, Priebe, Jason wrote: > This patch adds a new filter that allows you to drive dynamic graphic > overlays > on a live encoding by creating/updating/deleting a specified 32-bit PNG. > This is very different from the overlay filter, because it lets you change > the overlay in real time dur

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

2016-09-22 Thread Sophia Wang
Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..936690d 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -738,13

[FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support

2016-09-22 Thread Josh de Kock
Hopefully the final iteration of this set--it drops SDL1 support entirely rather than adding another ffplay version and keeping the SDL1 output device. All of it has been reviewed before, so there shouldn't be too much (or anything to change). Josh de Kock (3): lavd: Add SDL2 output device MAI

[FFmpeg-devel] [PATCH 4/5] ffplay: add SDL2 support

2016-09-22 Thread Josh de Kock
From: Marton Balint This commit also drops SDL1 support for ffplay. Tested-by: James Almer (Windows, mingw-w64) Signed-off-by: Josh de Kock --- Changelog | 1 + configure | 6 +- ffplay.c | 594 ++ 3 files changed, 250 insertion

[FFmpeg-devel] [PATCH 2/5] MAINTAINERS: update my entries

2016-09-22 Thread Josh de Kock
Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f1f991d..d1e487a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -285,6 +285,7 @@ libavdevice pulse_audio_enc.c Lukas

[FFmpeg-devel] [PATCH 3/5] lavd/opengl: use SDL2

2016-09-22 Thread Josh de Kock
From: Lukasz Marek Signed-off-by: Lukasz Marek Signed-off-by: Josh de Kock --- libavdevice/opengl_enc.c | 109 +-- 1 file changed, 49 insertions(+), 60 deletions(-) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index 1dbbb80..9425

[FFmpeg-devel] [PATCH 5/5] lavd: drop SDL1 device & drop SDL1 support in general

2016-09-22 Thread Josh de Kock
Signed-off-by: Josh de Kock --- Changelog| 2 + configure| 33 + libavdevice/Makefile | 1 - libavdevice/alldevices.c | 1 - libavdevice/sdl.c| 377 --- 5 files changed, 3 insertions(+), 411 deletio

[FFmpeg-devel] [PATCH 1/5] lavd: Add SDL2 output device

2016-09-22 Thread Josh de Kock
Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- Changelog| 1 + configure| 28 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 377 +++ 5 files changed,

[FFmpeg-devel] [PATCH] avfilter: add dynoverlay filter.

2016-09-22 Thread Priebe, Jason
This patch adds a new filter that allows you to drive dynamic graphic overlays on a live encoding by creating/updating/deleting a specified 32-bit PNG. This is very different from the overlay filter, because it lets you change the overlay in real time during a live stream. It doesn't allow you to

Re: [FFmpeg-devel] [PATCH 6/6] ffprobe.c: Indicate decode-but-discard packets when doing -show_packets.

2016-09-22 Thread Sasi Inguva
ping On Thu, Sep 15, 2016 at 1:36 PM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > ffprobe.c | 3 +- > tests/ref/fate/concat-demuxer-extended-lavf-mxf| 2 +- > .../ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- > tests/ref/f

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-22 Thread Sasi Inguva
On Thu, Sep 22, 2016 at 5:49 AM, wm4 wrote: > On Tue, 20 Sep 2016 14:29:46 -0700 > Sasi Inguva wrote: > > > Signed-off-by: Sasi Inguva > > --- > > libavcodec/utils.c | 15 +++--- > > libavformat/mov.c| 81 > > >

[FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-22 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavcodec/utils.c | 16 +++--- libavformat/mov.c| 81 tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +- tests/ref/fate/gaplessenc-pcm-to-mov-aac | 2 +- 4 files changed, 79

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-22 Thread James Almer
On 9/15/2016 2:36 PM, James Almer wrote: > There have been some complains from developers about keeping both > SDL1 and SDL2 support at the same time even after all SDL1 code > has been already ported, and especially since it makes maintaining > ffplay more complex, so seeing the waters are divided

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

2016-09-22 Thread Sophia Wang
I think you're right. Seems like the best solution is to maintain the number of calls to matroska_deliver_packet(); patch modification on the way. On Wed, Aug 31, 2016 at 6:30 PM, Michael Niedermayer wrote: > > On Mon, Aug 15, 2016 at 10:27:47AM -0700, Sophia Wang wrote: > > Of the 3 functions t

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-22 Thread Stefano Sabatini
On date Sunday 2016-09-18 15:28:45 +0200, Stefano Sabatini encoded: > On date Saturday 2016-09-17 18:42:35 +0200, Paul B Mahol encoded: > > On 9/17/16, Stefano Sabatini wrote: > > > On date Sunday 2016-09-04 23:25:56 +0200, Michael Niedermayer encoded: > > >> On Sun, Sep 04, 2016 at 06:24:37PM +02

[FFmpeg-devel] [PATCH] avformat/utils: avoid using marked decoders for probing

2016-09-22 Thread Timo Rothenpieler
--- libavformat/utils.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 05d2315..93ea6ff 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -188,6 +188,8 @@ FF_ENABLE_DEPRECATION_WARNINGS static c

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, master uses _WIN32 checks in both places so if its not set, it will never error, because it'll never even try to call it. 3.1 uses a different check because it was refactored in master later, and while 3.1.3 was still missing one check, it was fixed after that release was made. Unless master

Re: [FFmpeg-devel] [PATCH 1/2] img2: added support for %t output pattern

2016-09-22 Thread Roger Pack
On 1/4/12, Yuval Adam wrote: > From: Yuval Adam > > The image2 muxer now supports timestamps in output filenames. > When used in an output patterm '%t' will be replaced with the frames > timestamp in hours, minutes and seconds (hh:mm:ss). A somewhat updated (but not yet cleaned up) revision: ht

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-22 Thread wm4
On Thu, 15 Sep 2016 14:36:32 -0300 James Almer wrote: > There have been some complains from developers about keeping both > SDL1 and SDL2 support at the same time even after all SDL1 code > has been already ported, and especially since it makes maintaining > ffplay more complex, so seeing the wat

Re: [FFmpeg-devel] [PATCH 2/3] avformat/utils: avoid using marked decoders for probing

2016-09-22 Thread Michael Niedermayer
On Thu, Sep 22, 2016 at 02:00:04PM +0200, Timo Rothenpieler wrote: > --- > libavformat/utils.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 05d2315..87a6dd7 100644 > --- a/libavformat/utils.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add new AVOID_PROBING capability

2016-09-22 Thread Michael Niedermayer
On Thu, Sep 22, 2016 at 02:00:03PM +0200, Timo Rothenpieler wrote: > --- > doc/APIchanges | 3 +++ > libavcodec/avcodec.h | 10 ++ > libavcodec/version.h | 4 ++-- > 3 files changed, 15 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Tobias Rapp
On 22.09.2016 14:23, Hendrik Leppkes wrote: On Thu, Sep 22, 2016 at 2:21 PM, Timo Rothenpieler wrote: master uses _WIN32 checks in both places so if its not set, it will never error, because it'll never even try to call it. But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP

Re: [FFmpeg-devel] [PATCH 3/4] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

2016-09-22 Thread wm4
On Mon, 19 Sep 2016 21:20:08 +0200 Carl Eugen Hoyos wrote: > 2016-09-19 20:32 GMT+02:00 wm4 : > > > But I guess you don't care, neither did whoever pushed this > > low quality patch before the patch was fixed? > > I believe you didn't oppose the current mailing list rules so > please refrain

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-22 Thread wm4
On Tue, 20 Sep 2016 14:29:46 -0700 Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/utils.c | 15 +++--- > libavformat/mov.c| 81 > > tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +- > tes

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add new AVOID_PROBING capability

2016-09-22 Thread wm4
On Thu, 22 Sep 2016 14:00:03 +0200 Timo Rothenpieler wrote: > --- > doc/APIchanges | 3 +++ > libavcodec/avcodec.h | 10 ++ > libavcodec/version.h | 4 ++-- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 158a0b2..5d57

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 2:21 PM, Timo Rothenpieler wrote: >> master uses _WIN32 checks in both places so if its not set, it will >> never error, because it'll never even try to call it. > > But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP > compatibility, as the function doesn'

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Timo Rothenpieler
> master uses _WIN32 checks in both places so if its not set, it will > never error, because it'll never even try to call it. But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP compatibility, as the function doesn't exist there, but _WIN32 is obviously set? Or does master just n

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 1:52 PM, Timo Rothenpieler wrote: > Am 22.09.2016 um 13:37 schrieb Michael Fritscher: >> Hi, >> >> ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is >> defined, but _WIN32 is not if compiling under cygwin (fresh install, no >> mingw). >> >> SetDllDirectory()

[FFmpeg-devel] [PATCH 2/3] avformat/utils: avoid using marked decoders for probing

2016-09-22 Thread Timo Rothenpieler
--- libavformat/utils.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 05d2315..87a6dd7 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -188,6 +188,8 @@ FF_ENABLE_DEPRECATION_WARNINGS static const AVC

[FFmpeg-devel] [PATCH 3/3] avcodec/cuvid: mark as avoid for probing

2016-09-22 Thread Timo Rothenpieler
--- libavcodec/cuvid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cuvid.c b/libavcodec/cuvid.c index db96ac6..c040b09 100644 --- a/libavcodec/cuvid.c +++ b/libavcodec/cuvid.c @@ -911,7 +911,7 @@ static const AVOption options[] = { .send_packet= cuvi

[FFmpeg-devel] [PATCH 1/3] avcodec: add new AVOID_PROBING capability

2016-09-22 Thread Timo Rothenpieler
--- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 10 ++ libavcodec/version.h | 4 ++-- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 158a0b2..5d577e4 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,9 @@ libavut

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Timo Rothenpieler
Am 22.09.2016 um 13:37 schrieb Michael Fritscher: > Hi, > > ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is > defined, but _WIN32 is not if compiling under cygwin (fresh install, no > mingw). > > SetDllDirectory() is called whenever HAVE_SETDLLDIRECTORY is defined, > there is no

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is defined, but _WIN32 is not if compiling under cygwin (fresh install, no mingw). SetDllDirectory() is called whenever HAVE_SETDLLDIRECTORY is defined, there is no check for _WIN32. The configure script seems to test window

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Tobias Rapp
On 22.09.2016 12:30, Michael Fritscher wrote: Hi, I try to build ffmpeg 3.1.3 on cygwin64 on Windows. Configstring: ./configure --prefix=/usr/local --enable-ffplay --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 --enable-nonfree --enable-shared --enable-libfreetype --enable-lib

Re: [FFmpeg-devel] [PATCH] avformat/utils: force native h264 decoder for probing

2016-09-22 Thread Timo Rothenpieler
Am 22.09.2016 um 12:36 schrieb Michael Niedermayer: > On Thu, Sep 22, 2016 at 11:09:08AM +0200, Timo Rothenpieler wrote: >> --- >> libavformat/utils.c | 18 +++--- >> 1 file changed, 15 insertions(+), 3 deletions(-) > > LGTM > > thx pushed ___

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 12:30 PM, Michael Fritscher wrote: > Hi, > > I try to build ffmpeg 3.1.3 on cygwin64 on Windows. > > Configstring: ./configure --prefix=/usr/local --enable-ffplay > --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 > --enable-nonfree --enable-shared --enable-

Re: [FFmpeg-devel] [PATCH] avformat/utils: force native h264 decoder for probing

2016-09-22 Thread Michael Niedermayer
On Thu, Sep 22, 2016 at 11:09:08AM +0200, Timo Rothenpieler wrote: > --- > libavformat/utils.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use go

[FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, I try to build ffmpeg 3.1.3 on cygwin64 on Windows. Configstring: ./configure --prefix=/usr/local --enable-ffplay --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 --enable-nonfree --enable-shared --enable-libfreetype --enable-libgsm --enable-libmp3lame --enable-libopencv -

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder: Limit sf_idx difference for all cases

2016-09-22 Thread Claudio Freire
On Sat, Sep 10, 2016 at 3:37 AM, Claudio Freire wrote: > On Thu, Aug 25, 2016 at 8:57 AM, Rostislav Pehlivanov > wrote: >>> 64ed96a710787ba5d0666746a8562e7d.dee >>> >>> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/aaccoder.

[FFmpeg-devel] [PATCH] avformat/utils: force native h264 decoder for probing

2016-09-22 Thread Timo Rothenpieler
--- libavformat/utils.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index a9bd034..05d2315 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -186,6 +186,18 @@ FF_ENABLE_DEPRECATION_WARNINGS retur

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: don't call open_file when seek position within a file

2016-09-22 Thread Nicolas George
Le jour de la Récompense, an CCXXIV, raymond a écrit : > --- > libavformat/concatdec.c | 27 --- > 1 file changed, 20 insertions(+), 7 deletions(-) Thanks for the patch. The object of the change is interesting, but there are some implementation concerns, see below. Also,

Re: [FFmpeg-devel] [PATCH]lavc/avpacket: Fix undefined behaviour, do not pass a null pointer to memcpy()

2016-09-22 Thread Carl Eugen Hoyos
2016-09-22 3:39 GMT+02:00 Michael Niedermayer : > On Thu, Sep 22, 2016 at 01:07:06AM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #5857. >> >> Please comment, Carl Eugen > >> avpacket.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> 6ff2850caef558476bbe

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding.

2016-09-22 Thread Sasi Inguva
friendly ping On Tue, Sep 20, 2016 at 2:29 PM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/utils.c | 15 +++--- > libavformat/mov.c| 81 > > tests/ref/fate/gaplessenc-itunes-to-ipod-aac |