Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskaenc: support writting Chroma Location elements

On 10/22/2016 5:38 PM, James Almer wrote: > On 10/15/2016 12:40 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/matroskaenc.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >> index a48f5bb..d655

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: use display aspect ratio for DisplayWidth and DisplayHeight when possible

On 10/22/2016 5:33 PM, James Almer wrote: > This avoids potential rounding errors and guarantees the source aspect > ratio is preserved. > Keep writing pixel values when Stereo 3D Mode is enabled and for WebM, > as the format doesn't support anything else. > > This fixes ticket #5743, implementing

[FFmpeg-devel] [PATCH] crystalhd: Reorder mspeg4 decoder after software decoders

This avoids it getting picked by default, which is generally undesirable and can break test runs. Signed-off-by: Philip Langdale --- libavcodec/allcodecs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index b592aa3..594d104 1

Re: [FFmpeg-devel] [PATCH] fate: add apng encoding/muxing test

On 10/27/2016 8:45 PM, Andreas Cadhalpun wrote: > Also test the fallback to png creation for a single frame. > > Signed-off-by: Andreas Cadhalpun > --- > > Obviously, the patch fixing this has to be applied first. > > --- > tests/fate/avformat.mak | 1 + > tests/lavf-regression.sh | 9 +++

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 28.10.2016 01:33, James Almer wrote: > On 10/27/2016 7:43 PM, Andreas Cadhalpun wrote: >> To avoid confusion and for lack of a better name I called the variables in >> the encoder/muxer >> contexts extra_side_data*. > > extra_data* (with an underscore so it's different) is IMO better. It conta

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 10/27/2016 7:43 PM, Andreas Cadhalpun wrote: > On 27.10.2016 23:39, James Almer wrote: >> > On 10/27/2016 5:38 PM, Andreas Cadhalpun wrote: >>> >> libavcodec/pngenc.c | 4 >>> >> libavformat/apngenc.c | 27 --- >>> >> 2 files changed, 28 insertions(+), 3 deletion

[FFmpeg-devel] [PATCH] fate: add apng encoding/muxing test

Also test the fallback to png creation for a single frame. Signed-off-by: Andreas Cadhalpun --- Obviously, the patch fixing this has to be applied first. --- tests/fate/avformat.mak | 1 + tests/lavf-regression.sh | 9 + tests/ref/lavf/apng | 6 ++ 3 files changed, 16 inserti

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

On Thu, Oct 27, 2016 at 11:38:27PM +0530, Pallavi Kumari wrote: > Hi Michael, > > I have attached a patch with the mail. > > With `avcodec_get_frame_defaults (&frame)` in the function readAudio > program was working fine with old version in my system. But this function > is not in the latest git

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 27.10.2016 23:39, James Almer wrote: > On 10/27/2016 5:38 PM, Andreas Cadhalpun wrote: >> libavcodec/pngenc.c | 4 >> libavformat/apngenc.c | 27 --- >> 2 files changed, 28 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct timescale when seeking for audio.

gentle ping. Thanks! On Mon, Oct 24, 2016 at 4:20 PM, Michael Niedermayer wrote: > On Sun, Oct 23, 2016 at 10:41:52PM -0700, Sasi Inguva wrote: > > Attaching the fate sample. > > uploaded > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If y

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 10/27/2016 5:38 PM, Andreas Cadhalpun wrote: > On 27.10.2016 21:37, James Almer wrote: >> > If apng encoder needs to add new extradata in a packet, it should do it >> > with av_packet_new_side_data() instead. > Thanks for the hint. Attached is a patch fixing it that way. > > Best regards, > And

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On Thu, Oct 27, 2016 at 10:59 PM, Philip Langdale wrote: > On 2016-10-27 13:47, Hendrik Leppkes wrote: >> >> On Thu, Oct 27, 2016 at 5:09 PM, Philip Langdale >> wrote: >>> >>> On Thu, 27 Oct 2016 16:01:42 +0200 >>> Timo Rothenpieler wrote: >>> > > breaks fate: > > ./configure

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On 2016-10-27 13:47, Hendrik Leppkes wrote: On Thu, Oct 27, 2016 at 5:09 PM, Philip Langdale wrote: On Thu, 27 Oct 2016 16:01:42 +0200 Timo Rothenpieler wrote: > > breaks fate: > > ./configure && make -j12 fate-vsynth1-msmpeg4 > ... > TESTvsynth1-msmpeg4 > --- ./tests/ref/vsynth/vsynth1-

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On Thu, Oct 27, 2016 at 5:09 PM, Philip Langdale wrote: > On Thu, 27 Oct 2016 16:01:42 +0200 > Timo Rothenpieler wrote: > >> > >> > breaks fate: >> > >> > ./configure && make -j12 fate-vsynth1-msmpeg4 >> > ... >> > TESTvsynth1-msmpeg4 >> > --- ./tests/ref/vsynth/vsynth1-msmpeg4 2016-10-27 >>

Re: [FFmpeg-devel] [PATCH] avcodec: validate codec parameters in avcodec_parameters_to_context

On 27.10.2016 22:14, Michael Niedermayer wrote: > On Wed, Oct 26, 2016 at 01:59:59AM +0200, Andreas Cadhalpun wrote: >> Note that the added asserts are triggered by *many* of my fuzzed samples. >> I'm happy to write patches for these cases, if we achieve agreement >> that the central check alone is

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 27.10.2016 21:37, James Almer wrote: > If apng encoder needs to add new extradata in a packet, it should do it > with av_packet_new_side_data() instead. Thanks for the hint. Attached is a patch fixing it that way. Best regards, Andreas >From 4325ccdaf3bb7c74312cbaeb49d76fe535f18956 Mon Sep 17

Re: [FFmpeg-devel] [PATCH] hls: always call avformat_find_stream_info for subdemuxers

On 27.10.2016 21:30, Hendrik Leppkes wrote: > On Thu, Oct 27, 2016 at 9:20 PM, Andreas Cadhalpun > wrote: >> This fixes probing dts/eac3/mp2 in hls. >> >> This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13. >> > > That commit does a lot of magic flag handling to avoid calling tha

Re: [FFmpeg-devel] [PATCH] hls: always call avformat_find_stream_info for subdemuxers

On Thu, 27 Oct 2016, Hendrik Leppkes wrote: On Thu, Oct 27, 2016 at 9:20 PM, Andreas Cadhalpun wrote: This fixes probing dts/eac3/mp2 in hls. This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13. That commit does a lot of magic flag handling to avoid calling that function a

Re: [FFmpeg-devel] [PATCH] avcodec: validate codec parameters in avcodec_parameters_to_context

On Wed, Oct 26, 2016 at 01:59:59AM +0200, Andreas Cadhalpun wrote: > On 25.10.2016 14:56, Hendrik Leppkes wrote: > > On Tue, Oct 25, 2016 at 2:39 PM, wm4 wrote: > >> On Tue, 25 Oct 2016 09:47:29 +0200 > >> Hendrik Leppkes wrote: > >> > >>> On Tue, Oct 25, 2016 at 1:50 AM, Andreas Cadhalpun > >>>

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

On 10/27/2016 4:19 PM, Andreas Cadhalpun wrote: > This fixes creating apng files. > > This partly reverts commit 5ef19590802f000299e418143fc2301e3f43affe. > > Signed-off-by: Andreas Cadhalpun > --- > ffmpeg.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/ffmpeg.c b/ffmp

Re: [FFmpeg-devel] [PATCH] hls: always call avformat_find_stream_info for subdemuxers

On Thu, Oct 27, 2016 at 9:20 PM, Andreas Cadhalpun wrote: > This fixes probing dts/eac3/mp2 in hls. > > This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13. > That commit does a lot of magic flag handling to avoid calling that function all the time (in fact that seems to be one of

[FFmpeg-devel] [PATCH] hls: always call avformat_find_stream_info for subdemuxers

This fixes probing dts/eac3/mp2 in hls. This partly reverts commit 04964ac311abe670fb3b60290a330f2067544b13. Signed-off-by: Andreas Cadhalpun --- libavformat/hls.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3c0

[FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

This fixes creating apng files. This partly reverts commit 5ef19590802f000299e418143fc2301e3f43affe. Signed-off-by: Andreas Cadhalpun --- ffmpeg.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index 3b91710..9971148 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@

Re: [FFmpeg-devel] FFmpeg 3.2

On 27.10.2016 20:07, Michael Niedermayer wrote: > i didnt see this before making the release Bad timing, can happen. (I guess I should have checked this earlier, or rather FATE should have...) > but 3.2.1 is planed in a week or 2 Let's get it fixed in that release. Best regards, Andreas _

Re: [FFmpeg-devel] FFmpeg 3.2

On 27.10.2016 18:44, James Almer wrote: > Could you do a bisect and trac ticket for these? HLS got a lot of commits in > the past > few months. > apng didn't, so that one is weird. I've found the commits causing the problems: * commit 5ef19590802f000299e418143fc2301e3f43affe causes the apng issu

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

Hi, On Thu, Oct 27, 2016 at 2:36 PM, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > Hello > > On 10/27/2016 11:25 AM, James Almer wrote: > >> [..] >> >> This is not how things were agreed. >> >> > I haven't agreed to this. Agreement that does not have to be unanimous. Ronald

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

Hello On 10/27/2016 11:25 AM, James Almer wrote: [..] This is not how things were agreed. I haven't agreed to this. The patch fixes nothing while breaking master for ffserver users. There's a way forward, but the patch can't be applied before it happens. Bests, -- Reynaldo H. Verdejo Pino

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On 10/27/2016 3:36 PM, Reynaldo H. Verdejo Pinochet wrote: > Hello > > On 10/27/2016 11:25 AM, James Almer wrote: >> [..] >> >> This is not how things were agreed. >> > > I haven't agreed to this. You could have shown your displeasure in the relevant discussion and patch threads, and on IRC. Why

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On 10/27/2016 3:22 PM, Reynaldo H. Verdejo Pinochet wrote: > I understand you might be upset but please refrain from > using bad language. > > The way I see it your removal will happen once there's a > solution in place just not before. This is why the patch > is not rejected. This is not how thi

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On Thu, Oct 27, 2016 at 11:03:07AM -0700, Reynaldo H. Verdejo Pinochet wrote: > I'm not OK with this patch. My reasons are: > > * There are users relying on it > * We gain nothing by removing ffserver without a > replacement or alternate solution > > One solution I would support is a transition

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

I understand you might be upset but please refrain from using bad language. The way I see it your removal will happen once there's a solution in place just not before. This is why the patch is not rejected. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On 27 October 2016 at 19:14, James Almer wrote: > On 10/27/2016 3:03 PM, Reynaldo H. Verdejo Pinochet wrote: > > I'm not OK with this patch. My reasons are: > > > > * There are users relying on it > > * We gain nothing by removing ffserver without a > > replacement or alternate solution > > > >

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On 10/27/2016 3:03 PM, Reynaldo H. Verdejo Pinochet wrote: > I'm not OK with this patch. My reasons are: > > * There are users relying on it > * We gain nothing by removing ffserver without a > replacement or alternate solution > We've discussed the removal of ffserver and even /announced/ it

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

Hi Michael, I have attached a patch with the mail. With `avcodec_get_frame_defaults (&frame)` in the function readAudio program was working fine with old version in my system. But this function is not in the latest git repo so I used `av_frame_unref(&frame)` instead and the program segfaults. I a

Re: [FFmpeg-devel] FFmpeg 3.2

On Thu, Oct 27, 2016 at 06:15:52PM +0200, Andreas Cadhalpun wrote: > Hi, > > On 26.10.2016 21:29, Michael Niedermayer wrote: > > On Tue, Sep 27, 2016 at 03:30:03PM +0200, Michael Niedermayer wrote: > >> Its long since FFmpeg 3.1, so its time to make 3.2 > >> ill branch release/3.2 off master and m

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

I'm not OK with this patch. My reasons are: * There are users relying on it * We gain nothing by removing ffserver without a replacement or alternate solution One solution I would support is a transition made by moving all applications to a separate repo hosted within the same infra. With a co

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On 2016-10-27 09:48, Nicolas George wrote: Le sextidi 6 brumaire, an CCXXV, Philip Langdale a écrit : the library spams stdout (which sucks, but what can you do) First step, look if there is a clean way of fixing it from the outside. Maybe by setting a logging callback? You probably already di

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

Le sextidi 6 brumaire, an CCXXV, Philip Langdale a écrit : > the library spams stdout (which sucks, but what can you do) First step, look if there is a clean way of fixing it from the outside. Maybe by setting a logging callback? You probably already did that. Second step, if there is no clean wa

Re: [FFmpeg-devel] FFmpeg 3.2

On 10/27/2016 1:15 PM, Andreas Cadhalpun wrote: > Hi, > > On 26.10.2016 21:29, Michael Niedermayer wrote: >> On Tue, Sep 27, 2016 at 03:30:03PM +0200, Michael Niedermayer wrote: >>> Its long since FFmpeg 3.1, so its time to make 3.2 >>> ill branch release/3.2 off master and make 3.2 in maybe about

Re: [FFmpeg-devel] FFmpeg 3.2

Hi, On 26.10.2016 21:29, Michael Niedermayer wrote: > On Tue, Sep 27, 2016 at 03:30:03PM +0200, Michael Niedermayer wrote: >> Its long since FFmpeg 3.1, so its time to make 3.2 >> ill branch release/3.2 off master and make 3.2 in maybe about a week or >> 2 unless something delays it > > release/3

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

On date Wednesday 2016-10-26 01:46:35 +0200, Michael Niedermayer encoded: > On Tue, Oct 25, 2016 at 05:07:34PM +0200, Stefano Sabatini wrote: [...] > > 267580c51d49daf94e73a33175c63ecfed6a0bed > > 0002-lavf-add-ffprobe-demuxer.patch > > From 4e0aac4bc00104483859f9950af2ffb15fea6c12 Mon Sep 17 00:

Re: [FFmpeg-devel] [PATCH 4/4] tests/fate/avformat: add segment.c tests

On Thu, Oct 27, 2016 at 01:16:13AM -0500, Rodger Combs wrote: > --- > tests/fate/avformat.mak | 56 +++ > tests/ref/fate/segment-adts-to-mkv-header-000 | 20 > tests/ref/fate/segment-adts-to-mkv-header-001 | 21 + > tests/ref/fate/segment-adts-to-mkv-heade

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On Thu, 27 Oct 2016 16:01:42 +0200 Timo Rothenpieler wrote: > > > > breaks fate: > > > > ./configure && make -j12 fate-vsynth1-msmpeg4 > > ... > > TESTvsynth1-msmpeg4 > > --- ./tests/ref/vsynth/vsynth1-msmpeg4 2016-10-27 > > 03:11:18.675647981 +0200 +++ tests/data/fate/vsynth1-msmpeg4 > >

Re: [FFmpeg-devel] decode_slice_header error

On Thu, Oct 27, 2016 at 12:26:09 +, Stefano Carucci wrote: > I came across an issue while decoding the H264 elementary stream with the > following error: This is the development list, not the usage list. > [h264 @ 0x1851540] Found reference and non-reference fields in the > same frame, which

Re: [FFmpeg-devel] [PATCH] lavd/xcbgrab: do not try to create refcounted packets.

Nicolas George wrote: The framework will allocate a buffer and copy the data to it, that takes time. But it avoids constently creating and destroyng the shared memory segment, and that saves more time. On my setup, from ~200 to ~300 FPS at full screen (1920×1200), from ~1400 to ~3300 at smaller

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

> > breaks fate: > > ./configure && make -j12 fate-vsynth1-msmpeg4 > ... > TESTvsynth1-msmpeg4 > --- ./tests/ref/vsynth/vsynth1-msmpeg4 2016-10-27 03:11:18.675647981 +0200 > +++ tests/data/fate/vsynth1-msmpeg4 2016-10-27 15:01:15.397863504 +0200 Does fate seriously test crystalhd hardwa

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

On 10/26/2016 7:43 PM, Rostislav Pehlivanov wrote: > From 48d1ed653e7841f49f50559510ca06f524cbbf1f Mon Sep 17 00:00:00 2001 > From: Rostislav Pehlivanov > Date: Wed, 26 Oct 2016 23:38:46 +0100 > Subject: [PATCH] Remove the ffserver program > > Also changes the mpjpeg boundary tag to "ffmpeg" (it'

Re: [FFmpeg-devel] [PATCH 2/4] lavf/matroskaenc: fix uninitialized read

On 10/27/2016 3:16 AM, Rodger Combs wrote: > --- > libavformat/matroskaenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index d91055f..c94a490 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matrosk

Re: [FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

On Wed, Oct 26, 2016 at 12:40:20PM -0700, Philip Langdale wrote: > The new decode API allows for m:n decode patterns, which is what > you need to use this hardware in a sane way. There are so many > situations where 1:1 doesn't happen naturally that it's a miracle > I got it working as well as I di

[FFmpeg-devel] decode_slice_header error

Hello, I came across an issue while decoding the H264 elementary stream with the following error: [h264 @ 0x1851540] Found reference and non-reference fields in the same frame, which is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it mean

[FFmpeg-devel] why the option 'timeout' in native rtmp plugin doesn't work

Hi, 1) I want to open and read some rtmp live stream, and don't like wait indefinite time for some rtmp stream when there is no rtmp stream to come. Therefore, the option of 'timeout' is used to set the longest waiting time. But it didn't work, and avformat_open_input() reported as follows:

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 15:34 GMT+08:00 Rodger Combs : > > > On Oct 27, 2016, at 02:07, Steven Liu wrote: > > > > 2016-10-27 15:01 GMT+08:00 Steven Liu lingjiujia...@gmail.com>>: > > > >> > >> > >> 2016-10-27 14:52 GMT+08:00 Rodger Combs : > >> > >>> > On Oct 27, 2016, at 01:41, Steven Liu > wrote: > >

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

> On Oct 27, 2016, at 02:07, Steven Liu wrote: > > 2016-10-27 15:01 GMT+08:00 Steven Liu >: > >> >> >> 2016-10-27 14:52 GMT+08:00 Rodger Combs : >> >>> On Oct 27, 2016, at 01:41, Steven Liu wrote: 2016-10-27 14:16 GMT+08:00 Rodger Combs : >>

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 14:52 GMT+08:00 Rodger Combs : > > > On Oct 27, 2016, at 01:41, Steven Liu wrote: > > > > 2016-10-27 14:16 GMT+08:00 Rodger Combs : > > > >> --- > >> libavformat/segment.c | 40 +++- > >> 1 file changed, 39 insertions(+), 1 deletion(-) > >> > >> diff

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 15:01 GMT+08:00 Steven Liu : > > > 2016-10-27 14:52 GMT+08:00 Rodger Combs : > >> >> > On Oct 27, 2016, at 01:41, Steven Liu wrote: >> > >> > 2016-10-27 14:16 GMT+08:00 Rodger Combs : >> > >> >> --- >> >> libavformat/segment.c | 40 +++- >> >> 1 file