[FFmpeg-devel] [PATCH] aacenc: quit when the audio queue reaches 0 rather than keeping track of empty frames

2016-11-06 Thread Rostislav Pehlivanov
The libopus encoder does the same thing and its better than keeping track of when the empty flush frames appear. Signed-off-by: Rostislav Pehlivanov --- libavcodec/aacenc.c | 9 +++-- libavcodec/aacenc.h | 1 - 2 files changed, 3 insertions(+), 7 deletions(-) diff

[FFmpeg-devel] [PATCH] mpegaudio_parser: don't return AVERROR_PATCHWELCOME

2016-11-06 Thread Andreas Cadhalpun
The API does not allow returning AVERROR codes. It triggers an assert in av_parser_parse2. Signed-off-by: Andreas Cadhalpun --- libavcodec/mpegaudio_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegaudio_parser.c

Re: [FFmpeg-devel] [PATCH 01/12] adxdec: validate sample_rate

2016-11-06 Thread Andreas Cadhalpun
On 02.11.2016 23:09, Andreas Cadhalpun wrote: > In the absence of further comments, I intend to push this set in a few days. I've pushed this now. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] hls: fix leaking avio_opts on hls_read_header error

2016-11-06 Thread Andreas Cadhalpun
Use the hls_close function to reduce code duplication. Signed-off-by: Andreas Cadhalpun --- libavformat/hls.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index

Re: [FFmpeg-devel] [PATCH 3/3 v2] avformat/hls: Add missing error check for avcodec_parameters_copy()

2016-11-06 Thread Andreas Cadhalpun
On 06.11.2016 23:52, Anssi Hannula wrote: > Signed-off-by: Anssi Hannula > --- > > 07.11.2016, 00:35, Andreas Cadhalpun kirjoitti: >> On 06.11.2016 22:44, Anssi Hannula wrote: >>> Signed-off-by: Anssi Hannula >>> --- >>> libavformat/hls.c | 18

[FFmpeg-devel] [PATCH 3/3 v2] avformat/hls: Add missing error check for avcodec_parameters_copy()

2016-11-06 Thread Anssi Hannula
Signed-off-by: Anssi Hannula --- 07.11.2016, 00:35, Andreas Cadhalpun kirjoitti: > On 06.11.2016 22:44, Anssi Hannula wrote: >> Signed-off-by: Anssi Hannula >> --- >> libavformat/hls.c | 18 ++ >> 1 file changed, 14 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Add missing error check for avcodec_parameters_copy()

2016-11-06 Thread Andreas Cadhalpun
On 06.11.2016 22:44, Anssi Hannula wrote: > Signed-off-by: Anssi Hannula > --- > libavformat/hls.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > This misses checking the return code of the other occurrence of

Re: [FFmpeg-devel] [PATCH 2/3 v2] avformat/hls: Fix probing mpegts audio streams that use probing

2016-11-06 Thread Andreas Cadhalpun
On 06.11.2016 22:44, Anssi Hannula wrote: > Commit 04964ac311abe670f ("avformat/hls: Fix missing streams in some > cases with MPEG TS") caused a regression where subdemuxer streams that > use probing (e.g. dts/eac3/mp2 in mpegts) no longer get probed properly. > > This is because the codec

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hls: Factor copying stream info to a separate function

2016-11-06 Thread Andreas Cadhalpun
On 06.11.2016 22:44, Anssi Hannula wrote: > Signed-off-by: Anssi Hannula > --- > > libavformat/hls.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 3c09dd8..6fb652c 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat: Allow forcing use of AVParsers

2016-11-06 Thread Hendrik Leppkes
On Sun, Nov 6, 2016 at 9:16 PM, Michael Niedermayer wrote: > TODO: version bump, docs > > Signed-off-by: Michael Niedermayer > --- > libavformat/avformat.h | 8 > libavformat/options_table.h | 7 +++ > libavformat/utils.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_drawtext: fixed default/flt formatting ignoring offset parameter

2016-11-06 Thread Michael Niedermayer
On Mon, Sep 26, 2016 at 04:36:01PM -0400, Alexander Agranovsky wrote: > > vf_drawtext.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > c20a7bcfcac020dda3970d547556227e2a19e822 > 0001-avfilter-vf_drawtext-fixed-default-flt-formatting-ig.patch > From

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Fix probing mpegts audio streams that use probing

2016-11-06 Thread Anssi Hannula
05.11.2016, 19:51, Andreas Cadhalpun kirjoitti: > On 05.11.2016 18:47, Andreas Cadhalpun wrote: >> On 05.11.2016 17:39, Anssi Hannula wrote: >>> @@ -1981,6 +1986,11 @@ static int hls_read_packet(AVFormatContext *s, >>> AVPacket *pkt) >>> >>>

[FFmpeg-devel] [PATCH 1/3] avformat/hls: Factor copying stream info to a separate function

2016-11-06 Thread Anssi Hannula
Signed-off-by: Anssi Hannula --- libavformat/hls.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3c09dd8..6fb652c 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1528,6

[FFmpeg-devel] [PATCH 3/3] avformat/hls: Add missing error check for avcodec_parameters_copy()

2016-11-06 Thread Anssi Hannula
Signed-off-by: Anssi Hannula --- libavformat/hls.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ce52bf5..a744908 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1528,9 +1528,13

[FFmpeg-devel] [PATCH 2/3 v2] avformat/hls: Fix probing mpegts audio streams that use probing

2016-11-06 Thread Anssi Hannula
Commit 04964ac311abe670f ("avformat/hls: Fix missing streams in some cases with MPEG TS") caused a regression where subdemuxer streams that use probing (e.g. dts/eac3/mp2 in mpegts) no longer get probed properly. This is because the codec parameters from the subdemuxer stream, once probed, are

Re: [FFmpeg-devel] [PATCH] flv format support mp3 audio with 48khz

2016-11-06 Thread Michael Niedermayer
On Wed, Sep 28, 2016 at 05:26:35PM +0200, wm4 wrote: > On Wed, 28 Sep 2016 07:47:47 -0700 > fuqiuping wrote: > > > --- > > libavformat/flvenc.c |8 > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > diff --git a/libavformat/flvenc.c

Re: [FFmpeg-devel] [PATCH] workaround for IOS9 getaddrinfo in IPv6 only network use hardcode IPv4 address can not resolve port number.

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 09:31:09AM -0800, Dave Yeo wrote: > On 11/06/16 04:34 AM, Michael Niedermayer wrote: > >>src/libavformat/tcp.c: In function 'tcp_open': > >>>src/libavformat/tcp.c:128:25: error: dereferencing pointer to > >>>incomplete type > >>> if (!sockaddr_v6->sin6_port){ > >>>

[FFmpeg-devel] [PATCH] avformat: Allow forcing use of AVParsers

2016-11-06 Thread Michael Niedermayer
TODO: version bump, docs Signed-off-by: Michael Niedermayer --- libavformat/avformat.h | 8 libavformat/options_table.h | 7 +++ libavformat/utils.c | 3 +++ 3 files changed, 18 insertions(+) diff --git a/libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH] workaround for IOS9 getaddrinfo in IPv6 only network use hardcode IPv4 address can not resolve port number.

2016-11-06 Thread Dave Yeo
On 11/06/16 04:34 AM, Michael Niedermayer wrote: src/libavformat/tcp.c: In function 'tcp_open': >src/libavformat/tcp.c:128:25: error: dereferencing pointer to >incomplete type > if (!sockaddr_v6->sin6_port){ > ^ >src/libavformat/tcp.c:129:24: error:

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect: Remove dependency on channel layout

2016-11-06 Thread Michael Niedermayer
On Sat, Sep 10, 2016 at 11:21:28AM +0200, Nicolas George wrote: > Le decadi 20 fructidor, an CCXXIV, Michael Niedermayer a écrit : > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/af_volumedetect.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: parameters for filter thread counts

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 09:20:33AM -0500, DeHackEd wrote: > On 11/06/2016 06:44 AM, Michael Niedermayer wrote: > > On Sun, Oct 30, 2016 at 09:25:39AM -0400, DeHackEd wrote: > > [...] > > > >> if ((ret = avfilter_graph_parse2(fg->graph, graph_desc, , > >> )) < 0) > >> diff --git

Re: [FFmpeg-devel] [PATCH] doc/libx26[45]: Add documentation for forced-idr

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 01:46:30PM +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > As request by Michael. > --- > doc/encoders.texi | 8 > 1 file changed, 8 insertions(+) applied thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: parameters for filter thread counts

2016-11-06 Thread DeHackEd
On 11/06/2016 06:44 AM, Michael Niedermayer wrote: > On Sun, Oct 30, 2016 at 09:25:39AM -0400, DeHackEd wrote: > [...] > >> if ((ret = avfilter_graph_parse2(fg->graph, graph_desc, , >> )) < 0) >> diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c >> index 4d25fff..dc94380 100644 >> --- a/ffmpeg_opt.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Fix probing mpegts audio streams that use probing

2016-11-06 Thread Anssi Hannula
05.11.2016, 19:27, Hendrik Leppkes kirjoitti: > On Sat, Nov 5, 2016 at 5:39 PM, Anssi Hannula wrote: >> Commit 04964ac311abe670f ("avformat/hls: Fix missing streams in some >> cases with MPEG TS") caused a regression where subdemuxer streams that >> use probing (e.g.

[FFmpeg-devel] [PATCH] doc/libx26[45]: Add documentation for forced-idr

2016-11-06 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- As request by Michael. --- doc/encoders.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 5a60e7e..ba60e0a 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1751,6

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-06 Thread Derek Buitenhuis
On 11/6/2016 12:40 PM, Michael Niedermayer wrote: > IMO we should support it if its possible without large hacks I don't really have an opinion myself, so to speak. I was just noting it. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 10:08:23AM +0530, Sasi Inguva wrote: > When I play the file using Quicktime Player 7 , it errs out saying "invalid > public movie atom found" . Quicktime 10.4 shows a black screen . Even vlc > doesn't play the video. It's true that it used to work before, but don't > know

Re: [FFmpeg-devel] [PATCH] workaround for IOS9 getaddrinfo in IPv6 only network use hardcode IPv4 address can not resolve port number.

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 12:22:04AM -0700, Dave Yeo wrote: > On 08/24/16 03:46 AM, liu jc wrote: > >Signed-off-by: liujingchao > >--- > > libavformat/tcp.c | 8 > > 1 file changed, 8 insertions(+) > > mode change 100644 => 100755 libavformat/tcp.c > > > >diff --git

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: write metadata descriptor for timed ID3 packets

2016-11-06 Thread Stefano Sabatini
On date Sunday 2016-08-21 18:23:21 +0200, Michael Niedermayer encoded: > On Sun, Aug 21, 2016 at 10:44:27AM +0200, Stefano Sabatini wrote: > > On date Saturday 2016-08-20 18:57:52 +0200, Michael Niedermayer encoded: > > > On Sat, Aug 20, 2016 at 03:48:35PM +0200, Stefano Sabatini wrote: > > > > On

Re: [FFmpeg-devel] [PATCH v3] ffmpeg: parameters for filter thread counts

2016-11-06 Thread Michael Niedermayer
On Sun, Oct 30, 2016 at 09:25:39AM -0400, DeHackEd wrote: [...] > if ((ret = avfilter_graph_parse2(fg->graph, graph_desc, , > )) < 0) > diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c > index 4d25fff..dc94380 100644 > --- a/ffmpeg_opt.c > +++ b/ffmpeg_opt.c > @@ -3365,12 +3365,16 @@ const

Re: [FFmpeg-devel] [PATCH] workaround for IOS9 getaddrinfo in IPv6 only network use hardcode IPv4 address can not resolve port number.

2016-11-06 Thread Dave Yeo
On 08/24/16 03:46 AM, liu jc wrote: Signed-off-by: liujingchao --- libavformat/tcp.c | 8 1 file changed, 8 insertions(+) mode change 100644 => 100755 libavformat/tcp.c diff --git a/libavformat/tcp.c b/libavformat/tcp.c old mode 100644 new mode 100755 index