Re: [FFmpeg-devel] TR-03 implementation

2016-11-12 Thread Carlos Fernandez Sanz
On Sat, Nov 12, 2016 at 8:17 PM, Ali KIZIL wrote: > If someone wants to try, he can give a try, release a patch, it can be > discussed in a discussion level. I really find saying such comments like " > We don't need more broadcasting shit in ffmpeg." and "and it is why > FFmpeg is full of bro

Re: [FFmpeg-devel] TR-03 implementation

2016-11-12 Thread Ali KIZIL
2016-11-11 0:24 GMT+03:00 Kieran Kunhya : > > > > sure, ffmpeg has support for many pixel formats and adding more > > pixfmts is not a problem. > > > > my best answer would be to look at commits which add other pixel > > formats and just follow how they were added to libswscale. make some > > fate

Re: [FFmpeg-devel] [Patch] hwaccel transocode broken

2016-11-12 Thread Ali KIZIL
2016-11-11 14:47 GMT+03:00 Yogender Gupta : > >>These are merges. Unless you volunteer to do the merges yourself (and > properly please) you'll have to live with this. > > So were there merges that got left and broke the functionality. When do we > get these merges in ? Please let me know if I can

Re: [FFmpeg-devel] [PATCH 1/3] lavu: Add AVSphericalMapping type and frame side data

2016-11-12 Thread Vittorio Giovara
On Sat, Nov 12, 2016 at 6:11 PM, Michael Niedermayer wrote: > Hi > > On Sat, Nov 12, 2016 at 12:30:52PM -0500, Vittorio Giovara wrote: >> On Sat, Nov 12, 2016 at 9:41 AM, James Almer wrote: >> > On 11/11/2016 10:39 PM, Michael Niedermayer wrote: >> >> On Fri, Nov 11, 2016 at 05:49:00PM -0500, Vit

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add newline to avformat_write_header error message

2016-11-12 Thread Marton Balint
On Sun, 13 Nov 2016, Michael Niedermayer wrote: On Sat, Nov 12, 2016 at 02:23:29AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx Applied, thanks. Marton _

Re: [FFmpeg-devel] [PATCH 2/2] lavf/fifo: fix undefined behaviour in deinit when destroying mutex

2016-11-12 Thread Marton Balint
On Sat, 12 Nov 2016, Jan Sebechlebsky wrote: On 11/12/2016 02:23 AM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/fifo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 15435fe..8f525e5 100644 --- a

Re: [FFmpeg-devel] [PATCH] vp9_mc_template: disable assert for SCALED == 0

2016-11-12 Thread Ronald S. Bultje
Hi Andreas, On Nov 12, 2016 5:52 PM, "Andreas Cadhalpun" < andreas.cadhal...@googlemail.com> wrote: > > The handling of the other block sizes was disabled for 'SCALED == 0' in > commit dc96c0f9fc96bf4167633befc074394062793322, so this assert should > be disabled, too, as it can now be triggered. >

Re: [FFmpeg-devel] [PATCH] lavfi/ebur128: specify scaling_factor directly

2016-11-12 Thread Marton Balint
On Sun, 13 Nov 2016, Michael Niedermayer wrote: On Sun, Nov 13, 2016 at 02:43:39AM +0100, Marton Balint wrote: This should fix build with Solaris CC. Signed-off-by: Marton Balint --- libavfilter/ebur128.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) LGTM Applied, t

Re: [FFmpeg-devel] [PATCH] lavfi/ebur128: specify scaling_factor directly

2016-11-12 Thread Michael Niedermayer
On Sun, Nov 13, 2016 at 02:43:39AM +0100, Marton Balint wrote: > This should fix build with Solaris CC. > > Signed-off-by: Marton Balint > --- > libavfilter/ebur128.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B

[FFmpeg-devel] [PATCH] lavfi/ebur128: specify scaling_factor directly

2016-11-12 Thread Marton Balint
This should fix build with Solaris CC. Signed-off-by: Marton Balint --- libavfilter/ebur128.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavfilter/ebur128.c b/libavfilter/ebur128.c index 8e216c4..a46692e 100644 --- a/libavfilter/ebur128.c +++ b/libavfilter/

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add newline to avformat_write_header error message

2016-11-12 Thread Michael Niedermayer
On Sat, Nov 12, 2016 at 02:23:29AM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man'

Re: [FFmpeg-devel] [PATCH] lavf/mux: don't warn about missing timestamps on attached pictures

2016-11-12 Thread Michael Niedermayer
On Sat, Nov 12, 2016 at 06:01:58PM -0600, Rodger Combs wrote: > --- > libavformat/mux.c | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. signatur

Re: [FFmpeg-devel] [PATCH] configure: use check_lib2 for cuda and cuvid

2016-11-12 Thread Timo Rothenpieler
Seems like I never tested on any 32bit platform. lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavf/mux: don't warn about missing timestamps on attached pictures

2016-11-12 Thread Rodger Combs
--- libavformat/mux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mux.c b/libavformat/mux.c index 77823a4..963d006 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -575,6 +575,7 @@ static int compute_muxer_pkt_fields(AVFormatContext *s, AVStream *st, AVPacket *

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-11-12 Thread James Almer
On 10/20/2016 3:25 PM, Andreas Cadhalpun wrote: > On 20.10.2016 03:25, Michael Niedermayer wrote: >> On Wed, Oct 19, 2016 at 07:30:29PM +0200, Andreas Cadhalpun wrote: >>> On 19.10.2016 04:15, James Almer wrote: On 10/17/2016 9:57 PM, Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 09

Re: [FFmpeg-devel] [PATCH 1/3] lavu: Add AVSphericalMapping type and frame side data

2016-11-12 Thread Michael Niedermayer
Hi On Sat, Nov 12, 2016 at 12:30:52PM -0500, Vittorio Giovara wrote: > On Sat, Nov 12, 2016 at 9:41 AM, James Almer wrote: > > On 11/11/2016 10:39 PM, Michael Niedermayer wrote: > >> On Fri, Nov 11, 2016 at 05:49:00PM -0500, Vittorio Giovara wrote: [...] > >> > >>> +double yaw; ///< Clockwi

[FFmpeg-devel] [PATCH] vp9_mc_template: disable assert for SCALED == 0

2016-11-12 Thread Andreas Cadhalpun
The handling of the other block sizes was disabled for 'SCALED == 0' in commit dc96c0f9fc96bf4167633befc074394062793322, so this assert should be disabled, too, as it can now be triggered. Signed-off-by: Andreas Cadhalpun --- At least that would be the easy fix, but I'd be glad if Ronald could c

Re: [FFmpeg-devel] [PATCH v2] libavformat/tee: Add fifo support for tee

2016-11-12 Thread Jan Sebechlebsky
On 10/31/2016 04:56 PM, Nicolas George wrote: +if (av_match_name(use_fifo, "true,y,yes,enable,enabled,on,1")) { +tee_slave->use_fifo = 1; +} else if (av_match_name(use_fifo, "false,n,no,disable,disabled,off,0")) { I am not happy about the duplication of the tests fr

Re: [FFmpeg-devel] [PATCH 2/2] lavf/fifo: fix undefined behaviour in deinit when destroying mutex

2016-11-12 Thread Jan Sebechlebsky
On 11/12/2016 02:23 AM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/fifo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 15435fe..8f525e5 100644 --- a/libavformat/fifo.c +++ b/libavformat/fifo.c @@

Re: [FFmpeg-devel] [PATCH 1/3] lavu: Add AVSphericalMapping type and frame side data

2016-11-12 Thread Vittorio Giovara
On Sat, Nov 12, 2016 at 9:41 AM, James Almer wrote: > On 11/11/2016 10:39 PM, Michael Niedermayer wrote: >> On Fri, Nov 11, 2016 at 05:49:00PM -0500, Vittorio Giovara wrote: >> [...] >>> +/** >>> + * This structure describes how to handle spherical videos, outlining >>> + * information about proje

Re: [FFmpeg-devel] [PATCH 3/3] mov: Export spherical information

2016-11-12 Thread Vittorio Giovara
On Fri, Nov 11, 2016 at 6:23 PM, James Almer wrote: > On 11/11/2016 7:49 PM, Vittorio Giovara wrote: >> This implements Spherical Video V1 and V2, as described in the >> spatial-media collection by Google. >> >> Signed-off-by: Vittorio Giovara >> --- >> Please CC. >> Vittorio >> >> libavformat/i

Re: [FFmpeg-devel] [PATCH] feature: xcbgrab single window

2016-11-12 Thread Ing . Radomír Polách
2016-11-11 11:35 GMT+01:00 Nicolas George : > Thanks for the patch. See comments below. > > > Subject: Re: [FFmpeg-devel] [PATCH] feature: xcbgrab single window > > The recommended syntax would be "lavd/xcbgrab: add single window mode". > Ok. > > > Allows to grab only a single window by using s

Re: [FFmpeg-devel] [PATCH] lavc/vaapi: Add VP8 decode hwaccel

2016-11-12 Thread Mark Thompson
On 12/11/16 13:57, Mark Thompson wrote: > On 11/11/16 07:57, Jun Zhao wrote: >> @@ -2800,14 +2849,18 @@ static int >> vp8_decode_update_thread_context(AVCodecContext *dst, >> s->mb_width = s_src->mb_width; >> s->mb_height = s_src->mb_height; >> } >> - >> s->prob[0]

Re: [FFmpeg-devel] [PATCH 1/3] lavu: Add AVSphericalMapping type and frame side data

2016-11-12 Thread James Almer
On 11/11/2016 10:39 PM, Michael Niedermayer wrote: > On Fri, Nov 11, 2016 at 05:49:00PM -0500, Vittorio Giovara wrote: > [...] >> +/** >> + * This structure describes how to handle spherical videos, outlining >> + * information about projection, initial layout, and any other view >> modifier. >> +

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: fix poc incorrect issue after meeting idr frame.

2016-11-12 Thread Mark Thompson
On 11/11/16 07:02, Jun Zhao wrote: > From 25a5cc94fba53405acd53f9613fa5d206ce748f0 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Fri, 11 Nov 2016 14:53:49 +0800 > Subject: [PATCH] lavc/vaapi_encode_h264: fix poc incorrect issue after meeting > idr frame. > > when meeting IDR frame, vaapi_enco

Re: [FFmpeg-devel] [PATCH] lavc/vaapi: Add VP8 decode hwaccel

2016-11-12 Thread Mark Thompson
On 11/11/16 07:57, Jun Zhao wrote: > From 4635e7e4a0ea24f77e71ffc9a9074e75c61bfe44 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Fri, 11 Nov 2016 15:51:01 +0800 > Subject: [PATCH] lavc/vaapi: Add VP8 decode hwaccel > > Add VP8 decode hwaccel based on the libav: > commit a9fb134730da1f9642eb5a2

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix the hevc vaapi encoder output shaking issue.

2016-11-12 Thread Mark Thompson
On 11/11/16 02:24, Jun Zhao wrote: > From 5db0b2cd0930ed88d853114f13b69a80a44d9c4c Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Fri, 11 Nov 2016 10:04:53 +0800 > Subject: [PATCH] lavc/vaapi_encode_h265: fix the hevc vaapi encoder output > shaking issue. > > the max_num_reorder_pics/max_dec_p

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Workaround interlaced mpeg4 edge MC bug

2016-11-12 Thread Moritz Barsnick
On Sat, Nov 12, 2016 at 13:34:02 +0100, Carl Eugen Hoyos wrote: > > +if ((ctx->lavc_build&0xFF) >= 100) { > (Do we guarantee that MICRO <= 255?) Most of the version macros in libavutil/version.h will not behave as expected if not, as they assume 8 bits. So, yes, that's an implicit requirem

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Workaround interlaced mpeg4 edge MC bug

2016-11-12 Thread Carl Eugen Hoyos
2016-11-12 12:31 GMT+01:00 Michael Niedermayer : > +if ((ctx->lavc_build&0xFF) >= 100) { (Do we guarantee that MICRO <= 255?) > +if (ctx->lavc_build > 3621476 && ctx->lavc_build < 3752550) Sorry, I meant this patch, not 1/2: Please mention the relevant change (60ab6e24?) in

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Fix edge emu buffer overlap with interlaced mpeg4

2016-11-12 Thread Carl Eugen Hoyos
2016-11-12 12:31 GMT+01:00 Michael Niedermayer : > Fixes Ticket5936 Please also mention the relevant original commit. Was it 60ab6e24574a984655800d1f7ce16c05f4e9b28c? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mai

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Fix edge emu buffer overlap with interlaced mpeg4

2016-11-12 Thread Michael Niedermayer
Fixes Ticket5936 Signed-off-by: Michael Niedermayer --- libavcodec/mpegpicture.c | 2 +- libavcodec/mpegvideo.c| 2 +- libavcodec/mpegvideo_enc.c| 2 +- libavcodec/mpegvideo_motion.c | 4 ++-- libavcodec/version.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)

[FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Workaround interlaced mpeg4 edge MC bug

2016-11-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 1 + libavcodec/mpeg4videodec.c| 5 + libavcodec/mpegvideo.c| 2 ++ libavcodec/mpegvideo_motion.c | 4 libavcodec/options_table.h| 1 + 5 files changed, 13 insertions(+) diff --git a/libavcodec/avcode

Re: [FFmpeg-devel] [PATCH] configure: use check_lib2 for cuda and cuvid

2016-11-12 Thread Hendrik Leppkes
On Sat, Nov 12, 2016 at 1:44 AM, Hendrik Leppkes wrote: > Fixes building on Windows with MSVC using the link libraries distributed with > the CUDA SDK. > > check_lib2 is required here because it includes the header to get the full > signature of the > function, including the stdcall calling conv

Re: [FFmpeg-devel] [PATCH] increment initial_prog_date_time when removing old segments

2016-11-12 Thread Steven Liu
2016-11-12 0:53 GMT+08:00 Michael Niedermayer : > On Fri, Nov 11, 2016 at 09:59:16PM +0800, Steven Liu wrote: > > 2016-11-11 21:58 GMT+08:00 Steven Liu : > > > > > > > > > > > 2016-11-11 21:40 GMT+08:00 Michael Niedermayer >: > > > > > >> On Fri, Nov 11, 2016 at 10:13:43AM +0100, Robert Nagy wrot

[FFmpeg-devel] DNXHD timecode for muxing

2016-11-12 Thread Robert Nagy
I would like to try and add timecode support into the dnxhd enc/dec. The DNXHD part is pretty simple. However, I'm a little unsure how to make sure the timecode is read and used during transcoding. Basically I would like to be able to do: ffmpeg -i input -timecode:v x -c:v dnxhd - | ffmpeg -i -