[FFmpeg-devel] 答复: About swr_convert_frame of FFmpeg 3.2 Release

2016-11-22 Thread He Lei
Sorry, File is swresample_frame.c; 发件人: He Lei 发送时间: 2016年11月23日 11:20 收件人: ffmpeg-devel@ffmpeg.org 主题: [FFmpeg-devel] About swr_convert_frame of FFmpeg 3.2 Release I convert audio frame from s16p to s16 used swr_convert_frame; I

[FFmpeg-devel] About swr_convert_frame of FFmpeg 3.2 Release

2016-11-22 Thread He Lei
I convert audio frame from s16p to s16 used swr_convert_frame; I found the out_frame ->linesize[0] is more then in_frame; After view the code, I don’t get it ; At lines 144 of file swr_convert_frame.c, Why to add 3 when calculated nb_samples? ___

[FFmpeg-devel] [PATCH] web/consulting: add myself

2016-11-22 Thread Steven Liu
Been getting occassional consulting help emails for a while, so I might as well add myself here. Signed-off-by: Steven Liu --- src/consulting | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/consulting b/src/consulting index

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: Fix av_frame_make_writable usage

2016-11-22 Thread Michael Niedermayer
On Wed, Nov 23, 2016 at 02:09:14AM +0100, wm4 wrote: > On Mon, 24 Oct 2016 00:12:00 +0200 > Sam Hocevar wrote: > > > This patch moves the av_frame_make_writable() call from fill_yuv_image > > to get_video_frame so that its argument can be the actual frame that > > will be sent

Re: [FFmpeg-devel] [PATCH] flvdec: set need_context_update when changing codec id

2016-11-22 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 10:28:20PM +0100, Andreas Cadhalpun wrote: > Otherwise the codec context and codecpar might disagree on the codec id, > triggering asserts in av_parser_parse2. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/flvdec.c | 16

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: prevent sbr gain from being zero

2016-11-22 Thread Michael Niedermayer
On Sun, Nov 13, 2016 at 09:29:11PM +0100, Andreas Cadhalpun wrote: > It causes division by zero crashes. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/aacsbr_fixed.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-22 Thread Michael Niedermayer
On Mon, Nov 14, 2016 at 09:55:15PM +0100, Andreas Cadhalpun wrote: > On 14.11.2016 20:54, Anton Khirnov wrote: > > Quoting Andreas Cadhalpun (2016-11-14 20:30:10) > >> On 14.11.2016 00:01, Luca Barbato wrote: > >>> On 13/11/2016 19:23, Andreas Cadhalpun wrote: > avc->channels can be 0. > >>>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread wm4
On Tue, 22 Nov 2016 23:30:38 +0100 Carl Eugen Hoyos wrote: > 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun > : > > > disabled sdl && disable sdl2 > > +enabled sdl2 && sdl_requested=yes > > I consider this ugly and it makes sdl different

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: Fix av_frame_make_writable usage

2016-11-22 Thread wm4
On Mon, 24 Oct 2016 00:12:00 +0200 Sam Hocevar wrote: > This patch moves the av_frame_make_writable() call from fill_yuv_image > to get_video_frame so that its argument can be the actual frame that > will be sent to the encoder. > > This fixes data corruption issues in codecs

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/options_table: make channel_layouts uint64

2016-11-22 Thread Michael Niedermayer
On Sun, Nov 20, 2016 at 08:56:18PM +0100, Andreas Cadhalpun wrote: > On 20.11.2016 12:57, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/options_table.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 11:06:49PM +0100, Andreas Cadhalpun wrote: > On 22.11.2016 12:06, Michael Niedermayer wrote: > > On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: > >> OK. Now I've another question. Why does the check involve o->max? > >> Is the out-of-range check at the

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Andreas Cadhalpun
On 23.11.2016 01:06, Josh de Kock wrote: > On 22/11/2016 23:37, Andreas Cadhalpun wrote: >> On 23.11.2016 00:01, Josh de Kock wrote: >>> On 22/11/2016 22:22, Andreas Cadhalpun wrote: On 10.11.2016 22:24, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] rmdec: validate block alignment

2016-11-22 Thread Andreas Cadhalpun
On 23.11.2016 00:47, Michael Niedermayer wrote: > On Fri, Nov 18, 2016 at 10:37:36PM +0100, Andreas Cadhalpun wrote: >> On 18.11.2016 02:44, Michael Niedermayer wrote: >>> On Thu, Nov 17, 2016 at 10:52:30PM +0100, Andreas Cadhalpun wrote: This fixes division by zero crashes.

Re: [FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-22 Thread Andreas Cadhalpun
On 20.11.2016 00:44, Andreas Cadhalpun wrote: > On 19.11.2016 23:34, Michael Niedermayer wrote: >> On Sat, Nov 19, 2016 at 05:27:19PM +0100, Andreas Cadhalpun wrote: >>> diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c >>> index b8a0c55..be3914b 100644 >>> --- a/libavcodec/smacker.c >>>

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:37, Andreas Cadhalpun wrote: > On 23.11.2016 00:01, Josh de Kock wrote: >> On 22/11/2016 22:22, Andreas Cadhalpun wrote: >>> On 10.11.2016 22:24, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/sbgdec.c |

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: Adjust vid probe threshold to correct mis-detection

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 15, 2016 at 08:06:42PM +0100, Michael Niedermayer wrote: > Fixes: _ij.mp3 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: Fix av_frame_make_writable usage

2016-11-22 Thread Sam Hocevar
On Mon, Oct 24, 2016, Sam Hocevar wrote: > This fixes data corruption issues in codecs that keep references on > one or several previous frames. This doesn't seem to have gotten much attention. Any comments maybe? -- Sam. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] rmdec: validate block alignment

2016-11-22 Thread Michael Niedermayer
On Fri, Nov 18, 2016 at 10:37:36PM +0100, Andreas Cadhalpun wrote: > On 18.11.2016 02:44, Michael Niedermayer wrote: > > On Thu, Nov 17, 2016 at 10:52:30PM +0100, Andreas Cadhalpun wrote: > >> This fixes division by zero crashes. > >> > >> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:50, Josh de Kock wrote: > On 22/11/2016 22:43, Andreas Cadhalpun wrote: >> On 17.11.2016 22:55, Andreas Cadhalpun wrote: >>> Metadata streams have priv_data set to NULL. >>> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/mxfdec.c |

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Andreas Cadhalpun
On 23.11.2016 00:01, Josh de Kock wrote: > On 22/11/2016 22:22, Andreas Cadhalpun wrote: >> On 10.11.2016 22:24, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/sbgdec.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread wm4
On Tue, 22 Nov 2016 15:05:36 -0800 Wan-Teh Chang wrote: > Hi wm4, > > On Tue, Nov 22, 2016 at 1:41 PM, wm4 wrote: > > > > Again, once the atomics changes in Libav are merged, the avpriv_atomic_ > > additions will have to be deleted, and code

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread wm4
On Tue, 22 Nov 2016 23:57:15 +0100 Michael Niedermayer wrote: > On Tue, Nov 22, 2016 at 02:00:12PM -0800, Wan-Teh Chang wrote: > > Hi Michael, > > > > On Tue, Nov 22, 2016 at 1:22 PM, Michael Niedermayer > > wrote: > > > > > > ok, i see th race

Re: [FFmpeg-devel] [PATCH] oggparsevp8: set need_context_update when changing codec id

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:45, James Almer wrote: > On 11/15/2016 6:51 PM, Andreas Cadhalpun wrote: >> Otherwise the codec context and codecpar might disagree on the codec id, >> triggering asserts in av_parser_parse2. >> >> Signed-off-by: Andreas Cadhalpun >> --- >>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:11, Andreas Cadhalpun wrote: On 22.11.2016 23:43, Josh de Kock wrote: On 22/11/2016 22:33, Andreas Cadhalpun wrote: Because it avoids confusing users. And the checks for other system libraries should do this, too. I see no real reason to add this, but neither a reason to

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Hi Michael, On Tue, Nov 22, 2016 at 2:57 PM, Michael Niedermayer wrote: > > we have plenty of code that accesses fields without the extra layer > of weak atomics. > For example the progress code in the frame threading. The progress code in the frame threading also has

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:08 PM, James Zern wrote: > On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: >> On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse >> wrote: >>> Report the actual level of the encoded output if a level is >>>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:43, Josh de Kock wrote: > On 22/11/2016 22:33, Andreas Cadhalpun wrote: >> Because it avoids confusing users. And the checks for other system >> libraries should do this, too. >> > > I see no real reason to add this, but neither a reason to block it either. > I personally think

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Hi wm4, On Tue, Nov 22, 2016 at 1:41 PM, wm4 wrote: > > Again, once the atomics changes in Libav are merged, the avpriv_atomic_ > additions will have to be deleted, and code using it rewritten. Thanks for the heads-up. Is there an atomics patch for libav being reviewed

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:22, Andreas Cadhalpun wrote: On 10.11.2016 22:24, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/sbgdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/sbgdec.c

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 02:00:12PM -0800, Wan-Teh Chang wrote: > Hi Michael, > > On Tue, Nov 22, 2016 at 1:22 PM, Michael Niedermayer > wrote: > > > > ok, i see th race but do you really need the atomic operations ? > > isnt merging the 2 variables into 1 as you do enough

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:43, Andreas Cadhalpun wrote: On 17.11.2016 22:55, Andreas Cadhalpun wrote: Metadata streams have priv_data set to NULL. Signed-off-by: Andreas Cadhalpun --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] oggparsevp8: set need_context_update when changing codec id

2016-11-22 Thread James Almer
On 11/15/2016 6:51 PM, Andreas Cadhalpun wrote: > Otherwise the codec context and codecpar might disagree on the codec id, > triggering asserts in av_parser_parse2. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/oggparsevp8.c | 1 + > 1 file changed,

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:33, Andreas Cadhalpun wrote: On 22.11.2016 23:30, Carl Eugen Hoyos wrote: 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun : disabled sdl && disable sdl2 +enabled sdl2 && sdl_requested=yes I consider this ugly That is very subjective.

Re: [FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-22 Thread Andreas Cadhalpun
On 17.11.2016 22:55, Andreas Cadhalpun wrote: > Metadata streams have priv_data set to NULL. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] oggparsevp8: set need_context_update when changing codec id

2016-11-22 Thread Andreas Cadhalpun
On 15.11.2016 22:51, Andreas Cadhalpun wrote: > Otherwise the codec context and codecpar might disagree on the codec id, > triggering asserts in av_parser_parse2. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/oggparsevp8.c | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] pgssubdec: only set w/h/linesize when allocating data

2016-11-22 Thread Andreas Cadhalpun
On 09.11.2016 23:27, Andreas Cadhalpun wrote: > Rects with positive w/h/linesize but no data are invalid. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/pgssubdec.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:30, Carl Eugen Hoyos wrote: > 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun > : > >> disabled sdl && disable sdl2 >> +enabled sdl2 && sdl_requested=yes > > I consider this ugly That is very subjective. > and it makes sdl different to all

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Carl Eugen Hoyos
2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun : > disabled sdl && disable sdl2 > +enabled sdl2 && sdl_requested=yes I consider this ugly and it makes sdl different to all other system libraries: Why? Carl Eugen ___

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-22 Thread Andreas Cadhalpun
On 14.11.2016 21:55, Andreas Cadhalpun wrote: > From d33ded293d15e8ceab666bea834d436f3a225bcc Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun > Date: Mon, 14 Nov 2016 21:41:45 +0100 > Subject: [PATCH] libopusdec: default to stereo for invalid number of

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: prevent sbr gain from being zero

2016-11-22 Thread Andreas Cadhalpun
On 13.11.2016 21:29, Andreas Cadhalpun wrote: > It causes division by zero crashes. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/aacsbr_fixed.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/aacsbr_fixed.c

Re: [FFmpeg-devel] [PATCH] sbgdec: prevent NULL pointer access

2016-11-22 Thread Andreas Cadhalpun
On 10.11.2016 22:24, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/sbgdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c > index bb020d7..cbedd12 100644 >

Re: [FFmpeg-devel] [PATCH] mpegpicture: use coded_width/coded_height to allocate frame

2016-11-22 Thread Andreas Cadhalpun
On 07.11.2016 22:32, Andreas Cadhalpun wrote: > This fixes a heap-buffer-overflow in ff_er_frame_end when decoding mss2 with > coded_width/coded_height larger than width/height. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/mpegpicture.c | 12

Re: [FFmpeg-devel] [PATCH] flvdec: set need_context_update when changing codec id

2016-11-22 Thread Andreas Cadhalpun
On 04.11.2016 22:28, Andreas Cadhalpun wrote: > Otherwise the codec context and codecpar might disagree on the codec id, > triggering asserts in av_parser_parse2. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/flvdec.c | 16 > 1 file

Re: [FFmpeg-devel] [PATCH] oggparsetheora: set need_context_update when changing codec id

2016-11-22 Thread Andreas Cadhalpun
On 04.11.2016 22:27, Andreas Cadhalpun wrote: > Otherwise the codec context and codecpar might disagree on the codec id, > triggering asserts in av_parser_parse2. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/oggparsetheora.c | 2 ++ > 1 file

[FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 7d094df..0d85a54 100755 --- a/configure +++ b/configure @@ -5846,7 +5846,9 @@ if enabled gcrypt; then fi disabled sdl &&

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 12:06, Michael Niedermayer wrote: > On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: >> OK. Now I've another question. Why does the check involve o->max? >> Is the out-of-range check at the beginning of write_number not >> sufficient? > > removed, this too came

Re: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 01:41, Carl Eugen Hoyos wrote: > 2016-11-22 0:20 GMT+01:00 Andreas Cadhalpun > : >> On 20.11.2016 21:27, Carl Eugen Hoyos wrote: > >>> But --enable-sdl2 made no difference at all, or do I misunderstand? >> >> Indeed, I just thought it would. Isn't

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 01:35, Carl Eugen Hoyos wrote: > 2016-11-22 0:06 GMT+01:00 Andreas Cadhalpun > : >> I tend to silently accept zero, because I'd like a >> consistent solution and in some cases rejecting zero >> causes FATE failures. > > If there were a bug, you

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Hi Michael, On Tue, Nov 22, 2016 at 1:22 PM, Michael Niedermayer wrote: > > ok, i see th race but do you really need the atomic operations ? > isnt merging the 2 variables into 1 as you do enough ? > (i mean the tools might still complain but would there be an actual >

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 01:27, Carl Eugen Hoyos wrote: > 2016-11-22 0:40 GMT+01:00 Andreas Cadhalpun > : > >> For example what should be done about overflows, e.g. when >> calculating the bit rate? Does this count as demuxer failing? > > I don't understand this question:

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread wm4
On Tue, 22 Nov 2016 13:36:11 -0800 Wan-Teh Chang wrote: > Make the one-time initialization in av_get_cpu_flags() thread-safe. The > static variables |flags| and |checked| in libavutil/cpu.c are read and > written using normal load and store operations. These are

Re: [FFmpeg-devel] [PATCH] Make the one-time initialization in av_get_cpu_flags() thread-safe.

2016-11-22 Thread Wan-Teh Chang
This patch was generated in error. Please ignore it. Wan-Teh Chang On Tue, Nov 22, 2016 at 11:30 AM, Wan-Teh Chang wrote: > The static variables |flags| and |checked| in libavutil/cpu.c are read > and written using normal load and store instructions. These are > considered as

[FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Make the one-time initialization in av_get_cpu_flags() thread-safe. The static variables |flags| and |checked| in libavutil/cpu.c are read and written using normal load and store operations. These are considered as data races. The fix is to use atomic load and store operations. The fix also

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 11:28:48AM -0800, Wan-Teh Chang wrote: > Hi Michael, > > On Mon, Nov 21, 2016 at 4:35 PM, Michael Niedermayer > wrote: > > On Mon, Nov 21, 2016 at 03:37:49PM -0800, Wan-Teh Chang wrote: > >> Make the one-time initialization in av_get_cpu_flags()

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_encode_h264: fix poc incorrect issue after meeting idr frame.

2016-11-22 Thread Andy Furniss
Mark Thompson wrote: On 14/11/16 07:11, Jun Zhao wrote: V2 : - Change the last_idr_frame filed location based on Mark code review. - Modify the commit message to actually explain the problem. From a1bf2b021effd36f8297b331855a282d775f2a44 Mon Sep 17 00:00:00 2001 From: Jun Zhao

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse > wrote: >> Report the actual level of the encoded output if a level is >> targeted or the level is passively tracked with a target of 0. >> --- >>

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 31 +++ > 1 file changed, 31

[FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Here is a new version of my patch to address Michael's review comments. Wan-Teh Chang (1): Make the one-time initialization in av_get_cpu_flags() thread-safe. libavutil/Makefile | 1 + libavutil/atomic.c | 40 ++ libavutil/atomic.h | 34

[FFmpeg-devel] [PATCH] Make the one-time initialization in av_get_cpu_flags() thread-safe.

2016-11-22 Thread Wan-Teh Chang
The static variables |flags| and |checked| in libavutil/cpu.c are read and written using normal load and store instructions. These are considered as data races. The fix is to use atomic load and store instructions. The fix also eliminates the |checked| variable because the invalid value of -1 for

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

2016-11-22 Thread Alex Converse
On Fri, Nov 18, 2016 at 3:44 PM, James Zern wrote: > > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse > wrote: > > Levels are specified at https://www.webmproject.org/vp9/levels/ > > --- > > libavcodec/libvpxenc.c | 10 ++ > > 1

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread Wan-Teh Chang
Hi Michael, On Mon, Nov 21, 2016 at 4:35 PM, Michael Niedermayer wrote: > On Mon, Nov 21, 2016 at 03:37:49PM -0800, Wan-Teh Chang wrote: >> Make the one-time initialization in av_get_cpu_flags() thread-safe. >> The fix assumes -1 is an invalid value for cpu flags. > >

Re: [FFmpeg-devel] [PATCH 0/2] cuvid: Add support for P010/P016 output formats

2016-11-22 Thread Philip Langdale
On Tue, 22 Nov 2016 08:27:46 -0800 Philip Langdale wrote: > The latest nvidia drivers support P010/P016 output formats for > 10/12bit content. > > Philip Langdale (2): > libavutil/hwcontext_cuda: Support P010 and P016 formats > avcodec/cuvid: Add support for P010/P016 as

[FFmpeg-devel] [PATCH 2/2] avcodec/cuvid: Add support for P010/P016 as an output surface format

2016-11-22 Thread Philip Langdale
The nvidia 375.xx driver introduces support for P016 output surfaces, for 10bit and 12bit HEVC content (it's also the first driver to support hardware decoding of 12bit content). The cuvid api, as far as I can tell, only declares one output format that they appear to refer to as P016 in the

[FFmpeg-devel] [PATCH 1/2] libavutil/hwcontext_cuda: Support P010 and P016 formats

2016-11-22 Thread Philip Langdale
CUVID is now capable of returning 10bit and 12bit decoded content in P010/P016. Let's support transfering those formats. Signed-off-by: Philip Langdale --- libavutil/hwcontext_cuda.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 0/2] cuvid: Add support for P010/P016 output formats

2016-11-22 Thread Philip Langdale
The latest nvidia drivers support P010/P016 output formats for 10/12bit content. Philip Langdale (2): libavutil/hwcontext_cuda: Support P010 and P016 formats avcodec/cuvid: Add support for P010/P016 as an output surface format compat/cuda/dynlink_cuviddec.h | 3 +- libavcodec/cuvid.c

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix uninitialized return value

2016-11-22 Thread Tobias Rapp
On 22.11.2016 15:06, Michael Niedermayer wrote: On Tue, Nov 22, 2016 at 02:43:57PM +0100, Tobias Rapp wrote: On 22.11.2016 14:34, Michael Niedermayer wrote: On Tue, Nov 22, 2016 at 09:16:26AM +0100, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- ffmpeg.c | 2 +- 1

Re: [FFmpeg-devel] Help with adding new adpcm decoder

2016-11-22 Thread Moritz Barsnick
On Tue, Nov 22, 2016 at 15:04:46 +0100, Michael Niedermayer wrote: > On Tue, Nov 22, 2016 at 12:47:04PM +0100, James Darnley wrote: > > The file starts with a riff wave header that lies about being pcm and > > other values, but I can force the decoder with ffmpeg. In the data > > block (which has

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix uninitialized return value

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 02:43:57PM +0100, Tobias Rapp wrote: > On 22.11.2016 14:34, Michael Niedermayer wrote: > >On Tue, Nov 22, 2016 at 09:16:26AM +0100, Tobias Rapp wrote: > >>Signed-off-by: Tobias Rapp > >>--- > >> ffmpeg.c | 2 +- > >> 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] Help with adding new adpcm decoder

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 12:47:04PM +0100, James Darnley wrote: > I want to add a decoder for a game's music, specifically Falcom's Xanadu > Next. I think the audio could be decompressed by adpcm_ms but the > problem comes from the rest of the format. > > The file starts with a riff wave header

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix uninitialized return value

2016-11-22 Thread Tobias Rapp
On 22.11.2016 14:34, Michael Niedermayer wrote: On Tue, Nov 22, 2016 at 09:16:26AM +0100, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) do you have a testcase for this ? No, I just stumbled over it

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix uninitialized return value

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 09:16:26AM +0100, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) do you have a testcase for this ? [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avutil: fix data race in av_get_cpu_flags().

2016-11-22 Thread wm4
On Mon, 21 Nov 2016 15:37:48 -0800 Wan-Teh Chang wrote: > Hi, > > This patch makes the one-time initialization in av_get_cpu_flags() > thread-safe. The data race was reported by ThreadSanitizer. > > Wan-Teh Chang (1): > avutil: fix data race in

[FFmpeg-devel] FFmpeg 3.2.1

2016-11-22 Thread Michael Niedermayer
Hi all ill make 3.2.1 soon if you want to backport something, do so now thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the

[FFmpeg-devel] Help with adding new adpcm decoder

2016-11-22 Thread James Darnley
I want to add a decoder for a game's music, specifically Falcom's Xanadu Next. I think the audio could be decompressed by adpcm_ms but the problem comes from the rest of the format. The file starts with a riff wave header that lies about being pcm and other values, but I can force the decoder

Re: [FFmpeg-devel] [PATCH 2/3] avutil/opt: Add AV_OPT_TYPE_UINT64

2016-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2016 at 12:29:02AM +0100, Andreas Cadhalpun wrote: > On 20.11.2016 21:52, Michael Niedermayer wrote: > > On Sun, Nov 20, 2016 at 08:55:44PM +0100, Andreas Cadhalpun wrote: > >> On 20.11.2016 12:57, Michael Niedermayer wrote: > >>> +if (intnum == 1 && d ==

[FFmpeg-devel] [PATCH] ffplay -vcodec h264_vda *. error :segmentation fault. bug fix.

2016-11-22 Thread gaochao1
--- libavcodec/vda_h264_dec.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/vda_h264_dec.c b/libavcodec/vda_h264_dec.c index 92839e2..809c2f4 100644 --- a/libavcodec/vda_h264_dec.c +++ b/libavcodec/vda_h264_dec.c @@ -226,12 +226,14 @@ static av_cold

[FFmpeg-devel] [PATCH] lavc/vaapi_hevc: fix scaling list duplicate transfer issue.

2016-11-22 Thread Jun Zhao
From 4059bc56cba30b26bc194673968c3a51014e315f Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 22 Nov 2016 15:58:50 +0800 Subject: [PATCH] lavc/vaapi_hevc: fix scaling list duplicate transfer issue. scaling list is already transfered to raster scan during head parsing, so

[FFmpeg-devel] [PATCH] ffmpeg: fix uninitialized return value

2016-11-22 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index c47a824..4e58528 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2067,7 +2067,7 @@ static int decode(AVCodecContext *avctx, AVFrame *frame, int