Re: [FFmpeg-devel] [PATCH 08/17] lavfi: add helpers to consume frames from link FIFOs.

On Sun, Dec 25, 2016 at 02:00:13AM +0100, Nicolas George wrote: > Le quintidi 5 nivôse, an CCXXV, Michael Niedermayer a écrit : > > Why do these functions exist twice ? > > the API would be simpler with just one set > > You mean the _samples / _frame versions, or the normal / _sure versions? i

Re: [FFmpeg-devel] [PATCH] ffplay: add startup volume option

24.12.2016, 20:00, "Marton Balint" : > On Thu, 22 Dec 2016, gajja...@yandex.com wrote: > >>  From: Ganesh Ajjanagadde >> >>  Fixes Ticket 5389. >> >>  Signed-off-by: Ganesh Ajjanagadde >>  --- >>  doc/ffplay.texi | 4 >>  

Re: [FFmpeg-devel] [PATCH] ffplay: add startup volume option

On Thu, 22 Dec 2016, gajja...@yandex.com wrote: From: Ganesh Ajjanagadde Fixes Ticket 5389. Signed-off-by: Ganesh Ajjanagadde --- doc/ffplay.texi | 4 ffplay.c| 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 11/17] lavfi: cosmetic: remove forward declaration.

On Sat, Dec 24, 2016 at 06:41:43PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 2 -- > 1 file changed, 2 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings

Re: [FFmpeg-devel] [PATCH 10/17] lavfi: add AVFilter.activate.

On Sat, Dec 24, 2016 at 06:41:42PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 6 +- > libavfilter/avfilter.h | 5 + > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH 08/17] lavfi: add helpers to consume frames from link FIFOs.

On Sat, Dec 24, 2016 at 06:41:40PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 63 > ++ > libavfilter/internal.h | 47 + > 2 files changed, 110

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_link_process_timeline().

Le quintidi 5 nivôse, an CCXXV, Michael Niedermayer a écrit : > This seems to just factorize code > LGTM Yes; the previous one too. As I said, quite straightforward, just making existing pieces of code available for the next steps. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [PATCH 06/17] lavfi: add ff_link_process_timeline().

On Sat, Dec 24, 2016 at 06:41:38PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.c | 34 +- > libavfilter/internal.h | 6 ++ > 2 files changed, 27 insertions(+), 13 deletions(-) This seems to just

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

Le quintidi 5 nivôse, an CCXXV, Michael Niedermayer a écrit : > On Sat, Dec 24, 2016 at 06:41:49PM +0100, Nicolas George wrote: > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersink.c | 211 > > --- > > 1 file changed,

Re: [FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

On Sat, Dec 24, 2016 at 06:41:49PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/buffersink.c | 211 > --- > 1 file changed, 54 insertions(+), 157 deletions(-) this seems not applying cleanly here

Re: [FFmpeg-devel] [PATCH] avcodec/dca: set initial sample_fmt to FLTP

Am 24.12.2016 21:17 schrieb "foo86" : Fixes regression introduced in 39f7620d76c7a133535ed7a535f7a74fefa6e435. Not setting default sample_fmt can result in failed transcode when audio stream starts later in a file. I don't agree with this. Letting decoders set their

[FFmpeg-devel] [PATCH] avcodec/dca: set initial sample_fmt to FLTP

Fixes regression introduced in 39f7620d76c7a133535ed7a535f7a74fefa6e435. Not setting default sample_fmt can result in failed transcode when audio stream starts later in a file. Set initial sample_fmt to FLTP, which is the "baseline" format decoder produces. Fixes ticket #5998. ---

[FFmpeg-devel] [PATCH 11/17] lavfi: cosmetic: remove forward declaration.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 4638ff71ee..3927e7f7ac 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -45,8 +45,6 @@ #include

[FFmpeg-devel] [PATCH 06/17] lavfi: add ff_link_process_timeline().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 34 +- libavfilter/internal.h | 6 ++ 2 files changed, 27 insertions(+), 13 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index b05a75182a..92cba6f7a1

[FFmpeg-devel] [PATCH 16/17] lavfi: do not call ff_filter_frame() with activate.

avfilter_graph_request_oldest() does work that should be done by either the filter or the application. The principle of this function, calling ff_request_frame() from outside the filter was always shaky. This version is less elegant since it requires making special cases for each filter, but it

[FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 211 --- 1 file changed, 54 insertions(+), 157 deletions(-) Hum, it seems diff is not making it easy to see what functions are changed, deleted or added.

[FFmpeg-devel] [PATCH 13/17] lavfi: add ff_link_set_frame_wanted().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/internal.h | 8 2 files changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 6d24f74c08..c3e30b80b7 100644 --- a/libavfilter/avfilter.c +++

[FFmpeg-devel] [PATCH 10/17] lavfi: add AVFilter.activate.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 6 +- libavfilter/avfilter.h | 5 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 1df1157f02..4638ff71ee 100644 --- a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 08/17] lavfi: add helpers to consume frames from link FIFOs.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 63 ++ libavfilter/internal.h | 47 + 2 files changed, 110 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 15/17] lavfi: make two functions static.

ff_request_frame_to_filter() and ff_filter_frame_to_filter() are only used in avfilter.c. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 4 ++-- libavfilter/internal.h | 4 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 07/17] lavfi: pass min explicitly to samples_ready().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 92cba6f7a1..22a1fedd17 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@

[FFmpeg-devel] [PATCH 09/17] lavfi: use the consume helpers in ff_filter_frame_to_filter().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index e2eb2980be..1df1157f02 100644 --- a/libavfilter/avfilter.c +++

[FFmpeg-devel] [PATCH 14/17] lavfi: disallow ff_request_frame for filters using activate.

Having two different functions allows to have stricter tests and detect errors earlier. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 1 + libavfilter/internal.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 12/17] lavfi: move ff_update_link_current_pts() into the utility functions.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 3927e7f7ac..6d24f74c08 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1116,7

[FFmpeg-devel] [PATCH 04/17] lavfi: merge two variables after a recent commit.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 2de5a0ea78..83daef4609 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c

[FFmpeg-devel] lavfi: introduce a new way of designing filters

This rather long patch series introduces a new way of designing filters. The series is rather long in number of patches, but each step is quite simple and straightforward. The new design is this: instead of having filter_frame and request_frame on all pads, filters have a single callback,

[FFmpeg-devel] [PATCH 05/17] lavfi: add ff_link_process_commands().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 24 +++- libavfilter/internal.h | 6 ++ 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 83daef4609..b05a75182a 100644 ---

[FFmpeg-devel] [PATCH 03/17] lavfi: implement ff_link_make_frame_writable().

Unlike av_frame_is_writable(), it uses the link's alloc callback, making direct rendering possible. The code comes from ff_filter_frame_framed(), moved with mostly trivial changes. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 94

[FFmpeg-devel] [PATCH 02/17] lavfi: export ff_filter_set_ready() to the library.

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 2 +- libavfilter/internal.h | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index c1858fb6a0..191554eb6d 100644 --- a/libavfilter/avfilter.c +++

[FFmpeg-devel] [PATCH 01/17] lavfi: add ff_link_acknowledge_status().

Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 13 + libavfilter/internal.h | 6 ++ 2 files changed, 19 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 0020ee163a..c1858fb6a0 100644 --- a/libavfilter/avfilter.c +++

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > you snipped the context and reply to the quote as if it was meant > in a different context. > Not everyone intends to attack you :) Sorry; I might have still been a little on edge. > The quoted text are the steps which IMHO make

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

On 12/24/16, Ronald S. Bultje wrote: > Hi, > > On Sat, Dec 24, 2016 at 6:09 AM, Paul B Mahol wrote: > >> On 12/24/16, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Fri, Dec 23, 2016 at 6:18 PM, James Almer wrote: >> >

Re: [FFmpeg-devel] [PATCH] avutil/tests: Improved code coverage for random_seed

On Sat, Dec 24, 2016 at 12:30:06AM -0300, James Almer wrote: > On 12/22/2016 9:12 PM, Thomas Turner wrote: > > Signed-off-by: Thomas Turner > > --- > > libavutil/tests/random_seed.c | 34 +- > > tests/ref/fate/random_seed| 1 + > > 2

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

Hi, On Sat, Dec 24, 2016 at 6:09 AM, Paul B Mahol wrote: > On 12/24/16, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Dec 23, 2016 at 6:18 PM, James Almer wrote: > > > >> On 12/23/2016 8:00 PM, Ronald S. Bultje wrote: > >> > Hi, > >>

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) > the file is not sharable, this change undoes the effect of the > non-recursive patch > > use of vframes generally shows differences which seem to return to what

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

On Sat, Dec 24, 2016 at 10:39:58AM +0100, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > > deadlocks > > > > ./ffmpeg -i mpegts_with_dvbsubs.ts -filter_complex > >

Re: [FFmpeg-devel] [PATCH] avcodec/magicyuv: add SIMD for median of 10bits

On 12/24/16, Ronald S. Bultje wrote: > Hi, > > On Fri, Dec 23, 2016 at 6:18 PM, James Almer wrote: > >> On 12/23/2016 8:00 PM, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Fri, Dec 23, 2016 at 12:32 PM, Paul B Mahol wrote: >> > >> >>

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add SIMD support for median prediction for planar formats

On 12/24/16, Michael Niedermayer wrote: > On Fri, Dec 23, 2016 at 05:44:22PM +0100, Paul B Mahol wrote: >> ffmpeg | branch: master | Paul B Mahol | Fri Dec 23 >> 15:41:51 2016 +0100| [ea93052db3594f93f2d10be085a770184da0513d] | >> committer: Paul B Mahol

[FFmpeg-devel] [PATCH] lavfi, ffmpeg: simplify filter names.

The names are only used for technical output and debugging. Make them similar to C identifiers for easier quick reading of debug dumps. Signed-off-by: Nicolas George --- ffmpeg_filter.c | 24 libavfilter/avfiltergraph.c | 6 +++--- 2 files

[FFmpeg-devel] [PATCH 2/2] lavfi/buffersrc: push the frame deeper if requested.

Reduce peak memory consumption with ffmpeg in certain cases. Signed-off-by: Nicolas George --- libavfilter/buffersrc.c | 25 + 1 file changed, 25 insertions(+) Unchanged. diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index

[FFmpeg-devel] [PATCH 1/2] lavf/framesync: detect EOF immediately.

Fix an infinite loop in forward_status_change(). Signed-off-by: Nicolas George --- libavfilter/framesync.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index 7920cdb379..eb05d66a86 100644 ---

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add Apple Pixlet decoder

On 12/24/16, Andreas Cadhalpun wrote: +*got_frame = 1; + +return pktsize; >>> >>> Since this is a video decoder, this should always return the full >>> avpkt->size. >> >> Wrong. It returns what it consumes. > > Video decoders are expected

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > deadlocks > > ./ffmpeg -i mpegts_with_dvbsubs.ts -filter_complex > '[#0xf30]scale=320:240:flags=bilinear[sub];[#0xfa8]scale=320:240:flags=bilinear[video];[video][sub]overlay[v]' > -map '[v]' -map '#0x1048' -t 1 a.mkv > >