Re: [FFmpeg-devel] mac, ios clock_gettime patch

2017-02-04 Thread Wang Bin
> > So how is it possible that clock_gettime() must not be defined to allow > starting the executable, but this object has to be? Because I build ffmpeg with cc and linker flag "-mmacosx-version-min=10.7" to support lower os versions. If no such flag, the target os is the sdk version you use, e.g

Re: [FFmpeg-devel] mac, ios clock_gettime patch

2017-02-04 Thread Carl Eugen Hoyos
2017-02-05 3:12 GMT+01:00 Wang Bin : >> >> dyld: Symbol not found: _kVTCompressionPropertyKey_H264EntropyMode > > What system? kVTCompressionPropertyKey_H264EntropyMode is > available since macOS 10.9 and iOS 10.8. Indicating this is about 10.7. > If targeting older system, we have to define it's

Re: [FFmpeg-devel] mac, ios clock_gettime patch

2017-02-04 Thread Wang Bin
> > dyld: Symbol not found: _kVTCompressionPropertyKey_H264EntropyMode What system? kVTCompressionPropertyKey_H264EntropyMode is available since macOS 10.9 and iOS 10.8. If targeting older system, we have to define it's value like kVTVideoDecoderSpecification_RequireHardwareAcceleratedVideoDecode

Re: [FFmpeg-devel] [PATCH] avfilter/scale: use int64_t for height/width calculation to address overflow

2017-02-04 Thread Michael Niedermayer
On Sat, Feb 04, 2017 at 10:04:36AM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavfilter/scale.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/scale.c b/libavfilter/scale.c > index 50cd442..9725f1f 100644 > --- a/libavfilter/scale.c > +++

Re: [FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

2017-02-04 Thread Michael Niedermayer
On Sat, Feb 04, 2017 at 10:04:07AM -0800, Aman Gupta wrote: > On Fri, Feb 3, 2017 at 3:04 PM, Michael Niedermayer > wrote: [...] > > > > If you dont have coverity access, tell me and ill send you an invite > > > > Please do. invite sent [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730

[FFmpeg-devel] [PATCH] avfilter/af_pan: fix null pointer dereference on empty token

2017-02-04 Thread Marton Balint
Fixes Coverity CID 1396254. Signed-off-by: Marton Balint --- libavfilter/af_pan.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index 94f1587..00eef2b 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter/af_pan.c @@ -115,6 +115,11 @@ static a

[FFmpeg-devel] [PATCH] ffplay: change keyboard volume control to logarithmic

2017-02-04 Thread Marton Balint
The command line parameter remains linear. Signed-off-by: Marton Balint --- ffplay.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ffplay.c b/ffplay.c index 1c9db73..cf138dc 100644 --- a/ffplay.c +++ b/ffplay.c @@ -73,8 +73,8 @@ const int program_birth_year = 200

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-04 Thread Compn
On Sat, 4 Feb 2017 12:59:13 +0100, wm4 wrote: > On Sat, 4 Feb 2017 00:02:16 +0200 > Ivo Andonov wrote: > > > 2017-02-03 23:18 GMT+02:00 Compn : > > > > > On Fri, 3 Feb 2017 15:46:20 +0200, Ivo Andonov > > > wrote: > > > > > > > I successfully used a modified Pinetron library on Windows to u

Re: [FFmpeg-devel] fixed vs floating point mp3 encoder

2017-02-04 Thread Moritz Barsnick
On Fri, Feb 03, 2017 at 17:57:12 -0500, Lina Sharifi wrote: > Hi, > I am using ffmpeg integrated with libmp3lame for encoding > (AV_CODEC_ID_MP3), Is there an option for to enable fixed point (integer) > encoder? Probably a codec flag? ffmpeg supports libshine, which is a fixed-point encoder. That

Re: [FFmpeg-devel] [PATCHv2 2/2] avfilter/ebur128: fix relative threshold calculation for multiple contexts

2017-02-04 Thread Marton Balint
On Sat, 4 Feb 2017, Marton Balint wrote: This reworks the code a bit and also disallows NULL contexts. Fixes Coverity CID 1396273, 1396279. Signed-off-by: Marton Balint --- libavfilter/ebur128.c | 46 -- 1 file changed, 16 insertions(+), 30 deletion

Re: [FFmpeg-devel] [PATCH] doc/muxers: remove confusing example for segment muxer option clocktime_wrap_duration

2017-02-04 Thread Marton Balint
On Fri, 27 Jan 2017, Marton Balint wrote: Detecting a leap second depends on a lot of things, segment time, segment offset, system leap second implementation, the removed part is a huge simplification which can be misleading, so it is best to remove it. Signed-off-by: Marton Balint --- doc/mu

Re: [FFmpeg-devel] [PATCH] avformat/segment: remove last_cut check when detecting a new segment

2017-02-04 Thread Marton Balint
On Mon, 30 Jan 2017, Marton Balint wrote: On Thu, 26 Jan 2017, Marton Balint wrote: Not starting a new segment if the elapsed microsecs since the start of the day equals the the elapsed microsecs since the start of the day at the time of the last cut seems plain wrong to me, Deti do you

Re: [FFmpeg-devel] [PATCH] ffplay: fix borderless mode on Windows

2017-02-04 Thread Marton Balint
On Sat, 4 Feb 2017, Marton Balint wrote: Signed-off-by: Marton Balint --- ffplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index 6325e6f..1c9db73 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1261,13 +1261,15 @@ static int video_open(VideoState *is)

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-04 Thread Bodecs Bela
2017.02.04. 20:45 keltezéssel, Hendrik Leppkes írta: On Sat, Feb 4, 2017 at 6:55 PM, Aman Gupta wrote: From: Aman Gupta Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-04 Thread Hendrik Leppkes
On Sat, Feb 4, 2017 at 6:55 PM, Aman Gupta wrote: > From: Aman Gupta > > Adds a `-hls_flags +temp_file` which will write segment data to > filename.tmp, and then rename to filename when the segment is complete. > > This patch is similar in spirit to one used in Plex's ffmpeg fork, and > allows a

Re: [FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

2017-02-04 Thread Aman Gupta
On Fri, Feb 3, 2017 at 3:04 PM, Michael Niedermayer wrote: > On Wed, Feb 01, 2017 at 04:30:18PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > Implements support for height/width expressions in vf_scale_vaapi, > > by refactoring common code into a new libavfilter/scale.c > > --- > > liba

[FFmpeg-devel] [PATCH] avfilter/scale: use int64_t for height/width calculation to address overflow

2017-02-04 Thread Aman Gupta
From: Aman Gupta --- libavfilter/scale.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/scale.c b/libavfilter/scale.c index 50cd442..9725f1f 100644 --- a/libavfilter/scale.c +++ b/libavfilter/scale.c @@ -68,7 +68,7 @@ int ff_scale_eval_dimensions(void *log_

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-04 Thread Aman Gupta
From: Aman Gupta Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to one used in Plex's ffmpeg fork, and allows a transcoding webserver to ensure incomplete segment files are ne

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-04 Thread Vittorio Giovara
On Fri, Feb 3, 2017 at 5:57 PM, Aaron Colwell wrote: > I still think you don't understand what these fields do given what you say > here. Yes there is a little more math. At the end of the day all these > fields do is specify a the min & max for the latitude & longitude. This > essentially transla

Re: [FFmpeg-devel] [PATCH 1/6] opus_rc: rename total_bits_used to total_bits and #define some constants

2017-02-04 Thread Rostislav Pehlivanov
On 1 February 2017 at 03:13, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/opus_celt.c | 2 +- > libavcodec/opus_rc.c | 19 +-- > libavcodec/opus_rc.h | 6 +++--- > 3 files changed, 17 insertions(+), 10 deletions(-) > > diff --git a/l

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-04 Thread wm4
On Fri, 3 Feb 2017 14:42:44 -0800 Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is increased by a > longstanding b

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-04 Thread wm4
On Sat, 4 Feb 2017 00:02:16 +0200 Ivo Andonov wrote: > 2017-02-03 23:18 GMT+02:00 Compn : > > > On Fri, 3 Feb 2017 15:46:20 +0200, Ivo Andonov > > wrote: > > > > > I successfully used a modified Pinetron library on Windows to use my own > > > software for decoding the stream. While fiddling w

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-04 Thread Hendrik Leppkes
On Sat, Feb 4, 2017 at 10:29 AM, Carl Eugen Hoyos wrote: > 2017-02-04 10:25 GMT+01:00 Hendrik Leppkes : > >> Another MSVC workaround is an undocumented compiler pragma, which >> works in 2013, but not in 2012 (#pragma >> execution_character_set("utf-8")), but adding pragmas to files is also >> not

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-04 Thread Carl Eugen Hoyos
2017-02-04 10:25 GMT+01:00 Hendrik Leppkes : > Another MSVC workaround is an undocumented compiler pragma, which > works in 2013, but not in 2012 (#pragma > execution_character_set("utf-8")), but adding pragmas to files is also > not something you can just easily hide away without it becoming ugly

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-04 Thread Hendrik Leppkes
On Sat, Feb 4, 2017 at 10:25 AM, Hendrik Leppkes wrote: > On Sat, Feb 4, 2017 at 5:50 AM, Matt Oliver wrote: >> On 4 February 2017 at 02:32, Hendrik Leppkes wrote: >> >>> On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: >>> > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: >>> >> Without the /UTF

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-04 Thread Hendrik Leppkes
On Sat, Feb 4, 2017 at 5:50 AM, Matt Oliver wrote: > On 4 February 2017 at 02:32, Hendrik Leppkes wrote: > >> On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: >> > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: >> >> Without the /UTF-8 switch, the MSVC compiler treats all files as in the >> >> sy

Re: [FFmpeg-devel] mac, ios clock_gettime patch

2017-02-04 Thread Carl Eugen Hoyos
2017-01-03 7:26 GMT+01:00 Wang Bin : > If ffmpeg is build with iOS 10 sdk, program will crash on iOS > 9. This patch fixes the crash. Does anybody know why clock_gettime() behaves differently than kVTCompressionPropertyKey_H264EntropyMode in libavcodec/videotoolboxenc.c? Iiuc, the call to clock_ge

Re: [FFmpeg-devel] DVR MPEG4 variant (AS-3024)

2017-02-04 Thread Carl Eugen Hoyos
2017-02-03 18:08 GMT+01:00 Ivo Andonov : > 2017-02-03 18:16 GMT+02:00 Carl Eugen Hoyos : >> How would another owner of this DVR get the streams? > > Now that is a separate question. If it has to be integrated in the ffmpeg > suite, I can provide a PHP script that connects to the DVR and fetches th