Re: [FFmpeg-devel] [PATCH] hlsenc: intialize only on ref_pkt and drop all packets

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 23:35 Michael Niedermayer napsal(a): On Sun, Feb 12, 2017 at 07:31:43PM +0100, Miroslav Slugeň wrote: This patch will fix cutting hls segments into exactly same length. Because it will intialize only on first ref_packet, which is video frame, not audio frame (old behavior) It

Re: [FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 23:20 Philip Langdale napsal(a): On Sun, 12 Feb 2017 22:43:41 +0100 Miroslav Slugeň wrote: Dne 12.2.2017 v 22:31 Timo Rothenpieler napsal(a): On 2/12/2017 10:25 PM, Miroslav Slugeň wrote: This patch is for discussion only, not ready to commit yet and

Re: [FFmpeg-devel] [PATCH v2 1/3] ffmpeg_opt: pass output framerate as a hint to the encoder

2017-02-12 Thread Tobias Rapp
On 06.02.2017 13:33, Tobias Rapp wrote: Sets framerate field in output codec context if explicitly specified on the command-line. Signed-off-by: Tobias Rapp --- ffmpeg_opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index

Re: [FFmpeg-devel] [PATCH 1/2] AVFrame: add an opaque_ref field

2017-02-12 Thread wm4
On Sat, 11 Feb 2017 17:30:24 +0100 Michael Niedermayer wrote: > On Sat, Feb 11, 2017 at 02:17:36PM +0100, wm4 wrote: > > This is an extended version of the AVFrame.opaque field, which can be > > used to attach arbitrary user information to an AVFrame. > > > > The

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v4]

2017-02-12 Thread Takayuki 'January June' Suwa
From: Takayuki 'January June' Suwa This adds "-profile[:v] profile_name"-style option. --- libavcodec/omx.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 16df50e..cfe2613 100644 ---

Re: [FFmpeg-devel] [PATCH 3/4] aacsbr: Associate SBR data with AAC elements on init

2017-02-12 Thread Alex Converse
On Thu, Feb 9, 2017 at 4:11 PM, Carl Eugen Hoyos wrote: > > 2017-02-09 18:40 GMT+01:00 Alex Converse : > > Quiets some log spam on pure upsampling mode. > > Please mention ticket #5163. > Done > For the whole patchset, I suggest you push as soon as

Re: [FFmpeg-devel] [PATCH 2/9] ffmpeg: do packet ts rescaling in write_packet()

2017-02-12 Thread wm4
On Fri, 10 Feb 2017 22:43:26 +0100 Michael Niedermayer wrote: > On Fri, Feb 10, 2017 at 01:35:34PM +0100, wm4 wrote: > > From: Anton Khirnov > > > > This will be useful in the following commit, after which the muxer > > timebase is not always

[FFmpeg-devel] [PATCH v2 3/4] aacsbr: Associate SBR data with AAC elements on init

2017-02-12 Thread Alex Converse
Quiets some log spam on pure upsampling mode. Fixes ticket 5163. --- libavcodec/aacdec_template.c | 2 +- libavcodec/aacsbr.h | 2 +- libavcodec/aacsbr_template.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacdec_template.c

[FFmpeg-devel] [PATCH v2 1/4] aac_latm: Allow unaligned AudioSpecificConfig

2017-02-12 Thread Alex Converse
Fixes ticket 4730 --- libavcodec/aacdec.c | 26 -- libavcodec/aacdec_template.c | 82 libavcodec/mpeg4audio.c | 76 ++-- libavcodec/mpeg4audio.h | 12 ++- 4 files changed, 120

Re: [FFmpeg-devel] [PATCH] (for discussion): cuvid: allow to crop and resize in decoder

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 21:07:40 +0100 Miroslav Slugeň wrote: > Dne 12.2.2017 v 20:59 Hendrik Leppkes napsal(a): > > On Sun, Feb 12, 2017 at 8:51 PM, Miroslav Slugeň > > wrote: > >> This patch is for discussion only, not ready to commit yet. > >> > >> 1.

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg: prefer cuvid decoders when use option -cuvid

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 21:20:12 + Mark Thompson wrote: > On 12/02/17 20:37, Miroslav Slugeň wrote: > > This patch is for discussion only, not ready to commit yet and maybe newer > > will be. > > > > We were facing issue when using -hwaccel cuvid we have to also specify > >

Re: [FFmpeg-devel] [PATCH] avcodec/fmvc: find Uninitialized variables for Coverity

2017-02-12 Thread Steven Liu
2017-02-13 7:43 GMT+08:00 Steven Liu : > Initialized variables opcode to indent > > Signed-off-by: Steven Liu > --- > libavcodec/fmvc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/fmvc.c b/libavcodec/fmvc.c >

Re: [FFmpeg-devel] [PATCH v2 0/5] A native Opus encoder

2017-02-12 Thread Rostislav Pehlivanov
On 12 February 2017 at 11:33, Nicolas George wrote: > Le tridi 23 pluviôse, an CCXXV, Rostislav Pehlivanov a écrit : > > This series of commits implements a native Opus encoder. > > That is wonderful news. > > I do not have the knowledge to review the patches themselves. > > But

[FFmpeg-devel] [PATCH] avcodec/fmvc: find Uninitialized variables for Coverity

2017-02-12 Thread Steven Liu
Initialized variables opcode to indent Signed-off-by: Steven Liu --- libavcodec/fmvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fmvc.c b/libavcodec/fmvc.c index 54bb6f9..5e54d33 100644 --- a/libavcodec/fmvc.c +++ b/libavcodec/fmvc.c @@

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix stream level metadata handling

2017-02-12 Thread Steven Liu
2017-02-12 9:36 GMT+08:00 Steven Liu : > > > 2017-02-12 5:31 GMT+08:00 Bodecs Bela : > >> Dear All, >> >> hls-encoder currently does not provide stream level metadata to mpegts >> muxer. This patch also fixes track #3848 bug. >> >> Please review this

Re: [FFmpeg-devel] [PATCH] hlsenc: intialize only on ref_pkt and drop all packets

2017-02-12 Thread Michael Niedermayer
On Sun, Feb 12, 2017 at 07:31:43PM +0100, Miroslav Slugeň wrote: > This patch will fix cutting hls segments into exactly same length. > Because it will intialize only on first ref_packet, which is video > frame, not audio frame (old behavior) > > It will also drop all packets without PTS, drop

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Timo Rothenpieler
> I just tried your build with this cmd line: > > ffmpeg -hwaccel cuvid -c:v h264_cuvid -i simpson_1920p_h264.mp4 -y -c:v > hevc_nvenc -an -b:v 512K -qmin 5 -qmax 50 -preset slow > out_1920p_1920p_hq.mp4 > > And everything works well, do you have not working example? > > I have GTX 1060 3GB

Re: [FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Philip Langdale
On Sun, 12 Feb 2017 22:43:41 +0100 Miroslav Slugeň wrote: > Dne 12.2.2017 v 22:31 Timo Rothenpieler napsal(a): > > On 2/12/2017 10:25 PM, Miroslav Slugeň wrote: > >> This patch is for discussion only, not ready to commit yet and > >> maybe newer will be. > >> > >> NVENC in

Re: [FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 10:43 PM, Miroslav Slugeň wrote: > Dne 12.2.2017 v 22:31 Timo Rothenpieler napsal(a): >> On 2/12/2017 10:25 PM, Miroslav Slugeň wrote: >>> This patch is for discussion only, not ready to commit yet and maybe >>> newer will be. >>> >>> NVENC in current CUDA 8 SDK is setting wrong

Re: [FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 22:31 Timo Rothenpieler napsal(a): On 2/12/2017 10:25 PM, Miroslav Slugeň wrote: This patch is for discussion only, not ready to commit yet and maybe newer will be. NVENC in current CUDA 8 SDK is setting wrong aspect ratio when encoding resolution 720x576 and 720x480 and using

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/02/2017 15:28, Marton Balint wrote: > > On Sun, 12 Feb 2017, Josh de Kock wrote: > >> Hi Carl, >> >> I'm not sure, 0.2.28 doesn't compile on my system. It has been >> tested with the latest version 0.2.38. > > I only checked the source

Re: [FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 10:25 PM, Miroslav Slugeň wrote: > This patch is for discussion only, not ready to commit yet and maybe > newer will be. > > NVENC in current CUDA 8 SDK is setting wrong aspect ratio when encoding > resolution 720x576 and 720x480 and using AR 4:3 or 16:9 it will encode > to h264

[FFmpeg-devel] [PATCH] (for discussion): nvenc: fix wrong aspect ratio for 720x576 and 720x480 resolution

2017-02-12 Thread Miroslav Slugeň
This patch is for discussion only, not ready to commit yet and maybe newer will be. NVENC in current CUDA 8 SDK is setting wrong aspect ratio when encoding resolution 720x576 and 720x480 and using AR 4:3 or 16:9 it will encode to h264 header that 15:11 and 20:11 is used. This is very very

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg: prefer cuvid decoders when use option -cuvid

2017-02-12 Thread Mark Thompson
On 12/02/17 20:37, Miroslav Slugeň wrote: > This patch is for discussion only, not ready to commit yet and maybe newer > will be. > > We were facing issue when using -hwaccel cuvid we have to also specify input > decoder like -c:v _cuvid for every input and input video format was >

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Timo Rothenpieler
> I have seen those patches in mailing list. Have you tried it on QUADRO > cards which are not limited to only 2 streams per system? It could be > related to protection in NVIDIA drivers for NON-PRO cards. It it definitely not related to that limitation, that fails way ealier and with a somewhat

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-02-12 Thread Micah Galizia
On Sun, Feb 12, 2017 at 6:28 AM, Nicolas George wrote: > Thanks for the patch. See remarks below. > > Le tridi 23 pluviôse, an CCXXV, Micah Galizia a écrit : >> On some authenticated Neulion streams, they send a cookie from the past, >> like so: >> >> Set-Cookie: nlqptid="";

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:59 Timo Rothenpieler napsal(a): On 2/12/2017 8:53 PM, Miroslav Slugeň wrote: Dne 12.2.2017 v 20:25 Timo Rothenpieler napsal(a): On 2/12/2017 8:18 PM, Miroslav Slugeň wrote: This patch is for discussion only, not ready to commit yet. We were facing issue when using -hwaccel

[FFmpeg-devel] [PATCH] (for discussion): ffmpeg: prefer cuvid decoders when use option -cuvid

2017-02-12 Thread Miroslav Slugeň
This patch is for discussion only, not ready to commit yet and maybe newer will be. We were facing issue when using -hwaccel cuvid we have to also specify input decoder like -c:v _cuvid for every input and input video format was sometimes mpeg2/h264/hevc. So this is my FIX/HACK to only

[FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option v2

2017-02-12 Thread Miroslav Slugeň
Add drop_second_field for CUVID input. It is not enabled by default this time and will fix reporting correct frame_rate -- Miroslav Slugeň >From c5277c84eba2b1f7b6ee92cf7cb4a2df23a9b536 Mon Sep 17 00:00:00 2001 From: Miroslav Slugen Date: Sun, 12 Feb 2017

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 21:01 Timo Rothenpieler napsal(a): On 2/12/2017 8:56 PM, Miroslav Slugeň wrote: 2. We should change it in libx264 and libx265 Changing it in nvenc now would be kind of an API break, as the behaviour might change without someone expecting it.

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:56 PM, Miroslav Slugeň wrote: >>> 2. We should change it in libx264 and libx265 >> Changing it in nvenc now would be kind of an API break, as the behaviour >> might change without someone expecting it. >> ___ >> ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:56 Timo Rothenpieler napsal(a): On 2/12/2017 8:35 PM, Miroslav Slugeň wrote: Thx for comment, cuvid can't output 50fps deinterlaced output, both frames are same, and default behavior for yadif is to downcovert to half frame rate, so i think is very clever to do the same

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:53 PM, Miroslav Slugeň wrote: > Dne 12.2.2017 v 20:25 Timo Rothenpieler napsal(a): >> On 2/12/2017 8:18 PM, Miroslav Slugeň wrote: >>> This patch is for discussion only, not ready to commit yet. >>> >>> We were facing issue when using -hwaccel cuvid, then we were unable to >>> use

Re: [FFmpeg-devel] [PATCH] (for discussion): cuvid: allow to crop and resize in decoder

2017-02-12 Thread Hendrik Leppkes
On Sun, Feb 12, 2017 at 8:51 PM, Miroslav Slugeň wrote: > This patch is for discussion only, not ready to commit yet. > > 1. Cuvid decoder actualy support scaling input to requested resolution > without any performance penalty (like libnpp does), so this patch is proof > of

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:52 Timo Rothenpieler napsal(a): On 2/12/2017 8:43 PM, Miroslav Slugeň wrote: Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra

Re: [FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:35 PM, Miroslav Slugeň wrote: > Thx for comment, > > cuvid can't output 50fps deinterlaced output, both frames are same, and > default behavior for yadif is to downcovert to half frame rate, so i > think is very clever to do the same here. > > Also if we return in decoder that

Re: [FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Hendrik Leppkes
On Sun, Feb 12, 2017 at 8:35 PM, Miroslav Slugeň wrote: > Thx for comment, > > cuvid can't output 50fps deinterlaced output, both frames are same, and > default behavior for yadif is to downcovert to half frame rate, so i think > is very clever to do the same here. > Thats

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:25 Timo Rothenpieler napsal(a): On 2/12/2017 8:18 PM, Miroslav Slugeň wrote: This patch is for discussion only, not ready to commit yet. We were facing issue when using -hwaccel cuvid, then we were unable to use -filter_complex filters for video streams, this hack fixed it,

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:43 PM, Miroslav Slugeň wrote: > Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): >> The current behavior is intended like it is. >> On the default of -1, it does not care about I/IDR frame requests, in >> mode 0 it will generate intra frames, and in mode 1 it will generate >> full

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:29 Timo Rothenpieler napsal(a): The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra frames, and in mode 1 it will generate full IDR frames.

Re: [FFmpeg-devel] [PATCH] nvenc: support dynamic aspect ratio change

2017-02-12 Thread Miroslav Slugeň
Dne 12.2.2017 v 20:27 Timo Rothenpieler napsal(a): On 2/12/2017 7:53 PM, Miroslav Slugeň wrote: If there is input like DVB-T streams it can change aspect ratio on-the-fly, so nvenc should respect this change and change aspect ratio in encoder. Haven't tested yet, but seems like a good idea.

Re: [FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Miroslav Slugeň
Thx for comment, cuvid can't output 50fps deinterlaced output, both frames are same, and default behavior for yadif is to downcovert to half frame rate, so i think is very clever to do the same here. Also if we return in decoder that input is framerate/2 when deinterlacing we should stay

Re: [FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Timo Rothenpieler
The current behavior is intended like it is. On the default of -1, it does not care about I/IDR frame requests, in mode 0 it will generate intra frames, and in mode 1 it will generate full IDR frames. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] nvenc: support dynamic aspect ratio change

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 7:53 PM, Miroslav Slugeň wrote: > If there is input like DVB-T streams it can change aspect ratio > on-the-fly, so nvenc should respect this change and change aspect ratio > in encoder. Haven't tested yet, but seems like a good idea. Are there other parameters that would make sense

Re: [FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Timo Rothenpieler
On 2/12/2017 8:18 PM, Miroslav Slugeň wrote: > This patch is for discussion only, not ready to commit yet. > > We were facing issue when using -hwaccel cuvid, then we were unable to > use -filter_complex filters for video streams, this hack fixed it, but i > am sure that it is not ready to

Re: [FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Timo Rothenpieler
It does make sense, the deinterlacers convert 50 interlaced fields to 50 progressive frames, like for example yadif can do as well. And disabling that functionality by default seems strange to me, as it's clearly the superior mode of operation. On 2/12/2017 8:02 PM, Miroslav Slugeň wrote: >

Re: [FFmpeg-devel] [PATCH] movenc: add support for track names in ISML manifests

2017-02-12 Thread Michael Niedermayer
On Sun, Feb 12, 2017 at 03:10:34PM +0200, Jan Ekstrom wrote: > On Sat, Feb 11, 2017 at 1:21 AM, Jan Ekström wrote: > > ... > > > > Poked Martin about this last night, and his comment was: > `<@wbs> JEEB: doesn't look harmful to me, so no objection` ok, ill apply it thx [...]

[FFmpeg-devel] [PATCH] (for discussion): ffmpeg_filter: initialize cuvid for filter_complex

2017-02-12 Thread Miroslav Slugeň
This patch is for discussion only, not ready to commit yet. We were facing issue when using -hwaccel cuvid, then we were unable to use -filter_complex filters for video streams, this hack fixed it, but i am sure that it is not ready to commit, because it is dirty/ugly fix. -- Miroslav Slugeň

[FFmpeg-devel] [PATCH] cuvid: add drop_second_field as input option and enable it by default

2017-02-12 Thread Miroslav Slugeň
There is no need to copy second field if deinterlacing, it doesn't make sense to use two times same image. -- Miroslav Slugeň >From 73d8f9fa17c26125a5b03243284f67126c70d7a6 Mon Sep 17 00:00:00 2001 From: Miroslav Slugen Date: Sun, 12 Feb 2017 20:00:51 +0100

[FFmpeg-devel] [PATCH] nvenc: support dynamic aspect ratio change

2017-02-12 Thread Miroslav Slugeň
If there is input like DVB-T streams it can change aspect ratio on-the-fly, so nvenc should respect this change and change aspect ratio in encoder. -- Miroslav Slugeň >From d836780d56fb7d7a63d91a2af87a0f84743d95d6 Mon Sep 17 00:00:00 2001 From: Miroslav Slugen

[FFmpeg-devel] [PATCH] hlsenc: intialize only on ref_pkt and drop all packets

2017-02-12 Thread Miroslav Slugeň
This patch will fix cutting hls segments into exactly same length. Because it will intialize only on first ref_packet, which is video frame, not audio frame (old behavior) It will also drop all packets without PTS, drop all packets before initialization and drop all packets before first

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add ffmpeg-security alias members

2017-02-12 Thread Michael Niedermayer
On Sat, Feb 11, 2017 at 10:19:59PM +0100, Paul B Mahol wrote: > On 2/10/17, Michael Niedermayer wrote: > > Iam listing the reason for each, this is mostly my oppinion and i didnt ask > > most > > if they agree with the listed reason to be listed with their name, so its > >

[FFmpeg-devel] [PATCH] ffmpeg: add new forced_keyframes option -hls:time

2017-02-12 Thread Miroslav Slugeň
If we are using copyts parameter it is not possible to inserting key frames same way as hlsenc requests, this will lead to different hls segments length. -copyts is required for long period audio/video sync Small modification to hlsenc.c is also required and will arrive in next patch. --

[FFmpeg-devel] [PATCH] cuvid: don't overwrite deinterlace at progressive input

2017-02-12 Thread Miroslav Slugeň
If there is progressive input it will disable deinterlacing in cuvid for all future frames even those interlaced. I suggest to backport this patch to stable, because deinterlacing of combined files (progressive+interlaced) is currently broken in cuvid. -- Miroslav Slugeň >From

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 16:52:21 +0100 wm4 wrote: > On Sun, 12 Feb 2017 16:48:57 +0100 > Carl Eugen Hoyos wrote: > > > Hi! > > > > Attached patch written yesterday silences warnings when compiling > > ffmpeg.c, don't know how useful it is, only

[FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

2017-02-12 Thread Miroslav Slugeň
There was error in forcing key frames. If IDR was set to -1 (default) forced key frame will be never propagated to encoder. I also suggest to backport this patch to current stable version, because -forced_keyframe behavior in NVENC is actualy broken. -- Miroslav Slugeň >From

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Paul B Mahol
On 2/12/17, Nicolas George wrote: > Le quartidi 24 pluviose, an CCXXV, Carl Eugen Hoyos a ecrit : >> New patch attached, Carl Eugen > > Thanks. The new patch looks fine to me, of course. > > I have said my piece on the other considerations, I do not think the > eventual decision

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : > New patch attached, Carl Eugen Thanks. The new patch looks fine to me, of course. I have said my piece on the other considerations, I do not think the eventual decision is mine to make. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 17:12 GMT+01:00 Marton Balint : > > On Sun, 12 Feb 2017, Carl Eugen Hoyos wrote: > >> Attached patch written yesterday silences warnings when compiling >> ffmpeg.c, don't know how useful it is, only fate-tested. > > Writing a warning about the failed filter functions is

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 17:00 GMT+01:00 Nicolas George : > Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : >> Hi! >> >> Attached patch written yesterday silences warnings when compiling >> ffmpeg.c, don't know how useful it is, only fate-tested. >> >> Please comment, Carl Eugen >

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Marton Balint a écrit : > Writing a warning about the failed filter functions is good, but ffmpeg has > a -xerror option as well, so I guess the proper fix would be to propagate > the error through the functions and fail the encoding process as well if > -xerror

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Marton Balint
On Sun, 12 Feb 2017, Carl Eugen Hoyos wrote: Hi! Attached patch written yesterday silences warnings when compiling ffmpeg.c, don't know how useful it is, only fate-tested. Writing a warning about the failed filter functions is good, but ffmpeg has a -xerror option as well, so I guess the

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXV, Carl Eugen Hoyos a écrit : > Hi! > > Attached patch written yesterday silences warnings when compiling > ffmpeg.c, don't know how useful it is, only fate-tested. > > Please comment, Carl Eugen > From 525aff909aec50d4e1a49f289ff9069300a4b51f Mon Sep 17

Re: [FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread wm4
On Sun, 12 Feb 2017 16:48:57 +0100 Carl Eugen Hoyos wrote: > Hi! > > Attached patch written yesterday silences warnings when compiling > ffmpeg.c, don't know how useful it is, only fate-tested. > > Please comment, Carl Eugen Conflicts with my merge patches.

[FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

2017-02-12 Thread Carl Eugen Hoyos
Hi! Attached patch written yesterday silences warnings when compiling ffmpeg.c, don't know how useful it is, only fate-tested. Please comment, Carl Eugen From 525aff909aec50d4e1a49f289ff9069300a4b51f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 12 Feb 2017

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Marton Balint
On Sun, 12 Feb 2017, Carl Eugen Hoyos wrote: 2017-02-12 15:35 GMT+01:00 Josh de Kock : I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. Does the updated patch look better? I prefer it if nobody wants to test old

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Marton Balint
On Sun, 12 Feb 2017, Josh de Kock wrote: Hi Carl, I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. I only checked the source code, and in 0.2.28 the function is already deprecated. So the original patch should be fine, I prefer that.

Re: [FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 15:35 GMT+01:00 Josh de Kock : > I'm not sure, 0.2.28 doesn't compile on my system. It has > been tested with the latest version 0.2.38. > > Does the updated patch look better? I prefer it if nobody wants to test old versions. > -vbi_decoder_delete(ctx->vbi); > -

[FFmpeg-devel] [PATCH v2] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Josh de Kock
Hi Carl, I'm not sure, 0.2.28 doesn't compile on my system. It has been tested with the latest version 0.2.38. Does the updated patch look better? Josh Signed-off-by: Josh de Kock --- libavcodec/libzvbi-teletextdec.c | 15 +-- 1 file changed, 13 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix stream level metadata handling

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 10:24 GMT+01:00 Steven Liu : > 2017-02-12 17:17 GMT+08:00 Bodecs Bela : >> Should I change the status of the track ticket or is there >> somebody who is the maintainer of trac? We do not track patch status there (if this was your question),

Re: [FFmpeg-devel] [PATCH] movenc: add support for track names in ISML manifests

2017-02-12 Thread Jan Ekstrom
On Sat, Feb 11, 2017 at 1:21 AM, Jan Ekström wrote: > ... > Poked Martin about this last night, and his comment was: `<@wbs> JEEB: doesn't look harmful to me, so no objection` Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Make a pointer cast explicit to silence a warning

2017-02-12 Thread Carl Eugen Hoyos
2017-02-12 13:43 GMT+01:00 Marton Balint : > > On Sat, 11 Feb 2017, Carl Eugen Hoyos wrote: > >> Attached patch silences a warning, don't know what is preferred here. > > LGTM. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] avdevice/iec61883: free packet on buffer allocation error

2017-02-12 Thread Marton Balint
On Thu, 9 Feb 2017, Marton Balint wrote: Fixes Coverity CID 1396416. Signed-off-by: Marton Balint --- libavdevice/iec61883.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/iec61883.c b/libavdevice/iec61883.c index c45ae9a..721dca3 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] avformat/fifo: assert on disallowed message type and state combinations

2017-02-12 Thread Marton Balint
On Thu, 9 Feb 2017, Marton Balint wrote: Fixes Coverity CID 1396277. Signed-off-by: Marton Balint --- libavformat/fifo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 8f525e5..2cbe5c5 100644 ---

Re: [FFmpeg-devel] [PATCH] lavc/libzvbi: remove deprecated API usage

2017-02-12 Thread Marton Balint
On Sat, 11 Feb 2017, Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavcodec/libzvbi-teletextdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/libzvbi-teletextdec.c b/libavcodec/libzvbi-teletextdec.c index d1f0a9f..2ed4a82

Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Make a pointer cast explicit to silence a warning

2017-02-12 Thread Marton Balint
On Sat, 11 Feb 2017, Carl Eugen Hoyos wrote: Hi! Attached patch silences a warning, don't know what is preferred here. LGTM. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

2017-02-12 Thread Paul B Mahol
On 2/12/17, Clement Boesch wrote: > On Sun, Feb 12, 2017 at 12:51:11PM +0100, Paul B Mahol wrote: >> On 2/11/17, Clement Boesch wrote: >> > On Sat, Feb 11, 2017 at 11:56:07AM +0100, Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol >> >> --- >> >>

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

2017-02-12 Thread Clément Bœsch
On Sun, Feb 12, 2017 at 12:51:11PM +0100, Paul B Mahol wrote: > On 2/11/17, Clement Boesch wrote: > > On Sat, Feb 11, 2017 at 11:56:07AM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavformat/mpl2dec.c | 8 > >> 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

2017-02-12 Thread Paul B Mahol
On 2/11/17, Clement Boesch wrote: > On Sat, Feb 11, 2017 at 11:56:07AM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavformat/mpl2dec.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/libavformat/mpl2dec.c

Re: [FFmpeg-devel] [PATCH v2 0/5] A native Opus encoder

2017-02-12 Thread Nicolas George
Le tridi 23 pluviôse, an CCXXV, Rostislav Pehlivanov a écrit : > This series of commits implements a native Opus encoder. That is wonderful news. I do not have the knowledge to review the patches themselves. But I think they are missing an essential, but fortunately rather easy, part: user

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-02-12 Thread Nicolas George
Thanks for the patch. See remarks below. Le tridi 23 pluviôse, an CCXXV, Micah Galizia a écrit : > On some authenticated Neulion streams, they send a cookie from the past, > like so: > > Set-Cookie: nlqptid=""; Domain=.neulion.com; Expires=Thu, 01-Jan-1970 > 00:00:10 GMT; Path=/ > > As a

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix stream level metadata handling

2017-02-12 Thread Steven Liu
2017-02-12 17:17 GMT+08:00 Bodecs Bela : > > > 2017.02.12. 2:36 keltezéssel, Steven Liu írta: > >> 2017-02-12 5:31 GMT+08:00 Bodecs Bela : >> >> Dear All, >>> >>> hls-encoder currently does not provide stream level metadata to mpegts >>> muxer. This patch

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix stream level metadata handling

2017-02-12 Thread Bodecs Bela
2017.02.12. 2:36 keltezéssel, Steven Liu írta: 2017-02-12 5:31 GMT+08:00 Bodecs Bela : Dear All, hls-encoder currently does not provide stream level metadata to mpegts muxer. This patch also fixes track #3848 bug. Please review this bug fix. Thank you in advance. best