Re: [FFmpeg-devel] [PATCH] swresample/swresample: do not use s32p internally by default when resampling

2017-03-15 Thread wm4
On Thu, 16 Mar 2017 12:43:10 +0700 Muhammad Faiz wrote: > use fltp when doing s32 -> s32 resampling > because s32p has no simd optimization > > benchmark: > old 17.913s > new 7.584s (use fma3) > > Signed-off-by: Muhammad Faiz > --- > libswresample/swresample.c | 2 ++ > 1 file changed, 2 ins

[FFmpeg-devel] [PATCH] swresample/swresample: do not use s32p internally by default when resampling

2017-03-15 Thread Muhammad Faiz
use fltp when doing s32 -> s32 resampling because s32p has no simd optimization benchmark: old 17.913s new 7.584s (use fma3) Signed-off-by: Muhammad Faiz --- libswresample/swresample.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswresample/swresample.c b/libswresample/swresample.c

[FFmpeg-devel] [PATCH] swresample/x86/resample: extend resample_double to support avx and fma3

2017-03-15 Thread Muhammad Faiz
benchmark: sse2 10.670s avx 8.763s fma3 8.380s Signed-off-by: Muhammad Faiz --- libswresample/x86/resample.asm| 15 --- libswresample/x86/resample_init.c | 10 ++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/libswresample/x86/resample.asm b/libswresa

Re: [FFmpeg-devel] FFmpeg 3.3

2017-03-15 Thread wm4
On Tue, 14 Mar 2017 12:29:52 +0100 Michael Niedermayer wrote: > Hi all > > are there any issues/tickets that block making 3.3 ? > > What about the spherical API size_t / uint32_t issue ? > we can change it before the release but not after it > I will insist that avcodec, avformat: deprecat

[FFmpeg-devel] [PATCH 2/2] ffmpeg: don't unnecessarily use a deprecated API function

2017-03-15 Thread wm4
Since we've disabled side data merging in ffmpeg.c, this really changes nothing. --- ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 63fc1bc5f4..bc2157e544 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -818,7 +818,6 @@ static void output_packet(OutputFile *of, AV

[FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-15 Thread wm4
This patch deprecates anything that has to do with merging/splitting side data. Automatic side data merging (and splitting), as well as all API symbols involved in it, are removed completely. Two FF_API_ defines are dedicated to deprecating API symbols related to this: FF_API_MERGE_SD_API removes

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread James Almer
On 3/15/2017 6:39 PM, Vittorio Giovara wrote: > These values are defined to be 32bit in the specification, > so it makes more sense to store them as fixed width. > > Signed-off-by: Vittorio Giovara > --- > Updated commit message, changed a couple of internal types. > Please CC or I can't see repl

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix duration wrong when no pkt duration

2017-03-15 Thread Steven Liu
2017-03-16 6:24 GMT+08:00 Alexander Strasser : > Hi! > > On 2017-03-13 17:12 +0800, Steven Liu wrote: > > when cannot get pkt duration, hlsenc segments duration will > > be set to 0, this patch can fix it. > > > > Signed-off-by: Steven Liu > > --- > > libavformat/hlsenc.c | 7 ++- > > 1 file

[FFmpeg-devel] [PATCH] lavf/mpegtsenc: clarify pcr_period unit of measurement

2017-03-15 Thread Lou Logan
pcr_period is in milliseconds. Signed-off-by: Lou Logan --- libavformat/mpegtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 0f394c5fe0..3250dde311 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.

[FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'

2017-03-15 Thread Michael Niedermayer
Fixes: 864/clusterfuzz-testcase-4774385942528000 See: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: 2147483647 - -14133 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/f

[FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Check stripsize strippos for overflow

2017-03-15 Thread Michael Niedermayer
Fixes: 861/clusterfuzz-testcase-5688284384591872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/tiff.c b/libavc

[FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-03-15 Thread Matthew Gregan
Hi, The attached patch adds demuxing support for Opus audio codec in ISOBMFF/MP4. This is based on v0.6.8 of the draft spec at https://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html. Firefox supports demuxing/playback of these files since Firefox 50. >From 9d6f1b4c12b08cf5fbba61bdeb31c785aa

[FFmpeg-devel] [PATCH 1/2] Add experimental support for Opus in ISO BMFF (MP4)

2017-03-15 Thread Matthew Gregan
Hi, The attached patch adds experimental muxing support for Opus audio codec in ISOBMFF/MP4. This is based on v0.6.8 of the draft spec at https://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html. Firefox supports demuxing/playback of these files since Firefox 50. >From cff9b592d4efd87e80120fb

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Ronald S. Bultje
Hi, On Wed, Mar 15, 2017 at 6:12 PM, Michael Niedermayer wrote: > On Wed, Mar 15, 2017 at 07:18:30PM +, Kieran Kunhya wrote: > > > > > > > > I have tons of testcases for h264 that are 1KB and can make error > > > > > concealment run for ages. > > > > > > and how is this related to a fix for

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/simple_idct_template: Fix several integer overflows

2017-03-15 Thread Michael Niedermayer
On Tue, Mar 14, 2017 at 10:20:45PM +0100, Michael Niedermayer wrote: > On Mon, Mar 13, 2017 at 12:53:27PM +0100, Michael Niedermayer wrote: > > On Mon, Mar 13, 2017 at 09:51:40AM +0100, Paul B Mahol wrote: > > > On 3/13/17, Michael Niedermayer wrote: > > > > Benchmarks with START_TIMER indicate th

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wavpack: Fix multiple integer overflows

2017-03-15 Thread Michael Niedermayer
On Tue, Mar 14, 2017 at 01:52:23AM +0100, Michael Niedermayer wrote: > Fixes: 839/clusterfuzz-testcase-4871084446842880 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 12

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

2017-03-15 Thread Aman Gupta
On Wed, Mar 15, 2017 at 2:06 PM, Michael Niedermayer wrote: > On Wed, Mar 15, 2017 at 12:53:03PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > includes a fate test, which requires > > https://s3.amazonaws.com/tmm1/ccaptions/scte20.ts > > to be uploaded as sub/scte20.ts > > uploaded > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Alexander Strasser
Hi! This is not a review, just a comment you can address in case you push this. On 2017-03-15 04:12 +0100, Michael Niedermayer wrote: > Fixes timeout with 847/clusterfuzz-testcase-5291877358108672 > Fixes timeout with 850/clusterfuzz-testcase-5721296509861888 > > This likely will need to be twe

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix duration wrong when no pkt duration

2017-03-15 Thread Alexander Strasser
Hi! On 2017-03-13 17:12 +0800, Steven Liu wrote: > when cannot get pkt duration, hlsenc segments duration will > be set to 0, this patch can fix it. > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 07:18:30PM +, Kieran Kunhya wrote: > > > > > > I have tons of testcases for h264 that are 1KB and can make error > > > > concealment run for ages. > > > > and how is this related to a fix for th vp* decoder ? > > > > My point is you can spend a lifetime fixing obscure c

[FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-15 Thread Mateusz Brzostek
Hello! There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: 1) there is overflow in dithering from 12-bit to 10-bit (output value > 1023); 2) for limit range the lower limit is not respected, for example from 10-bit to 8-bit value 64 is converted to 15; 3) for many iterat

[FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Vittorio Giovara
These values are defined to be 32bit in the specification, so it makes more sense to store them as fixed width. Signed-off-by: Vittorio Giovara --- Updated commit message, changed a couple of internal types. Please CC or I can't see replies. Vittorio libavformat/dump.c| 2 +- libavform

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/mpeg12dec: ensure a53_caption_size is reset on malloc failures

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 12:53:04PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mpeg12dec.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would gi

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 12:53:03PM -0700, Aman Gupta wrote: > From: Aman Gupta > > includes a fate test, which requires > https://s3.amazonaws.com/tmm1/ccaptions/scte20.ts > to be uploaded as sub/scte20.ts uploaded > --- > libavcodec/mpeg12dec.c | 39 +++

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mpeg12dec: ensure a53_caption_size is reset on malloc failures

2017-03-15 Thread Aman Gupta
From: Aman Gupta --- libavcodec/mpeg12dec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index cea8963..f71f207 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2255,8 +2255,11 @@ static int

[FFmpeg-devel] [PATCH v2 1/2] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

2017-03-15 Thread Aman Gupta
From: Aman Gupta includes a fate test, which requires https://s3.amazonaws.com/tmm1/ccaptions/scte20.ts to be uploaded as sub/scte20.ts --- libavcodec/mpeg12dec.c | 39 +++ tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-cc-scte20 | 15

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 12:10:35PM -0700, Aman Gupta wrote: > On Sat, Mar 11, 2017 at 7:05 AM, Michael Niedermayer > wrote: > > > On Mon, Mar 06, 2017 at 10:23:14AM -0800, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > --- > > > libavcodec/mpeg12dec.c | 38

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Kieran Kunhya
> > > > I have tons of testcases for h264 that are 1KB and can make error > > > concealment run for ages. > > and how is this related to a fix for th vp* decoder ? > My point is you can spend a lifetime fixing obscure conditions that cause error concealment to take a long time. Error concealment

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread James Almer
On 3/15/2017 3:51 PM, Michael Niedermayer wrote: > On Wed, Mar 15, 2017 at 08:58:39AM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Wed, Mar 15, 2017 at 8:21 AM, Kieran Kunhya wrote: >> >>> On Wed, 15 Mar 2017 at 12:05 Ronald S. Bultje wrote: >>> Hi, On Tue, Mar 14, 2017 at 11:12

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

2017-03-15 Thread Aman Gupta
On Sat, Mar 11, 2017 at 7:05 AM, Michael Niedermayer wrote: > On Mon, Mar 06, 2017 at 10:23:14AM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/mpeg12dec.c | 38 ++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 03:02:08PM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 15, 2017 at 2:51 PM, Michael Niedermayer > wrote: > > > On Wed, Mar 15, 2017 at 08:58:39AM -0400, Ronald S. Bultje wrote: [...] > but if people dont want EC code in vp56 then we can drop this code of > > cou

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread wm4
On Wed, 15 Mar 2017 15:02:08 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Mar 15, 2017 at 2:51 PM, Michael Niedermayer > wrote: > > > On Wed, Mar 15, 2017 at 08:58:39AM -0400, Ronald S. Bultje wrote: > > > I'm actually starting to believe that the error concealment code in this > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Ronald S. Bultje
Hi, On Wed, Mar 15, 2017 at 2:51 PM, Michael Niedermayer wrote: > On Wed, Mar 15, 2017 at 08:58:39AM -0400, Ronald S. Bultje wrote: > > I'm actually starting to believe that the error concealment code in this > > decoder (vp56) is fuzz-specific code also. Is there a real-world input > > where th

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 08:58:39AM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 15, 2017 at 8:21 AM, Kieran Kunhya wrote: > > > On Wed, 15 Mar 2017 at 12:05 Ronald S. Bultje wrote: > > > > > Hi, > > > > > > On Tue, Mar 14, 2017 at 11:12 PM, Michael Niedermayer < > > > mich...@niedermaye

Re: [FFmpeg-devel] [PATCH v2] swresample/options: enable linear_interp and exact_rational by default

2017-03-15 Thread Muhammad Faiz
On Mon, Mar 13, 2017 at 8:40 PM, Muhammad Faiz wrote: > better quality without speedloss > > Signed-off-by: Muhammad Faiz > --- > doc/resampler.texi | 5 +- > libswresample/options.c | 4 +- > tests/fate/libswresample.mak | 189 > --- >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread wm4
On Wed, 15 Mar 2017 08:58:39 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Mar 15, 2017 at 8:21 AM, Kieran Kunhya wrote: > > > On Wed, 15 Mar 2017 at 12:05 Ronald S. Bultje wrote: > > > > > Hi, > > > > > > On Tue, Mar 14, 2017 at 11:12 PM, Michael Niedermayer < > > > mich...@niedermay

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-15 Thread Philip Langdale
On Wed, 15 Mar 2017 10:09:17 +0100 (CET) wal...@free.fr wrote: > In the meantime, I have updated the CrystalHD kernel driver to linux > 4.9.y: https://github.com/wallak/crystalhd > > Wallak. I've been sending updates to: https://github.com/dbason/crystalhd --phil ___

Re: [FFmpeg-devel] [PATCH v2] avcodec/videotoolbox: add rc_max_bitrate control into videotoolbox

2017-03-15 Thread Richard Kern
On March 14, 2017 at 10:54:47 AM, Steven Liu (l...@chinaffmpeg.org) wrote: add kVTCompressionPropertyKey_DataRateLimits support by rc_max_bitrate Reviewed-by: Rick Kern Signed-off-by: Steven Liu --- libavcodec/videotoolboxenc.c | 47 1 file changed, 4

[FFmpeg-devel] [PATCH] configure: error out if jni is enabled and not found

2017-03-15 Thread Matthieu Bouron
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1e2e774950..a4890ca0d3 100755 --- a/configure +++ b/configure @@ -5744,7 +5744,7 @@ enabled frei0r&& { check_header frei0r.h || die "ERROR: frei0r.h hea enabled gmp

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Ronald S. Bultje
Hi, On Wed, Mar 15, 2017 at 8:21 AM, Kieran Kunhya wrote: > On Wed, 15 Mar 2017 at 12:05 Ronald S. Bultje wrote: > > > Hi, > > > > On Tue, Mar 14, 2017 at 11:12 PM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > > > > Fixes timeout with 847/clusterfuzz-testcase-5291877358108672 >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Kieran Kunhya
On Wed, 15 Mar 2017 at 12:05 Ronald S. Bultje wrote: > Hi, > > On Tue, Mar 14, 2017 at 11:12 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > Fixes timeout with 847/clusterfuzz-testcase-5291877358108672 > > Fixes timeout with 850/clusterfuzz-testcase-5721296509861888 > > > > This

Re: [FFmpeg-devel] [PATCH 0/2] lavc/libfdk-aacenc: VBR check message fix

2017-03-15 Thread Moritz Barsnick
On Sat, Mar 11, 2017 at 12:59:06 +0100, Michael Niedermayer wrote: > > I am under the impression that Martin Storsjö is > > maintaining the libfdk_aac wrapper, but primarily on "libav". He is > you could send martin a private mail and ask I did (or rather, he did by getting in touch with me priv

Re: [FFmpeg-devel] lavc/aarch64: add simple idct neon functions

2017-03-15 Thread Matthieu Bouron
On Mon, Mar 06, 2017 at 03:48:57PM +0100, Matthieu Bouron wrote: > On Thu, Feb 23, 2017 at 04:59:16PM +0100, Matthieu Bouron wrote: > > Hello, > > > > The following patchset add the ff_simple_idct function neon functions for > > the > > aarch64 platform. It's ported from armv7 simple_idct_neon wi

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-15 Thread Ronald S. Bultje
Hi, On Tue, Mar 14, 2017 at 11:12 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > Fixes timeout with 847/clusterfuzz-testcase-5291877358108672 > Fixes timeout with 850/clusterfuzz-testcase-5721296509861888 > > This likely will need to be tweaked Sorry, but this is getting insane. I c

Re: [FFmpeg-devel] [PATCH] lavc/h264dec: use OFFSET macro

2017-03-15 Thread Matthieu Bouron
On Tue, Feb 07, 2017 at 07:56:55PM +0100, Michael Niedermayer wrote: > On Mon, Feb 06, 2017 at 05:14:57PM +0100, Matthieu Bouron wrote: > > --- > > libavcodec/h264dec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ok Pushed. (and sorry for the delay). Thanks, Matthieu [...

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Carl Eugen Hoyos
2017-03-14 23:02 GMT+01:00 Vittorio Giovara : > These types better reflect the ones described in the specification and > avoid any platform-specific implementation issues. Sorry if I miss something but could you clarify who the author of this patch is? Thank you, Carl Eugen __

Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpeg good commit: 6d160afab2fa8d3bfb216fee96d3537ffc9e86e8

2017-03-15 Thread wallak
In the meantime, I have updated the CrystalHD kernel driver to linux 4.9.y: https://github.com/wallak/crystalhd Wallak. - Mail original - De: "wm4" À: ffmpeg-devel@ffmpeg.org Envoyé: Mardi 14 Mars 2017 23:35:13 Objet: Re: [FFmpeg-devel] The Crystalhd video decoder is broken - last ffmpe