[FFmpeg-devel] [PATCH] nvenc: Allow different const qps for I, P and B frames

2017-03-16 Thread Konda Raju
Adding subject line. Thanks and regards, Konda Raju -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Konda Raju Sent: Friday, March 17, 2017 9:56 AM To: ffmpeg-devel@ffmpeg.org Cc: phil...@overt.org Subject: [FFmpeg-devel] [PATCH] nvenc: Hi,

[FFmpeg-devel] [PATCH] nvenc:

2017-03-16 Thread Konda Raju
Hi, Please review the attached patch. This patch allows to specify different const qp values for I, P and B frames. This change is backward compatible. Note that the constQP values are initialized with default values in preset configuration, hence there is not "else()" block in set_constqp().

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Reuben Martin
On Thursday, March 16, 2017 3:54:39 PM CDT Marton Balint wrote: > On Thu, 16 Mar 2017, Nicolas George wrote: > > Le sextidi 26 ventôse, an CCXXV, Matthias Hunstock a écrit : > >> I did not find a comparable option for another device in libavdevice, > >> "format" was the initial suggestion of

[FFmpeg-devel] [PATCH v3] avformat/rtmpproto: change rtmp_open from url_open to url_open2

2017-03-16 Thread Steven Liu
use the option set by user Reported-by: Lancelot Lai Signed-off-by: Steven Liu --- libavformat/rtmpproto.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index

Re: [FFmpeg-devel] [PATCH] swresample/resample: do not assert compensation_distance on rebuild_filter

2017-03-16 Thread Muhammad Faiz
On Fri, Mar 17, 2017 at 9:27 AM, wm4 wrote: > On Fri, 17 Mar 2017 08:01:23 +0700 > Muhammad Faiz wrote: > >> when set_compensation is called with zero sample_delta, >> compensation does not happen (because dst_incr == ideal_dst_incr) >> but

Re: [FFmpeg-devel] [PATCH] swresample/resample: do not assert compensation_distance on rebuild_filter

2017-03-16 Thread wm4
On Fri, 17 Mar 2017 08:01:23 +0700 Muhammad Faiz wrote: > when set_compensation is called with zero sample_delta, > compensation does not happen (because dst_incr == ideal_dst_incr) > but compensation_distance is set > > regression since

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: quant_matrixes can be up to 65535, use uint16_t

2017-03-16 Thread Michael Niedermayer
Fixes invalid shift Fixes: 870/clusterfuzz-testcase-5649105424482304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mjpegdec.c | 10 +- libavcodec/mjpegdec.h |

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Constify AVBitStreamFilter* in AVBitStreamFilterContext struct.

2017-03-16 Thread Michael Niedermayer
On Thu, Mar 16, 2017 at 10:38:24PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes one of two remaining warnings when compiling > bitstream_filter.c. > > Please comment, Carl Eugen > avcodec.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-16 Thread Muhammad Faiz
On Fri, Mar 17, 2017 at 7:09 AM, wm4 wrote: > On Fri, 10 Mar 2017 09:19:38 +0700 > Muhammad Faiz wrote: > >> for higher quality resampling >> >> Signed-off-by: Muhammad Faiz >> --- > > This patch triggers this assertion: > > Assertion

[FFmpeg-devel] [PATCH] swresample/resample: do not assert compensation_distance on rebuild_filter

2017-03-16 Thread Muhammad Faiz
when set_compensation is called with zero sample_delta, compensation does not happen (because dst_incr == ideal_dst_incr) but compensation_distance is set regression since 01ebb57c03abde89bca7bdbc552917efcb8f551d Found-by: wm4 Signed-off-by: Muhammad Faiz

[FFmpeg-devel] [PATCH 3/3 v2] Documentation: update decklink options

2017-03-16 Thread Matthias Hunstock
Signed-off-by: Matthias Hunstock --- doc/indevs.texi | 14 ++ doc/outdevs.texi | 15 +++ 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 27cc3d5..a4c99a9 100644 --- a/doc/indevs.texi +++

[FFmpeg-devel] [PATCH 2/3 v2] decklink: new option 'format_code' to set video format by fourCC

2017-03-16 Thread Matthias Hunstock
Signed-off-by: Matthias Hunstock --- libavdevice/decklink_common.cpp | 17 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 5 +++-- libavdevice/decklink_dec_c.c| 1 + libavdevice/decklink_enc_c.c| 1 + 5 files

[FFmpeg-devel] [PATCH 1/3 v2] decklink: add format_code of display mode to list_format output

2017-03-16 Thread Matthias Hunstock
Signed-off-by: Matthias Hunstock --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index 8b499c5..82b3a0c 100644 ---

[FFmpeg-devel] [PATCH 0/3 v2] decklink: new option -format_code to specify video modes with constant fourCCs

2017-03-16 Thread Matthias Hunstock
This patch series introduces a new option for the decklink devices. Currently, a video mode can be explicitly set via -i "devicename@modenumber", which is a common need for capture and sometimes for playout. The current number based modes are not constant between different cards and sometimes

Re: [FFmpeg-devel] [PATCH] swresample/options: enable linear_interp and exact_rational by default

2017-03-16 Thread wm4
On Fri, 10 Mar 2017 09:19:38 +0700 Muhammad Faiz wrote: > for higher quality resampling > > Signed-off-by: Muhammad Faiz > --- This patch triggers this assertion: Assertion !c->frac && !c->dst_incr_mod && !c->compensation_distance failed at

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread wm4
On Fri, 17 Mar 2017 00:32:04 +0100 Michael Niedermayer wrote: > On Thu, Mar 16, 2017 at 09:20:55PM +0100, Nicolas George wrote: > > Le sextidi 26 ventôse, an CCXXV, Michael Niedermayer a écrit : > > > Applications which depend on the current default would need > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread Michael Niedermayer
On Thu, Mar 16, 2017 at 09:20:55PM +0100, Nicolas George wrote: > Le sextidi 26 ventôse, an CCXXV, Michael Niedermayer a écrit : > > Applications which depend on the current default would need > > ... to implement a correct structure to carry the data from their > demuxer to the lavc decoders.

Re: [FFmpeg-devel] [PATCH 2/3] ffplay: convert to new decode API

2017-03-16 Thread Marton Balint
On Wed, 15 Mar 2017, Marton Balint wrote: Since subtitles are not yet supported with the new API, CODEC_CAP_DELAY subtitle codecs (only libzvbi so far) may loose the last few buffered frames in the end of the stream. The impact of this is so limited, it seemded better to accept it than

[FFmpeg-devel] [PATCH 14/14] aarch64: vp9itxfm16: Do a simpler half/quarter idct16/idct32 when possible

2017-03-16 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This avoids loading and calculating coefficients that we know will be zero, and avoids filling the temp buffer with zeros in places where we know the second pass won't read. This gives a pretty substantial speedup for the smaller subpartitions.

[FFmpeg-devel] [PATCH 10/14] arm: vp9itxfm16: Make the larger core transforms standalone functions

2017-03-16 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This reduces the code size of libavcodec/arm/vp9itxfm_16bpp_neon.o from 17500 to 14516 bytes. This gives a small slowdown of a couple tens of cycles, up to around 150 cycles for the full case of the largest transform, but makes it more feasible

[FFmpeg-devel] [PATCH 11/14] aarch64: vp9itxfm16: Make the larger core transforms standalone functions

2017-03-16 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This reduces the code size of libavcodec/aarch64/vp9itxfm_16bpp_neon.o from 26288 to 21512 bytes. This gives a small slowdown of a couple of tens of cycles, but makes it more feasible to add more optimized versions of these transforms. Before:

[FFmpeg-devel] [PATCH 08/14] aarch64: vp9itxfm16: Avoid .irp when it doesn't save any lines

2017-03-16 Thread Martin Storsjö
This makes the code a bit more readable. --- libavcodec/aarch64/vp9itxfm_16bpp_neon.S | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_16bpp_neon.S b/libavcodec/aarch64/vp9itxfm_16bpp_neon.S index f80604f..86ea29e 100644

[FFmpeg-devel] [PATCH 03/14] arm/aarch64: vp9: Fix vertical alignment

2017-03-16 Thread Martin Storsjö
Align the second/third operands as they usually are. Due to the wildly varying sizes of the written out operands in aarch64 assembly, the column alignment is usually not as clear as in arm assembly. This is cherrypicked from libav commit 7995ebfad12002033c73feed422a1cfc62081e8f. ---

[FFmpeg-devel] [PATCH 09/14] aarch64: vp9itxfm16: Restructure the idct32 store macros

2017-03-16 Thread Martin Storsjö
This avoids concatenation, which can't be used if the whole macro is wrapped within another macro. --- libavcodec/aarch64/vp9itxfm_16bpp_neon.S | 90 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_16bpp_neon.S

[FFmpeg-devel] [PATCH 12/14] aarch64: vp9itxfm16: Move the load_add_store macro out from the itxfm16 pass2 function

2017-03-16 Thread Martin Storsjö
This allows reusing the macro for a separate implementation of the pass2 function. --- libavcodec/aarch64/vp9itxfm_16bpp_neon.S | 98 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_16bpp_neon.S

[FFmpeg-devel] [PATCH 06/14] arm: vp9itxfm16: Avoid reloading the idct32 coefficients

2017-03-16 Thread Martin Storsjö
Keep the idct32 coefficients in narrow form in q6-q7, and idct16 coefficients in lengthened 32 bit form in q0-q3. Avoid clobbering q0-q3 in the pass1 function, and squeeze the idct16 coefficients into q0-q1 in the pass2 function to avoid reloading them. The idct16 coefficients are clobbered and

[FFmpeg-devel] [PATCH 02/14] arm/aarch64: vp9itxfm: Skip loading the min_eob pointer when it won't be used

2017-03-16 Thread Martin Storsjö
In the half/quarter cases where we don't use the min_eob array, defer loading the pointer until we know it will be needed. This is cherrypicked from libav commit 3a0d5e206d24d41d87a25ba16a79b2ea04c39d4c. --- libavcodec/aarch64/vp9itxfm_neon.S | 3 ++- libavcodec/arm/vp9itxfm_neon.S | 4 ++--

[FFmpeg-devel] [PATCH 05/14] arm: vp9itxfm16: Fix vertical alignment

2017-03-16 Thread Martin Storsjö
--- libavcodec/arm/vp9itxfm_16bpp_neon.S | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/arm/vp9itxfm_16bpp_neon.S b/libavcodec/arm/vp9itxfm_16bpp_neon.S index a92f323..9c02ed9 100644 --- a/libavcodec/arm/vp9itxfm_16bpp_neon.S +++

[FFmpeg-devel] [PATCH 07/14] aarch64: vp9itxfm16: Fix a typo in a comment

2017-03-16 Thread Martin Storsjö
--- libavcodec/aarch64/vp9itxfm_16bpp_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/vp9itxfm_16bpp_neon.S b/libavcodec/aarch64/vp9itxfm_16bpp_neon.S index f53e94a..f80604f 100644 --- a/libavcodec/aarch64/vp9itxfm_16bpp_neon.S +++

[FFmpeg-devel] [PATCH 13/14] arm: vp9itxfm16: Do a simpler half/quarter idct16/idct32 when possible

2017-03-16 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This avoids loading and calculating coefficients that we know will be zero, and avoids filling the temp buffer with zeros in places where we know the second pass won't read. This gives a pretty substantial speedup for the smaller subpartitions.

[FFmpeg-devel] [PATCH 01/14] arm: vp9itxfm: Template the quarter/half idct32 function

2017-03-16 Thread Martin Storsjö
This reduces the number of lines and reduces the duplication. Also simplify the eob check for the half case. If we are in the half case, we know we at least will need to do the first three slices, we only need to check eob for the fourth one, so we can hardcode the value to check against instead

[FFmpeg-devel] [PATCH 04/14] arm: vp9itxfm16: Use the right lane size

2017-03-16 Thread Martin Storsjö
This makes the code slightly clearer, but doesn't make any functional difference. --- libavcodec/arm/vp9itxfm_16bpp_neon.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/arm/vp9itxfm_16bpp_neon.S b/libavcodec/arm/vp9itxfm_16bpp_neon.S index e6e9440..a92f323

Re: [FFmpeg-devel] [PATCH 1/3] decklink: add fourCC of display mode to list_format output

2017-03-16 Thread Marton Balint
On Thu, 16 Mar 2017, Matthias Hunstock wrote: Am 16.03.2017 um 20:55 schrieb Marton Balint: On Thu, 16 Mar 2017, Matthias Hunstock wrote: --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_common.cpp

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Carl Eugen Hoyos
2017-03-16 21:54 GMT+01:00 Marton Balint : > > On Thu, 16 Mar 2017, Nicolas George wrote: > >> Le sextidi 26 ventôse, an CCXXV, Matthias Hunstock a écrit : >>> >>> I did not find a comparable option for another device in libavdevice, >>> "format" was the initial suggestion of

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Marton Balint
On Thu, 16 Mar 2017, Matthias Hunstock wrote: --- libavdevice/decklink_common.cpp | 22 ++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 2 +- libavdevice/decklink_dec_c.c| 1 + 4 files changed, 21 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH]lavc/avcodec: Constify AVBitStreamFilter* in AVBitStreamFilterContext struct.

2017-03-16 Thread Carl Eugen Hoyos
Hi! Attached patch fixes one of two remaining warnings when compiling bitstream_filter.c. Please comment, Carl Eugen From 7fb60d42ee2137d1181ad0f6e214df87ed06400e Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 16 Mar 2017 22:31:44 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 1/3] decklink: add fourCC of display mode to list_format output

2017-03-16 Thread Matthias Hunstock
Am 16.03.2017 um 20:55 schrieb Marton Balint: > > > On Thu, 16 Mar 2017, Matthias Hunstock wrote: > >> --- >> libavdevice/decklink_common.cpp | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/libavdevice/decklink_common.cpp >>

Re: [FFmpeg-devel] [PATCH]lavc/bitstream_filter: Make a cast explicit

2017-03-16 Thread Carl Eugen Hoyos
2017-03-01 23:36 GMT+01:00 Carl Eugen Hoyos : > Hi! > > Attached patch silences one of three warnings when compiling > bitstream_filter.o, I suspect this cast is necessary. Ping. This seems to be another patch that does not show up on patchwork.ffmpeg.org (or that I cannot find

Re: [FFmpeg-devel] [FFmpeg-cvslog] Implement optimal huffman encoding for (M)JPEG.

2017-03-16 Thread James Almer
> ffmpeg | branch: master | Jerry Jiang | Wed Feb > 1 23:23:04 2017 -0800| [884506dfe2e29a5b2bd2905ca4f17e277e32acb1] | > committer: Rostislav Pehlivanov > > Implement optimal huffman encoding for (M)JPEG. > > > seems to break > > make fate-vsynth1-mjpeg-444 > > Fixed. > > >

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Carl Eugen Hoyos
2017-03-16 22:12 GMT+01:00 Vittorio Giovara : > On Thu, Mar 16, 2017 at 4:16 PM, Lou Logan wrote: >> On Wed, 15 Mar 2017 10:22:23 +0100 >> Carl Eugen Hoyos wrote: >> >>> Sorry if I miss something but could you clarify who the author

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Vittorio Giovara
On Thu, Mar 16, 2017 at 4:16 PM, Lou Logan wrote: > On Wed, 15 Mar 2017 10:22:23 +0100 > Carl Eugen Hoyos wrote: > >> Sorry if I miss something but could you clarify who the author of this >> patch is? > > CC'ing as Vittorio is not subscribed to the mailing

Re: [FFmpeg-devel] [PATCH]lavu/spherical: Make first parameter const

2017-03-16 Thread Vittorio Giovara
On Thu, Mar 16, 2017 at 4:26 PM, James Almer wrote: > On 3/16/2017 5:23 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch silences a gcc warning when compiling ffprobe. >> >> Please comment, Carl Eugen >> >> >>

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Nicolas George
Le sextidi 26 ventôse, an CCXXV, Marton Balint a écrit : > It selects video standard, field order and frame rate, these fourcc-s are > defined in the BlackMagic SDK. Example: 'Hp50' - HD 1080p50 format. Then "format_code", "standard_code", "standard_id", etc. > The argument you made is true for

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-16 Thread Mateusz Brzostek
W dniu 2017-03-16 o 19:17, Michael Niedermayer pisze: > On Wed, Mar 15, 2017 at 10:52:29PM +0100, Mateusz Brzostek wrote: >> Hello! >> >> There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: >> 1) there is overflow in dithering from 12-bit to 10-bit (output value > >>

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Marton Balint
On Thu, 16 Mar 2017, Nicolas George wrote: Le sextidi 26 ventôse, an CCXXV, Matthias Hunstock a écrit : I did not find a comparable option for another device in libavdevice, "format" was the initial suggestion of Marton. This is at least consistent with the existing "list_formats" option. I

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread wm4
On Thu, 16 Mar 2017 21:01:04 +0100 Michael Niedermayer wrote: > On Thu, Mar 16, 2017 at 05:20:51AM +0100, wm4 wrote: > > This patch deprecates anything that has to do with merging/splitting > > side data. Automatic side data merging (and splitting), as well as all > > API

Re: [FFmpeg-devel] [PATCH]lavu/spherical: Make first parameter const

2017-03-16 Thread James Almer
On 3/16/2017 5:23 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences a gcc warning when compiling ffprobe. > > Please comment, Carl Eugen > > > 0001-lavu-spherical-Make-AVSphericalMapping-pointer-param.patch > > > From 5040ee6f7dd43c8d66a241aa0376839916cd3d9f Mon Sep 17 00:00:00

[FFmpeg-devel] [PATCH]lavu/spherical: Make first parameter const

2017-03-16 Thread Carl Eugen Hoyos
Hi! Attached patch silences a gcc warning when compiling ffprobe. Please comment, Carl Eugen From 5040ee6f7dd43c8d66a241aa0376839916cd3d9f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 16 Mar 2017 21:19:48 +0100 Subject: [PATCH] lavu/spherical: Make

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread Nicolas George
Le sextidi 26 ventôse, an CCXXV, Michael Niedermayer a écrit : > Applications which depend on the current default would need ... to implement a correct structure to carry the data from their demuxer to the lavc decoders. Regards, -- Nicolas George signature.asc Description: Digital

Re: [FFmpeg-devel] [PATCH]lavc/internal: Constify AVPacket* in AVCodecInternal.

2017-03-16 Thread Carl Eugen Hoyos
2017-03-01 13:04 GMT+01:00 Michael Niedermayer : > On Sun, Feb 26, 2017 at 12:38:14PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes another warning when compiling libavcodec/utils.o. >> >> Please comment, Carl Eugen > > if it doesnt produce any new

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Lou Logan
On Wed, 15 Mar 2017 10:22:23 +0100 Carl Eugen Hoyos wrote: > Sorry if I miss something but could you clarify who the author of this > patch is? CC'ing as Vittorio is not subscribed to the mailing list. Not that you should have to know that as there was no CC request in this

Re: [FFmpeg-devel] [PATCH]lavc/avpacket: Make pkt parameter of av_packet_get_side_data() const

2017-03-16 Thread Carl Eugen Hoyos
2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos : > Anyway, new patch attached. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread Michael Niedermayer
On Thu, Mar 16, 2017 at 05:20:51AM +0100, wm4 wrote: > This patch deprecates anything that has to do with merging/splitting > side data. Automatic side data merging (and splitting), as well as all > API symbols involved in it, are removed completely. > > Two FF_API_ defines are dedicated to

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-16 Thread Carl Eugen Hoyos
2017-03-10 6:26 GMT+01:00 Wang Bin : [...] Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] decklink: add fourCC of display mode to list_format output

2017-03-16 Thread Marton Balint
On Thu, 16 Mar 2017, Matthias Hunstock wrote: --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index 8b499c5..131d186 100644 ---

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Carl Eugen Hoyos
2017-03-16 20:18 GMT+01:00 Vittorio Giovara : >> LGTM otherwise. >> > > Ok thank you > > The "other side" will apply this as well at the same time this is committed. Don't forget to fix the patch author! Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: clarify pcr_period unit of measurement

2017-03-16 Thread Lou Logan
On Wed, 15 Mar 2017 18:47:31 -0800 Lou Logan wrote: > pcr_period is in milliseconds. > > Signed-off-by: Lou Logan > --- > libavformat/mpegtsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pushed. ___

Re: [FFmpeg-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Vittorio Giovara
On Wed, Mar 15, 2017 at 11:31 PM, James Almer wrote: > On 3/15/2017 6:39 PM, Vittorio Giovara wrote: >> These values are defined to be 32bit in the specification, >> so it makes more sense to store them as fixed width. >> >> Signed-off-by: Vittorio Giovara

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'

2017-03-16 Thread Kieran Kunhya
On Thu, 16 Mar 2017 at 15:37 Michael Niedermayer wrote: > On Thu, Mar 16, 2017 at 11:41:12AM +, Kieran Kunhya wrote: > > > > > > + > > > +if (pocdiff0 != (int)pocdiff0) > > > +avpriv_request_sample(sl->h264->avctx, "pocdiff0 > overflow\n"); > > > +

Re: [FFmpeg-devel] [PATCH 3/4] lavfi: deprecate AVFilterGraph->resample_lavr_opts

2017-03-16 Thread wm4
On Mon, 6 Mar 2017 02:46:50 + Rostislav Pehlivanov wrote: > Not used by anything at all since we don't auto insert lavr filters. > > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges | 4 > libavfilter/avfilter.h |

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Nicolas George
Le sextidi 26 ventôse, an CCXXV, Matthias Hunstock a écrit : > I did not find a comparable option for another device in libavdevice, > "format" was the initial suggestion of Marton. This is at least > consistent with the existing "list_formats" option. I do not know what the option does, and

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

2017-03-16 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 10:52:29PM +0100, Mateusz Brzostek wrote: > Hello! > > There are 3 problems with DITHER_COPY macro in libswscale/swscale_unscaled.c: > 1) there is overflow in dithering from 12-bit to 10-bit (output value > 1023); > 2) for limit range the lower limit is not respected, for

Re: [FFmpeg-devel] [PATCH] swresample/swresample: do not use s32p internally by default when resampling

2017-03-16 Thread wm4
On Thu, 16 Mar 2017 17:00:17 +0700 Muhammad Faiz wrote: > On Thu, Mar 16, 2017 at 1:01 PM, wm4 wrote: > > On Thu, 16 Mar 2017 12:43:10 +0700 > > Muhammad Faiz wrote: > > > >> use fltp when doing s32 -> s32 resampling > >> because

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: clarify pcr_period unit of measurement

2017-03-16 Thread Michael Niedermayer
On Thu, Mar 16, 2017 at 08:56:54AM -0800, Lou Logan wrote: > On Thu, 16 Mar 2017 16:39:18 +0100 > Michael Niedermayer wrote: > > > i suggested it in the past already, but all time and duration values > > should be changed to use seconds. It would be much cleaner,

Re: [FFmpeg-devel] [PATCH v2] swresample/options: enable linear_interp and exact_rational by default

2017-03-16 Thread Muhammad Faiz
On Thu, Mar 16, 2017 at 12:05 AM, Muhammad Faiz wrote: > On Mon, Mar 13, 2017 at 8:40 PM, Muhammad Faiz wrote: >> better quality without speedloss >> >> Signed-off-by: Muhammad Faiz >> --- >> doc/resampler.texi | 5 +- >>

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: clarify pcr_period unit of measurement

2017-03-16 Thread Lou Logan
On Thu, 16 Mar 2017 16:39:18 +0100 Michael Niedermayer wrote: > i suggested it in the past already, but all time and duration values > should be changed to use seconds. It would be much cleaner, consistent > and less confusing. Agreed, but this minor commit can be

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-16 Thread Moritz Barsnick
On Wed, Mar 15, 2017 at 16:29:22 -0300, James Almer wrote: > Afaik, old flv videos used VP6 (libavcodec reports them as vp6f). There > are some real world files out there, like video game trailers. > I have a Diablo 3 and a Starcraft 2 trailers encoded in VP6 here if you'd > like to check them.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread wm4
On Thu, 16 Mar 2017 11:07:44 -0300 James Almer wrote: > On 3/16/2017 1:20 AM, wm4 wrote: > > This patch deprecates anything that has to do with merging/splitting > > side data. Automatic side data merging (and splitting), as well as all > > API symbols involved in it, are

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'

2017-03-16 Thread Michael Niedermayer
On Thu, Mar 16, 2017 at 11:41:12AM +, Kieran Kunhya wrote: > > > > + > > +if (pocdiff0 != (int)pocdiff0) > > +avpriv_request_sample(sl->h264->avctx, "pocdiff0 overflow\n"); > > + > > > > Do you think this condition will actually happen in the real world apart > from in

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Matthias Hunstock
Am 16.03.2017 um 15:40 schrieb Nicolas George: > I would advise to use a name much more specific than "format". I did not find a comparable option for another device in libavdevice, "format" was the initial suggestion of Marton. This is at least consistent with the existing "list_formats" option.

Re: [FFmpeg-devel] Refund request for travelling costs to Chemnitz

2017-03-16 Thread Stefano Sabatini
On date Tuesday 2017-03-14 22:15:11 +0100, Thilo Borgmann encoded: > Hi, > > > Alexander Strasser, Thilo Borgmann, Thomas Volkert and myself > > represented FFmpeg at the Chemnitzer Linuxtage 2017. We showed > > different filters in action on video screens, talked to guests and > > other projects

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264idct_template: fix multiple runtime error: signed integer overflow

2017-03-16 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 04:12:50AM +0100, Michael Niedermayer wrote: > Fixes: 857/clusterfuzz-testcase-5319093760557056 > > Benchmark changes from 335->333 (so if its not a random fluctuation then it > would be faster) > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_cabac: Fix runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself

2017-03-16 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 04:12:51AM +0100, Michael Niedermayer wrote: > Fixes: 858/clusterfuzz-testcase-5168477042114560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Nicolas George
Le sextidi 26 ventôse, an CCXXV, Matthias Hunstock a écrit : > --- > libavdevice/decklink_common.cpp | 22 ++ > libavdevice/decklink_common_c.h | 1 + > libavdevice/decklink_dec.cpp| 2 +- > libavdevice/decklink_dec_c.c| 1 + > 4 files changed, 21 insertions(+), 5

Re: [FFmpeg-devel] Refund request for Customs fees of donations

2017-03-16 Thread Stefano Sabatini
On date Thursday 2017-02-23 20:35:21 +0100, Thilo Borgmann encoded: > Hi, > > in the aftermath of ELCE 2016 we recieved a donation of 5 displays from a > company. These went to Michael Niedermayer, Carl Eugen Hoyos, Ronald Bultje, > Clement Boesch and myself. > > Unfortunately, due to lack of

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread James Almer
On 3/16/2017 1:20 AM, wm4 wrote: > This patch deprecates anything that has to do with merging/splitting > side data. Automatic side data merging (and splitting), as well as all > API symbols involved in it, are removed completely. > > Two FF_API_ defines are dedicated to deprecating API symbols

[FFmpeg-devel] [PATCH 3/3] Documentation: update decklink options

2017-03-16 Thread Matthias Hunstock
--- doc/indevs.texi | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 54f270b..92804cd 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -233,6 +233,12 @@ Defaults to @option{false}. If set to @option{true}, print a

[FFmpeg-devel] [PATCH 0/3] decklink: new option -format to specify video modes with constant fourCCs

2017-03-16 Thread Matthias Hunstock
This patch series introduces a new option for the decklink devices. Currently, a video mode can be explicitly set via -i "devicename@modenumber", which is a common need for capture and sometimes for playout. The current number based modes are not constant between different cards and sometimes

[FFmpeg-devel] [PATCH 1/3] decklink: add fourCC of display mode to list_format output

2017-03-16 Thread Matthias Hunstock
--- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index 8b499c5..131d186 100644 --- a/libavdevice/decklink_common.cpp +++ b/libavdevice/decklink_common.cpp @@ -276,6

[FFmpeg-devel] [PATCH 2/3] decklink: new option 'format' to set video format by fourCC

2017-03-16 Thread Matthias Hunstock
--- libavdevice/decklink_common.cpp | 22 ++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 2 +- libavdevice/decklink_dec_c.c| 1 + 4 files changed, 21 insertions(+), 5 deletions(-) diff --git a/libavdevice/decklink_common.cpp

Re: [FFmpeg-devel] [PATCH v3 1/2] codec: bitpacked: add decoder

2017-03-16 Thread Damien Riegel
On Tue, Feb 28, 2017 at 11:10:23PM +0100, Michael Niedermayer wrote: > On Tue, Feb 28, 2017 at 01:39:07PM -0500, Damien Riegel wrote: > > Add a codec capable of decoding some formats of the RFC4175. For now > > it's only capable of handling YCbCr-4:2:2 with 8-bit or 10-bit depth. > > > > For

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-16 Thread Rostislav Pehlivanov
On 16 March 2017 at 04:20, wm4 wrote: > This patch deprecates anything that has to do with merging/splitting > side data. Automatic side data merging (and splitting), as well as all > API symbols involved in it, are removed completely. > > Two FF_API_ defines are dedicated

[FFmpeg-devel] [PATCH v2] avformat/rtmpproto: change rtmp_open from url_open to url_open2

2017-03-16 Thread Steven Liu
use the option set by user Reported-by: Lancelot Lai Signed-off-by: Steven Liu --- libavformat/rtmpproto.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 5d7ad79..bbafa77

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_direct: Fix runtime error: signed integer overflow: -9 - 2147483647 cannot be represented in type 'int'

2017-03-16 Thread Kieran Kunhya
> > + > +if (pocdiff0 != (int)pocdiff0) > +avpriv_request_sample(sl->h264->avctx, "pocdiff0 overflow\n"); > + > Do you think this condition will actually happen in the real world apart from in glitchy live streams? Kieran ___

Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg

2017-03-16 Thread Saverio Blasi
Dear Mark, Sorry for the long delay in replying. We have now pushed some changes to our main Turing codec repository to address your comments below. Our custom boost libraries should now be correctly installed so there is no need for preserving any additional Turing build folder. These changes

[FFmpeg-devel] [PATCH] avcodec/vp56: Check avctx->error_concealment before enabling EC

2017-03-16 Thread Michael Niedermayer
Fixes timeout with 847/clusterfuzz-testcase-5291877358108672 Fixes timeout with 850/clusterfuzz-testcase-5721296509861888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH] avformat/rtmpproto: change rtmp_open from url_open to url_open2

2017-03-16 Thread Steven Liu
use the option set by user Reported-by: Lancelot Lai Signed-off-by: Steven Liu --- libavformat/rtmpproto.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 5d7ad79..e1fb16f

Re: [FFmpeg-devel] lavc/aarch64: add simple idct neon functions

2017-03-16 Thread Matthieu Bouron
On Wed, Mar 15, 2017 at 01:14:42PM +0100, Matthieu Bouron wrote: > On Mon, Mar 06, 2017 at 03:48:57PM +0100, Matthieu Bouron wrote: > > On Thu, Feb 23, 2017 at 04:59:16PM +0100, Matthieu Bouron wrote: > > > Hello, > > > > > > The following patchset add the ff_simple_idct function neon functions

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp56: Require 1 undamaged frame for 5 damaged frames for concealment to be used

2017-03-16 Thread Michael Niedermayer
On Wed, Mar 15, 2017 at 08:44:25PM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 15, 2017 at 6:12 PM, Michael Niedermayer > wrote: > > > On Wed, Mar 15, 2017 at 07:18:30PM +, Kieran Kunhya wrote: > > > > > > > > > > I have tons of testcases for h264 that are

Re: [FFmpeg-devel] [PATCH] swresample/swresample: do not use s32p internally by default when resampling

2017-03-16 Thread Muhammad Faiz
On Thu, Mar 16, 2017 at 1:01 PM, wm4 wrote: > On Thu, 16 Mar 2017 12:43:10 +0700 > Muhammad Faiz wrote: > >> use fltp when doing s32 -> s32 resampling >> because s32p has no simd optimization >> >> benchmark: >> old 17.913s >> new 7.584s (use fma3) >> >>

Re: [FFmpeg-devel] [PATCH 3/4] lavfi: deprecate AVFilterGraph->resample_lavr_opts

2017-03-16 Thread Rostislav Pehlivanov
On 6 March 2017 at 02:46, Rostislav Pehlivanov wrote: > Not used by anything at all since we don't auto insert lavr filters. > > > Ping, I'll push this tomorrow if there are no objections. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/4] ffmpeg: don't use resample_lavr_opts

2017-03-16 Thread Rostislav Pehlivanov
On 6 March 2017 at 17:51, Michael Niedermayer wrote: > On Mon, Mar 06, 2017 at 02:46:49AM +, Rostislav Pehlivanov wrote: > > That pointer isn't used by absolutely anything. > > > > Signed-off-by: Rostislav Pehlivanov > > --- > > ffmpeg_filter.c

Re: [FFmpeg-devel] [PATCH 4/4] lavfi: remove af_asynts filter

2017-03-16 Thread Rostislav Pehlivanov
On 6 March 2017 at 20:47, Marton Balint wrote: > > On Mon, 6 Mar 2017, Rostislav Pehlivanov wrote: > > Long overdue for removal, af_aresample should be used instead. >> >> Signed-off-by: Rostislav Pehlivanov >> --- >> Changelog | 1 + >>

Re: [FFmpeg-devel] [PATCH] swresample/swresample: do not use s32p internally by default when resampling

2017-03-16 Thread wm4
On Thu, 16 Mar 2017 12:43:10 +0700 Muhammad Faiz wrote: > use fltp when doing s32 -> s32 resampling > because s32p has no simd optimization > > benchmark: > old 17.913s > new 7.584s (use fma3) > > Signed-off-by: Muhammad Faiz > --- >