[FFmpeg-devel] [PATCH 2/2] lavc: vdpau: add support for new hw_frames_ctx and hw_device_ctx API

2017-03-21 Thread wm4
This supports retrieving the device from a provided hw_frames_ctx, and automatically creating a hw_frames_ctx if hw_device_ctx is set. The old API is not deprecated yet. The user can still use av_vdpau_bind_context() (with or without setting hw_frames_ctx), or use the API before that by allocating

[FFmpeg-devel] [PATCH 1/2] lavc: Add hwaccel_flags field to AVCodecContext

2017-03-21 Thread wm4
This "reuses" the flags introduced for the av_vdpau_bind_context() API function, and makes them available to all hwaccels. This does not affect the current vdpau API, as av_vdpau_bind_context() should obviously override the AVCodecContext.hwaccel_flags flags for the sake of compatibility. --- Libav

Re: [FFmpeg-devel] [PATCH 1/4] Place attribute_deprecated in the right position for struct declarations

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 22:43:55 + Mark Thompson wrote: > ... Patches 1-4 trivially LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-21 Thread Dzung Hoang
Sorry about the bad format for the patch. Here's another try. --- libavcodec/exr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 034920f..265d44d 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1640,6 +1640,9 @@ sta

Re: [FFmpeg-devel] [PATCH] avcodec/exr detect invalid line offset table and recreate table

2017-03-21 Thread Dzung Hoang
Thanks Martin for your comments. I made the requested changes here. --- libavcodec/exr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/exr.c b/libavcodec/exr.cindex 034920f..265d44d 100644--- a/libavcodec/exr.c+++ b/libavcodec/exr.c@@ -1640,6 +1640,9 @@ static

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: fix duration

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 11:25:21PM +, Thomas Mundt wrote: > Hi, > > attached patch will fix ticket #2674. > It makes the fps filter duplicate or drop the last frame depending on the > input and output frame rates. > Tested with examples from ticket 2674 and other files at various frame rates.

Re: [FFmpeg-devel] [PATCH] examples/vaapi_dec: Add a VA-API hwaccel decoding example

2017-03-21 Thread Jun Zhao
On 2017/3/21 12:57, wm4 wrote: > On Tue, 21 Mar 2017 12:45:26 +0800 > Jun Zhao wrote: > >> From 6b56c541ed7dd271ad0aa6eb6412a8427f009525 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 21 Mar 2017 11:04:41 +0800 >> Subject: [PATCH] examples/vaapi_dec: Add a VA-API hwaccel decoding exa

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_ps: Fix runtime error: signed integer overflow: 2147483647 + 26 cannot be represented in type 'int'

2017-03-21 Thread Michael Niedermayer
Fixes: 902/clusterfuzz-testcase-4561155144024064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264_ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264

[FFmpeg-devel] [PATCH 2/2] avcodec/h264: Check weight values to be within the specs limits.

2017-03-21 Thread Michael Niedermayer
Fixes: integer overflows Fixes: 911/clusterfuzz-testcase-5415105606975488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264_parse.c | 9 + libavcodec/h264_slice.c | 7 +-- 2 files

Re: [FFmpeg-devel] [PATCH 2/2 v3] decklink: new option 'format_code' to set video format by fourCC

2017-03-21 Thread Marton Balint
On Mon, 20 Mar 2017, Matthias Hunstock wrote: Signed-off-by: Matthias Hunstock --- doc/indevs.texi | 14 ++ libavdevice/decklink_common.cpp | 17 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 5 +++-- libavdevice/decklink_de

Re: [FFmpeg-devel] [PATCH 1/2 v3] decklink: add format_code of display mode to list_format output

2017-03-21 Thread Marton Balint
On Mon, 20 Mar 2017, Matthias Hunstock wrote: Signed-off-by: Matthias Hunstock --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Thanks, applied. Regards, Marton ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH V2] hwcontext: fix comments for av_hwdevice_ctx_alloc()

2017-03-21 Thread Mark Thompson
On 22/03/17 00:41, Jun Zhao wrote: > From d4f6c6c0412b817b1c278468c9a036233159d15e Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Sun, 19 Mar 2017 15:44:46 +0800 > Subject: [PATCH V2] hwcontext: fix comments for av_hwdevice_ctx_alloc() > > fix the wrong comments for av_hwdevice_ctx_alloc() >

Re: [FFmpeg-devel] [PATCH] hwcontext: fix comments for av_hwdevice_ctx_alloc()

2017-03-21 Thread Jun Zhao
On 2017/3/21 7:59, Mark Thompson wrote: > On 19/03/17 07:53, Jun Zhao wrote: >> From 74fa715cdc1e17ab3a59a9e3efa6ef142dd35d1a Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Sun, 19 Mar 2017 15:44:46 +0800 >> Subject: [PATCH] hwcontext: fix comments for av_hwdevice_ctx_alloc() >> >> fix the

[FFmpeg-devel] [PATCH V2] hwcontext: fix comments for av_hwdevice_ctx_alloc()

2017-03-21 Thread Jun Zhao
From d4f6c6c0412b817b1c278468c9a036233159d15e Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sun, 19 Mar 2017 15:44:46 +0800 Subject: [PATCH V2] hwcontext: fix comments for av_hwdevice_ctx_alloc() fix the wrong comments for av_hwdevice_ctx_alloc() Signed-off-by: Jun Zhao --- libavutil/hwcontext

[FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm

[FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
Test Reply mail use git send-email ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec.h: clarify decoupled decode/encode API docs

2017-03-21 Thread Marton Balint
On Wed, 15 Mar 2017, wm4 wrote: On Wed, 15 Mar 2017 03:47:56 +0100 Marton Balint wrote: Signed-off-by: Marton Balint --- libavcodec/avcodec.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index e32f579..8d3d06e 100644

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Ricardo Constantino
On 21 March 2017 at 22:50, Steven Liu wrote: > I don't know how to replay to an old thread with the patch by git > send-email :( > > Find the email you want to reply to in http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/thread.html and check the link in the address. It should contain th

[FFmpeg-devel] [PATCH] avfilter/vf_fps: fix duration

2017-03-21 Thread Thomas Mundt
Hi, attached patch will fix ticket #2674. It makes the fps filter duplicate or drop the last frame depending on the input and output frame rates. Tested with examples from ticket 2674 and other files at various frame rates. Regards, Thomas 0001-avfilter-vf_fps-fix-duration.patch Description: Bi

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
2017-03-22 7:23 GMT+08:00 Steven Liu : > v2 fixed: > 1. from autodetect to disabled > 2. from camelCase code style to ffmpeg code style > 3. from RepType to AVMediaType > 4. fix variable typo > 5. change time value from uint32_t to uint64_t > 6. removed be used once API > 7. change 'time(NULL)`, e

[FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
Ricardo Constantino 于2017年3月22日 周三上午12:27写道: > On 2017-03-21 13:16, Steven Liu wrote: > > @@ -5920,6 +5923,7 @@ enabled openssl && { use_pkg_config > openssl openssl/ssl.h OPENSSL_init > > check_lib openssl/ssl.h SSL_library_init > -lssl -lcrypto -lws2_32

[FFmpeg-devel] [PATCH 4/4] vaapi_vp9: Mark as async-safe

2017-03-21 Thread Mark Thompson
--- This was missed in e0cd598bc4684654d63942e9ff4872c0b48a7dc2 because it isn't in libav. libavcodec/vaapi_vp9.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c index a656ffb13c..7374465d49 100644 --- a/libavcodec/vaapi_vp9.c +++ b/libavco

[FFmpeg-devel] [PATCH 2/4] vaapi: Implement device-only setup

2017-03-21 Thread Mark Thompson
In this case, the user only supplies a device and the frame context is allocated internally by lavc. (cherry picked from commit 5dd9a4b88b287bf8c93520afda7becb1ad0d1894) --- This doesn't work with ffmpeg.c yet (still uses hw_frames_ctx), but is accessible to lavc users. See

[FFmpeg-devel] [PATCH 1/4] Place attribute_deprecated in the right position for struct declarations

2017-03-21 Thread Mark Thompson
From: Diego Biurrun libavcodec/vaapi.h:58:1: warning: attribute 'deprecated' is ignored, place it after "struct" to apply attribute to type declaration [-Wignored-attributes] (cherry picked from commit ed6a891c364f8b0850b557d9578b8920cc15a937) Signed-off-by: Mark Thompson --- libavcodec/vaapi

[FFmpeg-devel] [PATCH 3/4] vaapi_hevc: Mark as async-safe

2017-03-21 Thread Mark Thompson
--- This was missed in e0cd598bc4684654d63942e9ff4872c0b48a7dc2 because it wasn't in libav at the time. libavcodec/vaapi_hevc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c index 2b0e8ff326..34d32795b7 100644 --- a/libavcodec/vaapi_hevc

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread James Almer
On 3/21/2017 12:47 PM, Michael Niedermayer wrote: > On Tue, Mar 21, 2017 at 12:08:03PM -0300, James Almer wrote: >> On 3/21/2017 11:05 AM, Michael Niedermayer wrote: >>> On Tue, Mar 21, 2017 at 10:03:48AM -0300, James Almer wrote: On 3/21/2017 9:52 AM, Michael Niedermayer wrote: > On Mon,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/apng: fix setting frame delay when max_fps is set to no limit

2017-03-21 Thread James Almer
On 3/21/2017 9:45 AM, Michael Niedermayer wrote: > On Mon, Mar 20, 2017 at 11:03:22PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/apngdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM > thx Pushed.

Re: [FFmpeg-devel] [PATCH] avutil/x86inc: don't use movss in VBROADCASTSS macro when src and dst args are the same

2017-03-21 Thread James Almer
On 3/21/2017 12:06 PM, Henrik Gramner wrote: > x86util, not x86inc. Otherwise LGTM. Fixed and pushed. Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Hardware decoding buffer size

2017-03-21 Thread Steve Lhomme
Hi, We have this bug in VLC with an MPEG2 file that decodes with green bars at the top. After investigation it's because we allocate a 1920x1080 texture when it should actually need 1920x1088. https://trac.videolan.org/vlc/ticket/17856 In software decoding it works because we adjust the `ctx->cod

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegaudiodec_template: Fix 2 runtime error: signed integer overflow

2017-03-21 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 02:21:49AM +0100, Michael Niedermayer wrote: > Fixes: 873/clusterfuzz-testcase-5714546230558720 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegaudiodec_t

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

2017-03-21 Thread Paul B Mahol
On 3/21/17, Michael Niedermayer wrote: > On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote: >> Fixes #6214. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/dnxhd_parser.c | 65 >> ++- >> 1 file changed, 58 insertions(+), 7 deletions(-

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

2017-03-21 Thread Mark Reid
On Tue, Mar 21, 2017 at 11:02 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote: > > Fixes #6214. > > > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/dnxhd_parser.c | 65 ++ >

Re: [FFmpeg-devel] [PATCH] libavcodec/dnxhd: add support more dnxhr header prefixes

2017-03-21 Thread Mark Reid
On Tue, Mar 21, 2017 at 9:40 AM, Mark Reid wrote: > > > On Mon, Mar 20, 2017 at 12:48 PM, Paul B Mahol wrote: > >> On 7/12/16, Mark Reid wrote: >> > Hi, >> > The following patch adds support for detecting more dnxhr header >> prefixes. >> > >> > After generating many random resolution dnxhr fil

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote: > Fixes #6214. > > Signed-off-by: Paul B Mahol > --- > libavcodec/dnxhd_parser.c | 65 > ++- > 1 file changed, 58 insertions(+), 7 deletions(-) seems to change fate --- ./tests/ref/vsynth

Re: [FFmpeg-devel] [PATCH] lavc/mips: fix mpegvideo.h includes (UNTESTED)

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 03:24:37PM +0100, Clément Bœsch wrote: > --- > libavcodec/mips/blockdsp_mips.h| 3 ++- > libavcodec/mips/idctdsp_mips.h | 3 ++- > libavcodec/mips/me_cmp_mips.h | 2 +- > libavcodec/mips/pixblockdsp_mips.h | 3 ++- > libavcodec/mips/qpeldsp_mips.h | 3 ++- >

[FFmpeg-devel] [PATCH] Add A53 closed captions to mpeg picture header.

2017-03-21 Thread John P Poet
If AV_FRAME_DATA_A53_CC "user data" is available, encode it into the mpeg picture header. This follows the spec in section 6.2.3 of http://atsc.org/wp-content/uploads/2015/03/a_53-Part-4-2009.pdf I am working on gstreamer side, to inject the information into the ffmpeg side data, and have it gene

Re: [FFmpeg-devel] [PATCH] libavcodec/dnxhd: add support more dnxhr header prefixes

2017-03-21 Thread Mark Reid
On Mon, Mar 20, 2017 at 12:48 PM, Paul B Mahol wrote: > On 7/12/16, Mark Reid wrote: > > Hi, > > The following patch adds support for detecting more dnxhr header > prefixes. > > > > After generating many random resolution dnxhr files via quicktime, > > I have deduced that second 4 bytes in prefi

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Ricardo Constantino
On 2017-03-21 13:16, Steven Liu wrote: > @@ -5920,6 +5923,7 @@ enabled openssl && { use_pkg_config openssl > openssl/ssl.h OPENSSL_init > check_lib openssl/ssl.h SSL_library_init > -lssl -lcrypto -lws2_32 -lgdi32 || > die "

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 12:08:03PM -0300, James Almer wrote: > On 3/21/2017 11:05 AM, Michael Niedermayer wrote: > > On Tue, Mar 21, 2017 at 10:03:48AM -0300, James Almer wrote: > >> On 3/21/2017 9:52 AM, Michael Niedermayer wrote: > >>> On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH] avutil/x86inc: don't use movss in VBROADCASTSS macro when src and dst args are the same

2017-03-21 Thread Henrik Gramner
x86util, not x86inc. Otherwise LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread James Almer
On 3/21/2017 11:05 AM, Michael Niedermayer wrote: > On Tue, Mar 21, 2017 at 10:03:48AM -0300, James Almer wrote: >> On 3/21/2017 9:52 AM, Michael Niedermayer wrote: >>> On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote: Should fix ticket #6252 Signed-off-by: James Almer >>

Re: [FFmpeg-devel] [PATCH] swr/resample: free existing ResampleContext on reinit

2017-03-21 Thread James Almer
On 3/21/2017 11:39 AM, Michael Niedermayer wrote: > On Mon, Mar 20, 2017 at 10:33:53PM -0300, James Almer wrote: >> Fixes memleak (See opus-testvector12 fate test). >> >> Signed-off-by: James Almer >> --- >> libswresample/resample.c | 15 --- >> 1 file changed, 8 insertions(+), 7 dele

Re: [FFmpeg-devel] [PATCHv2 2/3] ffplay: convert to new decode API

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 07:34:32 -0700 Philip Langdale wrote: > On Mon, 20 Mar 2017 21:51:49 +0100 > Marton Balint wrote: > > > Since subtitles are not yet supported with the new API, > > CODEC_CAP_DELAY subtitle codecs (only libzvbi so far) may loose the > > last few buffered frames in the end of

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-21 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 06:43:50AM +0100, wm4 wrote: > On Sun, 19 Mar 2017 02:30:11 +0100 > Michael Niedermayer wrote: > > > On Sat, Mar 18, 2017 at 09:56:04AM +0100, wm4 wrote: > > > From: Anton Khirnov > > > > > > Certain hardware decoding APIs are not guaranteed to be thread-safe, so > > > h

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

2017-03-21 Thread Clément Bœsch
On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote: > Fixes #6214. > > Signed-off-by: Paul B Mahol > --- > libavcodec/dnxhd_parser.c | 65 > ++- > 1 file changed, 58 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dnxhd_parser.c b

[FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

2017-03-21 Thread Paul B Mahol
Fixes #6214. Signed-off-by: Paul B Mahol --- libavcodec/dnxhd_parser.c | 65 ++- 1 file changed, 58 insertions(+), 7 deletions(-) diff --git a/libavcodec/dnxhd_parser.c b/libavcodec/dnxhd_parser.c index 033b8ee..4f9bbce 100644 --- a/libavcodec/dnxhd_p

Re: [FFmpeg-devel] [PATCH] swr/resample: free existing ResampleContext on reinit

2017-03-21 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 10:33:53PM -0300, James Almer wrote: > Fixes memleak (See opus-testvector12 fate test). > > Signed-off-by: James Almer > --- > libswresample/resample.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) the move could be in a separete commit, if you

Re: [FFmpeg-devel] [PATCHv2 2/3] ffplay: convert to new decode API

2017-03-21 Thread Philip Langdale
On Mon, 20 Mar 2017 21:51:49 +0100 Marton Balint wrote: > Since subtitles are not yet supported with the new API, > CODEC_CAP_DELAY subtitle codecs (only libzvbi so far) may loose the > last few buffered frames in the end of the stream. > > The impact of this is so limited, it seemded better to

[FFmpeg-devel] [PATCH] lavc/mips: fix mpegvideo.h includes (UNTESTED)

2017-03-21 Thread Clément Bœsch
--- libavcodec/mips/blockdsp_mips.h| 3 ++- libavcodec/mips/idctdsp_mips.h | 3 ++- libavcodec/mips/me_cmp_mips.h | 2 +- libavcodec/mips/pixblockdsp_mips.h | 3 ++- libavcodec/mips/qpeldsp_mips.h | 3 ++- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/m

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 10:03:48AM -0300, James Almer wrote: > On 3/21/2017 9:52 AM, Michael Niedermayer wrote: > > On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote: > >> Should fix ticket #6252 > >> > >> Signed-off-by: James Almer > >> --- > >> libavformat/apngdec.c | 2 +- > >> 1 fil

Re: [FFmpeg-devel] [PATCH 1/2] avformat/apng: fix setting frame delay when max_fps is set to no limit

2017-03-21 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 11:03:22PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/apngdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequalit

[FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 14:09:49 +0100 Clément Bœsch wrote: > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > The old "API" that signaled rotation as a metadata value has been > > replaced by DISPLAYMATRIX side data quite a while ago. > > > > There is no reason to make muxers/demuxers/API u

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Clément Bœsch
On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata API is dangerous, as

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread James Almer
On 3/21/2017 9:52 AM, Michael Niedermayer wrote: > On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote: >> Should fix ticket #6252 >> >> Signed-off-by: James Almer >> --- >> libavformat/apngdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/apngd

Re: [FFmpeg-devel] [PATCH v5] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 08:32:59PM +0800, Steven Liu wrote: [...] > +static char *strreplace(const char *str, const char *from, const char *to) > +{ > +/* Adjust each of the below values to suit your needs. */ > +/* Increment positions cache size initially by this number. */ > +size_t

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-21 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote: > Should fix ticket #6252 > > Signed-off-by: James Almer > --- > libavformat/apngdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c > index 7a284e32c2..75dcf74a

[FFmpeg-devel] [PATCH v5] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Ronald S. Bultje
Hi, On Tue, Mar 21, 2017 at 3:45 AM, Carl Eugen Hoyos wrote: > 2017-03-21 8:42 GMT+01:00 wm4 : > > > There is no reason to make muxers/demuxers/API users support both. > > I don't understand this sentence: You mean having both APIs means > all users of FFmpeg have to support both APIs? Yes, of

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/interlace: change lowpass_line function

2017-03-21 Thread Thomas Mundt
>>Thomas Mundt schrieb am Mo, 13.3.2017: > Hi, > > this patch set > 1) changes the lowpass_line function prototype in vf_interlace and > vf_tinterlace as suggested by James Almer. > 2) adds a complex (-1 2 6 2 -1) vertical low-pass filter to vf_interlace and > vf_tinterlace. > This one slightly

Re: [FFmpeg-devel] [PATCH v4] avformat/dashdec: add dash demuxer base version

2017-03-21 Thread Ricardo Constantino
The 'mainifest' typos are still there. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-21 Thread Carl Eugen Hoyos
2017-03-17 13:45 GMT+01:00 wm4 : > Why do you hate your users (well those who need it) this much? Aren't you the one suggesting that we change API every year? You do realize that this is the only thing users don't want us to do? > Are you a monster? It is so good to know that you completely igno

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Carl Eugen Hoyos
2017-03-21 8:42 GMT+01:00 wm4 : > There is no reason to make muxers/demuxers/API users support both. I don't understand this sentence: You mean having both APIs means all users of FFmpeg have to support both APIs? Carl Eugen ___ ffmpeg-devel mailing li

[FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or