Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-26 Thread Steven Liu
2017-03-27 8:39 GMT+08:00 Rodger Combs : > > > On Mar 26, 2017, at 19:10, Steven Liu wrote: > > > > v2 fixed: > > 1. from autodetect to disabled > > 2. from camelCase code style to ffmpeg code style > > 3. from RepType to AVMediaType > > 4. fix variable typo > > 5. change time value from uint32_t

[FFmpeg-devel] [PATCH 1/2] avcodec/vorbis_enc_data: Include scalewidth band factors

2017-03-26 Thread Tyler Jones
Scale factors are copied from the AAC encoder tabulated data. Including the AAC tabulated header includes files that cause improper framing bits to be put in the header and an improper end of file. Providing this for the vorbis encoder is necessary to use the existing AAC psychoacoustic system. Win

[FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Implement transient detection in Vorbis encoder

2017-03-26 Thread Tyler Jones
The existing AAC psychoacoustic system is used to detect transients within the vorbis encoder. This is useful, in general, as an initial step in later utilizing a complex psychoacoustic model for the vorbis encoder, but more specifically allows the cacellation of pre-echo effects that frequently o

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 6:41 PM, Michael Niedermayer wrote: > On Sun, Mar 26, 2017 at 05:30:05PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Mar 26, 2017 at 3:31 PM, Michael Niedermayer > > > wrote: > > > > > On Sun, Mar 26, 2017 at 07:41:58PM +0200, wm4 wrote: > > > > On Sun, 26

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-26 Thread Rodger Combs
> On Mar 26, 2017, at 19:10, Steven Liu wrote: > > v2 fixed: > 1. from autodetect to disabled > 2. from camelCase code style to ffmpeg code style > 3. from RepType to AVMediaType > 4. fix variable typo > 5. change time value from uint32_t to uint64_t > 6. removed be used once API > 7. change 'ti

[FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-26 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Correct and make consistent AVERROR() in comments

2017-03-26 Thread Michael Niedermayer
On Sun, Mar 26, 2017 at 05:19:59PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 26, 2017 at 3:17 PM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --g

Re: [FFmpeg-devel] [PATCH] rtmpproto: send swfverify value as swfurl if latter is unused

2017-03-26 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 08:22:51PM +, Ricardo Constantino wrote: > Replicates lavf/librtmp.c behavior in L149-156 and rtmpdump's > behavior with "--swfVfy " passing the url to swfUrl. > > Fixes trac ticket #5549. > --- > libavformat/rtmpproto.c | 7 +-- > 1 file changed, 5 insertions(+),

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Michael Niedermayer
On Sun, Mar 26, 2017 at 05:30:05PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 26, 2017 at 3:31 PM, Michael Niedermayer > wrote: > > > On Sun, Mar 26, 2017 at 07:41:58PM +0200, wm4 wrote: > > > On Sun, 26 Mar 2017 19:16:26 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Sun, Ma

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-26 Thread Clément Bœsch
On Sun, Mar 26, 2017 at 06:17:57PM -0400, Ronald S. Bultje wrote: [...] > > I'll improve the message, but basically the djgpp libc can be configured > > to be POSIX only, where these functions functions and macro (pow2, PI) are > > not defined. We could do that in the configure (-D_POSIX_SOURCE). >

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-26 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 5:35 PM, Clément Bœsch wrote: > On Sun, Mar 26, 2017 at 05:21:23PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Mar 26, 2017 at 2:53 PM, Clément Bœsch wrote: > > > > > This conflict with the DJGPP libc which includes a pow2 function¹ > > > > > > We can not

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-26 Thread Clément Bœsch
On Sun, Mar 26, 2017 at 05:21:23PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 26, 2017 at 2:53 PM, Clément Bœsch wrote: > > > This conflict with the DJGPP libc which includes a pow2 function¹ > > > > We can not make DJGPP posix only to avoid the conflict due to the lack > > of posix_me

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 3:31 PM, Michael Niedermayer wrote: > On Sun, Mar 26, 2017 at 07:41:58PM +0200, wm4 wrote: > > On Sun, 26 Mar 2017 19:16:26 +0200 > > Michael Niedermayer wrote: > > > > > On Sun, Mar 26, 2017 at 06:51:11PM +0200, wm4 wrote: > > > > On Sun, 26 Mar 2017 18:11:01 +0200

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Correct and make consistent AVERROR() in comments

2017-03-26 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 3:17 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index af327ff9ad..4f3303366f 100644 >

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-26 Thread Ronald S. Bultje
Hi, On Sun, Mar 26, 2017 at 2:53 PM, Clément Bœsch wrote: > This conflict with the DJGPP libc which includes a pow2 function¹ > > We can not make DJGPP posix only to avoid the conflict due to the lack > of posix_memalign. > > [1]: http://www.delorie.com/djgpp/doc/libc-2.02/libc_536.html > --- >

Re: [FFmpeg-devel] [PATCH] ffmpeg: Remove hw_device_ctx output filter reinit hack

2017-03-26 Thread Mark Thompson
On 23/03/17 06:09, wm4 wrote: > On Wed, 22 Mar 2017 21:26:27 + > Mark Thompson wrote: > >> This was skipped in c17563c5d3c974a69709ebae0171534763b3051c because >> it depended on the filter setup merge, but was forgotten after that >> actually happened. >> >> Fixes hwaccel fate for stream size

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Michael Niedermayer
On Sun, Mar 26, 2017 at 07:41:58PM +0200, wm4 wrote: > On Sun, 26 Mar 2017 19:16:26 +0200 > Michael Niedermayer wrote: > > > On Sun, Mar 26, 2017 at 06:51:11PM +0200, wm4 wrote: > > > On Sun, 26 Mar 2017 18:11:01 +0200 > > > Michael Niedermayer wrote: > > > > > > > Fixes: 943/clusterfuzz-test

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
On Sun, Mar 26, 2017 at 1:53 PM, Kyle Swanson wrote: > Hi, > > On Sun, Mar 26, 2017 at 1:20 PM, Nicolas George wrote: >> >> Thanks for the patch. >> >> Le sextidi 6 germinal, an CCXXV, Kyle Swanson a écrit : >> > Squelches the following compiler warnings: >> > >> > libavcodec/opusenc.c:1051:16: w

[FFmpeg-devel] [PATCH] avcodec/avcodec: Correct and make consistent AVERROR() in comments

2017-03-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index af327ff9ad..4f3303366f 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -153,7 +153,7 @@ * U

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
Hi, On Sun, Mar 26, 2017 at 1:20 PM, Nicolas George wrote: > > Thanks for the patch. > > Le sextidi 6 germinal, an CCXXV, Kyle Swanson a écrit : > > Squelches the following compiler warnings: > > > > libavcodec/opusenc.c:1051:16: warning: format specifies type 'long' but > > the argument has type

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/dynaudnorm: rename pow2 to pow_2

2017-03-26 Thread Nicolas George
Le sextidi 6 germinal, an CCXXV, Clement Boesch a écrit : > This conflict with the DJGPP libc which includes a pow2 function¹ > > We can not make DJGPP posix only to avoid the conflict due to the lack > of posix_memalign. "cannot", I think. Regards, -- Nicolas George signature.asc Descript

[FFmpeg-devel] [PATCH 3/3] lavfi/xbr: undef PI if defined

2017-03-26 Thread Clément Bœsch
This conflict with the DJGPP libc math.h which includes a PI macro (to M_PI). We can not make DJGPP posix only to avoid the conflict due to the lack of posix_memalign. --- libavfilter/vf_xbr.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_xbr.c b/libavfilter/vf_xbr.c inde

[FFmpeg-devel] [PATCH 2/3] lavfi/psnr: rename pow2 to pow_2

2017-03-26 Thread Clément Bœsch
This conflict with the DJGPP libc which includes a pow2 function¹ We can not make DJGPP posix only to avoid the conflict due to the lack of posix_memalign. [1]: http://www.delorie.com/djgpp/doc/libc-2.02/libc_536.html --- libavfilter/vf_psnr.c | 8 1 file changed, 4 insertions(+), 4 del

[FFmpeg-devel] [PATCH 1/3] lavfi/dynaudnorm: rename pow2 to pow_2

2017-03-26 Thread Clément Bœsch
This conflict with the DJGPP libc which includes a pow2 function¹ We can not make DJGPP posix only to avoid the conflict due to the lack of posix_memalign. [1]: http://www.delorie.com/djgpp/doc/libc-2.02/libc_536.html --- libavfilter/af_dynaudnorm.c | 10 +- 1 file changed, 5 insertions(

[FFmpeg-devel] Fix DJGPP compilation

2017-03-26 Thread Clément Bœsch
$subj ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Nicolas George
Thanks for the patch. Le sextidi 6 germinal, an CCXXV, Kyle Swanson a écrit : > Squelches the following compiler warnings: > > libavcodec/opusenc.c:1051:16: warning: format specifies type 'long' but > the argument has type 'long long' [-Wformat] >avctx->bit_rate/1000, clipped_rate

[FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
Squelches the following compiler warnings: libavcodec/opusenc.c:1051:16: warning: format specifies type 'long' but the argument has type 'long long' [-Wformat] avctx->bit_rate/1000, clipped_rate/1000); ^~~~ libavcodec/opusenc.c:1051:38: warning: format

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread wm4
On Sun, 26 Mar 2017 19:16:26 +0200 Michael Niedermayer wrote: > On Sun, Mar 26, 2017 at 06:51:11PM +0200, wm4 wrote: > > On Sun, 26 Mar 2017 18:11:01 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: 943/clusterfuzz-testcase-5114865297391616 > > > > > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-03-26 Thread Aaron Levinson
On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb Aaron Levinson: When using the following command to play back either file: ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink SDI 4K", I noticed that with the mpegts file with the AAC audio stream, it would correctly

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Michael Niedermayer
On Sun, Mar 26, 2017 at 06:51:11PM +0200, wm4 wrote: > On Sun, 26 Mar 2017 18:11:01 +0200 > Michael Niedermayer wrote: > > > Fixes: 943/clusterfuzz-testcase-5114865297391616 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > > Signed

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread wm4
On Sun, 26 Mar 2017 18:11:01 +0200 Michael Niedermayer wrote: > Fixes: 943/clusterfuzz-testcase-5114865297391616 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpegdec.c | 3 ++-

Re: [FFmpeg-devel] [PATCH] avcodec/h264idct_template: Fix multiple runtime error: signed integer overflow

2017-03-26 Thread Michael Niedermayer
On Fri, Mar 24, 2017 at 03:37:50AM +0100, Michael Niedermayer wrote: > Fixes: 712/clusterfuzz-testcase-6647676227551232 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/h264idct_templ

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread Michael Niedermayer
Fixes: 943/clusterfuzz-testcase-5114865297391616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mjpegdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mjpeg

Re: [FFmpeg-devel] [PATCH 1/3] configure: use c++11 and fallback to c++0x for c++ files

2017-03-26 Thread James Almer
On 3/26/2017 7:22 AM, Marton Balint wrote: > > On Sat, 25 Mar 2017, James Almer wrote: > >> On 3/25/2017 8:51 PM, Marton Balint wrote: >>> Needed for the C+11 atomics. Also change add_cxxflags to check_cxxflags. >>> >>> Signed-off-by: Marton Balint >>> --- >>> configure | 2 +- >>> 1 file chang

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-03-26 Thread Matthias Hunstock
Am 26.03.2017 um 11:50 schrieb Aaron Levinson: > When using the following command to play back either file: > ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink SDI > 4K", I noticed that with the mpegts file with the AAC audio stream, > it would correctly select an interlaced video mode for the v

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-26 Thread Clément Bœsch
On Sun, Mar 26, 2017 at 12:35:54PM +0200, Marton Balint wrote: [...] > > - there is a FATE "test" with the expressive purpose of catching > > instances where the copyright header says "Libav" instead of > > "FFmpeg" after new files are added from Libav merges. One has to > > wonder why this is d

Re: [FFmpeg-devel] [PATCH v2] avformat/flvdec: check FLVHeader PreviousTagSize0

2017-03-26 Thread Bodecs Bela
2017.03.25. 14:15 keltezéssel, Steven Liu írta: refer to SPEC: Annex E. The FLV File Format said: E.3 TheFLVFileBody have a table: FieldTypeComment PreviousTagSize0 UI32Always 0 Signed-off-by: Steven Liu --- libavformat/flvdec.c | 12 +++- 1 file changed, 11 ins

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-26 Thread Marton Balint
On Sun, 26 Mar 2017, wm4 wrote: On Sat, 25 Mar 2017 21:33:50 -0300 James Almer wrote: On 3/25/2017 9:23 PM, Michael Niedermayer wrote: > On Sat, Mar 18, 2017 at 09:56:04AM +0100, wm4 wrote: >> From: Anton Khirnov >> >> Certain hardware decoding APIs are not guaranteed to be thread-safe, s

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-26 Thread wm4
On Sat, 25 Mar 2017 21:33:50 -0300 James Almer wrote: > On 3/25/2017 9:23 PM, Michael Niedermayer wrote: > > On Sat, Mar 18, 2017 at 09:56:04AM +0100, wm4 wrote: > >> From: Anton Khirnov > >> > >> Certain hardware decoding APIs are not guaranteed to be thread-safe, so > >> having the user acce

Re: [FFmpeg-devel] [PATCH 1/3] configure: use c++11 and fallback to c++0x for c++ files

2017-03-26 Thread Marton Balint
On Sat, 25 Mar 2017, James Almer wrote: On 3/25/2017 8:51 PM, Marton Balint wrote: Needed for the C+11 atomics. Also change add_cxxflags to check_cxxflags. Signed-off-by: Marton Balint --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure in

[FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-03-26 Thread Aaron Levinson
Hopefully I went through the patch process correctly, as this is the first time that I've done this. I didn't submit a ticket regarding this issue, but a detailed description of the problem can be found below. It is possible that there is an already existing ticket that corresponds to this iss