Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
Note that in case it wasn't clear, I confirmed that this patch works by running make on Linux and examining both the generated text file and the generated HTML file in a Web browser. Aaron On 4/21/2017 4:48 PM, Aaron Levinson wrote: On 4/21/2017 4:17 PM, Lou Logan wrote: On Fri, 21 Apr 2017

Re: [FFmpeg-devel] [PATCH 1/2] lavf/http.c: Free allocated client URLContext in case of error.

2017-04-21 Thread Stephan Holljes
On Tue, Apr 11, 2017 at 8:05 PM, Stephan Holljes wrote: > --- > > This version returns 0 in case of success and does not fallthrough to fail:. > > libavformat/http.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c >

[FFmpeg-devel] [PATCH] Make tools/target_dec_*_fuzzer buildable with configure and make

2017-04-21 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Makefile | 4 configure | 12 tools/Makefile| 10 ++ tools/target_dec_fuzzer.c | 12 4 files changed, 34 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] Is it legal to modify h264 sps for cropping

2017-04-21 Thread Xiaolei Yu
On 04/21/2017 10:15 PM, Hendrik Leppkes wrote: > On Fri, Apr 21, 2017 at 3:34 PM, Xiaolei Yu wrote: >> Some android devices do not properly align the input surface of MediaCodec >> (Nexus 4, Galxy Note 2) and >> we are forced to specify a multiple of 16 as the video

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread Hendrik Leppkes
On Sat, Apr 22, 2017 at 1:25 AM, Hendrik Leppkes wrote: > This brings our generation of the vpcC box up to date to version 1.0 > of the VP Codec ISO Media File Format Binding. > > Specifically, color/transfer properties are now written with values > based on ISO/IEC 23001-8,

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
On 4/21/2017 4:17 PM, Lou Logan wrote: > On Fri, 21 Apr 2017 16:05:16 -0700 > Aaron Levinson wrote: > >> From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 21 Apr 2017 15:55:11 -0700 >>

[FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread Hendrik Leppkes
This brings our generation of the vpcC box up to date to version 1.0 of the VP Codec ISO Media File Format Binding. Specifically, color/transfer properties are now written with values based on ISO/IEC 23001-8, which is the same reference specification the AVColor* enumerations are based on. ---

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Lou Logan
On Fri, 21 Apr 2017 16:05:16 -0700 Aaron Levinson wrote: > From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Fri, 21 Apr 2017 15:55:11 -0700 > Subject: [PATCH] Added additional note to fate.texi to

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread Hendrik Leppkes
On Fri, Apr 21, 2017 at 11:52 PM, James Almer wrote: > On 4/21/2017 6:47 PM, James Almer wrote: >> >> On 4/21/2017 6:34 PM, Hendrik Leppkes wrote: >>> >>> On Fri, Apr 21, 2017 at 11:25 PM, KongQun Yang >>> wrote: Hi Hendrik,

[FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 21 Apr 2017 15:55:11 -0700 Subject: [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread KongQun Yang
Correct. There is a mistake in the spec. I have created a pull request to fix that earlier today: https://github.com/webmproject/vp9-dash/pull/69 -- KongQun Yang (KQ) On Fri, Apr 21, 2017 at 2:52 PM, James Almer wrote: > On 4/21/2017 6:47 PM, James Almer wrote: > >> On

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread James Almer
On 4/21/2017 6:47 PM, James Almer wrote: On 4/21/2017 6:34 PM, Hendrik Leppkes wrote: On Fri, Apr 21, 2017 at 11:25 PM, KongQun Yang wrote: Hi Hendrik, Thanks for working on it. Version needs to be updated as well:

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread James Almer
On 4/21/2017 6:34 PM, Hendrik Leppkes wrote: On Fri, Apr 21, 2017 at 11:25 PM, KongQun Yang wrote: Hi Hendrik, Thanks for working on it. Version needs to be updated as well:

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread Hendrik Leppkes
On Fri, Apr 21, 2017 at 11:25 PM, KongQun Yang wrote: > Hi Hendrik, > > Thanks for working on it. Version needs to be updated as well: > https://github.com/FFmpeg/FFmpeg/blob/b905ba5bc18c89c7fccd862179575562ef19/libavformat/movenc.c#L1115. > Suggest moving it

Re: [FFmpeg-devel] [PATCH] movenc/isom: update vpcC box to the latest draft specification

2017-04-21 Thread KongQun Yang
Hi Hendrik, Thanks for working on it. Version needs to be updated as well: https://github.com/FFmpeg/FFmpeg/blob/b905ba5bc18c89c7fccd862179575562ef19/libavformat/movenc.c#L1115. Suggest moving it into ff_isom_write_vpcc function too. -- KongQun Yang (KQ) On Tue, Apr 18, 2017 at 7:30 AM,

Re: [FFmpeg-devel] [PATCH] rtmpproto: send swfverify value as swfurl if latter is unused

2017-04-21 Thread Ricardo Constantino
Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-21 Thread James Almer
On 4/21/2017 12:09 PM, Michael Niedermayer wrote: On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject: [PATCH] Fixed

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-21 Thread James Almer
On 4/21/2017 6:03 PM, James Almer wrote: On 4/21/2017 12:09 PM, Michael Niedermayer wrote: On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-21 Thread Marton Balint
On Thu, 20 Apr 2017, Aaron Levinson wrote: On 4/19/2017 2:27 PM, Marton Balint wrote: On Mon, 17 Apr 2017, James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep

[FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

2017-04-21 Thread Derek Buitenhuis
The WebM DASH spec states: The Initialization Segment shall not contain Clusters or Cues. The Segment Index corresponds to the Cues. Previously, it included the cues if they were at the front. Signed-off-by: Derek Buitenhuis --- libavformat/matroskadec.c |

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-21 Thread Michael Niedermayer
On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: > From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Thu, 20 Apr 2017 23:20:20 -0700 > Subject: [PATCH] Fixed memory leaks associated with AVStream objects if >

[FFmpeg-devel] [PATCH] Notify user when encode a CBR mp3 file without "-write_xing false". This may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it can’t

2017-04-21 Thread sharpbai
From: sharpbai Bug example: ffmpeg -i a.mp3 -c:a mp3 -ab 32k -ar 44100 -ac 1 b.mp3 The duration of the generated file b.mp3 is wrong on ios safari browser from ios7 to ios10. --- libavformat/mp3enc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-21 Thread Amine kabab
Normally, all the streams On 21/04/2017 12:49, wm4 wrote: > On Fri, 21 Apr 2017 11:34:39 +0100 > Amine kabab wrote: > >> Hi Ben, thanks for reviewing the patch, >> >> >> On 21/04/2017 08:13, Benoit Fouet wrote: >>> Hi, >>> >>> >>> On 20/04/2017 18:18, Amine kabab wrote:

Re: [FFmpeg-devel] Is it legal to modify h264 sps for cropping

2017-04-21 Thread Hendrik Leppkes
On Fri, Apr 21, 2017 at 3:34 PM, Xiaolei Yu wrote: > Some android devices do not properly align the input surface of MediaCodec > (Nexus 4, Galxy Note 2) and > we are forced to specify a multiple of 16 as the video width. A possible > workaround is to insert the desired

[FFmpeg-devel] Is it legal to modify h264 sps for cropping

2017-04-21 Thread Xiaolei Yu
Some android devices do not properly align the input surface of MediaCodec (Nexus 4, Galxy Note 2) and we are forced to specify a multiple of 16 as the video width. A possible workaround is to insert the desired crop into the output sps, but I am not sure if it is legal.

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-21 Thread wm4
On Fri, 21 Apr 2017 11:34:39 +0100 Amine kabab wrote: > Hi Ben, thanks for reviewing the patch, > > > On 21/04/2017 08:13, Benoit Fouet wrote: > > Hi, > > > > > > On 20/04/2017 18:18, Amine kabab wrote: > >> From 5079f9b7114589626a4c9fff0fbb8f6e0d2f4fd9 Mon Sep 17

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-21 Thread Amine kabab
Hi Ben, thanks for reviewing the patch, On 21/04/2017 08:13, Benoit Fouet wrote: > Hi, > > > On 20/04/2017 18:18, Amine kabab wrote: >> From 5079f9b7114589626a4c9fff0fbb8f6e0d2f4fd9 Mon Sep 17 00:00:00 2001 >> From: amine kabab >> Date: Thu, 20 Apr 2017 15:59:42 + >>

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-21 Thread Benoit Fouet
Hi, On 20/04/2017 18:18, Amine kabab wrote: > From 5079f9b7114589626a4c9fff0fbb8f6e0d2f4fd9 Mon Sep 17 00:00:00 2001 > From: amine kabab > Date: Thu, 20 Apr 2017 15:59:42 + > Subject: [PATCH] HLS skip down streams > > --- > libavformat/hls.c | 14 +- > 1

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-21 Thread Lucas Cooper
Does this need any more work or explanation? On 19 Apr. 2017 7:32 am, "Lucas Cooper" wrote: > Michael's right. The problem is that NaN is casted to an int, resulting in > rate having undefined value. Not sure how I neglected to add that part. > > On 19 Apr. 2017 2:32 am,

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-21 Thread Aaron Levinson
On 4/19/2017 2:27 PM, Marton Balint wrote: On Mon, 17 Apr 2017, James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson

[FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-21 Thread Aaron Levinson
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject: [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined Purpose: Fixed memory leaks associated