[FFmpeg-devel] [PATCH] avcodec/libfdk-aacdec: Correct buffer_size parameter

2017-05-24 Thread Michael Niedermayer
the timeDataSize argument to aacDecoder_DecodeFrame() seems undocumented and until 2016 04 (203e3f28fbebec7011342017fafc2a0bda0ce530) unused. after that commit libfdk-aacdec interprets it as size in sample units and memsets that on error. FFmpeg as well as others (like GStreamer) did interpret it

Re: [FFmpeg-devel] [PATCH 1/6] avformat/movenc: always check for new extradata on a packet

2017-05-24 Thread James Almer
On 4/15/2017 7:56 PM, Michael Niedermayer wrote: > On Thu, Apr 13, 2017 at 04:54:12PM -0300, James Almer wrote: >> Don't just look at zero sized packets, and also check for AAC extradata >> updates, in preparation for the following patches. >> >> Signed-off-by: James Almer >> --- >> libavformat/m

[FFmpeg-devel] RFQ on patch for decklink warnings

2017-05-24 Thread Felt, Patrick
Afternoon all, I’m looking at fixing some warnings on deprecated api calls in the decklink drivers. I’ve got a patch ready, but it looks like I might be leaking memory somewhere. In the old code using the av_dup_packet() is a free() of some kind required in code that I might be able to look f

Re: [FFmpeg-devel] [PATCH] udp: ignore UDP packets without payload

2017-05-24 Thread Daniel Kučera
2017-05-24 10:10 GMT+02:00 Daniel Kučera : > 2017-05-24 9:02 GMT+02:00 Nicolas George : >> >> Le quartidi 4 prairial, an CCXXV, Daniel Kucera a écrit : >> > Time to time some devices send UDP packets without payload. >> > ffmpeg previously exited on receiving such packet, this patch >> > fixes this

Re: [FFmpeg-devel] [PATCH] udp: ignore UDP packets without payload

2017-05-24 Thread Daniel Kučera
2017-05-24 9:02 GMT+02:00 Nicolas George : > > Le quartidi 4 prairial, an CCXXV, Daniel Kucera a écrit : > > Time to time some devices send UDP packets without payload. > > ffmpeg previously exited on receiving such packet, this patch > > fixes this behaviour. > > > > Signed-off-by: Daniel Kucera

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-24 Thread Ronald S. Bultje
Hi, On May 24, 2017 12:51 PM, "Clément Bœsch" wrote: On Wed, May 24, 2017 at 12:15:05PM -0400, Ronald S. Bultje wrote: > Should fix tsan errors in utvideoenc_rgb_left and related tests. > --- > libavcodec/frame_thread_encoder.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions

Re: [FFmpeg-devel] FFmpeg 3.3.1

2017-05-24 Thread Kyle Swanson
Hi, On Sun, May 14, 2017 at 5:15 AM, Michael Niedermayer wrote: > On Sun, May 14, 2017 at 11:05:42AM +0200, Hendrik Leppkes wrote: >> On Sun, May 14, 2017 at 3:18 AM, Michael Niedermayer >> wrote: >> > Hi all >> > >> > ill make 3.3.1 soon (likely within 24h) and releases from other >> > maintain

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-24 Thread Clément Bœsch
On Wed, May 24, 2017 at 12:15:05PM -0400, Ronald S. Bultje wrote: > Should fix tsan errors in utvideoenc_rgb_left and related tests. > --- > libavcodec/frame_thread_encoder.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/frame_thread_encoder.c

Re: [FFmpeg-devel] mp4 encryption with time code track

2017-05-24 Thread Eran Kornblau
Ping Eran From: Eran Kornblau Sent: Wednesday, May 17, 2017 12:50 PM To: FFmpeg development discussions and patches Subject: mp4 encryption with time code track Hi all, We bumped into an issue with the mp4 encryption support we submitted a while ago - in case ffmpeg decides to write a timecod

[FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-24 Thread Ronald S. Bultje
Should fix tsan errors in utvideoenc_rgb_left and related tests. --- libavcodec/frame_thread_encoder.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c index 27ae356..2746964 100644 --- a/libav

[FFmpeg-devel] [PATCH] hevc: fix race condition in max_ra/seq_decode.

2017-05-24 Thread Ronald S. Bultje
These variables are shared between frame threads, but they are updated post-setup_finished() if a EOB/EOS slice type occurs. Moving the EOB/EOS slices to the next frame thread instance (by parsing them leading into the next picture instead of trailing behind the last picture) effectively prevents t

[FFmpeg-devel] [PATCH] videotoolbox: log errors

2017-05-24 Thread wm4
With the new decode API, you can't handle errors directly in the API user - you only know that the hwaccel did not initialize at all. Add some approximate logging. --- libavcodec/videotoolbox.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videot

Re: [FFmpeg-devel] [PATCH 1/2] fate: add aac-al_sbr_ps_06_ur test

2017-05-24 Thread James Almer
On 5/23/2017 9:14 PM, Michael Niedermayer wrote: > On Tue, May 23, 2017 at 04:01:17PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Samples in >> ftp://mpaudconf:adif2...@ftp.iis.fhg.de/mpeg4audio-conformance/compressedMp4/al_sbr_ps_04_new.mp4 >> http://0x0.st/ESa.s16 (should b

Re: [FFmpeg-devel] [PATCH] lavc/mpegvideo_enc: allow to force low_delay by increasing strict_std_compliance

2017-05-24 Thread Stefano Sabatini
On date Tuesday 2017-05-23 15:07:31 +0200, Moritz Barsnick encoded: > On Tue, May 23, 2017 at 12:28:48 +0200, Stefano Sabatini wrote: > > -if (s->codec_id != AV_CODEC_ID_MPEG2VIDEO) { > > +if (s->codec_id != AV_CODEC_ID_MPEG2VIDEO && > > +s->strict_std_compliance >= FF_C

Re: [FFmpeg-devel] [PATCH] udp: ignore UDP packets without payload

2017-05-24 Thread Nicolas George
Le quartidi 4 prairial, an CCXXV, Daniel Kucera a écrit : > Time to time some devices send UDP packets without payload. > ffmpeg previously exited on receiving such packet, this patch > fixes this behaviour. > > Signed-off-by: Daniel Kucera > --- > libavformat/udp.c | 6 +- > 1 file changed,