Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: also write chapters when output is WebM

2017-06-01 Thread James Zern
On Thu, Jun 1, 2017 at 7:51 PM, James Almer wrote: > WebM supports a subset of elements from the Chapters master. > See https://www.webmproject.org/docs/container/#chapters > > Addresses ticket #6425 > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 29 --

[FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: also write tags when output is WebM

2017-06-01 Thread James Almer
WebM supports a subset of elements from the Tags master. See https://www.webmproject.org/docs/container/#tagging Signed-off-by: James Almer --- libavformat/matroskaenc.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavformat/matroskaenc.c b/liba

[FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: also write chapters when output is WebM

2017-06-01 Thread James Almer
WebM supports a subset of elements from the Chapters master. See https://www.webmproject.org/docs/container/#chapters Addresses ticket #6425 Signed-off-by: James Almer --- libavformat/matroskaenc.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-01 Thread Michael Niedermayer
On Thu, Jun 01, 2017 at 01:12:13PM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/aviobuf.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) breaks fate (infinte loops) example fate-swr-resample-s32p-2626-8000 [...] -- Michael GnuP

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add default value for AVCodecContext::refs

2017-06-01 Thread Ganapathy Raman Kasi
Timo, >> Is this supposed to fix the issue with -bf >0? We are working on another patch which will fix hw accelerated transcode (with -hwaccel cuvid) for bf > 0 and will send out for review soon. Thanks Ganapathy From: ffmpeg-devel on behalf of Timo Ro

Re: [FFmpeg-devel] Backport HLS Cookie Authentication Fixes to 3.3

2017-06-01 Thread Michael Niedermayer
On Tue, May 30, 2017 at 09:29:53PM -0400, Micah Galizia wrote: > Hello, > > I'd like to backport the HLS cookie authentication fixes to 3.3 so that Kodi > 18 picks them up. Originally, this was a three patch set but the first fix > (to av_small_strptime) is already in 3.3 and doesn't need to be

[FFmpeg-devel] [PATCH 3/3] avutil/tests: remove float_dsp test

2017-06-01 Thread James Almer
It's been ported to checkasm. Signed-off-by: James Almer --- libavutil/Makefile | 1 - libavutil/tests/.gitignore | 1 - libavutil/tests/float_dsp.c | 357 tests/fate/libavutil.mak| 6 - 4 files changed, 365 deletions(-) delete mo

[FFmpeg-devel] [PATCH 2/3] checkasm: add float_dsp tests

2017-06-01 Thread James Almer
Ported from libavutil/tests/float_dsp.c Signed-off-by: James Almer --- tests/checkasm/Makefile| 1 + tests/checkasm/checkasm.c | 20 +++ tests/checkasm/checkasm.h | 4 + tests/checkasm/float_dsp.c | 307 + tests/fate/checkasm.mak| 1 +

[FFmpeg-devel] [PATCH 1/3] checkasm: add a checkasm_checked_call function that doesn't issue emms

2017-06-01 Thread James Almer
Meant for DSP functions returning a float or double, as they'd fail if emms is called after every run on x86_32. Signed-off-by: James Almer --- tests/checkasm/checkasm.h | 11 +++ tests/checkasm/x86/checkasm.asm | 13 +++-- 2 files changed, 18 insertions(+), 6 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavc/golomb: Fix UE golomb overwrite issue.

2017-06-01 Thread Michael Niedermayer
On Wed, May 31, 2017 at 09:01:47AM +0800, Jun Zhao wrote: > > > On 2017/5/29 7:40, Michael Niedermayer wrote: > > On Fri, May 26, 2017 at 09:19:09AM +0800, Jun Zhao wrote: > >> golomb.h |5 - > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> 228c7180856b65d095dd0b8d59f3d3ff4f65774

Re: [FFmpeg-devel] [PATCH] libavfilter/scale2ref: Add constants for the primary input

2017-06-01 Thread Michael Niedermayer
On Tue, May 30, 2017 at 01:34:29PM -0400, Kevin Mark wrote: > Variables pertaining to the main video are now available when > using the scale2ref filter. This allows, as an example, scaling a > video with another as a reference point while maintaining the > original aspect ratio of the primary/non-

Re: [FFmpeg-devel] [PATCH]libavformat/http: fix http error eof

2017-06-01 Thread Michael Niedermayer
On Thu, Jun 01, 2017 at 07:48:38AM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Jun 1, 2017 at 2:27 AM, raymond zheng > wrote: > > > This patch is only for solving the bug introduced by chunksize has been > > initial set as UINT64 MAX. > > > > I understand. So what will happen if the server

[FFmpeg-devel] [PATCH] ffprobe: Use pixdesc API to provide color space names

2017-06-01 Thread Vittorio Giovara
This API is more up-to-date, provides names compatible with filters and external encoders, and is consistent with the other color property variables. Signed-off-by: Vittorio Giovara --- ffprobe.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ffprobe.c b/ffprobe.c ind

Re: [FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Alan Pope
Hi Timo, On 1 June 2017 at 14:47, Timo Rothenpieler wrote: > Would this only grant access to the binaries, or also the > libraries/development files? > Not sure I follow. The snap can contain whatever you want, binaries, libraries etc. At build time you can specify 'build-packages' required by t

Re: [FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Steven Liu
2017-06-01 21:51 GMT+08:00 Alan Pope : > Hi Reto, > > On 1 June 2017 at 12:37, Reto Kromer wrote: > > Alan Pope wrote: > > > >>Snaps are universal Linux packages. > > > > On number of Linux distributions you can use Linuxbrew: > > > > brew install ffmpeg --with-the-parameters-you-wish > > > > I

Re: [FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Alan Pope
Hi Reto, On 1 June 2017 at 12:37, Reto Kromer wrote: > Alan Pope wrote: > >>Snaps are universal Linux packages. > > On number of Linux distributions you can use Linuxbrew: > > brew install ffmpeg --with-the-parameters-you-wish > > It works pretty well! We use it on Ubuntu and on Slackware. > Mo

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add default value for AVCodecContext::refs

2017-06-01 Thread Timo Rothenpieler
Am 01.06.2017 um 09:58 schrieb Srinath K R:> AVCodecContext::refs is used to control the DPB size to be used by the > encoder. The default value for AVCodecContext::refs as set in > libavcodec/options_table.h is 1. > > This patch sets AVCodecContext::refs to 0 for h264_nvenc and hevc_nvenc in > ord

Re: [FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Timo Rothenpieler
Am 01.06.2017 um 12:09 schrieb Alan Pope: > Hello, > > I work for Canonical on Snapcraft [0]. We recently asked [1] our > community of users and developers what applications they'd like to see > snapped. ffmpeg came up on the list so I thought I'd contact your > devel list in the first instance. >

Re: [FFmpeg-devel] [PATCH 2/3] avutil/avstring: Fix av_match_name() with seperators in the name itself

2017-06-01 Thread wm4
On Thu, 1 Jun 2017 13:44:45 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/avstring.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavutil/avstring.c b/libavutil/avstring.c > index f03dd25141..c1348b3a1

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-01 Thread Tobias Rapp
On 01.06.2017 13:44, Michael Niedermayer wrote: This prevents an exploit leading to an information leak The existing exploit depends on a specific decoder as well. It does appear though that the exploit should be possible with any decoder. The problem is that as long as sensitive information get

Re: [FFmpeg-devel] [PATCH]libavformat/http: fix http error eof

2017-06-01 Thread Ronald S. Bultje
Hi, On Thu, Jun 1, 2017 at 2:27 AM, raymond zheng wrote: > This patch is only for solving the bug introduced by chunksize has been > initial set as UINT64 MAX. > I understand. So what will happen if the server responds that the chunksize is really actually UINT64_MAX? How do we distinguish betw

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-06-01 Thread Michael Niedermayer
On Thu, Jun 01, 2017 at 12:13:35PM +0200, Michael Niedermayer wrote: > On Thu, Jun 01, 2017 at 11:02:09AM +0200, Tobias Rapp wrote: > > On 31.05.2017 18:33, Michael Niedermayer wrote: > > >On Wed, May 31, 2017 at 05:18:57PM +0200, Tobias Rapp wrote: > > >>On 31.05.2017 15:42, wm4 wrote: > > >>>On W

[FFmpeg-devel] [PATCH 2/3] avutil/avstring: Fix av_match_name() with seperators in the name itself

2017-06-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/avstring.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index f03dd25141..c1348b3a13 100644 --- a/libavutil/avstring.c +++ b/libavutil/avstring.c @@ -342,22 +342

[FFmpeg-devel] [PATCH 1/3] Consistently use av_match_name() for whitelists

2017-06-01 Thread Michael Niedermayer
Also make docs consistent Signed-off-by: Michael Niedermayer --- doc/codecs.texi | 3 ++- doc/formats.texi| 3 ++- libavcodec/utils.c | 2 +- libavformat/avio.c | 2 +- libavformat/utils.c | 4 ++-- 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/codecs.texi b/doc/co

[FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-01 Thread Michael Niedermayer
This prevents an exploit leading to an information leak The existing exploit depends on a specific decoder as well. It does appear though that the exploit should be possible with any decoder. The problem is that as long as sensitive information gets into the decoder, the output of the decoder beco

Re: [FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Reto Kromer
Alan Pope wrote: >Snaps are universal Linux packages. On number of Linux distributions you can use Linuxbrew: brew install ffmpeg --with-the-parameters-you-wish It works pretty well! We use it on Ubuntu and on Slackware. Most of the Homebrew packages are available also on Linuxbrew. Best reg

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-01 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/aviobuf.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 1667e9f08b..40cff4dc56 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -556,13 +556,

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-06-01 Thread Michael Niedermayer
On Thu, Jun 01, 2017 at 11:02:09AM +0200, Tobias Rapp wrote: > On 31.05.2017 18:33, Michael Niedermayer wrote: > >On Wed, May 31, 2017 at 05:18:57PM +0200, Tobias Rapp wrote: > >>On 31.05.2017 15:42, wm4 wrote: > >>>On Wed, 31 May 2017 14:49:19 +0200 > >>>Michael Niedermayer wrote: > >>> > [..

[FFmpeg-devel] Snapping ffmpeg

2017-06-01 Thread Alan Pope
Hello, I work for Canonical on Snapcraft [0]. We recently asked [1] our community of users and developers what applications they'd like to see snapped. ffmpeg came up on the list so I thought I'd contact your devel list in the first instance. Snaps are universal Linux packages. Developers can eas

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add a few SIMD function for AAC PS

2017-06-01 Thread Clément Bœsch
On Thu, May 25, 2017 at 01:22:22PM -0300, James Almer wrote: [...] > > +function ff_ps_stereo_interpolate_ipdopd_neon, export=1 > > +movrel x5, ipdopd_factors > > +ld1 {v20.4S}, [x5] > > +ld1 {v0.4S,v1.4S}, [x2] > > +ld1 {v6.4S,v7.4S}, [x

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-06-01 Thread Tobias Rapp
On 31.05.2017 18:33, Michael Niedermayer wrote: On Wed, May 31, 2017 at 05:18:57PM +0200, Tobias Rapp wrote: On 31.05.2017 15:42, wm4 wrote: On Wed, 31 May 2017 14:49:19 +0200 Michael Niedermayer wrote: [...] Security fixes should be as simple as possible. Well, your fix isn't simple. I

[FFmpeg-devel] [PATCH] Disable MSA optimization for big endian arch

2017-06-01 Thread shivraj.patil
From: Shivraj Patil The current upstreamed code has been written and tested for Little Endian systems. We do have plans to add the Big Endian support in near future, but till that time, need to disable all to avoid its usage and failures. Signed-off-by: Shivraj Patil --- configure |4 +++

[FFmpeg-devel] [PATCH] avcodec/nvenc: Add default value for AVCodecContext::refs

2017-06-01 Thread Srinath K R
AVCodecContext::refs is used to control the DPB size to be used by the encoder. The default value for AVCodecContext::refs as set in libavcodec/options_table.h is 1. This patch sets AVCodecContext::refs to 0 for h264_nvenc and hevc_nvenc in order to let the driver take the decision of the correct