Re: [FFmpeg-devel] [PATCH] avcodec/imc: cast float to int prior to comparing with int variable

2017-06-27 Thread Paul B Mahol
On 6/26/17, Paul B Mahol wrote: > On 6/26/17, Michael Niedermayer wrote: >> On Mon, Jun 26, 2017 at 12:44:48PM +0200, Paul B Mahol wrote: >>> From: Kostya Shishkov >>> >>> Fixes #3886. >>> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/imc.c | 2 +- >>> 1 file changed, 1 insertion(+),

Re: [FFmpeg-devel] [PATCH] Add wayland support for VAAPI

2017-06-27 Thread Mark Thompson
On 27/06/17 07:38, David Fort wrote: > Wayland environment became quite popular with gnome 3. This patch adds the > ability to > initialize the VAAPI accelerator from a wayland display. Is there some specific use-case which needs this? The X11 support mainly exists because of old systems (*coug

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/proresenc: switch default prores encoder to prores_ks

2017-06-27 Thread Paul B Mahol
On 6/27/17, Michael Niedermayer wrote: > On Tue, Jun 27, 2017 at 12:20:05AM +0200, Paul B Mahol wrote: >> On 6/27/17, Michael Niedermayer wrote: >> > On Mon, Jun 26, 2017 at 11:55:35PM +0200, Paul B Mahol wrote: >> >> Rationale: >> >> prores_ks have more features and is faster for qscale > 0 >> >

[FFmpeg-devel] [PATCH 1/3] avcodec/s302m: fix AVOption flags

2017-06-27 Thread foo86
--- libavcodec/s302m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/s302m.c b/libavcodec/s302m.c index a68ac79f2c..4350d97f0a 100644 --- a/libavcodec/s302m.c +++ b/libavcodec/s302m.c @@ -201,7 +201,7 @@ static int s302m_decode_frame(AVCodecContext *avctx, void *d

[FFmpeg-devel] [PATCH 3/3] avformat: add SMPTE 337M demuxer

2017-06-27 Thread foo86
--- Changelog| 1 + doc/general.texi | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/s337m.c | 205 +++ libavformat/version.h| 2 +- 6 files changed, 210 insertions(+), 1 delet

[FFmpeg-devel] [PATCH 2/3] avcodec: add Dolby E decoder

2017-06-27 Thread foo86
--- configure |1 + doc/general.texi|1 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h|1 + libavcodec/codec_desc.c |7 + libavcodec/dolby_e.c| 716 + libavcodec/dolby_e.h| 11

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/s302m: fix AVOption flags

2017-06-27 Thread Paul B Mahol
On 6/27/17, foo86 wrote: > --- > libavcodec/s302m.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Allow less than 2 rows of slices for low vertical resolution

2017-06-27 Thread Michael Niedermayer
On Mon, Jun 26, 2017 at 05:33:02PM +0200, Paul B Mahol wrote: > On 6/26/17, Michael Niedermayer wrote: > > Fixes: Ticket5548 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ffv1enc.c | 4 > > 1 file changed, 4 insertions(+) > > LGTM applied > > Could this calculation

Re: [FFmpeg-devel] [PATCH] Add wayland support for VAAPI

2017-06-27 Thread Hardening
Le 27/06/2017 à 09:54, Mark Thompson a écrit : > On 27/06/17 07:38, David Fort wrote: >> Wayland environment became quite popular with gnome 3. This patch adds the >> ability to >> initialize the VAAPI accelerator from a wayland display. > > Is there some specific use-case which needs this? The

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/proresenc: switch default prores encoder to prores_ks

2017-06-27 Thread Michael Niedermayer
On Tue, Jun 27, 2017 at 10:38:47AM +0200, Paul B Mahol wrote: > On 6/27/17, Michael Niedermayer wrote: > > On Tue, Jun 27, 2017 at 12:20:05AM +0200, Paul B Mahol wrote: > >> On 6/27/17, Michael Niedermayer wrote: > >> > On Mon, Jun 26, 2017 at 11:55:35PM +0200, Paul B Mahol wrote: > >> >> Rationa

[FFmpeg-devel] [PATCH] avcodec/wavpack: Fix invalid shift

2017-06-27 Thread Michael Niedermayer
Fixes: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 2377/clusterfuzz-testcase-minimized-6108505935183872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcod

Re: [FFmpeg-devel] [PATCH] avcodec/imc: cast float to int prior to comparing with int variable

2017-06-27 Thread Michael Niedermayer
On Tue, Jun 27, 2017 at 09:45:38AM +0200, Paul B Mahol wrote: > On 6/26/17, Paul B Mahol wrote: > > On 6/26/17, Michael Niedermayer wrote: > >> On Mon, Jun 26, 2017 at 12:44:48PM +0200, Paul B Mahol wrote: > >>> From: Kostya Shishkov > >>> > >>> Fixes #3886. > >>> > >>> Signed-off-by: Paul B Mah

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/proresenc: switch default prores encoder to prores_ks

2017-06-27 Thread Paul B Mahol
On 6/27/17, Michael Niedermayer wrote: > On Tue, Jun 27, 2017 at 10:38:47AM +0200, Paul B Mahol wrote: >> On 6/27/17, Michael Niedermayer wrote: >> > On Tue, Jun 27, 2017 at 12:20:05AM +0200, Paul B Mahol wrote: >> >> On 6/27/17, Michael Niedermayer wrote: >> >> > On Mon, Jun 26, 2017 at 11:55:3

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add Dolby E decoder

2017-06-27 Thread Derek Buitenhuis
On 6/27/2017 10:59 AM, foo86 wrote: > +init_tables(); This should be run under ff_thread_once() and thread-safe init flag added to the internal caps. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-06-27 Thread Paul B Mahol
On 6/20/17, Paras Chadha wrote: > Above changes done. Also fixed an issue with BLANK keyword. > > Signed-off-by: Paras Chadha > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h

Re: [FFmpeg-devel] Multiprogram mode for mpeg TS

2017-06-27 Thread Michael Niedermayer
On Mon, Jun 26, 2017 at 12:51:08PM +0300, ffm...@a.legko.ru wrote: > > > On Mon, 26 Jun 2017, Hendrik Leppkes wrote: > > >Individual changes should be submitted as seperate patches. Having > >several unrelated changes in one patch makes it impossible to apply or > >even properly review it. > all

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-27 Thread Michael Niedermayer
On Mon, Jun 26, 2017 at 02:20:03PM +0200, James Darnley wrote: > On 2017-06-25 21:27, Michael Niedermayer wrote: > > On Sat, Jun 24, 2017 at 06:30:26PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Sat, Jun 24, 2017 at 3:27 PM, Michael Niedermayer > >> >> > >>> This patch changes the defau

[FFmpeg-devel] [PATCH 1/2] x86/vf_blend: add sse and ssse3 extremity functions

2017-06-27 Thread James Almer
Signed-off-by: James Almer --- libavfilter/x86/vf_blend.asm| 25 + libavfilter/x86/vf_blend_init.c | 4 tests/checkasm/vf_blend.c | 1 + 3 files changed, 30 insertions(+) diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm index 33b1a

[FFmpeg-devel] [PATCH 2/2] x86/vf_blend: optimize difference and negation functions

2017-06-27 Thread James Almer
Process more pixels per loop. Signed-off-by: James Almer --- libavfilter/x86/vf_blend.asm | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm index 25f6f5affc..d5e512e6e0 100644

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: add sse and ssse3 extremity functions

2017-06-27 Thread Paul B Mahol
On 6/27/17, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm| 25 + > libavfilter/x86/vf_blend_init.c | 4 > tests/checkasm/vf_blend.c | 1 + > 3 files changed, 30 insertions(+) > LGTM, I have couple more blend modes t

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_blend: optimize difference and negation functions

2017-06-27 Thread Paul B Mahol
On 6/27/17, James Almer wrote: > Process more pixels per loop. > > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm | 40 > 1 file changed, 24 insertions(+), 16 deletions(-) > LGTM ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] x86inc: don't use read-only data sections on COFF targets

2017-06-27 Thread James Almer
On 6/27/2017 3:54 AM, Clément Bœsch wrote: > On Mon, Jun 26, 2017 at 12:32:15AM -0300, James Almer wrote: >> Yasm: >> src/libavfilter/x86/af_volume.asm:24: warning: Standard COFF does not >> support read-only data sections >> src/libavfilter/x86/af_volume.asm:24: warning: Unrecognized qualifier `a

Re: [FFmpeg-devel] [PATCH] Add wayland support for VAAPI

2017-06-27 Thread Mark Thompson
On 27/06/17 13:13, Hardening wrote: > Le 27/06/2017 à 09:54, Mark Thompson a écrit : >> On 27/06/17 07:38, David Fort wrote: >>> Wayland environment became quite popular with gnome 3. This patch adds the >>> ability to >>> initialize the VAAPI accelerator from a wayland display. >> >> Is there som

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: add sse and ssse3 extremity functions

2017-06-27 Thread James Almer
On 6/27/2017 12:50 PM, Paul B Mahol wrote: > On 6/27/17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_blend.asm| 25 + >> libavfilter/x86/vf_blend_init.c | 4 >> tests/checkasm/vf_blend.c | 1 + >> 3 files changed, 30 inse

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_blend: optimize difference and negation functions

2017-06-27 Thread James Almer
On 6/27/2017 12:50 PM, Paul B Mahol wrote: > On 6/27/17, James Almer wrote: >> Process more pixels per loop. >> >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_blend.asm | 40 >> 1 file changed, 24 insertions(+), 16 deletions(-) >> > > LGTM P

[FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: Move bitstream end check out of inner loop

2017-06-27 Thread Michael Niedermayer
This is not needed when the buffer is large enough for the worst case of a line 2% faster vlc reading Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/

[FFmpeg-devel] [PATCH 5/5] avcodec/utvideodec: Factor multiply out of inner loop

2017-06-27 Thread Michael Niedermayer
0.5% faster loop Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 788f4475b9..a20e28320c 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideode

[FFmpeg-devel] [PATCH 3/5] avcodec/utvideodec: enable unchecked bitreader

2017-06-27 Thread Michael Niedermayer
inner reader loop becomes 16% faster Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 411df47730..1418cde543 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideode

[FFmpeg-devel] [PATCH 4/5] avcodec/utvideodec: bswap directly without memcpy

2017-06-27 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 1418cde543..788f4475b9 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideodec.c @@ -188,11 +

[FFmpeg-devel] [PATCH 2/5] avcodec/utvideodec: hardcode vlc bits

2017-06-27 Thread Michael Niedermayer
2.5% faster vlc decoding Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 815b71cfb6..411df47730 100644 --- a/libavcodec/utvideodec.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: Move bitstream end check out of inner loop

2017-06-27 Thread Michael Niedermayer
On Tue, Jun 27, 2017 at 09:47:31PM +0200, Michael Niedermayer wrote: "Summary email is empty, skipping it" somehow the summary mail for the thread was lost ... it basically said thats a bunch of trivial optimizations surrounding the vlc reader loop. [...] -- Michael GnuPG fingerprint: 9FF

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: add 64-bit ipred_dr_32x32_16 avx2 implementation

2017-06-27 Thread Ronald S. Bultje
Hi, On Sun, Jun 25, 2017 at 10:42 AM, Ilia Valiakhmetov wrote: > vp9_diag_downright_32x32_12bpp_c: 429.7 > vp9_diag_downright_32x32_12bpp_sse2: 158.9 > vp9_diag_downright_32x32_12bpp_ssse3: 144.6 > vp9_diag_downright_32x32_12bpp_avx: 141.0 > vp9_diag_downright_32x32_12bpp_avx2: 73.8 > > Almost 5

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: Move bitstream end check out of inner loop

2017-06-27 Thread Paul B Mahol
On 6/27/17, Michael Niedermayer wrote: > On Tue, Jun 27, 2017 at 09:47:31PM +0200, Michael Niedermayer wrote: > > "Summary email is empty, skipping it" > > somehow the summary mail for the thread was lost ... > > it basically said thats a bunch of trivial optimizations surrounding > the vlc reader

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: Move bitstream end check out of inner loop

2017-06-27 Thread Paul B Mahol
On 6/27/17, Paul B Mahol wrote: > On 6/27/17, Michael Niedermayer wrote: >> On Tue, Jun 27, 2017 at 09:47:31PM +0200, Michael Niedermayer wrote: >> >> "Summary email is empty, skipping it" >> >> somehow the summary mail for the thread was lost ... >> >> it basically said thats a bunch of trivial

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/utvideodec: enable unchecked bitreader

2017-06-27 Thread Kieran Kunhya
On Tue, 27 Jun 2017 at 20:48 Michael Niedermayer wrote: > inner reader loop becomes 16% faster > > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c > index 411df47730..

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/utvideodec: enable unchecked bitreader

2017-06-27 Thread Paul B Mahol
On 6/27/17, Kieran Kunhya wrote: > On Tue, 27 Jun 2017 at 20:48 Michael Niedermayer > wrote: > >> inner reader loop becomes 16% faster >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/utvideodec.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavcodec/utvideodec.c

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: add sse and ssse3 extremity functions

2017-06-27 Thread Ivan Kalvachev
On 6/27/17, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm| 25 + > libavfilter/x86/vf_blend_init.c | 4 > tests/checkasm/vf_blend.c | 1 + > 3 files changed, 30 insertions(+) > > diff --git a/libavfilter/x86/vf_blend

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: add sse and ssse3 extremity functions

2017-06-27 Thread James Almer
On 6/27/2017 8:19 PM, Ivan Kalvachev wrote: > On 6/27/17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_blend.asm| 25 + >> libavfilter/x86/vf_blend_init.c | 4 >> tests/checkasm/vf_blend.c | 1 + >> 3 files changed, 30 ins

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/utvideodec: Factor multiply out of inner loop

2017-06-27 Thread Steven Liu
2017-06-28 3:47 GMT+08:00 Michael Niedermayer : > 0.5% faster loop > > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c > index 788f4475b9..a20e28320c